AspireMint reports: Add 3 slots for rewards (same ... #6225

New Issue

yourland-report · 2024-02-04T13:54:33Z

yourland-report commented

2024-02-04 13:54:33 +00:00

AspireMint reports a bug:

Add 3 slots for rewards (same like "Trash review" formspec). You can take from it but can't put anything. Only for rewards from events/quests. +add /mail notification

Player position:

{
	x = 2023.9830322266,
	y = 3.5,
	z = 1169.6879882813
}

Player look:

{
	x = -0.68400001525879,
	y = -0.44260174036026,
	z = 0.57986867427826
}

Player information:

{
	state = "Active",
	ip_version = 6,
	min_rtt = 0.025000000372529,
	avg_rtt = 0.028999999165535,
	min_jitter = 0,
	max_jitter = 1.6900000572205,
	connection_uptime = 15199,
	serialization_version = 29,
	patch = 0,
	max_rtt = 1.9859999418259,
	lang_code = "",
	formspec_version = 6,
	minor = 7,
	major = 5,
	avg_jitter = 0.0019999984651804,
	protocol_version = 42,
	version_string = "5.7.0"
}

Player meta:

{
	fields = {
		jointime = "1619715757",
		bitten = "0",
		hud_state = "on",
		crafted = "117934",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze\", \"3d_armor:chestplate_bronze\", \"3d_armor:leggings_bronze\", \"shields:shield_steel\", \"3d_armor:enchanted_boots_bronze_speed\", \"\"}",
		yl_church = "return {[\"last_heal\"] = 1705833044, [\"last_death_portal\"] = 1707054199, [\"last_death\"] = {[\"x\"] = -407, [\"y\"] = 47, [\"z\"] = 21485}}",
		inflicted_damage = "11780388",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		arenalib_infobox_arenaID = "0",
		punch_count = "544515",
		["petz:werewolf"] = "0",
		placed_nodes = "385596",
		["petz:lycanthropy"] = "0",
		yl_commons_thankyou = "270",
		xp = "2055713",
		died = "376",
		["petz:werewolf_clan_idx"] = "4",
		partychat = "party",
		repellant = "0",
		["stamina:level"] = "19",
		yl_commons_player_joined = "1707039723",
		["stamina:poisoned"] = "no",
		["ocean_build.last_warning"] = "1.65674e+09",
		["stamina:exhaustion"] = "34",
		yl_commons_player_created = "1619715757",
		played_time = "6626510",
		digged_nodes = "1962680",
		["signslib:pos"] = "(-422,48,21492)",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12"
	}
}

Log identifier


[MOD] yl_report log identifier = W3AfZVBoiEGymwUFvTYKoLN6l4SqdKml

Profiler save:

profile-20240204T135433.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 30s | max lag: 0.743s | clients (28/52): _Nod_, adhidev, Administrator, AliasAlreadyTaken, AspireMint, Bailiff, Boot, BTS-, carbon, Davidsoft, DragonWrangler1, emma-is-cool, JeCel, JinnyC, johanlegend, Keya, LeetPeet, Lupercus, Murmel, polik, poppyasdan, Ravise, rewired_X, Sagacity, Service, wace44, whosit, whostand

Teleport command:

/teleport xyz 2024 4 1170

Compass command:

/give_compass Construction W3AfZVBoiEGymwUFvTYKoLN6l4SqdKml D2691E 2024 4 1170

AspireMint reports a bug: > Add 3 slots for rewards (same like "Trash review" formspec). You can take from it but can't put anything. Only for rewards from events/quests. +add /mail notification Player position: ``` { x = 2023.9830322266, y = 3.5, z = 1169.6879882813 } ``` Player look: ``` { x = -0.68400001525879, y = -0.44260174036026, z = 0.57986867427826 } ``` Player information: ``` { state = "Active", ip_version = 6, min_rtt = 0.025000000372529, avg_rtt = 0.028999999165535, min_jitter = 0, max_jitter = 1.6900000572205, connection_uptime = 15199, serialization_version = 29, patch = 0, max_rtt = 1.9859999418259, lang_code = "", formspec_version = 6, minor = 7, major = 5, avg_jitter = 0.0019999984651804, protocol_version = 42, version_string = "5.7.0" } ``` Player meta: ``` { fields = { jointime = "1619715757", bitten = "0", hud_state = "on", crafted = "117934", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_bronze\", \"3d_armor:chestplate_bronze\", \"3d_armor:leggings_bronze\", \"shields:shield_steel\", \"3d_armor:enchanted_boots_bronze_speed\", \"\"}", yl_church = "return {[\"last_heal\"] = 1705833044, [\"last_death_portal\"] = 1707054199, [\"last_death\"] = {[\"x\"] = -407, [\"y\"] = 47, [\"z\"] = 21485}}", inflicted_damage = "11780388", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", arenalib_infobox_arenaID = "0", punch_count = "544515", ["petz:werewolf"] = "0", placed_nodes = "385596", ["petz:lycanthropy"] = "0", yl_commons_thankyou = "270", xp = "2055713", died = "376", ["petz:werewolf_clan_idx"] = "4", partychat = "party", repellant = "0", ["stamina:level"] = "19", yl_commons_player_joined = "1707039723", ["stamina:poisoned"] = "no", ["ocean_build.last_warning"] = "1.65674e+09", ["stamina:exhaustion"] = "34", yl_commons_player_created = "1619715757", played_time = "6626510", digged_nodes = "1962680", ["signslib:pos"] = "(-422,48,21492)", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12" } } ``` Log identifier ``` [MOD] yl_report log identifier = W3AfZVBoiEGymwUFvTYKoLN6l4SqdKml ``` Profiler save: ``` profile-20240204T135433.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 30s | max lag: 0.743s | clients (28/52): _Nod_, adhidev, Administrator, AliasAlreadyTaken, AspireMint, Bailiff, Boot, BTS-, carbon, Davidsoft, DragonWrangler1, emma-is-cool, JeCel, JinnyC, johanlegend, Keya, LeetPeet, Lupercus, Murmel, polik, poppyasdan, Ravise, rewired_X, Sagacity, Service, wace44, whosit, whostand ``` Teleport command: ``` /teleport xyz 2024 4 1170 ``` Compass command: ``` /give_compass Construction W3AfZVBoiEGymwUFvTYKoLN6l4SqdKml D2691E 2024 4 1170 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-04 13:54:33 +00:00

whosit commented

2024-02-04 14:22:24 +00:00

Just adding 3 or 6, or 10 new slots won't fix the problem.

There could be an infinite "reward storage" type of thing, that just adds your quest rewards to the list, and you can open any specific reward set at any time and claim it (take only of course). It could be done in the inventory as "reward journal", or as a special "reward claim chest" service, if we don't want players to have access to it at all times.

Just adding 3 or 6, or 10 new slots won't fix the problem. There could be an infinite "reward storage" type of thing, that just adds your quest rewards to the list, and you can open any specific reward set at any time and claim it (take only of course). It could be done in the inventory as "reward journal", or as a special "reward claim chest" service, if we don't want players to have access to it at all times.

sixer commented

2024-02-04 15:35:54 +00:00

Maybe this reward storage could be in form similar to an ender chest

AliasAlreadyTaken added the

1. kind/enhancement

label 2024-02-04 16:19:21 +00:00

Sokomine commented

2024-02-04 21:07:11 +00:00

I've started a reward_inv mod and whosit has written something similar - except just with one slot.

My mod still needs a bit of work. After that NPC can use it as well.

I've started a reward_inv mod and whosit has written something similar - except just with one slot. My mod still needs a bit of work. After that NPC can use it as well.

Chache commented

2024-02-10 00:33:31 +00:00

Alternative solution: whoever has got no free space in the inventory, just misses the rewards altogether.

The instruction "have X free spaces in the inventory" should be very simple to understand. If, after repeating that 10 times, there are players who still have no free space in the inventory... I no longer empathise with them.

Alternative solution: whoever has got no free space in the inventory, just misses the rewards altogether. The instruction "have X free spaces in the inventory" should be very simple to understand. If, after repeating that 10 times, there are players who still have no free space in the inventory... I no longer empathise with them.

👍 1

rewired_X commented

2024-02-10 00:51:02 +00:00

Problem with that approach is, the NPC won't let you get the rewards if someone that doesn't have 3 slots free is nearby. So if that approach is to be taken, the code would need to be adjusted to remove that safeguard.
Plus there's people who suddenly have to go afk without being able to check for 3 free spaces - what about that scenario?

Problem with that approach is, the NPC won't let you get the rewards if someone that doesn't have 3 slots free is nearby. So if that approach is to be taken, the code would need to be adjusted to remove that safeguard. Plus there's people who suddenly have to go afk without being able to check for 3 free spaces - what about that scenario?

whosit commented

2024-02-10 07:01:03 +00:00

Alternative solution: whoever has got no free space in the inventory, just misses the rewards altogether.

The instruction "have X free spaces in the inventory" should be very simple to understand. If, after repeating that 10 times, there are players who still have no free space in the inventory... I no longer empathise with them.

It works if you have single repeating quest with same number of rewards. If people don't know how many rewards quest will have or when it ends - it means they just randomly lose rewards. Can't learn all quests on a server before finishing them at least once 🐬

> Alternative solution: whoever has got no free space in the inventory, just misses the rewards altogether. > > The instruction "have X free spaces in the inventory" should be very simple to understand. If, after repeating that 10 times, there are players who still have no free space in the inventory... I no longer empathise with them. It works if you have single repeating quest with same number of rewards. If people don't know how many rewards quest will have or when it ends - it means they just randomly lose rewards. Can't learn all quests on a server before finishing them at least once 🐬

AliasAlreadyTaken commented

2024-02-11 02:27:56 +00:00

We can't demand people know before it happens how much space in the inventory is necessary. I'd rather support some approach where the reward is placed in some reward inventory ON THE NPC, that only the player who completed the quest, but didn't take the reward can access. Then the player could return later and grab the reward

Boot commented

2024-02-11 10:15:21 +00:00

Yes, this principle has already proven itself well in the still ongoing quest "Be a Friend of the Bailiffs' Dogs". There was no prize at the beginning and it can be picked up in the meantime, which is already done by most of the new friends of the Bailiffs' dogs.

Sign in to join this conversation.