AspireMint reports: Smartshops items looks differe ... #6169

New Issue

yourland-report · 2024-02-01T10:01:30Z

yourland-report commented

2024-02-01 10:01:30 +00:00

AspireMint reports a bug:

Smartshops items looks different when one of items image is 3D, see screenshot. Also wrong items order. https://i.imgur.com/jDrmLsL.png

Player position:

{
	x = 2125.8139648438,
	y = 15.5,
	z = 1192.8289794922
}

Player look:

{
	x = 0.003360997652635,
	y = -0.70090925693512,
	z = 0.71324253082275
}

Player information:

{
	min_rtt = 0.025000000372529,
	avg_rtt = 0.037000000476837,
	min_jitter = 0,
	max_jitter = 0.38999998569489,
	avg_jitter = 0.0089999996125698,
	connection_uptime = 896,
	serialization_version = 29,
	patch = 0,
	max_rtt = 0.45199999213219,
	protocol_version = 42,
	minor = 7,
	state = "Active",
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	version_string = "5.7.0",
	major = 5
}

Player meta:

{
	fields = {
		["stamina:exhaustion"] = "149.5",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		jointime = "1619715757",
		xp = "2056841",
		["ocean_build.ocean_built"] = "12",
		punch_count = "541048",
		yl_commons_player_joined = "1706780860",
		inflicted_damage = "11704632",
		died = "364",
		crafted = "117587",
		["3d_armor_inventory"] = "return {\"shields:shield_nether 1 34480\", \"3d_armor:chestplate_nether 1 34480\", \"3d_armor:boots_crystal 1 17240\", \"3d_armor:leggings_nether 1 34480\", \"3d_armor:helmet_nether 1 17240\", \"\"}",
		digged_nodes = "1962295",
		["stamina:level"] = "16",
		["petz:werewolf_clan_idx"] = "4",
		yl_commons_thankyou = "259",
		["ocean_build.forbidden"] = "true",
		bitten = "0",
		placed_nodes = "385458",
		played_time = "6522614",
		arenalib_infobox_arenaID = "0",
		hud_state = "on",
		repellant = "0",
		partychat = "party",
		["petz:werewolf"] = "0",
		yl_commons_player_created = "1619715757",
		["petz:lycanthropy"] = "0",
		["ocean_build.last_warning"] = "1.65674e+09",
		["signslib:pos"] = "(-422,48,21492)",
		yl_church = "return {[\"last_death_portal\"] = 1706719078, [\"last_heal\"] = 1705833044, [\"last_death\"] = {[\"x\"] = -407, [\"y\"] = 47, [\"z\"] = 21485}}",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = DPu0pSAJpEMvbEDXyQCg8hoSAVdpxxkm

Profiler save:

profile-20240201T100130.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4h 22min 7s | max lag: 1.14s | clients (11/52): Administrator, AliasAlreadyTaken, AspireMint, daydream, JinnyC, kogucik97, Murmel, NikocadoAvacado, Penelopee, pups, Service

Teleport command:

/teleport xyz 2126 16 1193

Compass command:

/give_compass Construction DPu0pSAJpEMvbEDXyQCg8hoSAVdpxxkm D2691E 2126 16 1193

AspireMint reports a bug: > Smartshops items looks different when one of items image is 3D, see screenshot. Also wrong items order. https://i.imgur.com/jDrmLsL.png Player position: ``` { x = 2125.8139648438, y = 15.5, z = 1192.8289794922 } ``` Player look: ``` { x = 0.003360997652635, y = -0.70090925693512, z = 0.71324253082275 } ``` Player information: ``` { min_rtt = 0.025000000372529, avg_rtt = 0.037000000476837, min_jitter = 0, max_jitter = 0.38999998569489, avg_jitter = 0.0089999996125698, connection_uptime = 896, serialization_version = 29, patch = 0, max_rtt = 0.45199999213219, protocol_version = 42, minor = 7, state = "Active", lang_code = "", formspec_version = 6, ip_version = 6, version_string = "5.7.0", major = 5 } ``` Player meta: ``` { fields = { ["stamina:exhaustion"] = "149.5", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", jointime = "1619715757", xp = "2056841", ["ocean_build.ocean_built"] = "12", punch_count = "541048", yl_commons_player_joined = "1706780860", inflicted_damage = "11704632", died = "364", crafted = "117587", ["3d_armor_inventory"] = "return {\"shields:shield_nether 1 34480\", \"3d_armor:chestplate_nether 1 34480\", \"3d_armor:boots_crystal 1 17240\", \"3d_armor:leggings_nether 1 34480\", \"3d_armor:helmet_nether 1 17240\", \"\"}", digged_nodes = "1962295", ["stamina:level"] = "16", ["petz:werewolf_clan_idx"] = "4", yl_commons_thankyou = "259", ["ocean_build.forbidden"] = "true", bitten = "0", placed_nodes = "385458", played_time = "6522614", arenalib_infobox_arenaID = "0", hud_state = "on", repellant = "0", partychat = "party", ["petz:werewolf"] = "0", yl_commons_player_created = "1619715757", ["petz:lycanthropy"] = "0", ["ocean_build.last_warning"] = "1.65674e+09", ["signslib:pos"] = "(-422,48,21492)", yl_church = "return {[\"last_death_portal\"] = 1706719078, [\"last_heal\"] = 1705833044, [\"last_death\"] = {[\"x\"] = -407, [\"y\"] = 47, [\"z\"] = 21485}}", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = DPu0pSAJpEMvbEDXyQCg8hoSAVdpxxkm ``` Profiler save: ``` profile-20240201T100130.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4h 22min 7s | max lag: 1.14s | clients (11/52): Administrator, AliasAlreadyTaken, AspireMint, daydream, JinnyC, kogucik97, Murmel, NikocadoAvacado, Penelopee, pups, Service ``` Teleport command: ``` /teleport xyz 2126 16 1193 ``` Compass command: ``` /give_compass Construction DPu0pSAJpEMvbEDXyQCg8hoSAVdpxxkm D2691E 2126 16 1193 ```

AliasAlreadyTaken was assigned by yourland-report

2024-02-01 10:01:30 +00:00

AliasAlreadyTaken added the

1. kind/bug

4. step/needs confirmation

labels 2024-02-01 12:13:18 +00:00

flux added

1. kind/documentation

and removed

1. kind/bug

4. step/needs confirmation

labels 2024-02-01 21:18:12 +00:00

flux commented

2024-02-01 21:22:26 +00:00

this is intentional. in the image on the left, we have available wield/inventory images, and we can then compose those into one image and display it as an upright sprite.

on the left, one of the items (the smartshop) has a nodebox drawtype and no wield/inventory image, so we have to display it as a wield item. the other items are then displayed as "regular" sprites, as these have the least impact on drawtime (1/2 that of upright sprites). yes, i could merge all the things with wield/inventory images into a single upright sprite as well, but the code logic is already complicated enough and the performance improvement would be negligible.

![image](/attachments/fd374b30-8b7b-48cd-b4af-14e23074b06e) this is intentional. in the image on the left, we have available wield/inventory images, and we can then compose those into one image and display it as an upright sprite. on the left, one of the items (the smartshop) has a nodebox drawtype and no wield/inventory image, so we have to display it as a wield item. the other items are then displayed as "regular" sprites, as these have the least impact on drawtime (1/2 that of upright sprites). yes, i could merge all the things with wield/inventory images into a single upright sprite as well, but the code logic is already complicated enough and the performance improvement would be negligible.

image.png

148 KiB

flux added the

1. kind/bug

3. source/mod upstream

labels 2024-02-01 21:22:49 +00:00

flux commented

2024-02-01 21:23:17 +00:00

oh, i see. the order of the items changes too. that's a bug....

flux added this to the flux's TODO list project 2024-02-01 21:23:26 +00:00

Sign in to join this conversation.