your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

Testserver build error ‘PP’ was not declared in this scope #6031

New Issue
Open
opened 2024-01-21 00:28:44 +00:00 by AliasAlreadyTaken · 3 comments
AliasAlreadyTaken commented 2024-01-21 00:28:44 +00:00
Owner
Copy Link

I'm trying to compile 5.8.0 with YL modifications: https://gitea.your-land.de/your-land/minetest/src/branch/yl_stable-5

make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:286: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_flat.cpp.o] Error 1
In file included from /home/mt/5.8.0/Minetest_test/src/mapblock.h:27,
                 from /home/mt/5.8.0/Minetest_test/src/mapgen/mapgen_singlenode.cpp:24:
/home/mt/5.8.0/Minetest_test/src/staticobject.h: In member function ‘void StaticObjectList::insert(irr::u16, const StaticObject&)’:
/home/mt/5.8.0/Minetest_test/src/staticobject.h:94:52: error: ‘PP’ was not declared in this scope
   94 |                                                 << PP(obj.pos) << ", \"...\")): "
      |                                                    ^~
In file included from /home/mt/5.8.0/Minetest_test/src/mapblock.h:27,
                 from /home/mt/5.8.0/Minetest_test/src/mapgen/mapgen_fractal.cpp:26:
/home/mt/5.8.0/Minetest_test/src/staticobject.h: In member function ‘void StaticObjectList::insert(irr::u16, const StaticObject&)’:
/home/mt/5.8.0/Minetest_test/src/staticobject.h:94:52: error: ‘PP’ was not declared in this scope
   94 |                                                 << PP(obj.pos) << ", \"...\")): "
      |                                                    ^~
make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:314: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_singlenode.cpp.o] Error 1
make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:300: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_fractal.cpp.o] Error 1
make[2]: Leaving directory '/home/mt/5.8.0/Minetest_test/build'
make[1]: *** [CMakeFiles/Makefile2:420: src/CMakeFiles/minetestserver.dir/all] Error 2
make[1]: Leaving directory '/home/mt/5.8.0/Minetest_test/build'
make: *** [Makefile:156: all] Error 2
make: Leaving directory '/home/mt/5.8.0/Minetest_test/build'

We added this due to entity issues, it worked nicely in 5.7.0, but most likely MT upstream changed something

c4ca8d53b6

removing PP(obj.pos) << allows me to compile at least :D

I'm trying to compile 5.8.0 with YL modifications: https://gitea.your-land.de/your-land/minetest/src/branch/yl_stable-5 ``` make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:286: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_flat.cpp.o] Error 1 In file included from /home/mt/5.8.0/Minetest_test/src/mapblock.h:27, from /home/mt/5.8.0/Minetest_test/src/mapgen/mapgen_singlenode.cpp:24: /home/mt/5.8.0/Minetest_test/src/staticobject.h: In member function ‘void StaticObjectList::insert(irr::u16, const StaticObject&)’: /home/mt/5.8.0/Minetest_test/src/staticobject.h:94:52: error: ‘PP’ was not declared in this scope 94 | << PP(obj.pos) << ", \"...\")): " | ^~ In file included from /home/mt/5.8.0/Minetest_test/src/mapblock.h:27, from /home/mt/5.8.0/Minetest_test/src/mapgen/mapgen_fractal.cpp:26: /home/mt/5.8.0/Minetest_test/src/staticobject.h: In member function ‘void StaticObjectList::insert(irr::u16, const StaticObject&)’: /home/mt/5.8.0/Minetest_test/src/staticobject.h:94:52: error: ‘PP’ was not declared in this scope 94 | << PP(obj.pos) << ", \"...\")): " | ^~ make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:314: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_singlenode.cpp.o] Error 1 make[2]: *** [src/CMakeFiles/minetestserver.dir/build.make:300: src/CMakeFiles/minetestserver.dir/mapgen/mapgen_fractal.cpp.o] Error 1 make[2]: Leaving directory '/home/mt/5.8.0/Minetest_test/build' make[1]: *** [CMakeFiles/Makefile2:420: src/CMakeFiles/minetestserver.dir/all] Error 2 make[1]: Leaving directory '/home/mt/5.8.0/Minetest_test/build' make: *** [Makefile:156: all] Error 2 make: Leaving directory '/home/mt/5.8.0/Minetest_test/build' ``` We added this due to entity issues, it worked nicely in 5.7.0, but most likely MT upstream changed *something* https://gitea.your-land.de/your-land/minetest/commit/c4ca8d53b6cede355e0b609508b44b44f163f210 removing `PP(obj.pos) <<` allows me to compile at least :D
AliasAlreadyTaken added the
3. source/engine
1. kind/bug
 labels 2024-01-21 00:28:57 +00:00
whosit commented 2024-01-21 01:28:49 +00:00
Member
Copy Link

Maybe just replacing PP(obj.pos) with obj.pos could work?
Because I had similar issue inside a mod - they added _tostring method to positions, but in 5.7.0 it didn't work.
Maybe current MT version has proper method implemented in C++ too?

Maybe just replacing `PP(obj.pos)` with `obj.pos` could work? Because I had similar issue inside a mod - they added _tostring method to positions, but in 5.7.0 it didn't work. Maybe current MT version has proper method implemented in C++ too?
Bla commented 2024-01-21 10:23:07 +00:00
Copy Link

We added this due to entity issues, it worked nicely in 5.7.0, but most likely MT upstream changed something

https://github.com/minetest/minetest/pull/13630

> We added this due to entity issues, it worked nicely in 5.7.0, but most likely MT upstream changed *something* https://github.com/minetest/minetest/pull/13630
👍 1
whosit commented 2024-03-17 23:54:55 +00:00
Member
Copy Link

Basically doing what PR found by Bla does:
adding
#include "irrlicht_changes/printing.h"
to staticobject.h
and changing PP(obj.pos) to just obj.pos makes it compile again.

Basically doing what PR found by Bla does: adding `#include "irrlicht_changes/printing.h"` to `staticobject.h` and changing `PP(obj.pos)` to just `obj.pos` makes it compile again.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6031
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?