flux reports: if a chat message has "/msg" i ... #6019

New Issue

yourland-report · 2024-01-20T04:55:09Z

yourland-report commented

2024-01-20 04:55:09 +00:00

flux reports a bug:

if a chat message has "/msg" in it, but wasn't interpreted as a message, send a warning to the player who sent it instead of sending it to everyone. //msg should be ignored by the mechanism, and sending the same message twice should allow it to be sent to public chat

Player position:

{
	x = 19462.80859375,
	y = 65,
	z = 21440.44921875
}

Player look:

{
	x = -0.017733296379447,
	y = -0.58240675926208,
	z = 0.81270402669907
}

Player information:

{
	protocol_version = 42,
	minor = 9,
	ip_version = 6,
	min_rtt = 0.16599999368191,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	lang_code = "",
	avg_jitter = 0.0010000020265579,
	connection_uptime = 38097,
	serialization_version = 29,
	patch = 0,
	major = 5,
	version_string = "5.9.0-dev-454dd8576-dirty",
	state = "Active",
	max_jitter = 4.2389998435974,
	max_rtt = 4.4169998168945,
	formspec_version = 7
}

Player meta:

{
	fields = {
		punch_count = "323827",
		["stamina:exhaustion"] = "30.5",
		inflicted_damage = "6403572",
		repellant = "0",
		["petz:werewolf"] = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["petz:lycanthropy"] = "1",
		arenalib_infobox_arenaID = "0",
		digged_nodes = "1724463",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 52, [\"z\"] = 214, [\"x\"] = 2810}, [\"last_death_portal\"] = 1692114993, [\"last_heal\"] = 1615504208}",
		["signslib:pos"] = "(1273,10,516)",
		yl_commons_thankyou = "371",
		hotbar_size = "16",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_party 1 7000\", \"3d_armor:leggings_rainbow 1 280\", \"shields:shield_rainbow 1 280\", \"3d_armor:chestplate_party 1 7000\", \"nether_mobs:dragon_boots 1 700\", \"\"}",
		played_time = "46135047",
		yl_commons_player_created = "1615351173",
		yl_commons_player_joined = "1705688426",
		died = "101",
		crafted = "211336",
		hud_state = "off",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_vignette_id"] = "20",
		xp = "2330866",
		jointime = "1615351173",
		bitten = "0",
		["petz:werewolf_clan_idx"] = "1",
		["hud_manager:spawnit:hud_enabled"] = "y",
		placed_nodes = "486453",
		["stamina:level"] = "12",
		partychat = "party",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = 0RP37NwnRj8tfzSlImdY1yS8SQM4cQzo

Profiler save:

profile-20240120T045509.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 12h 51min 3s | max lag: 0.723s | clients (16/52): AliasAlreadyTaken, Bailiff, BLuOXide, Calamity_Jones, daydream, Deathwing, flux, Giuseppe, JinnyC, Lixie, Lupercus, rheo, Service, Sofia28, tagtraum, taonza12

Teleport command:

/teleport xyz 19463 65 21440

Compass command:

/give_compass Construction 0RP37NwnRj8tfzSlImdY1yS8SQM4cQzo D2691E 19463 65 21440

flux reports a bug: > if a chat message has "/msg" in it, but wasn't interpreted as a message, send a warning to the player who sent it instead of sending it to everyone. //msg should be ignored by the mechanism, and sending the same message twice should allow it to be sent to public chat Player position: ``` { x = 19462.80859375, y = 65, z = 21440.44921875 } ``` Player look: ``` { x = -0.017733296379447, y = -0.58240675926208, z = 0.81270402669907 } ``` Player information: ``` { protocol_version = 42, minor = 9, ip_version = 6, min_rtt = 0.16599999368191, avg_rtt = 0.17499999701977, min_jitter = 0, lang_code = "", avg_jitter = 0.0010000020265579, connection_uptime = 38097, serialization_version = 29, patch = 0, major = 5, version_string = "5.9.0-dev-454dd8576-dirty", state = "Active", max_jitter = 4.2389998435974, max_rtt = 4.4169998168945, formspec_version = 7 } ``` Player meta: ``` { fields = { punch_count = "323827", ["stamina:exhaustion"] = "30.5", inflicted_damage = "6403572", repellant = "0", ["petz:werewolf"] = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["petz:lycanthropy"] = "1", arenalib_infobox_arenaID = "0", digged_nodes = "1724463", yl_church = "return {[\"last_death\"] = {[\"y\"] = 52, [\"z\"] = 214, [\"x\"] = 2810}, [\"last_death_portal\"] = 1692114993, [\"last_heal\"] = 1615504208}", ["signslib:pos"] = "(1273,10,516)", yl_commons_thankyou = "371", hotbar_size = "16", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_party 1 7000\", \"3d_armor:leggings_rainbow 1 280\", \"shields:shield_rainbow 1 280\", \"3d_armor:chestplate_party 1 7000\", \"nether_mobs:dragon_boots 1 700\", \"\"}", played_time = "46135047", yl_commons_player_created = "1615351173", yl_commons_player_joined = "1705688426", died = "101", crafted = "211336", hud_state = "off", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_vignette_id"] = "20", xp = "2330866", jointime = "1615351173", bitten = "0", ["petz:werewolf_clan_idx"] = "1", ["hud_manager:spawnit:hud_enabled"] = "y", placed_nodes = "486453", ["stamina:level"] = "12", partychat = "party", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = 0RP37NwnRj8tfzSlImdY1yS8SQM4cQzo ``` Profiler save: ``` profile-20240120T045509.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 12h 51min 3s | max lag: 0.723s | clients (16/52): AliasAlreadyTaken, Bailiff, BLuOXide, Calamity_Jones, daydream, Deathwing, flux, Giuseppe, JinnyC, Lixie, Lupercus, rheo, Service, Sofia28, tagtraum, taonza12 ``` Teleport command: ``` /teleport xyz 19463 65 21440 ``` Compass command: ``` /give_compass Construction 0RP37NwnRj8tfzSlImdY1yS8SQM4cQzo D2691E 19463 65 21440 ```

AliasAlreadyTaken was assigned by yourland-report

2024-01-20 04:55:09 +00:00

whosit commented

2024-01-20 05:03:46 +00:00

If you search through logs, much more often people just forget or misplace / at the beginning.
And /msg in the middle of the message is often used in the context use /msg name to send private messages.
Also people use and mistype shortcut /m...
Maybe try to look for "some variation of m or msg" + "some existing player name"?

If you search through logs, much more often people just forget or misplace `/` at the beginning. And `/msg` in the middle of the message is often used in the context `use /msg name to send private messages`. Also people use and mistype shortcut `/m`... Maybe try to look for "some variation of `m` or `msg`" + "some existing player name"?

AliasAlreadyTaken added the

1. kind/enhancement

label 2024-01-20 14:58:07 +00:00

AliasAlreadyTaken commented

2024-01-20 14:59:12 +00:00

Is planned for your-land/administration#76

AliasAlreadyTaken commented

2024-01-20 15:00:59 +00:00

The only thing we can reasonably detect is when a message starts with m PLAYERNAME MESSAGE or msg PLAYERNAME MESSAGE or 7m PLAYERNAME MESSAGE or m/ PLAYERNAME MESSAGE or m7 PLAYERNAME MESSAGE instead of /m PLAYERNAME MESSAGE

The only thing we can reasonably detect is when a message starts with `m PLAYERNAME MESSAGE` or `msg PLAYERNAME MESSAGE` or `7m PLAYERNAME MESSAGE` or `m/ PLAYERNAME MESSAGE` or `m7 PLAYERNAME MESSAGE` instead of `/m PLAYERNAME MESSAGE`

flux commented

2024-01-21 04:38:21 +00:00

it took me a moment to re-understand the issue.

if a chat message has "/msg" in it, but wasn't interpreted as a message

the kind of message i mean, is if someone types "blah blah /msg playerFoo this is meant to be private"

The only thing we can reasonably detect is when a message starts with

the issue i'm reporting isn't how the message starts, it's accidentally appending a private message to something i've already typed into chat

it took me a moment to re-understand the issue. > if a chat message has "/msg" in it, but wasn't interpreted as a message the kind of message i mean, is if someone types "blah blah /msg playerFoo this is meant to be private" > The only thing we can reasonably detect is when a message starts with the issue i'm reporting isn't how the message starts, it's accidentally appending a private message to something i've already typed into chat

AliasAlreadyTaken commented

2024-01-21 13:18:50 +00:00

I see. While that may be easy to detect, it may be impossible to tell apart those two cases:

blah blah /msg playerFoo this is meant to be private
Do /msg to send a private message

I see. While that may be easy to detect, it may be impossible to tell apart those two cases: 1. blah blah /msg playerFoo this is meant to be private 2. Do /msg to send a private message

flux commented

2024-01-23 02:35:33 +00:00

I see. While that may be easy to detect, it may be impossible to tell apart those two cases:

blah blah /msg playerFoo this is meant to be private

Do /msg to send a private message

from the above:

//msg should be ignored by the mechanism

this sentence isn't clear at all - i should have thought through this more before submitting. this is meant to imply there should be a way to escape the "/" so that you can still intentionally tell other players about commands using a slash. probably it should be "/msg ..." instead, as worldedit commands start with "//".

additionally, if you have a '/' in your chat message that looks like it might be part of a command, you should receive a reply like "did you mean to run the command '/msg player foo'? if you want to talk about the command, prefix '/' with '', i.e. '/msg player foo'"

> I see. While that may be easy to detect, it may be impossible to tell apart those two cases: > > 1. blah blah /msg playerFoo this is meant to be private > 2. Do /msg to send a private message from the above: > //msg should be ignored by the mechanism this sentence isn't clear at all - i should have thought through this more before submitting. this is meant to imply there should be a way to escape the "/" so that you can still intentionally tell other players about commands using a slash. probably it should be "\/msg ..." instead, as worldedit commands start with "//". additionally, if you have a '/' in your chat message that looks like it might be part of a command, you should receive a reply like "did you mean to run the command '/msg player foo'? if you want to talk about the command, prefix '/' with '\', i.e. '\/msg player foo'"

Sign in to join this conversation.