ALCOHOL3 reports: NPC quest problem: if you clos ... #5895

New Issue

yourland-report · 2024-01-03T16:12:00Z

yourland-report commented

2024-01-03 16:12:00 +00:00

ALCOHOL3 reports a bug:

NPC quest problem: if you close the dialog window at the moment when you give NPS an item, the item disappears irretrievably

Player position:

{
	z = 1188.7889404297,
	x = 2130.7768554688,
	y = 14.5
}

Player look:

{
	z = 0.99499362707138,
	x = 0.032138209789991,
	y = 0.09462957829237
}

Player information:

{
	state = "Active",
	lang_code = "",
	ip_version = 6,
	min_rtt = 0.037000000476837,
	minor = 8,
	min_jitter = 0,
	max_jitter = 2.7639999389648,
	avg_jitter = 0,
	connection_uptime = 4523,
	serialization_version = 29,
	patch = 0,
	max_rtt = 2.8120000362396,
	version_string = "5.8.0",
	avg_rtt = 0.03999999910593,
	formspec_version = 7,
	protocol_version = 42,
	major = 5
}

Player meta:

{
	fields = {
		hud_state = "on",
		yl_commons_thankyou = "97",
		yl_church = "return {[\"last_heal\"] = 1701851032, [\"last_death_portal\"] = 1704108252, [\"last_death\"] = {[\"x\"] = -750, [\"y\"] = 45, [\"z\"] = -673}}",
		yl_commons_player_created = "1639578877",
		yl_commons_player_joined = "1704293808",
		played_time = "3754198",
		digged_nodes = "2554333",
		placed_nodes = "1111726",
		died = "290",
		["ambience.mvol"] = "0",
		repellant = "0",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1639578877",
		bitten = "0",
		["stamina:level"] = "19",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "17",
		punch_count = "71928",
		["hud_manager:choppy:waypoint_enabled"] = "y",
		partychat = "party",
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "0",
		hotbar_size = "18",
		["ocean_build.last_warning"] = "1694076519",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_nether 1 18080\", \"shields:shield_nether 1 18080\", \"3d_armor:chestplate_nether 1 18080\", \"3d_armor:helmet_nether 1 9040\", \"3d_armor:boots_crystal 1 9040\", \"\"}",
		["petz:werewolf_clan_idx"] = "2",
		crafted = "824334",
		inflicted_damage = "1512650",
		["signslib:pos"] = "(-687,12,-953)",
		xp = "1813239"
	}
}

Log identifier


[MOD] yl_report log identifier = sG5Wd2KNfdI07PZJXeaoZtFXfzwxJs57

Profiler save:

profile-20240103T161200.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 6h 33min | max lag: 0.511s | clients (15/52): ALCOHOL3, AliasAlreadyTaken, bleek, Brabenec, DragonWrangler1, geomagas, Historia_reiss, JeCel, Murmel, ny, Pelu, poppyasdan, prowler, Sybil, whostand

Teleport command:

/teleport xyz 2131 15 1189

Compass command:

/give_compass Construction sG5Wd2KNfdI07PZJXeaoZtFXfzwxJs57 D2691E 2131 15 1189

ALCOHOL3 reports a bug: > NPC quest problem: if you close the dialog window at the moment when you give NPS an item, the item disappears irretrievably Player position: ``` { z = 1188.7889404297, x = 2130.7768554688, y = 14.5 } ``` Player look: ``` { z = 0.99499362707138, x = 0.032138209789991, y = 0.09462957829237 } ``` Player information: ``` { state = "Active", lang_code = "", ip_version = 6, min_rtt = 0.037000000476837, minor = 8, min_jitter = 0, max_jitter = 2.7639999389648, avg_jitter = 0, connection_uptime = 4523, serialization_version = 29, patch = 0, max_rtt = 2.8120000362396, version_string = "5.8.0", avg_rtt = 0.03999999910593, formspec_version = 7, protocol_version = 42, major = 5 } ``` Player meta: ``` { fields = { hud_state = "on", yl_commons_thankyou = "97", yl_church = "return {[\"last_heal\"] = 1701851032, [\"last_death_portal\"] = 1704108252, [\"last_death\"] = {[\"x\"] = -750, [\"y\"] = 45, [\"z\"] = -673}}", yl_commons_player_created = "1639578877", yl_commons_player_joined = "1704293808", played_time = "3754198", digged_nodes = "2554333", placed_nodes = "1111726", died = "290", ["ambience.mvol"] = "0", repellant = "0", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1639578877", bitten = "0", ["stamina:level"] = "19", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "17", punch_count = "71928", ["hud_manager:choppy:waypoint_enabled"] = "y", partychat = "party", ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "0", hotbar_size = "18", ["ocean_build.last_warning"] = "1694076519", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["3d_armor_inventory"] = "return {\"3d_armor:leggings_nether 1 18080\", \"shields:shield_nether 1 18080\", \"3d_armor:chestplate_nether 1 18080\", \"3d_armor:helmet_nether 1 9040\", \"3d_armor:boots_crystal 1 9040\", \"\"}", ["petz:werewolf_clan_idx"] = "2", crafted = "824334", inflicted_damage = "1512650", ["signslib:pos"] = "(-687,12,-953)", xp = "1813239" } } ``` Log identifier ``` [MOD] yl_report log identifier = sG5Wd2KNfdI07PZJXeaoZtFXfzwxJs57 ``` Profiler save: ``` profile-20240103T161200.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 6h 33min | max lag: 0.511s | clients (15/52): ALCOHOL3, AliasAlreadyTaken, bleek, Brabenec, DragonWrangler1, geomagas, Historia_reiss, JeCel, Murmel, ny, Pelu, poppyasdan, prowler, Sybil, whostand ``` Teleport command: ``` /teleport xyz 2131 15 1189 ``` Compass command: ``` /give_compass Construction sG5Wd2KNfdI07PZJXeaoZtFXfzwxJs57 D2691E 2131 15 1189 ```

AliasAlreadyTaken was assigned by yourland-report

2024-01-03 16:12:00 +00:00

whosit commented

2024-01-03 16:25:37 +00:00

It should be a "transaction" - you either get the item NPC promised to give you in exchange, or get your item back.
Sokomine says currently it's possible to set a flag so that NPC remembers that you gave them the thing, but I think that special transaction dialog may be easier for quest devs to use...

Or maybe, giving stuff to NPC instead of just jumping to a dialog_N that may become unreachable, should just set the flag "has given me an item" and dialog_N would have that flag as a precondition, and be always available somehow. Since the issue now is that giving item just jumps to some part of the dialog tree, instead of changing the state...

It should be a "transaction" - you either get the item NPC promised to give you in exchange, or get your item back. Sokomine says currently it's possible to set a flag so that NPC remembers that you gave them the thing, but I think that special transaction dialog may be easier for quest devs to use... Or maybe, giving stuff to NPC instead of just jumping to a dialog_N that may become unreachable, should just set the flag "has given me an item" and dialog_N would have that flag as a precondition, and be always available somehow. Since the issue now is that giving item just jumps to some part of the dialog tree, instead of changing the state...

AliasAlreadyTaken added the

1. kind/bug

4. step/needs confirmation

labels 2024-01-03 17:03:31 +00:00

Sokomine was assigned by AliasAlreadyTaken

2024-01-03 17:03:37 +00:00

Sign in to join this conversation.