Jammy reports: the thankyou cooldown exist ev ... #5883

New Issue

yourland-report · 2024-01-01T06:15:09Z

yourland-report commented

2024-01-01 06:15:09 +00:00

Jammy reports a bug:

the thankyou cooldown exist even if your privious thankyou was invalid(to nonexisting player)

Player position:

{
	x = 18908.712890625,
	y = 2.5,
	z = 18733.041015625
}

Player look:

{
	x = 0.51172780990601,
	y = -0.63876783847809,
	z = 0.57455235719681
}

Player information:

{
	min_jitter = 0,
	max_jitter = 1.8049999475479,
	avg_jitter = 0,
	connection_uptime = 2581,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	version_string = "5.8.0",
	formspec_version = 7,
	protocol_version = 42,
	minor = 8,
	min_rtt = 0.14300000667572,
	lang_code = "zh_CN",
	ip_version = 6,
	max_rtt = 1.9609999656677,
	major = 5,
	avg_rtt = 0.14699999988079
}

Player meta:

{
	fields = {
		["ocean_build.ocean_built"] = "8",
		jointime = "1700288470",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 360\", \"3d_armor:helmet_rainbow 1 18826\", \"shields:shield_rainbow 1 17976\", \"3d_armor:leggings_rainbow 1 17976\", \"3d_armor:chestplate_rainbow 1 17976\", \"\"}",
		["signslib:pos"] = "(18765,33,18509)",
		crafted = "58801",
		hud_state = "on",
		["petz:werewolf"] = "0",
		died = "241",
		["petz:werewolf_clan_idx"] = "2",
		["stamina:level"] = "5",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["ambience.svol"] = "0.1",
		yl_commons_thankyou = "24",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\", \"unified_inventory:bag_large\"}",
		yl_commons_player_created = "1700288470",
		yl_commons_player_joined = "1704087138",
		yl_church = "return {[\"last_heal\"] = 1700995484, [\"last_death_portal\"] = 1704071226, [\"last_death\"] = {[\"x\"] = 18821, [\"y\"] = 50, [\"z\"] = 18472}}",
		punch_count = "12757",
		xp = "72837",
		inflicted_damage = "245662",
		digged_nodes = "93295",
		placed_nodes = "39119",
		partychat = "party",
		repellant = "0",
		["petz:lycanthropy"] = "0",
		["stamina:exhaustion"] = "82",
		played_time = "980294",
		["ocean_build.last_warning"] = "1703421567"
	}
}

Log identifier


[MOD] yl_report log identifier = y9s41guJcBPBOMEfEnoDOACo8Tk6UWPl

Profiler save:

profile-20240101T061509.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 3h 33min 49s | max lag: 0.786s | clients (14/52): AliasAlreadyTaken, bancha, Brabenec, daydream, DezS4125, DutchessPyle, flux, Jammy, Kadax, Lupercus, ny, Parrish, Penelopee, rewired_X1

Teleport command:

/teleport xyz 18909 3 18733

Compass command:

/give_compass Construction y9s41guJcBPBOMEfEnoDOACo8Tk6UWPl D2691E 18909 3 18733

Jammy reports a bug: > the thankyou cooldown exist even if your privious thankyou was invalid(to nonexisting player) Player position: ``` { x = 18908.712890625, y = 2.5, z = 18733.041015625 } ``` Player look: ``` { x = 0.51172780990601, y = -0.63876783847809, z = 0.57455235719681 } ``` Player information: ``` { min_jitter = 0, max_jitter = 1.8049999475479, avg_jitter = 0, connection_uptime = 2581, serialization_version = 29, patch = 0, state = "Active", version_string = "5.8.0", formspec_version = 7, protocol_version = 42, minor = 8, min_rtt = 0.14300000667572, lang_code = "zh_CN", ip_version = 6, max_rtt = 1.9609999656677, major = 5, avg_rtt = 0.14699999988079 } ``` Player meta: ``` { fields = { ["ocean_build.ocean_built"] = "8", jointime = "1700288470", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 360\", \"3d_armor:helmet_rainbow 1 18826\", \"shields:shield_rainbow 1 17976\", \"3d_armor:leggings_rainbow 1 17976\", \"3d_armor:chestplate_rainbow 1 17976\", \"\"}", ["signslib:pos"] = "(18765,33,18509)", crafted = "58801", hud_state = "on", ["petz:werewolf"] = "0", died = "241", ["petz:werewolf_clan_idx"] = "2", ["stamina:level"] = "5", bitten = "0", ["stamina:poisoned"] = "no", ["ambience.svol"] = "0.1", yl_commons_thankyou = "24", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\", \"unified_inventory:bag_large\"}", yl_commons_player_created = "1700288470", yl_commons_player_joined = "1704087138", yl_church = "return {[\"last_heal\"] = 1700995484, [\"last_death_portal\"] = 1704071226, [\"last_death\"] = {[\"x\"] = 18821, [\"y\"] = 50, [\"z\"] = 18472}}", punch_count = "12757", xp = "72837", inflicted_damage = "245662", digged_nodes = "93295", placed_nodes = "39119", partychat = "party", repellant = "0", ["petz:lycanthropy"] = "0", ["stamina:exhaustion"] = "82", played_time = "980294", ["ocean_build.last_warning"] = "1703421567" } } ``` Log identifier ``` [MOD] yl_report log identifier = y9s41guJcBPBOMEfEnoDOACo8Tk6UWPl ``` Profiler save: ``` profile-20240101T061509.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 3h 33min 49s | max lag: 0.786s | clients (14/52): AliasAlreadyTaken, bancha, Brabenec, daydream, DezS4125, DutchessPyle, flux, Jammy, Kadax, Lupercus, ny, Parrish, Penelopee, rewired_X1 ``` Teleport command: ``` /teleport xyz 18909 3 18733 ``` Compass command: ``` /give_compass Construction y9s41guJcBPBOMEfEnoDOACo8Tk6UWPl D2691E 18909 3 18733 ```

AliasAlreadyTaken was assigned by yourland-report

2024-01-01 06:15:09 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

2. prio/low

2. prio/good first issue

labels 2024-01-01 16:29:43 +00:00

rewired_X commented

2024-03-15 17:01:50 +00:00

i might be able to figure this out if i can peek at the section of code responsible for this

i *might* be able to figure this out if i can peek at the section of code responsible for this

flux commented

2024-03-16 04:08:13 +00:00

i'm not even sure this is a problem. use tab autocomplete? from what i remember, thankyou uses canonical_name? why do you want to be able to fail to type someone's name repeatedly?

AliasAlreadyTaken commented

2024-03-16 15:51:01 +00:00

The issue is that when a player does /thankyou flox, he needs to wait until the cooldown expires before trying again. We could make it that there is no cooldown, when a name was mistyped. This becomes increasingly complex when there are multiple people thankyou'd at once. You'd have to keep trap for each when they were thankyou'd last by whom (n:m problem).

The issue is that when a player does `/thankyou flox`, he needs to wait until the cooldown expires before trying again. We could make it that there is no cooldown, when a name was mistyped. This becomes increasingly complex when there are multiple people thankyou'd at once. You'd have to keep trap for each when they were thankyou'd last by whom (n:m problem).

DragonWrangler referenced this issue

2024-04-19 18:31:22 +00:00

AspireMint reports: There is cooldown on /thankyou ... #6679

Sign in to join this conversation.