your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

You cannot add certain languages in /bug. I added Chinese characters to report a translation issue and it crashed the game. #5842

New Issue
Open
opened 2023-12-27 10:28:27 +00:00 by Jammy · 9 comments
Jammy commented 2023-12-27 10:28:27 +00:00
Copy Link

Server crash. Please try logging in again. Livestream: https://www.twitch.tv/bailiffofhaven Contact: info@your-land.de

Server crash. Please try logging in again. Livestream: https://www.twitch.tv/bailiffofhaven Contact: info@your-land.de
Jammy changed title from Server crash. This is very severe. to You cannot add certain languages in /bug. I added Chinese characters to report a translation issue and it crashed the game. 2023-12-27 10:33:41 +00:00
AzelfYL commented 2023-12-27 13:10:39 +00:00
Copy Link

Unable to reproduce on the test server, and I'll be damned before I try again on the main server

Unable to reproduce on the test server, and I'll be damned before I try again on the main server
whosit commented 2023-12-27 14:49:37 +00:00
Member
Copy Link

trace: your-land/log_yl_main#98

trace: https://gitea.your-land.de/your-land/log_yl_main/issues/98
AliasAlreadyTaken commented 2023-12-27 17:56:24 +00:00
Owner
Copy Link
2023-12-27 10:27:50: ERROR[CurlFetch]: HTTPFetch for https://gitea.your-land.de/api/v1/repos/your-land/bugtracker/issues?token=secret returned response code 500
2023-12-27 10:29:01: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_report' in callback environment_Step(): .../5.7.0/Minetest_live/bin/../mods/yl_report/functions.lua:58: attempt to concatenate field 'number' (a nil value)
2023-12-27 10:29:01: ERROR[Main]: stack traceback:
2023-12-27 10:29:01: ERROR[Main]: 	.../5.7.0/Minetest_live/bin/../mods/yl_report/functions.lua:58: in function 'result_of_gitea'
2023-12-27 10:29:01: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../mods/yl_report/init.lua:59: in function 'callback'
2023-12-27 10:29:01: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../builtin/game/misc.lua:213: in function 'func'
2023-12-27 10:29:01: ERROR[Main]: 	...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:27: in function <...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:11>
2023-12-27 10:29:01: ERROR[Main]: 	.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
``` 2023-12-27 10:27:50: ERROR[CurlFetch]: HTTPFetch for https://gitea.your-land.de/api/v1/repos/your-land/bugtracker/issues?token=secret returned response code 500 2023-12-27 10:29:01: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_report' in callback environment_Step(): .../5.7.0/Minetest_live/bin/../mods/yl_report/functions.lua:58: attempt to concatenate field 'number' (a nil value) 2023-12-27 10:29:01: ERROR[Main]: stack traceback: 2023-12-27 10:29:01: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/yl_report/functions.lua:58: in function 'result_of_gitea' 2023-12-27 10:29:01: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/yl_report/init.lua:59: in function 'callback' 2023-12-27 10:29:01: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/misc.lua:213: in function 'func' 2023-12-27 10:29:01: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:27: in function <...e/mt/5.7.0/Minetest_live/bin/../builtin/common/after.lua:11> 2023-12-27 10:29:01: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ```
AliasAlreadyTaken commented 2023-12-27 18:49:56 +00:00
Owner
Copy Link

My implementation begs a lot of questions. Why is this not made async?? Why do I only look at the succeed and not at the return code?

My implementation begs a lot of questions. Why is this not made async?? Why do I only look at the `succeed` and not at the return code?
flux added the
1. kind/bug
2. prio/critical
 labels 2023-12-27 20:13:27 +00:00
flux commented 2023-12-27 20:15:24 +00:00
Member
Copy Link

it's possible that the report failure was spurious and not related to the chinese characters - the code should be checking whether the report was a success

it's possible that the report failure was spurious and not related to the chinese characters - the code should be checking whether the report was a success
Jammy commented 2023-12-28 12:17:53 +00:00
Author
Copy Link

Seemingly it is fixed. I tested /bug again and did not crash.

Seemingly it is fixed. I tested /bug again and did not crash.
Boot commented 2023-12-28 12:29:12 +00:00
Member
Copy Link

In doing so, you deliberately accepted the crash of the server. This is against all the rules. I'm expecting a serious warning for Jammy.

In doing so, you deliberately accepted the crash of the server. This is against all the rules. I'm expecting a serious warning for Jammy.
👍 7 😕 1
rewired_X commented 2023-12-28 12:42:40 +00:00
Copy Link

Seemingly it is fixed. I tested /bug again and did not crash.

It doesn't matter what language you put in, the server crashed because gitea failed to generate the report w/ error 500. Thus causing the report code to fail due to a nil value being concatenated.

Plus this was already tested in the testserver: #5844

> Seemingly it is fixed. I tested /bug again and did not crash. It doesn't matter what language you put in, the server crashed because gitea failed to generate the report w/ error 500. Thus causing the report code to fail due to a nil value being concatenated. Plus this was already tested in the testserver: #5844
AliasAlreadyTaken commented 2023-12-28 15:51:39 +00:00
Owner
Copy Link

Seemingly it is fixed. I tested /bug again and did not crash.

Response code 500 means there was an internal server error, which apparently wasn't caused by chinese characters. Do NOT test stuff that might result in a servercrash on the main server!

> Seemingly it is fixed. I tested /bug again and did not crash. Response code 500 means there was an internal server error, which apparently wasn't caused by chinese characters. Do NOT test stuff that might result in a servercrash on the main server!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5842
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?