your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

deprecated moreblocks node definitions #5826

New Issue
Open
opened 2023-12-25 13:57:30 +00:00 by rewired_X · 18 comments
rewired_X commented 2023-12-25 13:57:30 +00:00
Copy Link

2023-12-25 08:55:16: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope.obj loaded with 5 mesh buffers but only 1 texture(s) specified, this is deprecated.

`2023-12-25 08:55:16: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope.obj loaded with 5 mesh buffers but only 1 texture(s) specified, this is deprecated.`
Screenshot (1234).png
772 KiB
Screenshot (1234).png
AliasAlreadyTaken commented 2023-12-25 16:36:07 +00:00
Owner
Copy Link

2023-12-25 05:04:01: WARNING[Main]: GenericCAO::addToScene(): Model mobs_oerkki.b3d loaded with 2 mesh buffers but only 1 texture(s) specified, this is deprecated.

2023-12-25 05:08:50: WARNING[Main]: GenericCAO::addToScene(): Model water_life_crocodile.b3d loaded with 9 mesh buffers but only 1 texture(s) specified, this is deprecated.

2023-12-25 05:04:01: WARNING[Main]: GenericCAO::addToScene(): Model mobs_oerkki.b3d loaded with 2 mesh buffers but only 1 texture(s) specified, this is deprecated. 2023-12-25 05:08:50: WARNING[Main]: GenericCAO::addToScene(): Model water_life_crocodile.b3d loaded with 9 mesh buffers but only 1 texture(s) specified, this is deprecated.
AliasAlreadyTaken added the
1. kind/bug
 label 2023-12-25 16:36:24 +00:00
AliasAlreadyTaken commented 2023-12-25 16:36:32 +00:00
Owner
Copy Link

source/maintenance ?

source/maintenance ?
flux commented 2023-12-25 19:23:22 +00:00
Member
Copy Link

the croc and oerkki are #5699

the croc and oerkki are #5699
flux commented 2023-12-25 19:24:15 +00:00
Member
Copy Link

should i fix this in my moreblocks fork, or should we upstream this to the other moreblocks?

should i fix this in my moreblocks fork, or should we upstream this to the other moreblocks?
flux added the
3. source/mod upstream
3. source/art
 labels 2023-12-25 19:29:35 +00:00
flux commented 2023-12-25 19:31:46 +00:00
Member
Copy Link

i created an upstream issue on the original fork in case someone fixes it (so i don't have to learn blender) https://github.com/minetest-mods/moreblocks/issues/203

i created an upstream issue on the original fork in case someone fixes it (so i don't have to learn blender) https://github.com/minetest-mods/moreblocks/issues/203
👍 1 😆 1
rewired_X commented 2024-02-03 00:15:46 +00:00
Author
Copy Link

Triggered again except its a different(?) slope
2024-02-02 19:14:14: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_outer_half.obj loaded with 4 mesh buffers but only 1 texture(s) specified, this is deprecated.

Triggered again except its a different(?) slope `2024-02-02 19:14:14: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_outer_half.obj loaded with 4 mesh buffers but only 1 texture(s) specified, this is deprecated.`
Screenshot (1636).png
1.2 MiB
Screenshot (1636).png
rewired_X commented 2024-02-03 12:41:12 +00:00
Author
Copy Link

can someone just place me in a room full of slopes
2024-02-03 07:39:21: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_half.obj loaded with 5 mesh buffers but only 1 texture(s) specified, this is deprecated.

can someone just place me in a room full of slopes `2024-02-03 07:39:21: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_half.obj loaded with 5 mesh buffers but only 1 texture(s) specified, this is deprecated.`
Screenshot (1637).png
1.2 MiB
Screenshot (1637).png
flux commented 2024-02-03 19:36:06 +00:00
Member
Copy Link

can someone just place me in a room full of slopes

that's in the attic of the advanced tutorial

> can someone just place me in a room full of slopes that's in the attic of the advanced tutorial
rewired_X commented 2024-02-03 20:11:45 +00:00
Author
Copy Link

can someone just place me in a room full of slopes

that's in the attic of the advanced tutorial

oh. in that case I went to there and no new warnings appeared. only after I explore the area around GV/Antarcity/Fanagoria i start getting warnings.

> > can someone just place me in a room full of slopes > > that's in the attic of the advanced tutorial oh. in that case I went to there and no new warnings appeared. only after I explore the area around GV/Antarcity/Fanagoria i start getting warnings.
AliasAlreadyTaken commented 2024-02-04 18:16:48 +00:00
Owner
Copy Link

Is this fixed by flux' moreblocks fork? If so, please add it to the moreblocks milestone.

Is this fixed by flux' moreblocks fork? If so, please add it to the moreblocks milestone.
flux commented 2024-02-04 20:22:10 +00:00
Member
Copy Link

Is this fixed by flux' moreblocks fork? If so, please add it to the moreblocks milestone.

no, i didn't touch the models, and i'd prefer not to have to if possible...

> Is this fixed by flux' moreblocks fork? If so, please add it to the moreblocks milestone. no, i didn't touch the models, and i'd prefer not to have to if possible...
Bla commented 2024-02-04 20:42:05 +00:00
Copy Link

"fixing" the model would also break other slope nodes.
a slope has 5 sides so the model has 1 material per side assigned, without that slopes like from logs(outside bark, inside wood) wouldn´t be possible.
the correct way is to also define a texture for the other 4 sides even if its the same texture.

"fixing" the model would also break other slope nodes. a slope has 5 sides so the model has 1 material per side assigned, without that slopes like from logs(outside bark, inside wood) wouldn´t be possible. the correct way is to also define a texture for the other 4 sides even if its the same texture.
flux commented 2024-02-04 22:44:07 +00:00
Member
Copy Link

"fixing" the model would also break other slope nodes.
a slope has 5 sides so the model has 1 material per side assigned, without that slopes like from logs(outside bark, inside wood) wouldn´t be possible.
the correct way is to also define a texture for the other 4 sides even if its the same texture.

it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one.

> "fixing" the model would also break other slope nodes. > a slope has 5 sides so the model has 1 material per side assigned, without that slopes like from logs(outside bark, inside wood) wouldn´t be possible. > the correct way is to also define a texture for the other 4 sides even if its the same texture. it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one.
flux commented 2024-02-04 22:46:56 +00:00
Member
Copy Link

it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one.

actually i wonder if i can fix this just by specifying the same tile 5 times... hm.

> it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one. actually i wonder if i can fix this just by specifying the same tile 5 times... hm.
👍 1
flux added this to the flux's TODO list project 2024-02-04 22:47:18 +00:00
flux self-assigned this 2024-02-04 22:47:23 +00:00
Bla commented 2024-02-04 22:51:11 +00:00
Copy Link

the correct way is to also define a texture for the other 4 sides even if its the same texture.

it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one.

please read again

> > the correct way is to also define a texture for the other 4 sides even if its the same texture. > > it's the other way around - the mesh expects 5 textures, but moreblocks is only supplying one. please read again
rewired_X commented 2024-03-18 19:12:55 +00:00
Author
Copy Link

another one:
2024-03-18 15:10:46: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_half_raised.obj loaded with 6 mesh buffers but only 1 texture(s) specified, this is deprecated.

another one: `2024-03-18 15:10:46: WARNING[Main]: GenericCAO::addToScene(): Model moreblocks_slope_half_raised.obj loaded with 6 mesh buffers but only 1 texture(s) specified, this is deprecated.`
Screenshot (2389).png
1.4 MiB
Screenshot (2389).png
AliasAlreadyTaken added this to the moreblocks milestone 2024-03-18 19:55:11 +00:00
flux commented 2024-03-19 03:24:19 +00:00
Member
Copy Link

i really don't want to learn how to edit 3d models with blender, but what else can i do? i get the feeling that my first 30 hours of work will be worse than what we've already got.

i really don't want to learn how to edit 3d models with blender, but what else can i do? i get the feeling that my first 30 hours of work will be worse than what we've already got.
whosit commented 2024-03-19 06:34:30 +00:00
Member
Copy Link

I think Bla is right: "fixing" it in blender would be just doing same as this:

diff --git a/models/moreblocks_slope_half.obj b/models/moreblocks_slope_half.obj
index 1fa631c..53f4f1c 100644
--- a/models/moreblocks_slope_half.obj
+++ b/models/moreblocks_slope_half.obj
@@ -10,7 +10,7 @@ vt 1.0000 0.0000
 vn 0.0000 0.8944 -0.4472
 s off
 f 2/1/1 1/2/1 4/3/1 3/4/1
-g bottom
+
 v -0.500000 -0.500000 0.500000
 v 0.500000 -0.500000 0.500000
 v -0.500000 -0.500000 -0.500000
@@ -22,7 +22,7 @@ vt 0.0000 1.0000
 vn 0.0000 -1.0000 -0.0000
 s off
 f 6/5/2 5/6/2 7/7/2 8/8/2
-g right
+
 v -0.500000 -0.000000 0.500000
 v -0.500000 -0.500000 0.500000
 v -0.500000 -0.500000 -0.500000
@@ -32,7 +32,7 @@ vt 1.0000 0.0000
 vn -1.0000 0.0000 0.0000
 s off
 f 9/9/3 11/10/3 10/11/3
-g left
+
 v 0.500000 -0.000000 0.500000
 v 0.500000 -0.500000 0.500000
 v 0.500000 -0.500000 -0.500000
@@ -42,7 +42,7 @@ vt 1.0000 0.0000
 vn 1.0000 0.0000 0.0000
 s off
 f 12/12/4 13/13/4 14/14/4
-g back
+
 v 0.500000 -0.000000 0.500000
 v -0.500000 -0.000000 0.500000
 v -0.500000 -0.500000 0.500000

i.e. removing named vertex groups.

And the result would be:
Screenshot 2024-03-19 092751

Which is not what we want. We want to specify textures for each side manually. So it's the code assigning texture is broken, and not the models.

In other words, it's not the model that's deprecated, but not specifying number of textures equal to number of "mesh buffers" is deprecated.

(I can't trigger the warning, either by placing slopes down or putting them into item frames, so I can't really confirm that warning is gone with this change, but it must be.)

I think Bla is right: "fixing" it in blender would be just doing same as this: ```diff diff --git a/models/moreblocks_slope_half.obj b/models/moreblocks_slope_half.obj index 1fa631c..53f4f1c 100644 --- a/models/moreblocks_slope_half.obj +++ b/models/moreblocks_slope_half.obj @@ -10,7 +10,7 @@ vt 1.0000 0.0000 vn 0.0000 0.8944 -0.4472 s off f 2/1/1 1/2/1 4/3/1 3/4/1 -g bottom + v -0.500000 -0.500000 0.500000 v 0.500000 -0.500000 0.500000 v -0.500000 -0.500000 -0.500000 @@ -22,7 +22,7 @@ vt 0.0000 1.0000 vn 0.0000 -1.0000 -0.0000 s off f 6/5/2 5/6/2 7/7/2 8/8/2 -g right + v -0.500000 -0.000000 0.500000 v -0.500000 -0.500000 0.500000 v -0.500000 -0.500000 -0.500000 @@ -32,7 +32,7 @@ vt 1.0000 0.0000 vn -1.0000 0.0000 0.0000 s off f 9/9/3 11/10/3 10/11/3 -g left + v 0.500000 -0.000000 0.500000 v 0.500000 -0.500000 0.500000 v 0.500000 -0.500000 -0.500000 @@ -42,7 +42,7 @@ vt 1.0000 0.0000 vn 1.0000 0.0000 0.0000 s off f 12/12/4 13/13/4 14/14/4 -g back + v 0.500000 -0.000000 0.500000 v -0.500000 -0.000000 0.500000 v -0.500000 -0.500000 0.500000 ``` i.e. removing named vertex groups. And the result would be: ![Screenshot 2024-03-19 092751](/attachments/becbb047-0515-4ced-b8cf-bd4755c60541) Which is not what we want. We want to specify textures for each side manually. So it's the code assigning texture is broken, and not the models. In other words, it's not the _model_ that's deprecated, but not specifying number of textures equal to number of "mesh buffers" is deprecated. (I can't trigger the warning, either by placing slopes down or putting them into item frames, so I can't really confirm that warning is gone with this change, but it must be.)
Screenshot 2024-03-19 092751.png
94 KiB
whosit changed title from deprecated moreblocks slope model to deprecated moreblocks node definitions 2024-03-19 06:48:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
moreblocks
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
flux
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5826
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?