daydream QA on test: waterlife - can't place the fi ... #5684

New Issue

yourland-report · 2023-12-14T01:34:23Z

yourland-report commented

2023-12-14 01:34:23 +00:00

daydream reports a bug:

waterlife - can't place the fish (like in a tank or back into ocean, etc.)

Player position:

{
	y = 0.070000000298023,
	z = -8416.8212890625,
	x = -7410.0966796875
}

Player look:

{
	y = -0.61152702569962,
	z = -0.49804055690765,
	x = 0.61480909585953
}

Player information:

{
	major = 5,
	version_string = "5.8.0",
	state = "Active",
	lang_code = "",
	minor = 8,
	min_rtt = 0.15700000524521,
	avg_rtt = 0.16400000452995,
	min_jitter = 0,
	max_jitter = 2.069000005722,
	avg_jitter = 0,
	connection_uptime = 3960,
	serialization_version = 29,
	patch = 0,
	max_rtt = 2.2309999465942,
	ip_version = 6,
	protocol_version = 42,
	formspec_version = 7
}

Player meta:

{
	fields = {
		["petz:werewolf_vignette_id"] = "19",
		["stamina:level"] = "6",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["signslib:pos"] = "(1971,-2757,1508)",
		["stamina:exhaustion"] = "52.5",
		punch_count = "522618",
		repellant = "0",
		yl_commons_thankyou = "663",
		played_time = "33320445",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		placed_nodes = "441027",
		xp = "2789403",
		crafted = "185768",
		["petz:werewolf_clan_idx"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 20043, [\"y\"] = 19987, [\"z\"] = 20040}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1694869693}",
		partychat = "party",
		inflicted_damage = "9089104",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 3286\", \"shields:shield_rainbow 1 1322\", \"3d_armor:chestplate_nether 1 5280\", \"3d_armor:leggings_nether 1 5280\", \"3d_armor:boots_crystal 1 3286\", \"\"}",
		jointime = "1650064821",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		xp_redo_hud_color = "0xFFC001",
		hud_state = "on",
		["petz:werewolf"] = "0",
		died = "339",
		digged_nodes = "2584690",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1702513721",
		arenalib_infobox_arenaID = "0",
		["ocean_build.last_warning"] = "1.65235e+09",
		["petz:lycanthropy"] = "0",
		["ocean_build.ocean_built"] = "8"
	}
}

Log identifier


[MOD] yl_report log identifier = U3XFNiTOpfHXNCKjsotYbT4nBG69NLTb

Profiler save:

profile-20231214T013423.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 51min 25s | max lag: 0.164s | clients (4/52): Administrator, Boris, daydream, rewired_X

Teleport command:

/teleport xyz -7410 0 -8417

Compass command:

/give_compass Construction U3XFNiTOpfHXNCKjsotYbT4nBG69NLTb D2691E -7410 0 -8417

daydream reports a bug: > waterlife - can't place the fish (like in a tank or back into ocean, etc.) Player position: ``` { y = 0.070000000298023, z = -8416.8212890625, x = -7410.0966796875 } ``` Player look: ``` { y = -0.61152702569962, z = -0.49804055690765, x = 0.61480909585953 } ``` Player information: ``` { major = 5, version_string = "5.8.0", state = "Active", lang_code = "", minor = 8, min_rtt = 0.15700000524521, avg_rtt = 0.16400000452995, min_jitter = 0, max_jitter = 2.069000005722, avg_jitter = 0, connection_uptime = 3960, serialization_version = 29, patch = 0, max_rtt = 2.2309999465942, ip_version = 6, protocol_version = 42, formspec_version = 7 } ``` Player meta: ``` { fields = { ["petz:werewolf_vignette_id"] = "19", ["stamina:level"] = "6", bitten = "0", ["stamina:poisoned"] = "no", ["signslib:pos"] = "(1971,-2757,1508)", ["stamina:exhaustion"] = "52.5", punch_count = "522618", repellant = "0", yl_commons_thankyou = "663", played_time = "33320445", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", placed_nodes = "441027", xp = "2789403", crafted = "185768", ["petz:werewolf_clan_idx"] = "1", yl_church = "return {[\"last_death\"] = {[\"x\"] = 20043, [\"y\"] = 19987, [\"z\"] = 20040}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1694869693}", partychat = "party", inflicted_damage = "9089104", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 3286\", \"shields:shield_rainbow 1 1322\", \"3d_armor:chestplate_nether 1 5280\", \"3d_armor:leggings_nether 1 5280\", \"3d_armor:boots_crystal 1 3286\", \"\"}", jointime = "1650064821", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", xp_redo_hud_color = "0xFFC001", hud_state = "on", ["petz:werewolf"] = "0", died = "339", digged_nodes = "2584690", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1702513721", arenalib_infobox_arenaID = "0", ["ocean_build.last_warning"] = "1.65235e+09", ["petz:lycanthropy"] = "0", ["ocean_build.ocean_built"] = "8" } } ``` Log identifier ``` [MOD] yl_report log identifier = U3XFNiTOpfHXNCKjsotYbT4nBG69NLTb ``` Profiler save: ``` profile-20231214T013423.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 51min 25s | max lag: 0.164s | clients (4/52): Administrator, Boris, daydream, rewired_X ``` Teleport command: ``` /teleport xyz -7410 0 -8417 ``` Compass command: ``` /give_compass Construction U3XFNiTOpfHXNCKjsotYbT4nBG69NLTb D2691E -7410 0 -8417 ```

AliasAlreadyTaken was assigned by yourland-report

2023-12-14 01:34:23 +00:00

AliasAlreadyTaken added the

1. kind/bug

3. source/integration

labels 2023-12-14 01:34:41 +00:00

daydream changed title from ~~daydream reports: waterlive - can't place the fi ...~~ to daydream reports: waterlife - can't place the fi ...

2023-12-14 01:35:05 +00:00

daydream changed title from ~~daydream reports: waterlife - can't place the fi ...~~ to daydream QA on test: waterlife - can't place the fi ...

2023-12-14 01:35:47 +00:00

flux added the

4. step/question

4. step/needs confirmation

labels 2023-12-14 21:13:17 +00:00

flux commented

2023-12-14 21:14:11 +00:00

which fish? i managed to place water_life:riverfish, water_life:coralfish, and water_life:clownfish into the ocean just fine. only petz fish can be placed in the petz fishtank.

AliasAlreadyTaken commented

2023-12-15 02:24:16 +00:00

We tried to place water_life:coralfish on orange corals

flux commented

2023-12-16 04:50:17 +00:00

We tried to place water_life:coralfish on orange corals

i'm able to just place those anywhere in the ocean. possibly it has biome/heat/humidity requirements, gotta dig into that. i didn't see any when i was digging about for the urchin spawn rules though...

> We tried to place water_life:coralfish on orange corals i'm able to just place those anywhere in the ocean. possibly it has biome/heat/humidity requirements, gotta dig into that. i didn't see any when i was digging about for the urchin spawn rules though...

flux commented

2023-12-16 21:23:01 +00:00

i can verify that i can place them one place, but not in another nearby place. still looking for what might be causing that.

flux commented

2023-12-16 21:37:36 +00:00

relevant code: 3975f86b4f/crafts.lua (L178-L179)

				local number = water_life.count_objects(pos,nil,"water_life:coralfish_tamed")
				if number.all > water_life.maxmobs or number.name > 10 then return itemstack end

water_life.count_objects counts all objects within 16 * minetest.settings:get_int("active_object_send_range_blocks") nodes of the position where the player is trying to place the fish - in our case, a sphere of radius 80. if there are more than minetest.settings:get_int("water_life_maxmobs") (30) of any object in that radius, including players, then the fish will fail to place. additionally, if there are more than 10 tamed coralfish in the same radius, it will also fail to place.

relevant code: https://gitea.your-land.de/your-land/water_life/src/commit/3975f86b4fb77d402633b62a3d16e4d2a4eae260/crafts.lua#L178-L179 ```lua local number = water_life.count_objects(pos,nil,"water_life:coralfish_tamed") if number.all > water_life.maxmobs or number.name > 10 then return itemstack end ``` `water_life.count_objects` counts all objects within `16 * minetest.settings:get_int("active_object_send_range_blocks")` nodes of the position where the player is trying to place the fish - in our case, a sphere of radius 80. if there are more than `minetest.settings:get_int("water_life_maxmobs")` (30) of *any* object in that radius, including players, then the fish will fail to place. additionally, if there are more than 10 tamed coralfish in the same radius, it will also fail to place.

flux commented

2023-12-16 21:38:38 +00:00

possibly this can be closed as "documented", or we can petition water_life to change the behavior, or at least give a warning about why it's not placing.

AliasAlreadyTaken commented

2023-12-17 00:45:41 +00:00

We could also remove all the restriction of placement and only obey them during spawn. I don't think it's a good mechanic that animals, once spawned, immediately die when the temperature is not right. During spawn it is good when the circumstances are obeyed.

The player has no way to tell whether a place is suitable or not
The player cannot see where temperature borders run. Imagine he builds an aquarium where a single block is not suitable. AS soon as fishes swim in, they die. This looks random and unintuitive
The player has no means of changing the temperature, like with fire blocks or similar

We could also remove all the restriction of placement and only obey them during spawn. I don't think it's a good mechanic that animals, once spawned, immediately die when the temperature is not right. During spawn it is good when the circumstances are obeyed. * The player has no way to tell whether a place is suitable or not * The player cannot see where temperature borders run. Imagine he builds an aquarium where a single block is not suitable. AS soon as fishes swim in, they die. This looks random and unintuitive * The player has no means of changing the temperature, like with fire blocks or similar

flux commented

2023-12-17 01:18:09 +00:00

I don't think it's a good mechanic that animals, once spawned, immediately die when the temperature is not right.

i agree, though that's not the issue here. if you can't place the fish due to over-congestion, you keep the item.

> I don't think it's a good mechanic that animals, once spawned, immediately die when the temperature is not right. i agree, though that's not the issue here. if you can't place the fish due to over-congestion, you keep the item.

Sign in to join this conversation.