Redshirt reports: entered the zeppelin docked at ... #5680

New Issue

yourland-report · 2023-12-14T00:33:10Z

yourland-report commented

2023-12-14 00:33:10 +00:00

Redshirt reports a bug:

entered the zeppelin docked at haven - and then was trapped. /spawn and /home gave successful teleport messages - but even after logging in anew i was still on the zeppelin. exiting via right-click worked - and got me killed. alias changed parking position a bit now, but it's still a problem. can't have players trapped on an airship desperately having to look for a crime to commint in order to get free without getting killed

Player position:

{
	y = 77.5,
	z = 1280.7459716797,
	x = 2181.8461914063
}

Player look:

{
	y = -0.39810872077942,
	z = -0.91513705253601,
	x = 0.063511244952679
}

Player information:

{
	max_rtt = 5.4340000152588,
	major = 5,
	ip_version = 6,
	min_rtt = 0.01799999922514,
	avg_rtt = 0.019999999552965,
	min_jitter = 0,
	max_jitter = 5.2449998855591,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 1555,
	patch = 0,
	formspec_version = 7,
	protocol_version = 42,
	minor = 9,
	lang_code = "",
	version_string = "5.9.0-dev-a98200bb4-dirty",
	serialization_version = 29,
	state = "Active"
}

Player meta:

{
	fields = {
		inflicted_damage = "892236",
		["stamina:level"] = "17",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"z\"] = 1269, [\"x\"] = 2158}, [\"last_death_portal\"] = 1671239183}",
		died = "9",
		crafted = "50509",
		["stamina:exhaustion"] = "49",
		played_time = "919321",
		partychat = "party",
		jointime = "1631645913",
		yl_commons_thankyou = "24",
		yl_commons_player_created = "1631645913",
		yl_commons_player_joined = "1702512457",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_clan_idx"] = "3",
		hud_state = "on",
		digged_nodes = "115034",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["petz:lycanthropy"] = "1",
		repellant = "0",
		arenalib_infobox_arenaID = "0",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "5",
		["stamina:poisoned"] = "no",
		["petz:werewolf"] = "0",
		xp = "121686",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 280\", \"shields:shield_rainbow 1 112\", \"3d_armor:chestplate_crystal 1 280\", \"3d_armor:boots_crystal 1 280\", \"3d_armor:leggings_crystal 1 280\"}",
		placed_nodes = "8936",
		punch_count = "40786"
	}
}

Log identifier


[MOD] yl_report log identifier = b6eJaeIJAw9vh23tT9zTBYEwfxlpPdg2

Profiler save:

profile-20231214T003310.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 5min 45s | max lag: 0.651s | clients (16/52): Alcotown, AliasAlreadyTaken, daydream, flux, Jammy, KitCat, Lupercus, nazthelizard122, poppyasdan, Redshirt, Service, static, STEALTH, taonza12, tour, zarac

Teleport command:

/teleport xyz 2182 78 1281

Compass command:

/give_compass Construction b6eJaeIJAw9vh23tT9zTBYEwfxlpPdg2 D2691E 2182 78 1281

Redshirt reports a bug: > entered the zeppelin docked at haven - and then was trapped. /spawn and /home gave successful teleport messages - but even after logging in anew i was still on the zeppelin. exiting via right-click worked - and got me killed. alias changed parking position a bit now, but it's still a problem. can't have players trapped on an airship desperately having to look for a crime to commint in order to get free without getting killed Player position: ``` { y = 77.5, z = 1280.7459716797, x = 2181.8461914063 } ``` Player look: ``` { y = -0.39810872077942, z = -0.91513705253601, x = 0.063511244952679 } ``` Player information: ``` { max_rtt = 5.4340000152588, major = 5, ip_version = 6, min_rtt = 0.01799999922514, avg_rtt = 0.019999999552965, min_jitter = 0, max_jitter = 5.2449998855591, avg_jitter = 0.0010000001639128, connection_uptime = 1555, patch = 0, formspec_version = 7, protocol_version = 42, minor = 9, lang_code = "", version_string = "5.9.0-dev-a98200bb4-dirty", serialization_version = 29, state = "Active" } ``` Player meta: ``` { fields = { inflicted_damage = "892236", ["stamina:level"] = "17", yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"z\"] = 1269, [\"x\"] = 2158}, [\"last_death_portal\"] = 1671239183}", died = "9", crafted = "50509", ["stamina:exhaustion"] = "49", played_time = "919321", partychat = "party", jointime = "1631645913", yl_commons_thankyou = "24", yl_commons_player_created = "1631645913", yl_commons_player_joined = "1702512457", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_clan_idx"] = "3", hud_state = "on", digged_nodes = "115034", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["petz:lycanthropy"] = "1", repellant = "0", arenalib_infobox_arenaID = "0", bitten = "0", ["petz:werewolf_vignette_id"] = "5", ["stamina:poisoned"] = "no", ["petz:werewolf"] = "0", xp = "121686", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 280\", \"shields:shield_rainbow 1 112\", \"3d_armor:chestplate_crystal 1 280\", \"3d_armor:boots_crystal 1 280\", \"3d_armor:leggings_crystal 1 280\"}", placed_nodes = "8936", punch_count = "40786" } } ``` Log identifier ``` [MOD] yl_report log identifier = b6eJaeIJAw9vh23tT9zTBYEwfxlpPdg2 ``` Profiler save: ``` profile-20231214T003310.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 5min 45s | max lag: 0.651s | clients (16/52): Alcotown, AliasAlreadyTaken, daydream, flux, Jammy, KitCat, Lupercus, nazthelizard122, poppyasdan, Redshirt, Service, static, STEALTH, taonza12, tour, zarac ``` Teleport command: ``` /teleport xyz 2182 78 1281 ``` Compass command: ``` /give_compass Construction b6eJaeIJAw9vh23tT9zTBYEwfxlpPdg2 D2691E 2182 78 1281 ```

AliasAlreadyTaken was assigned by yourland-report

2023-12-14 00:33:10 +00:00

AliasAlreadyTaken added the

1. kind/bug

4. step/discussion

labels 2023-12-14 01:35:13 +00:00

Chache commented

2023-12-14 11:39:51 +00:00

Maybe we shouldn't "park" the blimps at the observatory tower but somewhere more appropiate (alongside the Queen Clio at Haven Airport, for example)?

rewired_X commented

2023-12-14 14:09:47 +00:00

rewired would park it in a tree if he had to

AliasAlreadyTaken commented

2023-12-14 19:15:02 +00:00

There were suggestions to have small landing platforms on the Red Tower

AliasAlreadyTaken added the

3. source/ingame

1. kind/construction

labels 2023-12-14 19:15:15 +00:00

flux commented

2023-12-14 23:59:45 +00:00

i'm not going to implement it, but it'd be neat if there were integration w/ the leads mod...

/spawn and /home gave successful teleport messages - but even after logging in anew i was still on the zeppelin.

sounds like a regression of #1163?

i'm not going to implement it, but it'd be neat if there were integration w/ the leads mod... > /spawn and /home gave successful teleport messages - but even after logging in anew i was still on the zeppelin. sounds like a regression of https://gitea.your-land.de/your-land/bugtracker/issues/1163?

flux commented

2023-12-15 00:05:05 +00:00

sounds like a regression of #1163?

seems like you can still teleport out of minecarts, but not the airship. airship might be doing something weird.

also teleporting out of the minecarts is ... weirdly glitchy. it takes several seconds, and sometimes i teleport back to where the minecart still is?

> sounds like a regression of #1163? seems like you can still teleport out of minecarts, but not the airship. airship might be doing something weird. also teleporting out of the minecarts is ... weirdly glitchy. it takes several seconds, and sometimes i teleport back to where the minecart still is?

flux added the

3. source/integration

label 2023-12-15 00:05:39 +00:00

flux commented

2023-12-15 00:07:09 +00:00

discussion of where to park the zepplins notwithstanding, i think the fix here should be that /home and /spawn should properly remove the player from the vehicle. apparently we need to do this via integration.

discussion of where to park the zepplins notwithstanding, i think the fix here should be that `/home` and `/spawn` should properly remove the player from the vehicle. apparently we need to do this via integration.

👍 2

AliasAlreadyTaken commented

2023-12-15 02:01:23 +00:00

home and carts come from MTG. yay, Not even the same game looks left or right when it comes to integration with ITSELF.

flux commented

2023-12-16 00:14:18 +00:00

this is turning out to be trickier than i anticipated...

flux commented

2023-12-16 04:10:07 +00:00

upstream issue about how to proceed: https://github.com/APercy/steampunk_blimp/issues/9

i basically spent my whole functional day poking at this and writing the upstream issue...

upstream issue about how to proceed: https://github.com/APercy/steampunk_blimp/issues/9 i basically spent my whole functional day poking at this and writing the upstream issue...

👍 2

flux commented

2023-12-23 22:51:06 +00:00

there's a /blimp_eject command, which i'll try to incorporate into the teleportation logic

there's a `/blimp_eject` command, which i'll try to incorporate into the teleportation logic

flux added this to the flux's TODO list project 2023-12-23 23:00:36 +00:00

flux self-assigned this 2023-12-23 23:00:40 +00:00

AliasAlreadyTaken commented

2023-12-23 23:09:32 +00:00

Or we could ask upstream APercy to expose an ejection method?

flux commented

2023-12-23 23:56:40 +00:00

Or we could ask upstream APercy to expose an ejection method?

the ejection is exposed, it just also does additional stuff i don't want it to.

> Or we could ask upstream APercy to expose an ejection method? the ejection is exposed, it just also does additional stuff i don't want it to.

flux referenced this issue from a commit

2023-12-27 22:04:55 +00:00

your-land/bugtracker#5680 detach player from blimp when /home or /spawn etc.

flux commented

2023-12-27 22:05:17 +00:00

implemented 08ecfac3fe

implemented https://gitea.your-land.de/your-land/yl_commons/commit/08ecfac3fe2aeffbcc43f4f006a152af3bfa5c39

flux added

4. step/ready to QA test

and removed

4. step/discussion

labels 2023-12-27 22:05:27 +00:00

AliasAlreadyTaken added this to the 1.1.123 milestone 2023-12-27 23:22:56 +00:00

rewired_X referenced this issue

2024-01-10 20:45:43 +00:00

When you're standing at the mine tower in APercy's airship ... #5946

AliasAlreadyTaken commented

2024-01-28 15:29:42 +00:00

QA

I can't get myself to detach upon /spawn or /home

It flickers, it looks like it tries to, but somehow the airship seems to "drag" me back right after.

QA I can't get myself to detach upon /spawn or /home It flickers, it looks like it tries to, but somehow the airship seems to "drag" me back right after.

AliasAlreadyTaken added the

ugh/QA NOK

label 2024-01-28 15:29:54 +00:00

flux referenced this issue from a commit

2024-01-29 23:08:46 +00:00

your-land/bugtracker#5680 blimp changed the maximum number of passengers

flux commented

2024-01-29 23:09:33 +00:00

the blimp changed the maximum number of players it can carry. fixed the integration code: 906efc42ee

the blimp changed the maximum number of players it can carry. fixed the integration code: https://gitea.your-land.de/your-land/yl_commons/commit/906efc42ee7b268441259b873536cd970c45095a

👍 1

AliasAlreadyTaken commented

2024-01-30 04:27:46 +00:00

QA

/home works, I get sent home, but there's a recognizable delay. Apparently I need to click something or move a bit, before it would send me /home ?

/spawn detached me from the airship, but doesn't send me to spawn.

After detaching, I somehow keep the airship controls visible on hud.

QA `/home` works, I get sent home, but there's a recognizable delay. Apparently I need to click something or move a bit, before it would send me /home ? `/spawn` detached me from the airship, but doesn't send me to spawn. After detaching, I somehow keep the airship controls visible on hud.

flux commented

2024-01-30 20:59:34 +00:00

there's something seriously wrong with the test server, with the arrows floating in the air, things loading incredibly slowly, and the y_bows HUD getting way behind. i think these issues are also affecting the airship as well.

AliasAlreadyTaken commented

2024-01-31 04:13:35 +00:00

What could be wrong? The testserver is on MT 5.8.0 and latest update of yourland-mods, there are few mods being tested in worldmods (like basketcube). The database itself is from mid january. Alle other values, world folder, minetest.conf is the same, except things like server announce and port ofc.

flux commented

2024-02-01 00:15:05 +00:00

The testserver is on MT 5.8.0

that's the first thing i've heard that sounds suspicious; let's try going back to 5.7 and see if things improve. then again my local test server is also 5.8.

> The testserver is on MT 5.8.0 that's the first thing i've heard that sounds suspicious; let's try going back to 5.7 and see if things improve. then again my local test server is also 5.8.

AliasAlreadyTaken commented

2024-02-01 05:49:47 +00:00

We went back to 5.7.0 and tried it, but the wrong behaviour happens on 5.7.0 as well.

flux commented

2024-02-01 21:10:27 +00:00

possibly the fix to futil from #6156 might fix this?

whosit commented

2024-02-01 21:14:33 +00:00

Stuck HUD seems like a detachment bug, since the airship is even remotely controllable...

AliasAlreadyTaken commented

2024-03-04 06:32:20 +00:00

QA

There was an attempt to solve the detachment problem. Those are the cases:

Player is at the helm (yes/no)
Player is alone on board (yes/no)

Player does /h
Player does /spawn
Player is teleported out

Player ...	helm/alone	helm/not alone	not helm/alone	not helm/not alone
does /h	detach, /h, control remains	detach, /h, control remains	detach, /h delayed	detach, /h
does /spawn	detach, /spawn delayed, control remains	detach, no /spawn, control remains	detach, /spawn delayed	detach, no /spawn
is teleported	no detach, no tp, control remains	no detach, no tp, control remains	no detach, no tp	no detach, no tp
is jailed	detach, jailed after delay, control remains	detach, jailed quick, control remains	detach, jailed after delay	detach, jailed after delay

Expected in all cases is that control never remains and the player is moved to /home, /spawn, /jailed or the teleport destination immediately

QA There was an attempt to solve the detachment problem. Those are the cases: Player is at the helm (yes/no) Player is alone on board (yes/no) Player does /h Player does /spawn Player is teleported out | Player ... | helm/alone | helm/not alone | not helm/alone | not helm/not alone | | -------- | -------- | -------- | -------- | -------- | | does /h | detach, /h, control remains | detach, /h, control remains | detach, /h delayed | detach, /h | | does /spawn | detach, /spawn delayed, control remains | detach, no /spawn, control remains | detach, /spawn delayed | detach, no /spawn | | is teleported | no detach, no tp, control remains | no detach, no tp, control remains | no detach, no tp | no detach, no tp | | is jailed | detach, jailed after delay, control remains | detach, jailed quick, control remains | detach, jailed after delay | detach, jailed after delay | Expected in all cases is that control never remains and the player is moved to /home, /spawn, /jailed or the teleport destination immediately

whosit referenced this issue from a commit

2024-03-04 07:54:43 +00:00

fix steampunk_blimp detach your-land/bugtracker#5680

whosit commented

2024-03-04 07:57:57 +00:00

Found our integration code and added driver reset in this PR:
your-land/yl_commons#25

based on this formspec code from the blimp mod:
21bb86d3b1/forms.lua (L305)

~~we should bug APercy to add proper api function for this, because copying parts of his code is not the right way XD~~ - I now see the issue flux created for blimps..

Found our integration code and added driver reset in this PR: https://gitea.your-land.de/your-land/yl_commons/pulls/25 based on this formspec code from the blimp mod: https://gitea.your-land.de/your-land/steampunk_blimp/src/commit/21bb86d3b19b8d3acaf291552316c8e87d7358d3/forms.lua#L305 ~~we should bug APercy to add proper api function for this, because copying parts of his code is not the right way XD~~ - I now see the issue flux created for blimps..

whosit commented

2024-03-04 08:19:35 +00:00

Well that PR fixes remote control and hud problem, but there is still some weirdness remains...
At least locally, /h detaches me, but does not teleport.
Can't seem to enter blimp again soon after doing /h? (but can enter after some delay?)

/jail seems to use safe_teleport(), same as /spawn and /h
/teleport_other -- ? idk

Well that PR fixes remote control and hud problem, but there is still some weirdness remains... At least locally, `/h` detaches me, but does not teleport. Can't seem to enter blimp again soon after doing `/h`? (but can enter after some delay?) /jail seems to use `safe_teleport()`, same as /spawn and /h /teleport_other -- ? idk

whosit commented

2024-03-07 14:11:53 +00:00

Detaching on /h and /spawn works, there's no hud or remote controls anymore.
But /spawn just drops you down most of the time, and /h teleports you away after a delay....

Detaching on /h and /spawn works, there's no hud or remote controls anymore. But /spawn just drops you down most of the time, and /h teleports you away after a delay....

👍 1

AliasAlreadyTaken modified the milestone from 1.1.123 to 1.1.124

2024-03-07 18:12:34 +00:00

whosit commented

2024-03-08 16:28:15 +00:00

If you die while driving the blimp (by descending too fast for example), your HUD gets stuck too.

AliasAlreadyTaken referenced this issue

2024-04-26 23:05:22 +00:00

ts_furniture/init.lua:59: bad argument #1 to 'set_physics_override' (table expected, got number) #6726

Sign in to join this conversation.