testserver no spawns spawn_mobs.lua#L55 #5630

New Issue

AliasAlreadyTaken · 2023-12-09T06:04:30Z

AliasAlreadyTaken commented

2023-12-09 06:04:30 +00:00

https://gitea.your-land.de/your-land/minetest-spawnit/blame/branch/main/spawn_mobs.lua#L55

This keeps evaluating to "no spawn"

looks like the numbers are very low, if only one player is present:

2023-12-09 06:00:17: ACTION[Server]: should02 r=0.32703319056108
2023-12-09 06:00:17: ACTION[Server]: should02 (period * num_players) /(def.chance * s.spawn_chance_multiplier) =0.01147
2023-12-09 06:00:17: ACTION[Server]: should02 (period * num_players)=8.6025
2023-12-09 06:00:17: ACTION[Server]: should02 (def.chance * s.spawn_chance_multiplier)=750
2023-12-09 06:00:17: ACTION[Server]: should02 period=8.6025
2023-12-09 06:00:17: ACTION[Server]: should02 num_players =1
2023-12-09 06:00:17: ACTION[Server]: should02 def.chance =750
2023-12-09 06:00:17: ACTION[Server]: should02 s.spawn_chance_multiplier=1

That leads to the nether receiving no spawn at all. In this example we need more than 29 players online for this term to evaluate to true.

https://gitea.your-land.de/your-land/minetest-spawnit/blame/branch/main/spawn_mobs.lua#L55 This keeps evaluating to "no spawn" looks like the numbers are very low, if only one player is present: 2023-12-09 06:00:17: ACTION[Server]: should02 r=0.32703319056108 2023-12-09 06:00:17: ACTION[Server]: should02 (period * num_players) /(def.chance * s.spawn_chance_multiplier) =0.01147 2023-12-09 06:00:17: ACTION[Server]: should02 (period * num_players)=8.6025 2023-12-09 06:00:17: ACTION[Server]: should02 (def.chance * s.spawn_chance_multiplier)=750 2023-12-09 06:00:17: ACTION[Server]: should02 period=8.6025 2023-12-09 06:00:17: ACTION[Server]: should02 num_players =1 2023-12-09 06:00:17: ACTION[Server]: should02 def.chance =750 2023-12-09 06:00:17: ACTION[Server]: should02 s.spawn_chance_multiplier=1 That leads to the nether receiving no spawn at all. In this example we need more than 29 players online for this term to evaluate to true.

AliasAlreadyTaken added the

1. kind/bug

1. kind/balancing

2. prio/interesting

labels 2023-12-09 06:09:04 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-09 06:09:07 +00:00

flux commented

2023-12-09 23:09:46 +00:00

https://gitea.your-land.de/your-land/minetest-spawnit/blame/branch/main/spawn_mobs.lua#L55

This keeps evaluating to "no spawn"

correct, that is what usually should happen.

looks like the numbers are very low, if only one player is present:
...
In this example we need more than 29 players online for this term to evaluate to true.

if def.chance = 750, and 1 player is active, that means the mob should spawn once about every 750 seconds. looking further, the things which spawn once every 750 seconds are mostly petz and also mobs_animal:kitten, which shouldn't be spawning in the nether.

That leads to the nether receiving no spawn at all.

the nether was crowded the last time i was there, but i will check it again.

> https://gitea.your-land.de/your-land/minetest-spawnit/blame/branch/main/spawn_mobs.lua#L55 > > This keeps evaluating to "no spawn" correct, that is what usually should happen. > looks like the numbers are very low, if only one player is present: > ... > In this example we need more than 29 players online for this term to evaluate to true. if `def.chance = 750`, and 1 player is active, that means the mob should spawn once about every 750 seconds. looking further, the things which spawn once every 750 seconds are mostly petz and also mobs_animal:kitten, which shouldn't be spawning in the nether. > That leads to the nether receiving no spawn at all. the nether was crowded the last time i was there, but i will check it again.

flux commented

2023-12-09 23:17:09 +00:00

the nether was crowded the last time i was there, but i will check it again.

nothing is spawning in the nether... or anywhere else. angry flux noises

> the nether was crowded the last time i was there, but i will check it again. nothing is spawning in the nether... or anywhere else. *angry flux noises*

AliasAlreadyTaken commented

2023-12-09 23:46:13 +00:00

the nether was crowded the last time i was there, but i will check it again.

nothing is spawning in the nether... angry flux noises

patpat :D

It's not only a nether problem. We tried in previously unemerged mapblocks, they were near empty.

Especially in singleplayer this might show near-empty worlds

> > the nether was crowded the last time i was there, but i will check it again. > > nothing is spawning in the nether... *angry flux noises* *patpat* :D It's not only a nether problem. We tried in previously unemerged mapblocks, they were near empty. Especially in singleplayer this might show near-empty worlds

flux added the

4. step/at work

label 2023-12-10 01:14:54 +00:00

flux added this to the flux's TODO list project 2023-12-10 01:14:58 +00:00

flux self-assigned this 2023-12-10 01:15:03 +00:00

flux commented

2023-12-10 22:31:23 +00:00

think i figured out the issue - the code for checking whether the mob could spawn in a protected area was insisting that the spawn happen in an allowed protection area. if there was no area, it was not allowed. fixed: 7ca55654a3

think i figured out the issue - the code for checking whether the mob could spawn in a protected area was insisting that the spawn happen in an allowed protection area. if there was no area, it was not allowed. fixed: https://github.com/fluxionary/minetest-spawnit/commit/7ca55654a35616efcb27d1d598497c935a22e7f1

👍 1

flux added

4. step/ready to QA test

and removed

4. step/at work

labels 2023-12-10 22:31:34 +00:00

AliasAlreadyTaken commented

2023-12-11 02:36:38 +00:00

QA

Yay, things spawn again. The nether and previously not emerged mapblocks still feel a bit slow to fill up, but that's a numbers question now.

QA Yay, things spawn again. The nether and previously not emerged mapblocks still feel a bit slow to fill up, but that's a numbers question now.

AliasAlreadyTaken added the