daydream reports: are water life crocs supposed ... #5572

New Issue

yourland-report · 2023-11-30T04:15:15Z

yourland-report commented

2023-11-30 04:15:15 +00:00

daydream reports a bug:

are water life crocs supposed to be attacking my rainbow ponies on protected land?

Player position:

{
	z = 1610.0070800781,
	x = 2053.5749511719,
	y = 3.5
}

Player look:

{
	z = -0.35311901569366,
	x = 0.91846716403961,
	y = -0.1781152933836
}

Player information:

{
	major = 5,
	state = "Active",
	minor = 7,
	ip_version = 6,
	min_rtt = 0.15500000119209,
	avg_rtt = 0.16200000047684,
	min_jitter = 0,
	max_jitter = 3.2530000209808,
	avg_jitter = 0.0020000040531158,
	connection_uptime = 41125,
	serialization_version = 29,
	patch = 0,
	protocol_version = 42,
	lang_code = "",
	formspec_version = 6,
	max_rtt = 3.4260001182556,
	version_string = "5.7.0"
}

Player meta:

{
	fields = {
		punch_count = "522040",
		xp_redo_hud_color = "0xFFC001",
		["petz:werewolf"] = "0",
		arenalib_infobox_arenaID = "0",
		["petz:lycanthropy"] = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 646\", \"shields:shield_rainbow 1 266\", \"3d_armor:chestplate_nether\", \"3d_armor:leggings_nether\", \"3d_armor:boots_crystal 1 646\", \"\"}",
		["ocean_build.ocean_built"] = "8",
		["signslib:pos"] = "(2055,16,1132)",
		jointime = "1650064821",
		bitten = "0",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		xp = "2751470",
		["petz:werewolf_clan_idx"] = "1",
		played_time = "32531703",
		digged_nodes = "2540361",
		placed_nodes = "427310",
		died = "339",
		crafted = "179726",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		hud_state = "on",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1701276626",
		yl_commons_thankyou = "642",
		inflicted_damage = "9077502",
		["stamina:level"] = "9",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:poisoned"] = "no",
		repellant = "0",
		["stamina:exhaustion"] = "63.5",
		["ocean_build.last_warning"] = "1.65235e+09",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 20043, [\"y\"] = 19987, [\"z\"] = 20040}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1694869693}"
	}
}

Log identifier


[MOD] yl_report log identifier = aCaKmkRifqAi9wpKsnBYpEpGW2zmu3W1

Profiler save:

profile-20231130T041515.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 22h 48min 57s | max lag: 0.358s | clients (10/52): bluattire, daydream, hbreturns, nazthelizard122, Neon_, Parrish, Randy999, Sandmuel, taonza12, the_chosen_one

Teleport command:

/teleport xyz 2054 4 1610

Compass command:

/give_compass Construction aCaKmkRifqAi9wpKsnBYpEpGW2zmu3W1 D2691E 2054 4 1610

daydream reports a bug: > are water life crocs supposed to be attacking my rainbow ponies on protected land? Player position: ``` { z = 1610.0070800781, x = 2053.5749511719, y = 3.5 } ``` Player look: ``` { z = -0.35311901569366, x = 0.91846716403961, y = -0.1781152933836 } ``` Player information: ``` { major = 5, state = "Active", minor = 7, ip_version = 6, min_rtt = 0.15500000119209, avg_rtt = 0.16200000047684, min_jitter = 0, max_jitter = 3.2530000209808, avg_jitter = 0.0020000040531158, connection_uptime = 41125, serialization_version = 29, patch = 0, protocol_version = 42, lang_code = "", formspec_version = 6, max_rtt = 3.4260001182556, version_string = "5.7.0" } ``` Player meta: ``` { fields = { punch_count = "522040", xp_redo_hud_color = "0xFFC001", ["petz:werewolf"] = "0", arenalib_infobox_arenaID = "0", ["petz:lycanthropy"] = "0", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 646\", \"shields:shield_rainbow 1 266\", \"3d_armor:chestplate_nether\", \"3d_armor:leggings_nether\", \"3d_armor:boots_crystal 1 646\", \"\"}", ["ocean_build.ocean_built"] = "8", ["signslib:pos"] = "(2055,16,1132)", jointime = "1650064821", bitten = "0", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", xp = "2751470", ["petz:werewolf_clan_idx"] = "1", played_time = "32531703", digged_nodes = "2540361", placed_nodes = "427310", died = "339", crafted = "179726", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", hud_state = "on", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1701276626", yl_commons_thankyou = "642", inflicted_damage = "9077502", ["stamina:level"] = "9", ["petz:werewolf_vignette_id"] = "19", ["stamina:poisoned"] = "no", repellant = "0", ["stamina:exhaustion"] = "63.5", ["ocean_build.last_warning"] = "1.65235e+09", yl_church = "return {[\"last_death\"] = {[\"x\"] = 20043, [\"y\"] = 19987, [\"z\"] = 20040}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1694869693}" } } ``` Log identifier ``` [MOD] yl_report log identifier = aCaKmkRifqAi9wpKsnBYpEpGW2zmu3W1 ``` Profiler save: ``` profile-20231130T041515.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 22h 48min 57s | max lag: 0.358s | clients (10/52): bluattire, daydream, hbreturns, nazthelizard122, Neon_, Parrish, Randy999, Sandmuel, taonza12, the_chosen_one ``` Teleport command: ``` /teleport xyz 2054 4 1610 ``` Compass command: ``` /give_compass Construction aCaKmkRifqAi9wpKsnBYpEpGW2zmu3W1 D2691E 2054 4 1610 ```

AliasAlreadyTaken was assigned by yourland-report

2023-11-30 04:15:15 +00:00

flux added the

1. kind/bug

3. source/mod upstream

labels 2023-11-30 23:18:56 +00:00

flux commented

2023-11-30 23:19:28 +00:00

huh, i didn't realize water_life mobs could attack mobs from other mods. i'll have to investigate that. but in general, water_life has very little respect for protection.

flux commented

2023-11-30 23:27:59 +00:00

the logic says they should only attack players (1b8031e479/animals/crocodile.lua (L62C10-L62C16) and 1b8031e479/animals/crocodile.lua (L191)), but i verified that they attack tamed ponies. bad croc :\

the logic says they should only attack players (https://github.com/berengma/water_life/blob/1b8031e4792485ce87c0e9861044534dc923e97a/animals/crocodile.lua#L62C10-L62C16 and https://github.com/berengma/water_life/blob/1b8031e4792485ce87c0e9861044534dc923e97a/animals/crocodile.lua#L191), but i verified that they attack tamed ponies. bad croc :\

flux commented

2023-11-30 23:37:44 +00:00

i figured out part of it. apparently all petz are registered as shark food, which crocs also target?

flux referenced this issue from a commit

2023-12-01 00:20:19 +00:00

your-land/bugtracker#5572 prevent water_life mobs from considering protected petz shark food

flux referenced this issue from a commit

2023-12-01 00:20:19 +00:00

your-land/bugtracker#5572 prevent water_life mobs from considering protected petz shark food

flux commented

2023-12-01 00:20:55 +00:00

fixed this in integration: 79f7aa854e

i couldn't work myself up to PR upstream cuz the code is terrible.

crocs (and other water_life animals) will no longer attack petz that have a dreamcatcher on, or which are in a protected area.

fixed this in integration: https://gitea.your-land.de/your-land/yl_commons/commit/79f7aa854ec2577c4ddcf8f0aa8702202ecb3c8f i couldn't work myself up to PR upstream cuz the code is terrible. crocs (and other water_life animals) will no longer attack petz that have a dreamcatcher on, or which are in a protected area.

👍 2

flux added the

4. step/ready to QA test

label 2023-12-01 00:21:10 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-01 00:59:52 +00:00

AliasAlreadyTaken added the

ugh/QA OK

label 2023-12-03 19:26:24 +00:00

flux referenced this issue

2023-12-12 21:01:11 +00:00

Parrish reports: Water life mod is showing sign ... #5655

flux added