your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

AliasAlreadyTaken reports: Add a staff command to enable/ ... #5476

New Issue
Closed
opened 2023-11-11 18:33:14 +00:00 by yourland-report · 13 comments
yourland-report commented 2023-11-11 18:33:14 +00:00
Member
Copy Link

AliasAlreadyTaken reports a bug:

Add a staff command to enable/disable head movement of players

Player position:

{
	z = 1174.2629394531,
	x = 1979.3000488281,
	y = 18
}

Player look:

{
	z = -0.033164542168379,
	x = 0.99450272321701,
	y = -0.099319748580456
}

Player information:

{
	lang_code = "de",
	max_rtt = 2.095999956131,
	ip_version = 6,
	min_rtt = 0.014999999664724,
	avg_rtt = 0.020999999716878,
	min_jitter = 0,
	max_jitter = 1.1579999923706,
	avg_jitter = 0,
	connection_uptime = 38273,
	serialization_version = 29,
	formspec_version = 6,
	patch = 0,
	version_string = "5.7.0",
	state = "Active",
	protocol_version = 42,
	major = 5,
	minor = 7
}

Player meta:

{
	fields = {
		xp = "0",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		["petz:lycanthropy"] = "0",
		played_time = "94309041",
		digged_nodes = "140378",
		placed_nodes = "181751",
		died = "1591",
		crafted = "4786",
		yl_church = "return {[\"last_heal\"] = 1683837139, [\"last_death\"] = {[\"x\"] = 2251, [\"y\"] = -164, [\"z\"] = 1401}, [\"last_death_portal\"] = 1683839371}",
		["arena_lib_editor.players_number"] = "0",
		yl_commons_thankyou = "1294",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		arenalib_infobox_arenaID = "0",
		bitten = "0",
		hud_state = "on",
		["ocean_build.last_warning"] = "1.67421e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		szutil_watch = "return {}",
		partypvp = "true",
		punch_count = "65078",
		inflicted_damage = "2991262",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		xp_redo_hud_color = "0xFFFF00",
		yl_commons_player_joined = "1699689360",
		["arena_lib_editor.spawner_ID"] = "0",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		["signslib:pos"] = "(1976,14,1168)",
		["petz:werewolf_clan_idx"] = "4",
		arenalib_watchID = "0",
		lagometer = "1",
		partychat = "party",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:level"] = "2",
		team = "STAFF",
		["stamina:poisoned"] = "no",
		["petz:werewolf"] = "0",
		["stamina:exhaustion"] = "37",
		["petz:werewolf_vignette_id"] = "19",
		["arena_lib_editor.team_ID"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = hfnp3vCyKd1bkbIUXjwYcCcE1KfopoPN

Profiler save:

profile-20231111T183314.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 4h 21min 39s | max lag: 0.873s | clients (26/52): Acenix2, AliasAlreadyTaken, Bingo, Bishiro, bizon, Boot, Cezar, Chache, CloudZ, DanteLives, daydream, EDWIR, ElManu, flux, Heron, LadyPixels, Lucien_II, MartinCZ, MeZN, Noii, pavlo98, Pif, polylith, Service, Sokomine, Taiel

Teleport command:

/teleport xyz 1979 18 1174

Compass command:

/give_compass Construction hfnp3vCyKd1bkbIUXjwYcCcE1KfopoPN D2691E 1979 18 1174
AliasAlreadyTaken reports a bug: > Add a staff command to enable/disable head movement of players Player position: ``` { z = 1174.2629394531, x = 1979.3000488281, y = 18 } ``` Player look: ``` { z = -0.033164542168379, x = 0.99450272321701, y = -0.099319748580456 } ``` Player information: ``` { lang_code = "de", max_rtt = 2.095999956131, ip_version = 6, min_rtt = 0.014999999664724, avg_rtt = 0.020999999716878, min_jitter = 0, max_jitter = 1.1579999923706, avg_jitter = 0, connection_uptime = 38273, serialization_version = 29, formspec_version = 6, patch = 0, version_string = "5.7.0", state = "Active", protocol_version = 42, major = 5, minor = 7 } ``` Player meta: ``` { fields = { xp = "0", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", ["petz:lycanthropy"] = "0", played_time = "94309041", digged_nodes = "140378", placed_nodes = "181751", died = "1591", crafted = "4786", yl_church = "return {[\"last_heal\"] = 1683837139, [\"last_death\"] = {[\"x\"] = 2251, [\"y\"] = -164, [\"z\"] = 1401}, [\"last_death_portal\"] = 1683839371}", ["arena_lib_editor.players_number"] = "0", yl_commons_thankyou = "1294", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", arenalib_infobox_arenaID = "0", bitten = "0", hud_state = "on", ["ocean_build.last_warning"] = "1.67421e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", szutil_watch = "return {}", partypvp = "true", punch_count = "65078", inflicted_damage = "2991262", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", xp_redo_hud_color = "0xFFFF00", yl_commons_player_joined = "1699689360", ["arena_lib_editor.spawner_ID"] = "0", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", ["signslib:pos"] = "(1976,14,1168)", ["petz:werewolf_clan_idx"] = "4", arenalib_watchID = "0", lagometer = "1", partychat = "party", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:level"] = "2", team = "STAFF", ["stamina:poisoned"] = "no", ["petz:werewolf"] = "0", ["stamina:exhaustion"] = "37", ["petz:werewolf_vignette_id"] = "19", ["arena_lib_editor.team_ID"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = hfnp3vCyKd1bkbIUXjwYcCcE1KfopoPN ``` Profiler save: ``` profile-20231111T183314.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 4h 21min 39s | max lag: 0.873s | clients (26/52): Acenix2, AliasAlreadyTaken, Bingo, Bishiro, bizon, Boot, Cezar, Chache, CloudZ, DanteLives, daydream, EDWIR, ElManu, flux, Heron, LadyPixels, Lucien_II, MartinCZ, MeZN, Noii, pavlo98, Pif, polylith, Service, Sokomine, Taiel ``` Teleport command: ``` /teleport xyz 1979 18 1174 ``` Compass command: ``` /give_compass Construction hfnp3vCyKd1bkbIUXjwYcCcE1KfopoPN D2691E 1979 18 1174 ```
👍 1 🚀 1
AliasAlreadyTaken was assigned by yourland-report 2023-11-11 18:33:14 +00:00
Bla commented 2023-11-11 19:14:42 +00:00
Copy Link

suggesting /barber to stop head movement 😆

suggesting `/barber` to stop head movement 😆
😆 3
AliasAlreadyTaken added the
1. kind/enhancement
2. prio/elevated
 labels 2023-11-11 19:59:04 +00:00
flux commented 2023-11-12 01:06:23 +00:00
Member
Copy Link

what's the use case?

what's the use case?
Sokomine commented 2023-11-12 01:30:50 +00:00
Member
Copy Link

I suspect that the head movements contribute significantly to the too many packages problem and filling up my line. On the other hand head movements are extremly important on a social level for players.

I suspect that the head movements contribute significantly to the too many packages problem and filling up my line. On the other hand head movements are extremly important on a social level for players.
flux commented 2023-11-12 23:27:07 +00:00
Member
Copy Link

I suspect that the head movements contribute significantly to the too many packages problem and filling up my line.

ah, so this would then enable us to test that theory.

> I suspect that the head movements contribute significantly to the too many packages problem and filling up my line. ah, so this would then enable us to test that theory.
daydream commented 2023-11-13 00:01:42 +00:00
Member
Copy Link
-- Register a chat command to enable or disable a player's head movement mod
minetest.register_chatcommand("headmovement", {
    params = "<playername> <enable|disable>",
    description = "Enable or disable head movement mod for a player",
    privs = { staff = true },
    func = function(name, params)
        local playername, action = params:match("(%S+)%s(%S+)")
        if playername and action then
            local player = minetest.get_player_by_name(playername)
            if player then
                if action == "enable" then
                    player:set_physics_override({ sneak = true })
                elseif action == "disable" then
                    player:set_physics_override({ sneak = false })
                end
                return true, "Head movement mod " .. action .. "d for player " .. playername
            end
        end
        return false, "Invalid parameters"
    end,
})
``` -- Register a chat command to enable or disable a player's head movement mod minetest.register_chatcommand("headmovement", { params = "<playername> <enable|disable>", description = "Enable or disable head movement mod for a player", privs = { staff = true }, func = function(name, params) local playername, action = params:match("(%S+)%s(%S+)") if playername and action then local player = minetest.get_player_by_name(playername) if player then if action == "enable" then player:set_physics_override({ sneak = true }) elseif action == "disable" then player:set_physics_override({ sneak = false }) end return true, "Head movement mod " .. action .. "d for player " .. playername end end return false, "Invalid parameters" end, }) ```
DragonWrangler commented 2023-11-13 03:25:13 +00:00
Copy Link

maybe make it where each player can also disable or enable their own head movement

maybe make it where each player can also disable or enable their own head movement
AliasAlreadyTaken commented 2023-11-13 11:19:26 +00:00
Owner
Copy Link

This is a debug command. To see the most effect, I'd like it to disable or enable ALL head movement at once.

This is a debug command. To see the most effect, I'd like it to disable or enable ALL head movement at once.
TheMadModder commented 2023-11-14 16:02:38 +00:00
Copy Link

Best way to do this is make a yl_version only of headamin. by fixing the mistakes made in that mod and adding the scripting to enable and disable it. along with implementing the ingame command of /barber enable and /barber disable. here is a working example of just that. I however did make it so people can show how they feel with there head pos. i.e if a player looks down and sad and does /barber disable than there head will stay in that sad pos. however still allowing the player to have a normal view of moment and still able to play, interact, build, exc.. while have there head in there desired pos. this is easily changed to have head go back to basepos if so desired to when head movement is disabled.

local get_connected_players = minetest.get_connected_players
local abs = math.abs
local deg = math.deg
local basepos = vector.new(0, 6.47, 0)
local lastdir = {}
local head_movement_enabled = true

local function updateHeadMovement(dtime)
    if head_movement_enabled then
        local connected_players = get_connected_players()
        for _, player in ipairs(connected_players) do
            local pname = player:get_player_name()
            local ldeg = -deg(player:get_look_vertical())
            if abs((lastdir[pname] or 0) - ldeg) > 4 then
                lastdir[pname] = ldeg
                player:set_bone_position("Head", basepos, {x = ldeg, y = 0, z = 0})
            end
        end
    end
end

minetest.register_globalstep(updateHeadMovement)

minetest.register_on_leaveplayer(function(player)
    lastdir[player:get_player_name()] = nil
end)

minetest.register_chatcommand("barber", {
    description = "Enable or disable head movement",
    privs = {interact = true},
    func = function(name, param)
        if param == "enable" then
            head_movement_enabled = true
            return true, "Head movement enabled"
        elseif param == "disable" then
            head_movement_enabled = false
            return true, "Head movement disabled"
        else
            return false, "Invalid parameter. Usage: /barber <enable|disable>"
        end
    end,
})
Best way to do this is make a yl_version only of headamin. by fixing the mistakes made in that mod and adding the scripting to enable and disable it. along with implementing the ingame command of /barber enable and /barber disable. here is a working example of just that. I however did make it so people can show how they feel with there head pos. i.e if a player looks down and sad and does /barber disable than there head will stay in that sad pos. however still allowing the player to have a normal view of moment and still able to play, interact, build, exc.. while have there head in there desired pos. this is easily changed to have head go back to basepos if so desired to when head movement is disabled. ```lua local get_connected_players = minetest.get_connected_players local abs = math.abs local deg = math.deg local basepos = vector.new(0, 6.47, 0) local lastdir = {} local head_movement_enabled = true local function updateHeadMovement(dtime) if head_movement_enabled then local connected_players = get_connected_players() for _, player in ipairs(connected_players) do local pname = player:get_player_name() local ldeg = -deg(player:get_look_vertical()) if abs((lastdir[pname] or 0) - ldeg) > 4 then lastdir[pname] = ldeg player:set_bone_position("Head", basepos, {x = ldeg, y = 0, z = 0}) end end end end minetest.register_globalstep(updateHeadMovement) minetest.register_on_leaveplayer(function(player) lastdir[player:get_player_name()] = nil end) minetest.register_chatcommand("barber", { description = "Enable or disable head movement", privs = {interact = true}, func = function(name, param) if param == "enable" then head_movement_enabled = true return true, "Head movement enabled" elseif param == "disable" then head_movement_enabled = false return true, "Head movement disabled" else return false, "Invalid parameter. Usage: /barber <enable|disable>" end end, }) ```
TheMadModder commented 2023-11-14 16:18:12 +00:00
Copy Link

Here it is where it will reset head pos back to basepos if you prefer.

local get_connected_players = minetest.get_connected_players
local abs = math.abs
local deg = math.deg
local basepos = vector.new(0, 6.47, 0)
local lastdir = {}
local head_movement_enabled = true

local function updateHeadMovement(dtime)
    local connected_players = get_connected_players()
    
    for _, player in ipairs(connected_players) do
        local pname = player:get_player_name()
        local ldeg = -deg(player:get_look_vertical())
        
        if head_movement_enabled then
            if abs((lastdir[pname] or 0) - ldeg) > 4 then
                lastdir[pname] = ldeg
                player:set_bone_position("Head", basepos, {x = ldeg, y = 0, z = 0})
            end
        else
            lastdir[pname] = 0 -- Reset last direction to 0 when disabled
            player:set_bone_position("Head", basepos, {x = 0, y = 0, z = 0}) -- Resets head position to basepos when disabled
        end
    end
end

minetest.register_globalstep(updateHeadMovement)

minetest.register_on_leaveplayer(function(player)
    lastdir[player:get_player_name()] = nil
end)

minetest.register_chatcommand("barber", {
    description = "Enable or disable head movement",
    privs = {interact = true},
    func = function(name, param)
        if param == "enable" then
            head_movement_enabled = true
            return true, "Head movement enabled"
        elseif param == "disable" then
            head_movement_enabled = false
            return true, "Head movement disabled"
        else
            return false, "Invalid parameter. Usage: /barber <enable|disable>"
        end
    end,
})
Here it is where it will reset head pos back to basepos if you prefer. ```lua local get_connected_players = minetest.get_connected_players local abs = math.abs local deg = math.deg local basepos = vector.new(0, 6.47, 0) local lastdir = {} local head_movement_enabled = true local function updateHeadMovement(dtime) local connected_players = get_connected_players() for _, player in ipairs(connected_players) do local pname = player:get_player_name() local ldeg = -deg(player:get_look_vertical()) if head_movement_enabled then if abs((lastdir[pname] or 0) - ldeg) > 4 then lastdir[pname] = ldeg player:set_bone_position("Head", basepos, {x = ldeg, y = 0, z = 0}) end else lastdir[pname] = 0 -- Reset last direction to 0 when disabled player:set_bone_position("Head", basepos, {x = 0, y = 0, z = 0}) -- Resets head position to basepos when disabled end end end minetest.register_globalstep(updateHeadMovement) minetest.register_on_leaveplayer(function(player) lastdir[player:get_player_name()] = nil end) minetest.register_chatcommand("barber", { description = "Enable or disable head movement", privs = {interact = true}, func = function(name, param) if param == "enable" then head_movement_enabled = true return true, "Head movement enabled" elseif param == "disable" then head_movement_enabled = false return true, "Head movement disabled" else return false, "Invalid parameter. Usage: /barber <enable|disable>" end end, }) ```
flux commented 2023-11-15 21:49:06 +00:00
Member
Copy Link

5b0eac3fe4

note that this completely disables all the stuff in playeranim, not just the head, on the assumption that all the other bodyparts (bones) also contribute to the issue.

https://gitea.your-land.de/your-land/playeranim/commit/5b0eac3fe413146e707179c37ed4c38e82635bda note that this completely disables all the stuff in playeranim, not just the head, on the assumption that all the other bodyparts (bones) also contribute to the issue.
👍 1
flux added the
4. step/ready to QA test
 label 2023-11-15 21:49:16 +00:00
Sokomine commented 2023-11-15 22:42:16 +00:00
Member
Copy Link

Letting the head stay in a special fixed position might be of intrest for yl_cinema and yl_theatre (see #5492).

Letting the head stay in a special fixed position might be of intrest for yl_cinema and yl_theatre (see #5492).
👍 1
AliasAlreadyTaken added the
ugh/QA OK
 label 2023-12-05 20:44:12 +00:00
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-05 20:44:14 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-12-18 01:53:34 +00:00
AliasAlreadyTaken was unassigned by flux 2023-12-18 01:53:36 +00:00
flux commented 2023-12-18 01:54:12 +00:00
Member
Copy Link

this is live. is there already an issue about testing whether this helps @Sokomine's issues?

this is live. is there already an issue about testing whether this helps @Sokomine's issues?
flux closed this issue 2023-12-18 01:54:15 +00:00
AliasAlreadyTaken commented 2023-12-18 04:12:45 +00:00
Owner
Copy Link

There is #5005 but it doesn't mention head movement

There is #5005 but it doesn't mention head movement
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.122
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5476
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?