annah reports: When placed, Wet Reed [dryplan ... #5459

New Issue

yourland-report · 2023-11-05T02:39:20Z

yourland-report commented

2023-11-05 02:39:20 +00:00

annah reports a bug:

When placed, Wet Reed [dryplants] turns into Reed. My suggestion is that Wet Reed stays wet, as the green block can be useful in building.

Player position:

{
	z = 1248.4270019531,
	x = 10219.091796875,
	y = 1.5
}

Player look:

{
	z = 0.33397376537323,
	x = -0.92612528800964,
	y = 0.17536672949791
}

Player information:

{
	lang_code = "",
	protocol_version = 39,
	ip_version = 6,
	min_rtt = 0.18899999558926,
	avg_rtt = 0.19400000572205,
	min_jitter = 0,
	max_jitter = 1.6779999732971,
	avg_jitter = 0,
	connection_uptime = 14275,
	serialization_version = 28,
	patch = 1,
	major = 5,
	version_string = "5.4.1",
	formspec_version = 4,
	state = "Active",
	max_rtt = 1.8799999952316,
	minor = 4
}

Player meta:

{
	fields = {
		xp = "150458",
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 18440\", \"3d_armor:boots_crystal 1 18640\", \"shields:shield_crystal 1 18440\", \"3d_armor:leggings_crystal 1 18440\", \"3d_armor:helmet_crystal 1 1340\", \"\"}",
		["petz:lycanthropy"] = "0",
		played_time = "2432585",
		digged_nodes = "112708",
		placed_nodes = "59413",
		died = "34",
		crafted = "11286",
		yl_church = "return {[\"last_death_portal\"] = 1670640168, [\"last_death\"] = {[\"z\"] = 270, [\"x\"] = 3008, [\"y\"] = 70}}",
		yl_commons_thankyou = "15",
		["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"sneak\"] = true, [\"new_move\"] = true, [\"speed\"] = 2, [\"sneak_glitch\"] = false, [\"gravity\"] = 1}",
		bitten = "0",
		hud_state = "on",
		["ocean_build.last_warning"] = "1.6677e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		yl_commons_player_created = "1638588988",
		yl_commons_player_joined = "1699137741",
		inflicted_damage = "119998",
		jointime = "1638588988",
		["petz:werewolf_vignette_id"] = "5",
		["signslib:pos"] = "(-6656,18,-17028)",
		partychat = "party",
		repellant = "0",
		["petz:werewolf"] = "0",
		["stamina:level"] = "18",
		punch_count = "6611",
		["stamina:poisoned"] = "no",
		arenalib_infobox_arenaID = "0",
		["stamina:exhaustion"] = "68",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["petz:werewolf_clan_idx"] = "2"
	}
}

Log identifier


[MOD] yl_report log identifier = o1prxkhs7y3rpC1H993f5kX3Aq8ASObp

Profiler save:

profile-20231105T023920.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 19min 58s | max lag: 0.269s | clients (16/52): Acenix2, AliasAlreadyTaken, annah, Bokk, Chache, daydream, DragonWrangler1, hbreturns, Heron, JohannesPaulHoffman, NickBonin, Penelopee, Service, Sokomine, Tacit, the_chosen_one

Teleport command:

/teleport xyz 10219 2 1248

Compass command:

/give_compass Construction o1prxkhs7y3rpC1H993f5kX3Aq8ASObp D2691E 10219 2 1248

annah reports a bug: > When placed, Wet Reed [dryplants] turns into Reed. My suggestion is that Wet Reed stays wet, as the green block can be useful in building. Player position: ``` { z = 1248.4270019531, x = 10219.091796875, y = 1.5 } ``` Player look: ``` { z = 0.33397376537323, x = -0.92612528800964, y = 0.17536672949791 } ``` Player information: ``` { lang_code = "", protocol_version = 39, ip_version = 6, min_rtt = 0.18899999558926, avg_rtt = 0.19400000572205, min_jitter = 0, max_jitter = 1.6779999732971, avg_jitter = 0, connection_uptime = 14275, serialization_version = 28, patch = 1, major = 5, version_string = "5.4.1", formspec_version = 4, state = "Active", max_rtt = 1.8799999952316, minor = 4 } ``` Player meta: ``` { fields = { xp = "150458", ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 18440\", \"3d_armor:boots_crystal 1 18640\", \"shields:shield_crystal 1 18440\", \"3d_armor:leggings_crystal 1 18440\", \"3d_armor:helmet_crystal 1 1340\", \"\"}", ["petz:lycanthropy"] = "0", played_time = "2432585", digged_nodes = "112708", placed_nodes = "59413", died = "34", crafted = "11286", yl_church = "return {[\"last_death_portal\"] = 1670640168, [\"last_death\"] = {[\"z\"] = 270, [\"x\"] = 3008, [\"y\"] = 70}}", yl_commons_thankyou = "15", ["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"sneak\"] = true, [\"new_move\"] = true, [\"speed\"] = 2, [\"sneak_glitch\"] = false, [\"gravity\"] = 1}", bitten = "0", hud_state = "on", ["ocean_build.last_warning"] = "1.6677e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", yl_commons_player_created = "1638588988", yl_commons_player_joined = "1699137741", inflicted_damage = "119998", jointime = "1638588988", ["petz:werewolf_vignette_id"] = "5", ["signslib:pos"] = "(-6656,18,-17028)", partychat = "party", repellant = "0", ["petz:werewolf"] = "0", ["stamina:level"] = "18", punch_count = "6611", ["stamina:poisoned"] = "no", arenalib_infobox_arenaID = "0", ["stamina:exhaustion"] = "68", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["petz:werewolf_clan_idx"] = "2" } } ``` Log identifier ``` [MOD] yl_report log identifier = o1prxkhs7y3rpC1H993f5kX3Aq8ASObp ``` Profiler save: ``` profile-20231105T023920.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 19min 58s | max lag: 0.269s | clients (16/52): Acenix2, AliasAlreadyTaken, annah, Bokk, Chache, daydream, DragonWrangler1, hbreturns, Heron, JohannesPaulHoffman, NickBonin, Penelopee, Service, Sokomine, Tacit, the_chosen_one ``` Teleport command: ``` /teleport xyz 10219 2 1248 ``` Compass command: ``` /give_compass Construction o1prxkhs7y3rpC1H993f5kX3Aq8ASObp D2691E 10219 2 1248 ```

AliasAlreadyTaken was assigned by yourland-report

2023-11-05 02:39:20 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-11-05 05:49:58 +00:00

daydream commented

2023-11-05 22:40:33 +00:00

I agree - the green is an aesthetic design choice and having it turn serves what purpose?

flux added the

3. source/mod upstream

label 2023-11-10 19:51:43 +00:00

flux commented

2023-11-10 19:54:59 +00:00

controlled by this ABM: 54a3e1d98b/dryplants/reed.lua (L230-L255)

best solution is to PR w/ a setting that disables that ABM.

controlled by this ABM: https://github.com/mt-mods/plantlife_modpack/blob/54a3e1d98b5c8902b7608497795712967b6efffc/dryplants/reed.lua#L230-L255 best solution is to PR w/ a setting that disables that ABM.

flux added the

2. prio/good first issue

label 2023-11-10 19:55:10 +00:00

AliasAlreadyTaken commented

2023-11-10 22:00:30 +00:00

Not in favour. The same could be asked about cobblestone, why can't we have cobble stone in water, why must it turn to mossy cobble?

Without the ABM, how would people obtain dried reet?

Not in favour. The same could be asked about cobblestone, why can't we have cobble stone in water, why must it turn to mossy cobble? Without the ABM, how would people obtain dried reet?

flux commented

2023-11-12 00:31:45 +00:00

Without the ABM, how would people obtain dried reet?

you can already get it by putting the wet reed in a furnace

> Without the ABM, how would people obtain dried reet? you can already get it by putting the wet reed in a furnace

AliasAlreadyTaken commented

2023-11-12 18:58:56 +00:00

I'd like to change my opinion to: Sounds good.

Will add value without using more node definitons and removes an ABM. Let's change it so that it doesn't dry by itself, but needs to be dried in a furnace.

I'd like to change my opinion to: Sounds good. Will add value without using more node definitons and removes an ABM. Let's change it so that it doesn't dry by itself, but needs to be dried in a furnace.

AliasAlreadyTaken added the

4. step/approved

label 2023-11-12 18:59:02 +00:00

Sign in to join this conversation.