mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value) #5414

Closed
opened 2023-10-23 14:08:04 +00:00 by AliasAlreadyTaken · 7 comments
2023-10-23 14:05:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value)
2023-10-23 14:05:25: ERROR[Main]: stack traceback:
2023-10-23 14:05:25: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message'
2023-10-23 14:05:25: ERROR[Main]: ...t/5.7.0/Minetest_live/bin/../mods/mail_mod/ui/events.lua:220: in function 'func'
2023-10-23 14:05:25: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>
2023-10-23 14:05:25: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
``` 2023-10-23 14:05:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value) 2023-10-23 14:05:25: ERROR[Main]: stack traceback: 2023-10-23 14:05:25: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message' 2023-10-23 14:05:25: ERROR[Main]: ...t/5.7.0/Minetest_live/bin/../mods/mail_mod/ui/events.lua:220: in function 'func' 2023-10-23 14:05:25: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101> 2023-10-23 14:05:25: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432> ```
AliasAlreadyTaken added the
1. kind/bug
3. source/mod upstream
2. prio/critical
labels 2023-10-23 14:09:06 +00:00
Author
Owner
Upstream issue: https://github.com/mt-mods/mail/issues/115
Author
Owner

2023-10-23 18:26:51: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"back":"X"}
2023-10-23 18:26:52: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"trash":"CHG:5:0"}
2023-10-23 18:26:52: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"trash":"DCL:5:0"}
2023-10-23 18:26:53: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"receivers":"Empf\u00e4nger"}
2023-10-23 18:26:54: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"}
2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:2:0"}
2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"}
2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"DCL:3:0"}
2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:2:0"}
2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:4:0"}
2023-10-23 18:26:56: ACTION[Server]: [yl_commons] lua is using 236.1 MB
2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"}
2023-10-23 18:26:57: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"back":"X"}
2023-10-23 18:27:06: ACTION[Server]: [yl_commons] lua is using 305.3 MB
2023-10-23 18:27:11: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"delete":"L\u00f6schen"}
2023-10-23 18:27:13: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"empty":"Leer"}
2023-10-23 18:27:15: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"delete":"L\u00f6schen"}
2023-10-23 18:27:16: ACTION[Server]: [yl_commons] lua is using 376.3 MB
2023-10-23 18:27:16: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"restore":"Wiederherstellen"}
2023-10-23 18:27:16: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"read":"Lesen"}
2023-10-23 18:27:16: ACTION[Main]: Server: Shutting down
2023-10-23 18:27:16: ACTION[Server]: [MOD] smart_chat : Module core: *** leaves the World.
2023-10-23 18:27:16: ACTION[Server]: tour leaves game. List of players:
2023-10-23 18:27:19: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_test/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value)
2023-10-23 18:27:19: ERROR[Main]: stack traceback:
2023-10-23 18:27:19: ERROR[Main]: .../5.7.0/Minetest_test/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message'
2023-10-23 18:27:19: ERROR[Main]: ...t/5.7.0/Minetest_test/bin/../mods/mail_mod/ui/events.lua:220: in function 'func'
2023-10-23 18:27:19: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>
2023-10-23 18:27:19: ERROR[Main]: .../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:432>

2023-10-23 18:26:51: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"back":"X"} 2023-10-23 18:26:52: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"trash":"CHG:5:0"} 2023-10-23 18:26:52: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"trash":"DCL:5:0"} 2023-10-23 18:26:53: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"receivers":"Empf\u00e4nger"} 2023-10-23 18:26:54: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"} 2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:2:0"} 2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"} 2023-10-23 18:26:55: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"DCL:3:0"} 2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:2:0"} 2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:4:0"} 2023-10-23 18:26:56: ACTION[Server]: [yl_commons] lua is using 236.1 MB 2023-10-23 18:26:56: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"to":"CHG:3:0"} 2023-10-23 18:26:57: ACTION[Server]: [yl_commons] formspec "mail:receivers": tour submitted {"back":"X"} 2023-10-23 18:27:06: ACTION[Server]: [yl_commons] lua is using 305.3 MB 2023-10-23 18:27:11: ACTION[Server]: [yl_commons] formspec "mail:message": tour submitted {"delete":"L\u00f6schen"} 2023-10-23 18:27:13: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"empty":"Leer"} 2023-10-23 18:27:15: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"delete":"L\u00f6schen"} 2023-10-23 18:27:16: ACTION[Server]: [yl_commons] lua is using 376.3 MB 2023-10-23 18:27:16: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"restore":"Wiederherstellen"} 2023-10-23 18:27:16: ACTION[Server]: [yl_commons] formspec "mail:trash": tour submitted {"read":"Lesen"} 2023-10-23 18:27:16: ACTION[Main]: Server: Shutting down 2023-10-23 18:27:16: ACTION[Server]: [MOD] smart_chat : Module core: *** leaves the World. 2023-10-23 18:27:16: ACTION[Server]: tour leaves game. List of players: 2023-10-23 18:27:19: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_test/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value) 2023-10-23 18:27:19: ERROR[Main]: stack traceback: 2023-10-23 18:27:19: ERROR[Main]: .../5.7.0/Minetest_test/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message' 2023-10-23 18:27:19: ERROR[Main]: ...t/5.7.0/Minetest_test/bin/../mods/mail_mod/ui/events.lua:220: in function 'func' 2023-10-23 18:27:19: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101> 2023-10-23 18:27:19: ERROR[Main]: .../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:432>

I assume it crashes when you hit the "read" button without selecting a mail.

First time: deleted trash and clicked on the read button afterwards
second time: send myself a mail, clicked on read without selecting anything

I assume it crashes when you hit the "read" button without selecting a mail. First time: deleted trash and clicked on the read button afterwards second time: send myself a mail, clicked on read without selecting anything
Author
Owner

2023-10-26 21:27:05: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value)
2023-10-26 21:27:05: ERROR[Main]: stack traceback:
2023-10-26 21:27:05: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message'
2023-10-26 21:27:05: ERROR[Main]: ...t/5.7.0/Minetest_live/bin/../mods/mail_mod/ui/events.lua:220: in function 'func'
2023-10-26 21:27:05: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>
2023-10-26 21:27:05: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>

2023-10-26 21:27:05: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: attempt to index local 'message' (a nil value) 2023-10-26 21:27:05: ERROR[Main]: stack traceback: 2023-10-26 21:27:05: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/mail_mod/ui/message.lua:21: in function 'show_message' 2023-10-26 21:27:05: ERROR[Main]: ...t/5.7.0/Minetest_live/bin/../mods/mail_mod/ui/events.lua:220: in function 'func' 2023-10-26 21:27:05: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101> 2023-10-26 21:27:05: ERROR[Main]: .../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_live/bin/../builtin/game/register.lua:432>
Author
Owner

I added a dumbfix

function mail.show_message(name, id)
        local message = mail.get_message(name, id)
        mail.selected_idxs.message[name] = id
        if not message then core.log("error","mail mod: name=" .. dump(name).. ", id=" .. dump(id)) return end <-- added dumbfix
        local formspec = [[
                        size[8,9]

                        box[0,0;7,1.9;]] .. mail.colors.highlighted .. [[]

                        button[7.25,0.15;0.75,0.5;back;X]

                        label[0.2,0.1;]] .. S("From") .. [[: %s]
                        label[0.2,0.5;]] .. S("To") .. [[: %s]
                        label[0.2,0.9;]] .. S("CC") .. [[: %s]
                        label[0.2,1.3;]] .. S("Date") .. [[: %s]
                        tooltip[0.2,1.3;4.8,0.4;]] .. mail.time_ago(message.time) .. [[] <-- goes boom here

I added a dumbfix ``` function mail.show_message(name, id) local message = mail.get_message(name, id) mail.selected_idxs.message[name] = id if not message then core.log("error","mail mod: name=" .. dump(name).. ", id=" .. dump(id)) return end <-- added dumbfix local formspec = [[ size[8,9] box[0,0;7,1.9;]] .. mail.colors.highlighted .. [[] button[7.25,0.15;0.75,0.5;back;X] label[0.2,0.1;]] .. S("From") .. [[: %s] label[0.2,0.5;]] .. S("To") .. [[: %s] label[0.2,0.9;]] .. S("CC") .. [[: %s] label[0.2,1.3;]] .. S("Date") .. [[: %s] tooltip[0.2,1.3;4.8,0.4;]] .. mail.time_ago(message.time) .. [[] <-- goes boom here ```
Member

upstream issue is closed so presumably fixed

upstream issue is closed so presumably fixed
flux added the
4. step/ready to QA test
label 2023-11-08 21:23:53 +00:00
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-09 18:07:51 +00:00
AliasAlreadyTaken added the
ugh/QA OK
label 2023-11-30 16:34:16 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-12-18 01:02:36 +00:00
Member

presumed live

presumed live
flux closed this issue 2023-12-18 01:02:41 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5414
No description provided.