Recipe for purple does not match #5384

New Issue

Murmel · 2023-10-15T13:06:52Z

Murmel commented

2023-10-15 13:06:52 +00:00

When I seach the crafting guide how to craft violet, one of the recipes tells me, I could use red an blue.
Clicking on "All" my red an blue dye are transfered from the Inventory to the crafting table, but won't produce violet but magenta.. See screenshots.

When I seach the crafting guide how to craft violet, one of the recipes tells me, I could use red an blue. Clicking on "All" my red an blue dye are transfered from the Inventory to the crafting table, but won't produce violet but magenta.. See screenshots.

magenta.png

99 KiB

redblue.png

158 KiB

AliasAlreadyTaken added the

3. source/integration

label 2023-10-16 08:52:53 +00:00

flux added the

1. kind/bug

label 2023-11-07 00:23:39 +00:00

flux commented

2023-11-07 00:24:23 +00:00

i wish there was a way to see where specific recipes were defined...

flux referenced this issue from a commit

2023-11-07 00:41:28 +00:00

your-land/bugtracker#5384 fix dye crafting recipe conflict

flux commented

2023-11-07 00:41:52 +00:00

from MTG's dye:

red + blue -> violet
magenta + blue -> violet
pink + violet -> magenta

from unifieddyes:

blue + red -> magenta
blue + magenta -> violet

upstream issue: https://github.com/mt-mods/unifieddyes/issues/14, which i expect will be ignored.

in the meantime, i'll integration the recipes 642156f45a

from MTG's dye: * red + blue -> violet * magenta + blue -> violet * pink + violet -> magenta from unifieddyes: * blue + red -> magenta * blue + magenta -> violet upstream issue: https://github.com/mt-mods/unifieddyes/issues/14, which i expect will be ignored. in the meantime, i'll integration the recipes https://gitea.your-land.de/your-land/yl_commons/commit/642156f45a525050030c3e0fabbcc332886332cd

👍 1

flux added the

4. step/ready to QA test

label 2023-11-07 00:42:04 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-11 17:54:04 +00:00

AliasAlreadyTaken commented

2023-11-30 18:57:27 +00:00

QA

What's the "correct" combo? On testserver, both blue and red AND blue and magenta make two violet dye?

Maybe we should simply leave the recipe combinations to unified dyes and invalidate all others?

QA What's the "correct" combo? On testserver, both blue and red AND blue and magenta make two violet dye? Maybe we should simply leave the recipe combinations to unified dyes and invalidate all others?

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-11-30 18:58:35 +00:00

flux commented

2023-12-01 23:59:47 +00:00

QA

What's the "correct" combo? On testserver, both blue and red AND blue and magenta make two violet dye?

Maybe we should simply leave the recipe combinations to unified dyes and invalidate all others?

the problem here was that there was a recipe conflict - the same recipe was registered w/ two different outputs. many dyes have multiple different combination recipes. i'm not sure it's worth removing all the recipes from mtg dyes. it'd be good to clean up all the duplicate recipes from both mods, but imo a very low priority.

> QA > > What's the "correct" combo? On testserver, both blue and red AND blue and magenta make two violet dye? > > Maybe we should simply leave the recipe combinations to unified dyes and invalidate all others? the problem here was that there was a recipe conflict - the same recipe was registered w/ two different outputs. many dyes have multiple different combination recipes. i'm not sure it's worth removing all the recipes from mtg dyes. it'd be good to clean up all the duplicate recipes from both mods, but imo a very low priority.

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-12-04 18:12:25 +00:00

AliasAlreadyTaken commented

2023-12-04 18:12:53 +00:00

The recipe conflict is resolved. Let's postpone cleaning up all the recipes to another issue: #5605.

AliasAlreadyTaken referenced this issue

2023-12-04 18:14:08 +00:00

Clean up all the unified dyes recipes #5605

flux added