Chache reports: The former "rice seeds" have b ... #5324

New Issue

yourland-report · 2023-09-25T08:22:18Z

yourland-report commented

2023-09-25 08:22:18 +00:00

Chache reports a bug:

The former "rice seeds" have been unified into rice, but the recipe hasn't been eliminated, so now there's a recipe for cooking rice that yields... rice.

Player position:

{
	x = 3018.2739257813,
	y = 1.5,
	z = -2680.9460449219
}

Player look:

{
	x = -0.040532015264034,
	y = 0.15126080811024,
	z = 0.98766249418259
}

Player information:

{
	serialization_version = 29,
	patch = 0,
	minor = 7,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.028999999165535,
	lang_code = "es",
	max_rtt = 3.4749999046326,
	major = 5,
	formspec_version = 6,
	version_string = "5.7.0",
	avg_jitter = 0,
	avg_rtt = 0.032000001519918,
	min_jitter = 0,
	max_jitter = 3.3779997825623,
	protocol_version = 42,
	connection_uptime = 1021
}

Player meta:

{
	fields = {
		played_time = "10473499",
		digged_nodes = "1089620",
		placed_nodes = "542240",
		died = "13",
		crafted = "190806",
		partychat = "party",
		["signslib:pos"] = "(3010,4,-2712)",
		["ocean_build.ocean_built"] = "12",
		punch_count = "45620",
		arenalib_infobox_arenaID = "0",
		["ocean_build.last_warning"] = "1.65606e+09",
		jointime = "1645471717",
		bitten = "0",
		yl_commons_player_created = "1645471717",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 6580\", \"\", \"3d_armor:chestplate_crystal 1 6580\", \"3d_armor:leggings_crystal 1 6580\", \"3d_armor:boots_crystal 1 6580\", \"shields:shield_rainbow 1 14018\"}",
		["stamina:level"] = "11",
		yl_commons_player_joined = "1695629133",
		["stamina:poisoned"] = "no",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:exhaustion"] = "71.5",
		xp = "1328787",
		xp_redo_hud_color = "0xFFFF00",
		repellant = "0",
		inflicted_damage = "1512600",
		["ocean_build.forbidden"] = "true",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"z\"] = -2696, [\"x\"] = 2862}, [\"last_heal\"] = 1653594577, [\"last_death_portal\"] = 1682897352}",
		yl_commons_thankyou = "235",
		hud_state = "on"
	}
}

Log identifier


[MOD] yl_report log identifier = b2KQ3ju4mPzwXWKKnqnVl1J7NNJKAMBd

Profiler save:

profile-20230925T082218.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 51min 8s | max lag: 0.37s | clients (16/52): ALCOHOL3, AliasAlreadyTaken, Aliza, Azelf, Chache, Heron, jalaj, LadyPixels, Murmel, Naan, nazthelizard122, Penelopee, PrincessMarizza, Service, taonza12, VIHAAN_OP

Teleport command:

/teleport xyz 3018 2 -2681

Compass command:

/give_compass Construction b2KQ3ju4mPzwXWKKnqnVl1J7NNJKAMBd D2691E 3018 2 -2681

Chache reports a bug: > The former "rice seeds" have been unified into rice, but the recipe hasn't been eliminated, so now there's a recipe for cooking rice that yields... rice. Player position: ``` { x = 3018.2739257813, y = 1.5, z = -2680.9460449219 } ``` Player look: ``` { x = -0.040532015264034, y = 0.15126080811024, z = 0.98766249418259 } ``` Player information: ``` { serialization_version = 29, patch = 0, minor = 7, state = "Active", ip_version = 6, min_rtt = 0.028999999165535, lang_code = "es", max_rtt = 3.4749999046326, major = 5, formspec_version = 6, version_string = "5.7.0", avg_jitter = 0, avg_rtt = 0.032000001519918, min_jitter = 0, max_jitter = 3.3779997825623, protocol_version = 42, connection_uptime = 1021 } ``` Player meta: ``` { fields = { played_time = "10473499", digged_nodes = "1089620", placed_nodes = "542240", died = "13", crafted = "190806", partychat = "party", ["signslib:pos"] = "(3010,4,-2712)", ["ocean_build.ocean_built"] = "12", punch_count = "45620", arenalib_infobox_arenaID = "0", ["ocean_build.last_warning"] = "1.65606e+09", jointime = "1645471717", bitten = "0", yl_commons_player_created = "1645471717", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 6580\", \"\", \"3d_armor:chestplate_crystal 1 6580\", \"3d_armor:leggings_crystal 1 6580\", \"3d_armor:boots_crystal 1 6580\", \"shields:shield_rainbow 1 14018\"}", ["stamina:level"] = "11", yl_commons_player_joined = "1695629133", ["stamina:poisoned"] = "no", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:exhaustion"] = "71.5", xp = "1328787", xp_redo_hud_color = "0xFFFF00", repellant = "0", inflicted_damage = "1512600", ["ocean_build.forbidden"] = "true", yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"z\"] = -2696, [\"x\"] = 2862}, [\"last_heal\"] = 1653594577, [\"last_death_portal\"] = 1682897352}", yl_commons_thankyou = "235", hud_state = "on" } } ``` Log identifier ``` [MOD] yl_report log identifier = b2KQ3ju4mPzwXWKKnqnVl1J7NNJKAMBd ``` Profiler save: ``` profile-20230925T082218.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 9h 51min 8s | max lag: 0.37s | clients (16/52): ALCOHOL3, AliasAlreadyTaken, Aliza, Azelf, Chache, Heron, jalaj, LadyPixels, Murmel, Naan, nazthelizard122, Penelopee, PrincessMarizza, Service, taonza12, VIHAAN_OP ``` Teleport command: ``` /teleport xyz 3018 2 -2681 ``` Compass command: ``` /give_compass Construction b2KQ3ju4mPzwXWKKnqnVl1J7NNJKAMBd D2691E 3018 2 -2681 ```

AliasAlreadyTaken was assigned by yourland-report

2023-09-25 08:22:18 +00:00

AliasAlreadyTaken added the

1. kind/bug

3. source/integration

labels 2023-09-26 08:32:02 +00:00

flux referenced this issue from a commit

2023-11-03 18:04:22 +00:00

your-land/bugtracker#5324 remove cooking rice -> rice

flux added the

4. step/ready to QA test

label 2023-11-03 18:04:46 +00:00

flux commented

2023-11-03 18:04:57 +00:00

removed the recipe 9d66c35fd8

removed the recipe https://gitea.your-land.de/your-land/yl_commons/commit/9d66c35fd8f439c52912bef5ac88811d6babc0d1

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-03 21:22:43 +00:00

rewired_X commented

2023-11-03 21:44:53 +00:00

Not fixed.
Test still shows the recipe. (and main for that matter, but that might not count)

Not fixed. Test still shows the recipe. (and main for that matter, but that might not count)

AliasAlreadyTaken commented

2023-11-04 00:12:33 +00:00

Not fixed.
Test still shows the recipe. (and main for that matter, but that might not count)

Because I didn't update test immediately after the fix. Now I did :D

> Not fixed. > Test still shows the recipe. (and main for that matter, but that might not count) Because I didn't update test immediately after the fix. Now I did :D

rewired_X commented

2023-11-04 00:25:19 +00:00

Still isn't fixed

AliasAlreadyTaken commented

2023-11-04 00:41:50 +00:00

Does the removal of recipes take into account whether it's cooking or normal crafting?

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-11-04 00:41:57 +00:00

flux commented

2023-11-10 17:51:55 +00:00

huhhh just double checked and it's fixed in my local test server. if the recipe removal specifies the output, input and method are ignored and all recipes that output that item are removed.

just checked the test server and it's not there. where are people testing this where it's appearing?

huhhh just double checked and it's fixed in my local test server. if the recipe removal specifies the output, input and method are ignored and all recipes that output that item are removed. just checked the test server and it's not there. where are people testing this where it's appearing?

AliasAlreadyTaken commented

2023-11-10 18:01:48 +00:00

Which commit in what mod adds it?

rewired_X commented

2023-11-11 00:31:12 +00:00

ok, test shows the recipe is gone now. not sure why I still saw it after the fix was pushed

Screenshot (618).png

604 KiB

👍 1

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-11-11 00:35:14 +00:00

flux commented

2023-11-12 00:45:57 +00:00

Which commit in what mod adds it?

9d66c35fd8

not sure why I still saw it after the fix was pushed

fixes don't wind up on the test server immediately.

> Which commit in what mod adds it? https://gitea.your-land.de/your-land/yl_commons/commit/9d66c35fd8f439c52912bef5ac88811d6babc0d1 > not sure why I still saw it after the fix was pushed fixes don't wind up on the test server immediately.

👍 1

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-12-17 23:51:59 +00:00

AliasAlreadyTaken was unassigned by flux

2023-12-17 23:52:02 +00:00

flux commented

2023-12-17 23:52:09 +00:00

this is live

flux closed this issue