Test_User reports: dieing gives free unbreakable ... #5302

New Issue

yourland-report · 2023-09-22T22:40:16Z

yourland-report commented

2023-09-22 22:40:16 +00:00

Test_User reports a bug:

dieing gives free unbreakable armor now (stats not reset properly)

Player position:

{
	z = 1216.1419677734,
	x = 1984.8330078125,
	y = 14.5
}

Player look:

{
	z = -0.41449418663979,
	x = -0.78053587675095,
	y = -0.46792981028557
}

Player information:

{
	formspec_version = 6,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.11100000143051,
	avg_rtt = 0.13600000739098,
	min_jitter = 0,
	max_jitter = 3.8719999790192,
	avg_jitter = 0.019000008702278,
	connection_uptime = 484,
	serialization_version = 29,
	patch = 0,
	minor = 6,
	version_string = "5.6.0",
	max_rtt = 3.9939999580383,
	protocol_version = 41,
	lang_code = "",
	major = 5
}

Player meta:

{
	fields = {
		inflicted_damage = "344696",
		jointime = "1614192315",
		["stamina:exhaustion"] = "132.5",
		yl_commons_thankyou = "19",
		["signslib:pos"] = "(29273,26845,26974)",
		hud_state = "on",
		yl_church = "return {[\"last_heal\"] = 1622582060, [\"last_death_portal\"] = 1684501826, [\"last_death\"] = {[\"z\"] = 21088, [\"x\"] = 44, [\"y\"] = 74}}",
		partypvp = "true",
		played_time = "3091272",
		digged_nodes = "258097",
		placed_nodes = "36916",
		died = "352",
		crafted = "48107",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"player.Test_User.0.png\", \"blank.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_chestplate_crystal.png^3d_armor_leggings_crystal.png^nether_mobs_dragon_boots.png^shields_shield_crystal.png\", \"mobs_pick_lava.png\"}, [\"animation\"] = \"walk\", [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"animation_speed\"] = 30}",
		partychat = "main",
		["petz:werewolf_clan_idx"] = "1",
		["petz:werewolf_vignette_id"] = "19",
		hotbar_size = "32",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 21403\", \"\", \"3d_armor:chestplate_crystal 1 21203\", \"3d_armor:leggings_crystal 1 21153\", \"nether_mobs:dragon_boots 1 18640\", \"shields:shield_crystal 1 21060\"}",
		arenalib_infobox_arenaID = "0",
		punch_count = "22109",
		yl_commons_player_created = "1614192315",
		["petz:lycanthropy"] = "1",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp = "175760",
		yl_commons_player_joined = "1695421980",
		["petz:werewolf"] = "1",
		repellant = "0",
		bitten = "0",
		["stamina:level"] = "19",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = oFrsdWNePK0dmrM2XxPz4abPHCsSumyl

Profiler save:

profile-20230922T224016.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 36min 16s | max lag: 0.368s | clients (21/52): AliasAlreadyTaken, Boot, Chache, dafalite, daydream, Ecklair, ffelder, Glacierville, hbreturns, Heron, laira, nazthelizard122, poppyasdan, rewired_X, seetM, Service, SirLondoCat, Sokomine, Sysmatic, Test_User, visibleObject2

Teleport command:

/teleport xyz 1985 15 1216

Compass command:

/give_compass Construction oFrsdWNePK0dmrM2XxPz4abPHCsSumyl D2691E 1985 15 1216

Test_User reports a bug: > dieing gives free unbreakable armor now (stats not reset properly) Player position: ``` { z = 1216.1419677734, x = 1984.8330078125, y = 14.5 } ``` Player look: ``` { z = -0.41449418663979, x = -0.78053587675095, y = -0.46792981028557 } ``` Player information: ``` { formspec_version = 6, state = "Active", ip_version = 6, min_rtt = 0.11100000143051, avg_rtt = 0.13600000739098, min_jitter = 0, max_jitter = 3.8719999790192, avg_jitter = 0.019000008702278, connection_uptime = 484, serialization_version = 29, patch = 0, minor = 6, version_string = "5.6.0", max_rtt = 3.9939999580383, protocol_version = 41, lang_code = "", major = 5 } ``` Player meta: ``` { fields = { inflicted_damage = "344696", jointime = "1614192315", ["stamina:exhaustion"] = "132.5", yl_commons_thankyou = "19", ["signslib:pos"] = "(29273,26845,26974)", hud_state = "on", yl_church = "return {[\"last_heal\"] = 1622582060, [\"last_death_portal\"] = 1684501826, [\"last_death\"] = {[\"z\"] = 21088, [\"x\"] = 44, [\"y\"] = 74}}", partypvp = "true", played_time = "3091272", digged_nodes = "258097", placed_nodes = "36916", died = "352", crafted = "48107", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"player.Test_User.0.png\", \"blank.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_chestplate_crystal.png^3d_armor_leggings_crystal.png^nether_mobs_dragon_boots.png^shields_shield_crystal.png\", \"mobs_pick_lava.png\"}, [\"animation\"] = \"walk\", [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"animation_speed\"] = 30}", partychat = "main", ["petz:werewolf_clan_idx"] = "1", ["petz:werewolf_vignette_id"] = "19", hotbar_size = "32", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 21403\", \"\", \"3d_armor:chestplate_crystal 1 21203\", \"3d_armor:leggings_crystal 1 21153\", \"nether_mobs:dragon_boots 1 18640\", \"shields:shield_crystal 1 21060\"}", arenalib_infobox_arenaID = "0", punch_count = "22109", yl_commons_player_created = "1614192315", ["petz:lycanthropy"] = "1", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp = "175760", yl_commons_player_joined = "1695421980", ["petz:werewolf"] = "1", repellant = "0", bitten = "0", ["stamina:level"] = "19", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = oFrsdWNePK0dmrM2XxPz4abPHCsSumyl ``` Profiler save: ``` profile-20230922T224016.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 36min 16s | max lag: 0.368s | clients (21/52): AliasAlreadyTaken, Boot, Chache, dafalite, daydream, Ecklair, ffelder, Glacierville, hbreturns, Heron, laira, nazthelizard122, poppyasdan, rewired_X, seetM, Service, SirLondoCat, Sokomine, Sysmatic, Test_User, visibleObject2 ``` Teleport command: ``` /teleport xyz 1985 15 1216 ``` Compass command: ``` /give_compass Construction oFrsdWNePK0dmrM2XxPz4abPHCsSumyl D2691E 1985 15 1216 ```

AliasAlreadyTaken was assigned by yourland-report

2023-09-22 22:40:16 +00:00

AliasAlreadyTaken added the

1. kind/bug

2. prio/critical

labels 2023-09-23 01:39:13 +00:00

AliasAlreadyTaken referenced this issue from a commit

2023-09-23 06:26:34 +00:00

your-land/bugtracker#5302 Fix Armour duplication glitch

AliasAlreadyTaken added the

5. result/fixed

label 2023-09-23 06:31:09 +00:00

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-09-23 06:58:16 +00:00

AliasAlreadyTaken added the

3. source/mod upstream

label 2023-09-23 06:59:32 +00:00

AliasAlreadyTaken modified the milestone from 1.1.120 to 1.1.121

2023-09-28 05:16:49 +00:00

AliasAlreadyTaken added

4. step/ready to QA test

and removed

5. result/fixed

labels 2023-10-11 05:54:42 +00:00

AliasAlreadyTaken added the

ugh/QA main

label 2023-10-19 18:55:57 +00:00

flux commented

2023-11-01 22:15:31 +00:00

huh, what was this about?

AliasAlreadyTaken commented

2023-11-02 07:08:51 +00:00

huh, what was this about?

This was a glitch followed by that dumbfix delivered via 1.1.121:

f994936301

It hasn't happen since, but there was a report after my dumbfix went life that it still can be abused, when the user dies, then loses connection before he respawns

> huh, what was this about? This was a glitch followed by that dumbfix delivered via 1.1.121: https://gitea.your-land.de/your-land/minetest-bones_redo/commit/f994936301efa4642eccde2d9a2180bb0321bfaa It hasn't happen since, but there was a report after my dumbfix went life that it still can be abused, when the user dies, then loses connection before he respawns

flux commented

2023-11-10 01:29:17 +00:00

This was a glitch followed by that dumbfix delivered via 1.1.121:

dumbfix is correct, no need to do anything else :)

> This was a glitch followed by that dumbfix delivered via 1.1.121: dumbfix is correct, no need to do anything else :)

👍 1

AliasAlreadyTaken commented

2023-11-10 16:58:22 +00:00

Still, as soon as the fix is in upstream, we'll remove it from ours

flux commented

2023-11-11 23:55:17 +00:00

Still, as soon as the fix is in upstream, we'll remove it from ours

it's already fixed in the the version i maintain c85f720265/compat/3d_armor.lua (L1)

> Still, as soon as the fix is in upstream, we'll remove it from ours it's already fixed in the the version i maintain https://github.com/fluxionary/minetest-bones_redo/blob/c85f720265bbd4e5e8cbcd88f65a5a141ced1a8f/compat/3d_armor.lua#L1

👍 1

AliasAlreadyTaken closed this issue

2023-11-27 01:05:35 +00:00

AliasAlreadyTaken added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-11-27 01:05:48 +00:00

Sign in to join this conversation.