RIPBla reports: players with a party tag now h ... #5301

New Issue

yourland-report · 2023-09-22T21:45:24Z

yourland-report commented

2023-09-22 21:45:24 +00:00

RIPBla reports a bug:

players with a party tag now have a " between partyname and playername

Player position:

{
	z = 1621.1300048828,
	x = 2074.9721679688,
	y = -19.5
}

Player look:

{
	z = -0.49422577023506,
	x = 0.83668959140778,
	y = -0.23599021136761
}

Player information:

{
	formspec_version = 6,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.012000000104308,
	avg_rtt = 0.012000000104308,
	lang_code = "de",
	version_string = "5.7.0",
	max_rtt = 0.57200002670288,
	min_jitter = 0,
	max_jitter = 0.53200000524521,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 721,
	minor = 7,
	patch = 0,
	serialization_version = 29,
	protocol_version = 42,
	major = 5
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		placed_nodes = "186",
		died = "17",
		crafted = "6",
		yl_commons_thankyou = "2",
		partychat = "party",
		hud_state = "on",
		jointime = "1635610475",
		digged_nodes = "191",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = -29900, [\"x\"] = 4527, [\"y\"] = 5}, [\"last_death_portal\"] = 1665947611}",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 9340\", \"3d_armor:leggings_crystal 1 40\", \"3d_armor:chestplate_crystal 1 40\", \"3d_armor:helmet_crystal 1 40\", \"shields:shield_crystal 1 40\", \"\"}",
		yl_commons_player_joined = "1695418514",
		bitten = "0",
		["stamina:exhaustion"] = "159",
		arenalib_infobox_arenaID = "0",
		punch_count = "41",
		xp = "293",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		inflicted_damage = "502",
		repellant = "0",
		yl_commons_player_created = "1635610475",
		["stamina:level"] = "16",
		played_time = "1570371"
	}
}

Log identifier


[MOD] yl_report log identifier = gXEJK6CX3Xt4UUssjojR2AMLrPsPXmpW

Profiler save:

profile-20230922T214524.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 40min 19s | max lag: 0.382s | clients (22/52): AliasAlreadyTaken, Blue_bunny23, Boot, Chache, daydream, Ecklair, ffelder, Ghostmine, Glacierville, hbreturns, Heron, laira, Lmnop_1, nazthelizard122, poppyasdan, rewired_X, RIPBla, Service, SirLondoCat, Sokomine, Sysmatic, visibleObject2

Teleport command:

/teleport xyz 2075 -20 1621

Compass command:

/give_compass Construction gXEJK6CX3Xt4UUssjojR2AMLrPsPXmpW D2691E 2075 -20 1621

RIPBla reports a bug: > players with a party tag now have a " between partyname and playername Player position: ``` { z = 1621.1300048828, x = 2074.9721679688, y = -19.5 } ``` Player look: ``` { z = -0.49422577023506, x = 0.83668959140778, y = -0.23599021136761 } ``` Player information: ``` { formspec_version = 6, state = "Active", ip_version = 6, min_rtt = 0.012000000104308, avg_rtt = 0.012000000104308, lang_code = "de", version_string = "5.7.0", max_rtt = 0.57200002670288, min_jitter = 0, max_jitter = 0.53200000524521, avg_jitter = 0.0010000001639128, connection_uptime = 721, minor = 7, patch = 0, serialization_version = 29, protocol_version = 42, major = 5 } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", placed_nodes = "186", died = "17", crafted = "6", yl_commons_thankyou = "2", partychat = "party", hud_state = "on", jointime = "1635610475", digged_nodes = "191", yl_church = "return {[\"last_death\"] = {[\"z\"] = -29900, [\"x\"] = 4527, [\"y\"] = 5}, [\"last_death_portal\"] = 1665947611}", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 9340\", \"3d_armor:leggings_crystal 1 40\", \"3d_armor:chestplate_crystal 1 40\", \"3d_armor:helmet_crystal 1 40\", \"shields:shield_crystal 1 40\", \"\"}", yl_commons_player_joined = "1695418514", bitten = "0", ["stamina:exhaustion"] = "159", arenalib_infobox_arenaID = "0", punch_count = "41", xp = "293", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", inflicted_damage = "502", repellant = "0", yl_commons_player_created = "1635610475", ["stamina:level"] = "16", played_time = "1570371" } } ``` Log identifier ``` [MOD] yl_report log identifier = gXEJK6CX3Xt4UUssjojR2AMLrPsPXmpW ``` Profiler save: ``` profile-20230922T214524.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 40min 19s | max lag: 0.382s | clients (22/52): AliasAlreadyTaken, Blue_bunny23, Boot, Chache, daydream, Ecklair, ffelder, Ghostmine, Glacierville, hbreturns, Heron, laira, Lmnop_1, nazthelizard122, poppyasdan, rewired_X, RIPBla, Service, SirLondoCat, Sokomine, Sysmatic, visibleObject2 ``` Teleport command: ``` /teleport xyz 2075 -20 1621 ``` Compass command: ``` /give_compass Construction gXEJK6CX3Xt4UUssjojR2AMLrPsPXmpW D2691E 2075 -20 1621 ```

AliasAlreadyTaken was assigned by yourland-report

2023-09-22 21:45:24 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2023-09-22 23:33:57 +00:00

AliasAlreadyTaken commented

2023-10-14 09:29:06 +00:00

Cause is that the settingttypes of name_monoid now have a default value:

# tag separator used to separate components in the name tag
name_monoid.tag_separator (tag separator) string " "

Apparently Minetest interprets that not as spacebar, but as ". Solution is to add to minetest.conf

name_monoid.tag_separator =

Looks like there is no way to tell Minetest we want a blank/spacebar there.

Cause is that the settingttypes of name_monoid now have a default value: ``` # tag separator used to separate components in the name tag name_monoid.tag_separator (tag separator) string " " ``` Apparently Minetest interprets that not as spacebar, but as `"`. Solution is to add to minetest.conf ``` name_monoid.tag_separator = ``` Looks like there is no way to tell Minetest we want a blank/spacebar there.

AliasAlreadyTaken added the

4. step/ready to QA test

3. source/mod upstream

labels 2023-10-14 09:29:21 +00:00

AliasAlreadyTaken commented

2023-10-14 11:12:53 +00:00

Upstream: https://github.com/fluxionary/minetest-name_monoid/issues/3

flux commented

2023-11-06 22:03:24 +00:00

change that resulted in this was due to this https://github.com/fluxionary/minetest-name_monoid/issues/2

flux commented

2023-11-07 00:09:07 +00:00

ugh. it looks like minetest doesn't officially support having the default value of a string being a single space character, so i've had to invent my own syntax.

fixed in fmod 1029b7224b

ugh. it looks like minetest doesn't officially support having the default value of a string being a single space character, so i've had to invent my own syntax. fixed in fmod https://github.com/fluxionary/minetest-fmod/commit/1029b7224b342f72dac3af1e1009c76db25d087e

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-11 20:24:47 +00:00

AliasAlreadyTaken commented

2023-12-03 23:54:45 +00:00

QA

What's that syntax to leave a single blank between Partytag and name? I tried the following:

name_monoid.tag_separator =
name_monoid.tag_separator = ""
name_monoid.tag_separator = " "

I also tried leaving the setting out altogether.

leaving it out or empty resulted in no distance between tag and name, "" lead to a literal "" in between, " " same.

QA What's that syntax to leave a single blank between Partytag and name? I tried the following: ``` name_monoid.tag_separator = name_monoid.tag_separator = "" name_monoid.tag_separator = " " ``` I also tried leaving the setting out altogether. leaving it out or empty resulted in no distance between tag and name, "" lead to a literal "" in between, " " same.

AliasAlreadyTaken added the

4. step/question

label 2023-12-03 23:57:14 +00:00

flux commented

2023-12-04 00:44:33 +00:00

it should be " ", let me investigate

it should be `" "`, let me investigate

flux commented

2023-12-04 01:01:10 +00:00

it should be " ", let me investigate

wait, no it shouldn't. i fixed how the default value was specified in settingtypes.txt, not how it's specified in minetest.conf. hmmmmmmmmm..... there also doesn't appear to be a way to do that, but a fix for that will require an engine change :\

leaving it out or empty resulted in no distance between tag and name

for me, leaving that setting out entirely results in a space between them, the way it should...

> it should be `" "`, let me investigate wait, no it shouldn't. i fixed how the default value was specified in `settingtypes.txt`, not how it's specified in `minetest.conf`. hmmmmmmmmm..... there also doesn't appear to be a way to do that, but a fix for that will require an engine change :\ > leaving it out or empty resulted in no distance between tag and name for me, leaving that setting out entirely results in a space between them, the way it should...

AliasAlreadyTaken commented

2023-12-04 14:10:58 +00:00

You're right ... it's pretty hard to see though:

You're right ... it's pretty hard to see though: ![image](/attachments/eab187dc-d61f-4dae-9338-b987ef9f9301)

image.png

16 KiB

AliasAlreadyTaken added the

ugh/QA OK

label 2023-12-04 14:11:16 +00:00

flux added

5. result/fixed

and removed