your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

yl_cinema/internal.lua:141: bad argument #1 to 'ipairs' (table expected, got nil) #5259

New Issue
Closed
opened 2023-09-11 07:06:46 +02:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2023-09-11 07:06:46 +02:00
Owner
Copy Link
2023-09-11 07:05:51: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_cinema' in callback environment_Step(): ....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:141: bad argument #1 to 'ipairs' (table expected, got nil)
2023-09-11 07:05:51: ERROR[Main]: stack traceback:
2023-09-11 07:05:51: ERROR[Main]: 	[C]: in function 'ipairs'
2023-09-11 07:05:51: ERROR[Main]: 	....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:141: in function 'load_images_of_movie'
2023-09-11 07:05:51: ERROR[Main]: 	....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:366: in function 'func'
2023-09-11 07:05:51: ERROR[Main]: 	...t/5.6.0-dev/minetest-dev/bin/../builtin/common/after.lua:20: in function <...t/5.6.0-dev/minetest-dev/bin/../builtin/common/after.lua:5>
2023-09-11 07:05:51: ERROR[Main]: 	....6.0-dev/minetest-dev/bin/../builtin/common/register.lua:26: in function <....6.0-dev/minetest-dev/bin/../builtin/common/register.lua:12>
``` 2023-09-11 07:05:51: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'yl_cinema' in callback environment_Step(): ....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:141: bad argument #1 to 'ipairs' (table expected, got nil) 2023-09-11 07:05:51: ERROR[Main]: stack traceback: 2023-09-11 07:05:51: ERROR[Main]: [C]: in function 'ipairs' 2023-09-11 07:05:51: ERROR[Main]: ....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:141: in function 'load_images_of_movie' 2023-09-11 07:05:51: ERROR[Main]: ....6.0-dev/minetest-dev/bin/../mods/yl_cinema/internal.lua:366: in function 'func' 2023-09-11 07:05:51: ERROR[Main]: ...t/5.6.0-dev/minetest-dev/bin/../builtin/common/after.lua:20: in function <...t/5.6.0-dev/minetest-dev/bin/../builtin/common/after.lua:5> 2023-09-11 07:05:51: ERROR[Main]: ....6.0-dev/minetest-dev/bin/../builtin/common/register.lua:26: in function <....6.0-dev/minetest-dev/bin/../builtin/common/register.lua:12> ```
AliasAlreadyTaken added the
1. kind/bug
 label 2023-09-11 07:06:51 +02:00
AliasAlreadyTaken added this to the 1.1.120 milestone 2023-09-11 07:06:54 +02:00
AliasAlreadyTaken commented 2023-09-11 09:15:00 +02:00
Author
Owner
Copy Link

Crashes when a movie has no files of its own.

Repro: Add a movie with NO files.

Crashes when a movie has no files of its own. Repro: Add a movie with NO files.
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2023-09-11 09:15:06 +02:00
AliasAlreadyTaken added the
4. step/QA OK
 label 2023-09-21 07:19:48 +02:00
AliasAlreadyTaken commented 2023-09-21 07:20:42 +02:00
Author
Owner
Copy Link

QA

Couldn't find a test other than myself, so tested it myself. This is not much more than a dumbfix - we really need a JSON validator

QA Couldn't find a test other than myself, so tested it myself. This is not much more than a dumbfix - we really need a JSON validator
daydream commented 2023-09-22 00:31:42 +02:00
Owner
Copy Link

I had movies with no files, cuz they were all wrong or belonging to another movie or all named wrong... I had so many things wrong, I can hardly figure out which would apply here... but regardless, nothing crashed the server, so I wouldn't say it was TOO dumb :)

I had movies with no files, cuz they were all wrong or belonging to another movie or all named wrong... I had so many things wrong, I can hardly figure out which would apply here... but regardless, nothing crashed the server, so I wouldn't say it was TOO dumb :)
👍 1
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-11-22 01:13:05 +01:00
flux commented 2023-11-22 01:13:16 +01:00
Member
Copy Link

presuming this is live

presuming this is live
flux closed this issue 2023-11-22 01:13:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
1.1.120
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5259
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?