losing a balrog whip in a anvil by the wither exploding it (discussion) #5244

New Issue

MineWorlds · 2023-09-06T23:24:04Z

MineWorlds commented

2023-09-06 23:24:04 +00:00

i have lost a balrog whip in the nether in the same way in report #3278.
i would like to discuss whatever if it should be able to be refundble or not.

i have lost a balrog whip in the nether in the same way in report #3278. i would like to discuss whatever if it should be able to be refundble or not.

AzelfYL commented

2023-09-06 23:44:38 +00:00

As flux said in the report for that bug,

note that most dropped items are susceptible to being destroyed in an explosion, but the balrog whip is NOT. it's absolutely a bug that it can be destroyed while on an anvil,

my opinion is 100% yes. Idk if shanish has his whip refunded because he conjures them out of somewhere in his free time, but you get the point.

As flux said in the report for that bug, > note that most dropped items are susceptible to being destroyed in an explosion, but the balrog whip is NOT. it's absolutely a bug that it can be destroyed while on an anvil, my opinion is 100% yes. Idk if shanish has his whip refunded because he conjures them out of somewhere in his free time, but you get the point.

AliasAlreadyTaken commented

2023-09-06 23:49:23 +00:00

Is this a duplicate and should be discussed in the issue mentioned by Mineworlds or is there some other circumstances to this?

MineWorlds commented

2023-09-06 23:56:19 +00:00

maybe discuss here, would be easier to find + new opinions can arise.

Bla commented

2023-09-07 04:59:31 +00:00

Is this a duplicate and should be discussed in the issue mentioned by Mineworlds or is there some other circumstances to this?

Sounds like a dupe and MineWorlds should have added to the already existing issue instead of opening a new one with a unclear title.

@MineWorlds you should also provide more details, explaining what exactly happened and most importantly when it happened

> Is this a duplicate and should be discussed in the issue mentioned by Mineworlds or is there some other circumstances to this? Sounds like a dupe and MineWorlds should have added to the already existing issue instead of opening a new one with a unclear title. @MineWorlds you should also provide more details, explaining what exactly happened and most importantly when it happened

MineWorlds commented

2023-09-07 10:50:08 +00:00

@Bla if you want details: around 1400-1440 utc yesterday i was repairing my balrog whip in a anvil (at the deeprack biome by the lava curst). until withers ambushed and exploded the anvil along with the whip. i attempted to place an anvil on the object and see if anything will happen. but that didn't work and the object ending up vanishing. (the object is the balrog whip).

Bla commented

2023-09-07 10:53:36 +00:00

@Bla if you want details...

I don´t but Alias to check the log

> @Bla if you want details... I don´t but Alias to check the log

MineWorlds changed title from ~~controversial discussion~~ to losing a balrog whip in a anvil by the wither exploding (discussion)

2023-09-07 11:37:05 +00:00

MineWorlds changed title from ~~losing a balrog whip in a anvil by the wither exploding (discussion)~~ to losing a balrog whip in a anvil by the wither exploding it (discussion)

2023-09-07 11:37:36 +00:00

Sokomine commented

2023-09-07 19:30:07 +00:00

If even flux considers it a bug that the balrog whip is destroyed in an explosion - then perhaps we can assume that it is a bug? After all the whip did survive the explosion of the balrog itself. Any mere...withers...aren't likely to explode strong enough to really cause it harm.

The PR for cottages is still too big for me to sort out on the fly. But dropping the items (and logicly the anvil) when an explosion occours might make sense.

If even flux considers it a bug that the balrog whip is destroyed in an explosion - then perhaps we can assume that it *is* a bug? After all the whip did survive the explosion of the balrog itself. Any mere...withers...aren't likely to explode strong enough to really cause it harm. The PR for cottages is still too big for me to sort out on the fly. But dropping the items (and logicly the anvil) when an explosion occours might make sense.

👍 1

AliasAlreadyTaken commented

2023-09-07 20:40:09 +00:00

After all the whip did survive the explosion of the balrog itself.

That's a good point. There is no logic that the whip should be more vulnerable when placed on an anvil. If it is SO sturdy it survives the explosion of a balrog, then why doesn't it survive falling off an anvil?

I'd like to change my opinion to "Explosions should add wear to nearby items that have wear. Exploding anvils should drop the item and add a percentage of that wear according to the explosion. If the wear added by the explosion would destroy the item (including the whip), then it is gone for good."

> After all the whip did survive the explosion of the balrog itself. That's a good point. There is no logic that the whip should be more vulnerable when placed on an anvil. If it is SO sturdy it survives the explosion of a balrog, then why doesn't it survive falling off an anvil? I'd like to change my opinion to "Explosions should add wear to nearby items that have wear. Exploding anvils should drop the item and add a percentage of that wear according to the explosion. If the wear added by the explosion would destroy the item (including the whip), then it is gone for good."

AzelfYL commented

2023-09-08 08:04:41 +00:00

Personally, I'm pretty sure flux intended the balrog whip to basically be impossible to destroy with explosions.

I'd like to change my opinion to "Explosions should add wear to nearby items that have wear. Exploding anvils should drop the item and add a percentage of that wear according to the explosion. If the wear added by the explosion would destroy the item (including the whip), then it is gone for good."

I think that the discussion on specific items for this would deserve its own bug issue for discussion

Personally, I'm pretty sure flux intended the balrog whip to basically be impossible to destroy with explosions. > I'd like to change my opinion to "Explosions should add wear to nearby items that have wear. Exploding anvils should drop the item and add a percentage of that wear according to the explosion. If the wear added by the explosion would destroy the item (including the whip), then it is gone for good." I think that the discussion on specific items for this would deserve its own bug issue for discussion

AliasAlreadyTaken added the

1. kind/bug

label 2023-10-10 22:25:45 +00:00

AliasAlreadyTaken referenced this issue

2023-10-10 22:26:10 +00:00

LadyPixels reports: hi i was fixing my crystal swo ... #5360

flux commented

2023-10-31 01:07:23 +00:00

the relevant code: ed056ff3eb/whip.lua (L40-L43)

it's a bug that the anvil doesn't check the the item's on_blast callback when handling a blast itself. in truth, it doesn't even try to handle the blast, compared to most nodes w/ inventories.

probably this issue should be about refunding MineWorld's whip (i'm in favor of that, though biased because it was probably actually a whip out of my stash), and the older issue should be about fixing the behavior of the anvil.

the relevant code: https://github.com/fluxionary/minetest-mobs_balrog/blob/ed056ff3eb73ba02232e08b2155bb066ee8f7975/whip.lua#L40-L43 it's a bug that the anvil doesn't check the the item's on_blast callback when handling a blast itself. in truth, it doesn't even try to handle the blast, compared to most nodes w/ inventories. probably this issue should be about refunding MineWorld's whip (i'm in favor of that, though biased because it was probably actually a whip out of my stash), and the older issue should be about fixing the behavior of the anvil.

AliasAlreadyTaken commented

2023-10-31 04:03:19 +00:00

Mineworlds whip was refunded when I changed my opinion to "this is a bug" :)

AliasAlreadyTaken added the

5. result/fixed

3. source/ingame

1. kind/protocol

labels 2023-10-31 04:03:48 +00:00

AliasAlreadyTaken closed this issue

2023-10-31 04:03:51 +00:00

AliasAlreadyTaken referenced this issue

2023-11-11 21:35:19 +00:00