your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

copper248 reports: total block deletion glitch: e ... #5044

New Issue
Closed
opened 2023-08-02 02:05:13 +02:00 by yourland-report · 16 comments
yourland-report commented 2023-08-02 02:05:13 +02:00
Member
Copy Link

copper248 reports a bug:

total block deletion glitch: edit to previous bug, it is all nodes, the previous setup can result in a way to delete any block, to sum up the setup a block with a door pushed underneath and through it will just get deleted

Player position:

{
	y = -30902.5,
	z = 1445.9389648438,
	x = 1917.9788818359
}

Player look:

{
	y = -0.17003750801086,
	z = -0.33331206440926,
	x = 0.92735660076141
}

Player information:

{
	minor = 6,
	min_rtt = 0.12399999797344,
	avg_rtt = 0.19099999964237,
	max_rtt = 16.316999435425,
	max_jitter = 16.180000305176,
	avg_jitter = 0.024000003933907,
	connection_uptime = 4524,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	formspec_version = 6,
	ip_version = 6,
	protocol_version = 41,
	major = 5,
	version_string = "5.6.0",
	min_jitter = 0,
	lang_code = ""
}

Player meta:

{
	fields = {
		["stamina:exhaustion"] = "0",
		jointime = "1662436925",
		["ocean_build.last_warning"] = "1.66667e+09",
		["ocean_build.forbidden"] = "true",
		["petz:lycanthropy"] = "0",
		["stamina:level"] = "20",
		["ocean_build.ocean_built"] = "12",
		hud_state = "on",
		punch_count = "51733",
		["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 4278\", \"3d_armor:chestplate_rainbow 1 4278\", \"3d_armor:leggings_rainbow 1 4278\", \"3d_armor:helmet_rainbow 1 4278\", \"3d_armor:boots_crystal 1 10380\", \"\"}",
		inflicted_damage = "1104386",
		["signslib:pos"] = "(3645,28,1586)",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "19",
		yl_commons_thankyou = "15",
		digged_nodes = "626363",
		["petz:werewolf"] = "0",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}",
		yl_commons_player_created = "1662436925",
		yl_commons_player_joined = "1690930243",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:poisoned"] = "no",
		xp = "605222",
		["petz:werewolf_clan_idx"] = "3",
		repellant = "0",
		played_time = "1600070",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = -13054, [\"y\"] = 3, [\"z\"] = 12839}, [\"last_death_portal\"] = 1686291282, [\"last_heal\"] = 1664922768}",
		placed_nodes = "99004",
		died = "81",
		crafted = "73772",
		bitten = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = J0Nrxk1f4z3DmPGVZku2f8ZgVKZxPpqr

Profiler save:

profile-20230802T000513.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 11h 27min 46s | max lag: 0.756s | clients (19/52): 9T9, AliasAlreadyTaken, copper248, daydream, Ecklair, flux, Garag_Enthor, InitialD, IVARDI, jackofthebean000, JeCel, Joebanana, MicaelStarfire, nazthelizard122, rewired_X, Service, shanish2, tururrum, whosit

Teleport command:

/teleport xyz 1918 -30903 1446

Compass command:

/give_compass Construction J0Nrxk1f4z3DmPGVZku2f8ZgVKZxPpqr D2691E 1918 -30903 1446
copper248 reports a bug: > total block deletion glitch: edit to previous bug, it is all nodes, the previous setup can result in a way to delete any block, to sum up the setup a block with a door pushed underneath and through it will just get deleted Player position: ``` { y = -30902.5, z = 1445.9389648438, x = 1917.9788818359 } ``` Player look: ``` { y = -0.17003750801086, z = -0.33331206440926, x = 0.92735660076141 } ``` Player information: ``` { minor = 6, min_rtt = 0.12399999797344, avg_rtt = 0.19099999964237, max_rtt = 16.316999435425, max_jitter = 16.180000305176, avg_jitter = 0.024000003933907, connection_uptime = 4524, serialization_version = 29, patch = 0, state = "Active", formspec_version = 6, ip_version = 6, protocol_version = 41, major = 5, version_string = "5.6.0", min_jitter = 0, lang_code = "" } ``` Player meta: ``` { fields = { ["stamina:exhaustion"] = "0", jointime = "1662436925", ["ocean_build.last_warning"] = "1.66667e+09", ["ocean_build.forbidden"] = "true", ["petz:lycanthropy"] = "0", ["stamina:level"] = "20", ["ocean_build.ocean_built"] = "12", hud_state = "on", punch_count = "51733", ["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 4278\", \"3d_armor:chestplate_rainbow 1 4278\", \"3d_armor:leggings_rainbow 1 4278\", \"3d_armor:helmet_rainbow 1 4278\", \"3d_armor:boots_crystal 1 10380\", \"\"}", inflicted_damage = "1104386", ["signslib:pos"] = "(3645,28,1586)", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "19", yl_commons_thankyou = "15", digged_nodes = "626363", ["petz:werewolf"] = "0", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}", yl_commons_player_created = "1662436925", yl_commons_player_joined = "1690930243", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:poisoned"] = "no", xp = "605222", ["petz:werewolf_clan_idx"] = "3", repellant = "0", played_time = "1600070", yl_church = "return {[\"last_death\"] = {[\"x\"] = -13054, [\"y\"] = 3, [\"z\"] = 12839}, [\"last_death_portal\"] = 1686291282, [\"last_heal\"] = 1664922768}", placed_nodes = "99004", died = "81", crafted = "73772", bitten = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = J0Nrxk1f4z3DmPGVZku2f8ZgVKZxPpqr ``` Profiler save: ``` profile-20230802T000513.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1d 11h 27min 46s | max lag: 0.756s | clients (19/52): 9T9, AliasAlreadyTaken, copper248, daydream, Ecklair, flux, Garag_Enthor, InitialD, IVARDI, jackofthebean000, JeCel, Joebanana, MicaelStarfire, nazthelizard122, rewired_X, Service, shanish2, tururrum, whosit ``` Teleport command: ``` /teleport xyz 1918 -30903 1446 ``` Compass command: ``` /give_compass Construction J0Nrxk1f4z3DmPGVZku2f8ZgVKZxPpqr D2691E 1918 -30903 1446 ```
AliasAlreadyTaken was assigned by yourland-report 2023-08-02 02:05:13 +02:00
flux added the
1. kind/bug
2. prio/critical
 labels 2023-08-02 02:54:18 +02:00
flux commented 2023-08-02 03:00:07 +02:00
Member
Copy Link

image

image

image

notice the diamond block disappears in the last image

![image](/attachments/775b189d-4746-4338-a6f9-1a1bdd3a6384) ![image](/attachments/c326f326-fe71-4fac-97d9-967f240048df) ![image](/attachments/a14da0c1-8fc8-4b47-bae7-785a44306c13) notice the diamond block disappears in the last image
image.png
144 KiB
image.png
160 KiB
image.png
162 KiB
flux added the
3. source/mod upstream
3. source/integration
 labels 2023-08-02 03:02:06 +02:00
flux commented 2023-08-02 03:02:20 +02:00
Member
Copy Link

all doors, as multi-node structures, should probably be MVPS stoppers

all doors, as multi-node structures, should probably be MVPS stoppers
flux commented 2023-08-02 03:05:52 +02:00
Member
Copy Link

also, this is an upstream issue with minetest game. the code which deletes the node above the door should verify that the node is actually the doors:hidden node

also, this is an upstream issue with *minetest game*. the code which deletes the node above the door should verify that the node is actually the `doors:hidden` node
flux commented 2023-08-02 03:07:00 +02:00
Member
Copy Link

i may still end up writing some integration code for yl_commons after i report this upstream, to prevent this from being exploited. this can e.g. be used to destroy a chest along the lower edges of a protection area.

i may still end up writing some integration code for yl_commons after i report this upstream, to prevent this from being exploited. this can e.g. be used to destroy a chest along the lower edges of a protection area.
flux commented 2023-08-02 03:41:30 +02:00
Member
Copy Link

upstream PR: https://github.com/minetest/minetest_game/pull/3045

upstream PR: https://github.com/minetest/minetest_game/pull/3045
flux added the
4. step/blocked
 label 2023-08-02 03:41:39 +02:00
copper248 commented 2023-08-02 05:07:40 +02:00
Copy Link

i may still end up writing some integration code for yl_commons after i report this upstream, to prevent this from being exploited. this can e.g. be used to destroy a chest along the lower edges of a protection area.

I highly doubt it could be exploited in that way since areas typically extend far below the actual used area

I don't know what exactly this could be exploited for, perhaps some sort of tunnel bore type thing? idk, anyway, what pushable multinode structures are there other than doors? I tried electrum crystals and cannons, they don't work what else is there

> i may still end up writing some integration code for yl_commons after i report this upstream, to prevent this from being exploited. this can e.g. be used to destroy a chest along the lower edges of a protection area. I highly doubt it could be exploited in that way since areas typically extend far below the actual used area I don't know what exactly this could be exploited for, perhaps some sort of tunnel bore type thing? idk, anyway, what pushable multinode structures are there other than doors? I tried electrum crystals and cannons, they don't work what else is there
flux commented 2023-08-02 20:02:21 +02:00
Member
Copy Link

what pushable multinode structures are there other than doors? I tried electrum crystals and cannons, they don't work what else is there

those other things aren't multi-node structures. all doors have an invisible node above them to keep you from placing other things in that position.

i think armor stands might have something similar, i'm not sure we've got anything else. i know techpack has some multinode machines, but we don't use that.

> what pushable multinode structures are there other than doors? I tried electrum crystals and cannons, they don't work what else is there those other things aren't multi-node structures. all doors have an invisible node above them to keep you from placing other things in that position. i think armor stands might have something similar, i'm not sure we've got anything else. i know techpack has some multinode machines, but we don't use that.
flux commented 2023-08-02 20:03:44 +02:00
Member
Copy Link

3d armor stand appears to check that it's the expected node before removing it.

3d armor stand appears to check that it's the expected node before removing it.
flux added the
4. step/ready to QA test
 label 2023-08-03 01:28:14 +02:00
flux commented 2023-08-03 01:29:04 +02:00
Member
Copy Link

made doors MVPS stoppers 08de7a5840

i discovered after i'd manually typed in the name of every door that the doors mod actually publishes the names of all the registered ones. wasted a good hour or so on that.

made doors MVPS stoppers https://gitea.your-land.de/your-land/yl_commons/commit/08de7a5840dafbd6b107dcd9a3732ee00564bdc5 i discovered after i'd manually typed in the name of every door that the doors mod actually publishes the names of all the registered ones. wasted a good hour or so on that.
👍 1
AliasAlreadyTaken added this to the 1.1.120 milestone 2023-08-03 18:45:01 +02:00
copper248 commented 2023-08-06 20:42:50 +02:00
Copy Link

If a chest is deleted with this glitch while someone has the GUI open a blank chest is created

If a chest is deleted with this glitch while someone has the GUI open a blank chest is created
emptychest.png
234 KiB
emptychest.png
flux commented 2023-08-07 02:25:48 +02:00
Member
Copy Link

If a chest is deleted with this glitch while someone has the GUI open a blank chest is created

this is ... "expected". ish. when the inventory is modified (removed), the formspec updates to reflect the clients new knowledge of the chest contents (nothing). there's no way for the server to tell if a player has a node formspec open, so we couldn't even tell it to close if we wanted to.

actually, could the client should be able to detect if a node formspec was modified or removed and update accordingly?

> If a chest is deleted with this glitch while someone has the GUI open a blank chest is created this is ... "expected". ish. when the inventory is modified (removed), the formspec updates to reflect the clients new knowledge of the chest contents (nothing). there's no way for the server to tell if a player has a node formspec open, so we couldn't even tell it to close if we wanted to. actually, could the client should be able to detect if a node formspec was modified or removed and update accordingly?
copper248 commented 2023-08-07 15:28:05 +02:00
Copy Link

there appears to be something special about nodes that change when interacted with like chest to chest_open, the rest just kick you out like the block was destroyed normally

there appears to be something special about nodes that change when interacted with like chest to chest_open, the rest just kick you out like the block was destroyed normally
flux removed the
4. step/blocked
 label 2023-08-11 20:07:29 +02:00
flux commented 2023-08-11 20:08:32 +02:00
Member
Copy Link

mtg fix was merged https://github.com/minetest/minetest_game/pull/3045

doors will remain MVPS stoppers though.

mtg fix was merged https://github.com/minetest/minetest_game/pull/3045 doors will remain MVPS stoppers though.
AliasAlreadyTaken commented 2023-09-05 01:28:10 +02:00
Owner
Copy Link

QA:

There is no door group that unites all doors.

Some doors are not yet MVPS stoppers. Those are examples, not ALL doors were tested. It can be assumed that if one door is not a MVPS stopper, a similar one isn't as well.

cottages:half_door_inverted
cottages:half_door
doors:gate_aspen_wood_closed
doors:gate_junglewood_closed

apparently all pkarcs_doors

Many other doors and trapdoors are MVPS stoppers (now), among the even more obscure ones, like shared_doors, xpanes or locks

QA: There is no door group that unites all doors. Some doors are not yet MVPS stoppers. Those are examples, not ALL doors were tested. It can be assumed that if one door is not a MVPS stopper, a similar one isn't as well. ``` cottages:half_door_inverted cottages:half_door doors:gate_aspen_wood_closed doors:gate_junglewood_closed apparently all pkarcs_doors ``` Many other doors and trapdoors are MVPS stoppers (now), among the even more obscure ones, like shared_doors, xpanes or locks
AliasAlreadyTaken added the
4. step/QA NOK
 label 2023-09-05 01:28:33 +02:00
AliasAlreadyTaken commented 2023-09-21 06:09:55 +02:00
Owner
Copy Link

QA

Apparently all the doors I found lacking MVPS stoppers do not exhibit the faulty behaviour.

QA Apparently all the doors I found lacking MVPS stoppers do not exhibit the faulty behaviour.
AliasAlreadyTaken added
4. step/QA OK
 and removed
4. step/QA NOK
 labels 2023-09-21 06:10:02 +02:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-11-17 01:08:20 +01:00
AliasAlreadyTaken was unassigned by flux 2023-11-17 01:08:23 +01:00
flux commented 2023-11-17 01:08:34 +01:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-11-17 01:08:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
1.1.120
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5044
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?