flux reports: discussion: should machines li ... #5022

New Issue

yourland-report · 2023-07-28T00:29:31Z

yourland-report commented

2023-07-28 00:29:31 +00:00

flux reports a bug:

discussion: should machines like autocrafters "catch up" when an area is reloaded, the way that furnaces do?

Player position:

{
	y = 19.5,
	z = 438.19903564453,
	x = 1320.1750488281
}

Player look:

{
	y = -0.99872815608978,
	z = -0.0047186347655952,
	x = -0.050197351723909
}

Player information:

{
	state = "Active",
	ip_version = 6,
	min_rtt = 0.16500000655651,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	minor = 8,
	avg_jitter = 0,
	connection_uptime = 12784,
	serialization_version = 29,
	patch = 0,
	formspec_version = 6,
	protocol_version = 42,
	max_rtt = 3.0050001144409,
	max_jitter = 2.835000038147,
	major = 5,
	version_string = "5.8.0-dev-7388c87ad",
	lang_code = ""
}

Player meta:

{
	fields = {
		["stamina:exhaustion"] = "118.5",
		yl_commons_player_created = "1615351173",
		died = "100",
		["petz:werewolf_clan_idx"] = "1",
		digged_nodes = "1707402",
		["signslib:pos"] = "(1275,70,546)",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		jointime = "1615351173",
		bitten = "0",
		repellant = "0",
		["petz:werewolf"] = "0",
		yl_commons_thankyou = "324",
		["petz:lycanthropy"] = "1",
		xp = "2242215",
		placed_nodes = "468564",
		yl_commons_player_joined = "1690491408",
		["petz:werewolf_vignette_id"] = "20",
		hud_state = "on",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 1227, [\"x\"] = 35, [\"y\"] = 38}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1687231432}",
		partychat = "party",
		crafted = "202122",
		punch_count = "294636",
		["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 5400\", \"3d_armor:leggings_rainbow 1 5400\", \"3d_armor:helmet_rainbow 1 5400\", \"3d_armor:chestplate_rainbow 1 5400\", \"nether_mobs:dragon_boots 1 13500\", \"\"}",
		inflicted_damage = "5796852",
		["stamina:level"] = "10",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:poisoned"] = "no",
		played_time = "39608195"
	}
}

Log identifier


[MOD] yl_report log identifier = PFjYaudDaaUbb5HpHlPjgRmKfS9AYDpc

Profiler save:

profile-20230728T002931.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 52min 27s | max lag: 0.265s | clients (19/52): AliasAlreadyTaken, Aliza, DragonWrangler1, Empempires, evil123, flux, JakeCrepeerawman123, JeCel, kingtux, MineWorlds, mrminer, niceride, Oakenshield, Penelopee, Service, Shadow, Taiel, Wanchor, XiuBloom

Teleport command:

/teleport xyz 1320 20 438

Compass command:

/give_compass Construction PFjYaudDaaUbb5HpHlPjgRmKfS9AYDpc D2691E 1320 20 438

flux reports a bug: > discussion: should machines like autocrafters "catch up" when an area is reloaded, the way that furnaces do? Player position: ``` { y = 19.5, z = 438.19903564453, x = 1320.1750488281 } ``` Player look: ``` { y = -0.99872815608978, z = -0.0047186347655952, x = -0.050197351723909 } ``` Player information: ``` { state = "Active", ip_version = 6, min_rtt = 0.16500000655651, avg_rtt = 0.17499999701977, min_jitter = 0, minor = 8, avg_jitter = 0, connection_uptime = 12784, serialization_version = 29, patch = 0, formspec_version = 6, protocol_version = 42, max_rtt = 3.0050001144409, max_jitter = 2.835000038147, major = 5, version_string = "5.8.0-dev-7388c87ad", lang_code = "" } ``` Player meta: ``` { fields = { ["stamina:exhaustion"] = "118.5", yl_commons_player_created = "1615351173", died = "100", ["petz:werewolf_clan_idx"] = "1", digged_nodes = "1707402", ["signslib:pos"] = "(1275,70,546)", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", jointime = "1615351173", bitten = "0", repellant = "0", ["petz:werewolf"] = "0", yl_commons_thankyou = "324", ["petz:lycanthropy"] = "1", xp = "2242215", placed_nodes = "468564", yl_commons_player_joined = "1690491408", ["petz:werewolf_vignette_id"] = "20", hud_state = "on", yl_church = "return {[\"last_death\"] = {[\"z\"] = 1227, [\"x\"] = 35, [\"y\"] = 38}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1687231432}", partychat = "party", crafted = "202122", punch_count = "294636", ["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 5400\", \"3d_armor:leggings_rainbow 1 5400\", \"3d_armor:helmet_rainbow 1 5400\", \"3d_armor:chestplate_rainbow 1 5400\", \"nether_mobs:dragon_boots 1 13500\", \"\"}", inflicted_damage = "5796852", ["stamina:level"] = "10", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:poisoned"] = "no", played_time = "39608195" } } ``` Log identifier ``` [MOD] yl_report log identifier = PFjYaudDaaUbb5HpHlPjgRmKfS9AYDpc ``` Profiler save: ``` profile-20230728T002931.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 52min 27s | max lag: 0.265s | clients (19/52): AliasAlreadyTaken, Aliza, DragonWrangler1, Empempires, evil123, flux, JakeCrepeerawman123, JeCel, kingtux, MineWorlds, mrminer, niceride, Oakenshield, Penelopee, Service, Shadow, Taiel, Wanchor, XiuBloom ``` Teleport command: ``` /teleport xyz 1320 20 438 ``` Compass command: ``` /give_compass Construction PFjYaudDaaUbb5HpHlPjgRmKfS9AYDpc D2691E 1320 20 438 ```

👍 3

AliasAlreadyTaken was assigned by yourland-report

2023-07-28 00:29:31 +00:00

sixer commented

2023-07-28 19:08:09 +00:00

yes, that would mean less motivation to stay afk near them

👍 3

AliasAlreadyTaken commented

2023-07-28 21:50:42 +00:00

What machines could be done that way? Pipeworks?

Also, wouldn't that cause lag on the block loading when a lot of machines are in there?

What machines could be done that way? Pipeworks? Also, wouldn't that cause lag on the block loading when a lot of machines are in there?

AliasAlreadyTaken added the

1. kind/enhancement

3. source/integration

4. step/discussion

labels 2023-07-28 21:51:07 +00:00

Sokomine commented

2023-07-29 02:11:39 +00:00

Probably way less lag then when players actually afk there for hours. All the block needs to do is calculate what would have happened in the meantime

AliasAlreadyTaken commented

2023-07-29 02:26:49 +00:00

Even if, afk-ing near a machine causes low, but constant lag. So far, mesecons are not among the main lag sources. Having it all run once the block is loaded might cause a lag spike, which may be way less on average, but can be felt the moment it happens.

Even if, afk-ing near a machine causes low, but constant lag. So far, mesecons are not among the main lag sources. Having it all run once the block is loaded might cause a lag spike, which may be way less *on average*, but can be felt the moment it happens.

whosit commented

2023-07-29 06:10:02 +00:00

Crafting some items in bulk seemed to cause lag spikes, will this catch-up be affected by it?

sixer commented

2023-07-29 20:26:55 +00:00

this would be applicable only to isolated machines (furnace, autocrafter, ...) doing something internally (where you can easily calculate and do the work done in given time). not for stuff sent via pipes where approximating work done would be difficult

flux commented

2023-07-30 01:20:44 +00:00

Even if, afk-ing near a machine causes low, but constant lag. So far, mesecons are not among the main lag sources. Having it all run once the block is loaded might cause a lag spike, which may be way less on average, but can be felt the moment it happens.

Crafting some items in bulk seemed to cause lag spikes, will this catch-up be affected by it?

the only "machines" this change would apply to would be the autocrafter and the workbench, so we only need to worry about crafting.

we're using https://github.com/minetest/minetest/pull/13234, so it won't take much time to just calculate a crafting result repeatedly until we're done done.

if furnaces don't cause a lag spike, and craft all doesn't cause a lag spike, i wouldn't expect autocrafters to cause a lag spike even if dozens of them were all loaded at once. if we're worried, we can throttle the feature using action_queues.

> Even if, afk-ing near a machine causes low, but constant lag. So far, mesecons are not among the main lag sources. Having it all run once the block is loaded might cause a lag spike, which may be way less *on average*, but can be felt the moment it happens. > Crafting some items in bulk seemed to cause lag spikes, will this catch-up be affected by it? the only "machines" this change would apply to would be the autocrafter and the workbench, so we only need to worry about crafting. we're using https://github.com/minetest/minetest/pull/13234, so it won't take much time to just calculate a crafting result repeatedly until we're done done. if furnaces don't cause a lag spike, and craft all doesn't cause a lag spike, i wouldn't expect autocrafters to cause a lag spike even if dozens of them were all loaded at once. if we're worried, we can throttle the feature using [action_queues](https://github.com/fluxionary/minetest-action_queues).

Horus commented

2023-08-02 19:45:41 +00:00

can I humbly suggest the throttle be there before. Xhoas.
hate throttling in general, but automation alwys prone to breakage.

can I humbly suggest the throttle be there before. Xhoas. hate throttling in general, but automation alwys prone to breakage.

flux added this to the flux's TODO list project 2023-08-02 23:52:59 +00:00

Sign in to join this conversation.