display_modpack/signs eat backslashes #5016

New Issue

yourland-report · 2023-07-27T05:33:16Z

yourland-report commented

2023-07-27 05:33:16 +00:00

whosit reports a bug:

display_modpack/signs eat backslashes: write a sign containing "\", it's displayed properly, but when you edit it again, formspec treating them as escapes and they disappear

Player position:

{
	x = 25216.078125,
	y = 1.5,
	z = 30080.693359375
}

Player look:

{
	x = -0.037336625158787,
	y = -0.3863890171051,
	z = -0.92157989740372
}

Player information:

{
	connection_uptime = 2740,
	serialization_version = 29,
	patch = 0,
	lang_code = "",
	major = 5,
	version_string = "5.7.0",
	formspec_version = 6,
	max_rtt = 0.55699998140335,
	min_rtt = 0.03999999910593,
	minor = 7,
	state = "Active",
	ip_version = 6,
	protocol_version = 42,
	avg_rtt = 0.041999999433756,
	min_jitter = 0,
	max_jitter = 0.51599997282028,
	avg_jitter = 0
}

Player meta:

{
	fields = {
		xp_redo_hud_color = "0x0000ff",
		digged_nodes = "257705",
		placed_nodes = "79465",
		died = "759",
		crafted = "59626",
		yl_commons_player_created = "1615221933",
		repellant = "0",
		["petz:werewolf"] = "0",
		jointime = "1615221933",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "20",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		partychat = "party",
		["signslib:pos"] = "(25215,2,30079)",
		lagometer = "1",
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_crystal 1 10620\", \"3d_armor:chestplate_crystal 1 10620\", \"3d_armor:helmet_crystal 1 10620\", \"shields:shield_crystal 1 10620\", \"3d_armor:boots_crystal 1 14320\", \"\"}",
		["petz:werewolf_clan_idx"] = "3",
		punch_count = "37426",
		xp = "175976",
		inflicted_damage = "553630",
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "131",
		yl_church = "return {[\"last_death_portal\"] = 1690304150, [\"last_death\"] = {[\"x\"] = -17437, [\"y\"] = 170, [\"z\"] = 2300}, [\"last_heal\"] = 1687691946}",
		played_time = "6021481",
		arenalib_infobox_arenaID = "0",
		hud_state = "on",
		["stamina:level"] = "12",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["petz:lycanthropy"] = "1",
		yl_commons_player_joined = "1690433279",
		["stamina:exhaustion"] = "55.5"
	}
}

Log identifier


[MOD] yl_report log identifier = IVIpYLtx1bE3fqmg8d31CU1l1wdVZRBb

Profiler save:

profile-20230727T053316.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 13h 43min 58s | max lag: 0.465s | clients (14/52): AliasAlreadyTaken, Alinia, BLuOXide, evil123, flux, Fragers, Ivanshg, MicaelStarfire, Penelopee, Shadow, Sysmatic, Wanchor, whosit, whostand

Teleport command:

/teleport xyz 25216 2 30081

Compass command:

/give_compass Construction IVIpYLtx1bE3fqmg8d31CU1l1wdVZRBb D2691E 25216 2 30081

whosit reports a bug: > display_modpack/signs eat backslashes: write a sign containing "\\", it's displayed properly, but when you edit it again, formspec treating them as escapes and they disappear Player position: ``` { x = 25216.078125, y = 1.5, z = 30080.693359375 } ``` Player look: ``` { x = -0.037336625158787, y = -0.3863890171051, z = -0.92157989740372 } ``` Player information: ``` { connection_uptime = 2740, serialization_version = 29, patch = 0, lang_code = "", major = 5, version_string = "5.7.0", formspec_version = 6, max_rtt = 0.55699998140335, min_rtt = 0.03999999910593, minor = 7, state = "Active", ip_version = 6, protocol_version = 42, avg_rtt = 0.041999999433756, min_jitter = 0, max_jitter = 0.51599997282028, avg_jitter = 0 } ``` Player meta: ``` { fields = { xp_redo_hud_color = "0x0000ff", digged_nodes = "257705", placed_nodes = "79465", died = "759", crafted = "59626", yl_commons_player_created = "1615221933", repellant = "0", ["petz:werewolf"] = "0", jointime = "1615221933", bitten = "0", ["petz:werewolf_vignette_id"] = "20", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", partychat = "party", ["signslib:pos"] = "(25215,2,30079)", lagometer = "1", ["3d_armor_inventory"] = "return {\"3d_armor:leggings_crystal 1 10620\", \"3d_armor:chestplate_crystal 1 10620\", \"3d_armor:helmet_crystal 1 10620\", \"shields:shield_crystal 1 10620\", \"3d_armor:boots_crystal 1 14320\", \"\"}", ["petz:werewolf_clan_idx"] = "3", punch_count = "37426", xp = "175976", inflicted_damage = "553630", ["stamina:poisoned"] = "no", yl_commons_thankyou = "131", yl_church = "return {[\"last_death_portal\"] = 1690304150, [\"last_death\"] = {[\"x\"] = -17437, [\"y\"] = 170, [\"z\"] = 2300}, [\"last_heal\"] = 1687691946}", played_time = "6021481", arenalib_infobox_arenaID = "0", hud_state = "on", ["stamina:level"] = "12", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["petz:lycanthropy"] = "1", yl_commons_player_joined = "1690433279", ["stamina:exhaustion"] = "55.5" } } ``` Log identifier ``` [MOD] yl_report log identifier = IVIpYLtx1bE3fqmg8d31CU1l1wdVZRBb ``` Profiler save: ``` profile-20230727T053316.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 4d 13h 43min 58s | max lag: 0.465s | clients (14/52): AliasAlreadyTaken, Alinia, BLuOXide, evil123, flux, Fragers, Ivanshg, MicaelStarfire, Penelopee, Shadow, Sysmatic, Wanchor, whosit, whostand ``` Teleport command: ``` /teleport xyz 25216 2 30081 ``` Compass command: ``` /give_compass Construction IVIpYLtx1bE3fqmg8d31CU1l1wdVZRBb D2691E 25216 2 30081 ```

AliasAlreadyTaken was assigned by yourland-report

2023-07-27 05:33:16 +00:00

whosit changed title from ~~whosit reports: display_modpack/signs eat back ...~~ to whosit reports: display_modpack/signs eat backslashes

2023-07-27 05:33:50 +00:00

whosit added the

1. kind/bug

3. source/mod upstream

2. prio/low

labels 2023-07-27 05:34:11 +00:00

whosit changed title from ~~whosit reports: display_modpack/signs eat backslashes~~ to display_modpack/signs eat backslashes

2023-07-27 06:03:47 +00:00

Niklp commented

2023-07-27 11:52:34 +00:00

see https://github.com/mt-mods/display_modpack/issues/2

👍 1

Niklp commented

2023-07-27 15:34:28 +00:00

Fixed in 1f8e99c9c5 and bd59f7f78b

Fixed in https://github.com/mt-mods/display_modpack/commit/1f8e99c9c52afb05d7523b25e2e4fff6f236ed5f and https://github.com/mt-mods/display_modpack/commit/bd59f7f78b48cde3d73ee8d51dc2af66c50078dd

🎉 3

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-07-27 20:01:04 +00:00

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-07-27 20:01:08 +00:00

AliasAlreadyTaken commented

2023-08-25 06:47:46 +00:00

QA

This is somehow NOT fixed, backslashes still disappear. Repro:

Place a sign
Rightclick and enter "test\test" (test backslash test)
save
=> Reads "test\test"
Rightclick again

Wrong: Text in the sign says "testtest" (backslash vanished)
Expected: Text in the sign says "test\test" (backslash still present)

QA This is somehow NOT fixed, backslashes still disappear. Repro: 1. Place a sign 2. Rightclick and enter "test\test" (test backslash test) 3. save => Reads "test\test" 4. Rightclick again Wrong: Text in the sign says "testtest" (backslash vanished) Expected: Text in the sign says "test\test" (backslash still present)

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-08-25 06:47:52 +00:00

AliasAlreadyTaken commented

2023-08-25 08:43:39 +00:00

Reason is probably that we're still using the Archtec fork instead of the mt-mods fork.

👍 1 😆 1

AliasAlreadyTaken added this to the Alias@work project 2023-08-25 08:43:44 +00:00

AliasAlreadyTaken added the

4. step/at work

label 2023-08-25 10:36:35 +00:00

AliasAlreadyTaken commented