EvilRevised reports: Make (Super) Glow Glass connec ... #4980

Open
opened 2023-07-22 12:28:41 +00:00 by yourland-report · 13 comments

EvilRevised reports a bug:

Make (Super) Glow Glass connect again.

Player position:

{
	x = 613.67596435547,
	y = 77.5,
	z = 20507.21484375
}

Player look:

{
	x = -0.6500129699707,
	y = -0.34955334663391,
	z = 0.67475599050522
}

Player information:

{
	ip_version = 6,
	protocol_version = 41,
	avg_rtt = 0.023000000044703,
	min_jitter = 0,
	max_jitter = 0.23000000417233,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 133,
	formspec_version = 6,
	patch = 0,
	state = "Active",
	version_string = "5.7.0-dev-89e7f72",
	min_rtt = 0.021999999880791,
	minor = 7,
	serialization_version = 29,
	max_rtt = 0.25400000810623,
	major = 5,
	lang_code = ""
}

Player meta:

{
	fields = {
		jointime = "1616704710",
		bitten = "0",
		yl_commons_thankyou = "5",
		["signslib:pos"] = "(632,75,20546)",
		hud_state = "on",
		xp = "1049718",
		punch_count = "3838",
		arenalib_infobox_arenaID = "0",
		xp_redo_hud_color = "0x990000",
		inflicted_damage = "24232",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 588, [\"y\"] = 77, [\"z\"] = 20549}, [\"last_death_portal\"] = 1678580572}",
		crafted = "115096",
		["stamina:level"] = "18",
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 5920\", \"3d_armor:boots_crystal 1 5920\", \"3d_armor:leggings_crystal 1 5920\", \"3d_armor:helmet_crystal 1 5920\", \"shields:shield_crystal 1 5920\", \"\"}",
		yl_commons_player_created = "1616704710",
		repellant = "0",
		["stamina:exhaustion"] = "104.5",
		yl_commons_player_joined = "1690028818",
		partychat = "party",
		played_time = "2287838",
		digged_nodes = "915282",
		placed_nodes = "385521",
		died = "55",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = VjVgnpeq4JaP4Ylh8aDtJTxtcR1ju3vP

Profiler save:

profile-20230722T122841.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 3h 13min 52s | max lag: 6.04s | clients (26/52): 9T9, admiral, AliasAlreadyTaken, Aliza, Allan, Bailiff, Bingo, Chache, Daddel, daydream, EvilRevised, flux, HorusDamocles, icecreamkek, LadyPixels, Laurii, MBK, Murmel, Nibsokube, niceride, NodeBreaker, Penelopee, Shadow, Sokomine, Wanchor, whosit

Teleport command:

/teleport xyz 614 78 20507

Compass command:

/give_compass Construction VjVgnpeq4JaP4Ylh8aDtJTxtcR1ju3vP D2691E 614 78 20507
EvilRevised reports a bug: > Make (Super) Glow Glass connect again. Player position: ``` { x = 613.67596435547, y = 77.5, z = 20507.21484375 } ``` Player look: ``` { x = -0.6500129699707, y = -0.34955334663391, z = 0.67475599050522 } ``` Player information: ``` { ip_version = 6, protocol_version = 41, avg_rtt = 0.023000000044703, min_jitter = 0, max_jitter = 0.23000000417233, avg_jitter = 0.0010000001639128, connection_uptime = 133, formspec_version = 6, patch = 0, state = "Active", version_string = "5.7.0-dev-89e7f72", min_rtt = 0.021999999880791, minor = 7, serialization_version = 29, max_rtt = 0.25400000810623, major = 5, lang_code = "" } ``` Player meta: ``` { fields = { jointime = "1616704710", bitten = "0", yl_commons_thankyou = "5", ["signslib:pos"] = "(632,75,20546)", hud_state = "on", xp = "1049718", punch_count = "3838", arenalib_infobox_arenaID = "0", xp_redo_hud_color = "0x990000", inflicted_damage = "24232", yl_church = "return {[\"last_death\"] = {[\"x\"] = 588, [\"y\"] = 77, [\"z\"] = 20549}, [\"last_death_portal\"] = 1678580572}", crafted = "115096", ["stamina:level"] = "18", ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 5920\", \"3d_armor:boots_crystal 1 5920\", \"3d_armor:leggings_crystal 1 5920\", \"3d_armor:helmet_crystal 1 5920\", \"shields:shield_crystal 1 5920\", \"\"}", yl_commons_player_created = "1616704710", repellant = "0", ["stamina:exhaustion"] = "104.5", yl_commons_player_joined = "1690028818", partychat = "party", played_time = "2287838", digged_nodes = "915282", placed_nodes = "385521", died = "55", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = VjVgnpeq4JaP4Ylh8aDtJTxtcR1ju3vP ``` Profiler save: ``` profile-20230722T122841.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 7d 3h 13min 52s | max lag: 6.04s | clients (26/52): 9T9, admiral, AliasAlreadyTaken, Aliza, Allan, Bailiff, Bingo, Chache, Daddel, daydream, EvilRevised, flux, HorusDamocles, icecreamkek, LadyPixels, Laurii, MBK, Murmel, Nibsokube, niceride, NodeBreaker, Penelopee, Shadow, Sokomine, Wanchor, whosit ``` Teleport command: ``` /teleport xyz 614 78 20507 ``` Compass command: ``` /give_compass Construction VjVgnpeq4JaP4Ylh8aDtJTxtcR1ju3vP D2691E 614 78 20507 ```
AliasAlreadyTaken was assigned by yourland-report 2023-07-22 12:28:41 +00:00
AliasAlreadyTaken added the
4. step/needs confirmation
label 2023-07-22 12:44:37 +00:00
Member

perhaps EvilRevised unchecked the "connected glass" option in the graphics settings?

perhaps EvilRevised unchecked the "connected glass" option in the graphics settings?

I relate to the problem.

My SGG (and normal GG) were connecting when I joined the server, then about a year ago they ceased to do. I never found out why.

To be clear, the "connected glass" option in the graphic settings is checked, and normal glass does connect, as do clean and obsidian glass.

I relate to the problem. My SGG (and normal GG) were connecting when I joined the server, then about a year ago they ceased to do. I never found out why. To be clear, the "connected glass" option in the graphic settings is checked, and normal glass does connect, as do clean and obsidian glass.

Super Glow Glass is of the drawtype "glasslike_framed_optional", which means: This switches between the above 2 drawtypes according to the menu setting 'Connected Glass'.

Sounjds like it should be connected if the right setting is used? Boris had "connected glass" checked, but its still not connected.

Super Glow Glass is of the drawtype "glasslike_framed_optional", which means: This switches between the above 2 drawtypes according to the menu setting 'Connected Glass'. Sounjds like it *should* be connected if the right setting is used? Boris had "connected glass" checked, but its still not connected.
AliasAlreadyTaken added
1. kind/bug
and removed
4. step/needs confirmation
labels 2023-07-23 14:14:45 +00:00
Member

Sounjds like it should be connected if the right setting is used? Boris had "connected glass" checked, but its still not connected.

huh, it's connected for me. possibly there's another graphics setting that's relevant; getting a full minetest.conf dump w/ any private info removed would be useful.

> Sounjds like it *should* be connected if the right setting is used? Boris had "connected glass" checked, but its still not connected. huh, it's connected for me. possibly there's another graphics setting that's relevant; getting a full `minetest.conf` dump w/ any private info removed would be useful.
AliasAlreadyTaken added
1. kind/documentation
and removed
1. kind/bug
labels 2023-07-24 13:32:09 +00:00

Dev, 5.7.0 and 5.6.1 all behave as shown on screen for me. ~/minetest/minetest.conf attached.

Dev, 5.7.0 and 5.6.1 all behave as shown on screen for me. ~/minetest/minetest.conf attached.

Attached!

Attached!
Member

Notice how insides are still drawn differently when you enable connected glass option - it's just the front face that stays unconnected.

These are the only options I have common with Ravise:

address = your-land.de
autojump = false
aux1_descends = false
connected_glass = true
continuous_forward = false
cottages_feldweg_mode = mesh
doubletap_jump = false
enable_damage = false
enable_server = false
enable_shaders = true
keymap_cmd_local = KEY_PERIOD
keymap_decrease_viewing_range_min = KEY_MINUS
keymap_increase_viewing_range_min = KEY_PLUS
keymap_rangeselect = KEY_KEY_R
main_menu_technical_settings = true
maintab_LAST = online
pitch_move = false
port = 30000
remote_port = 30000
wieldview_node_tiles = false
wieldview_update_time = 2

Notice how insides are still drawn differently when you enable connected glass option - it's just the front face that stays unconnected. These are the only options I have common with Ravise: ``` address = your-land.de autojump = false aux1_descends = false connected_glass = true continuous_forward = false cottages_feldweg_mode = mesh doubletap_jump = false enable_damage = false enable_server = false enable_shaders = true keymap_cmd_local = KEY_PERIOD keymap_decrease_viewing_range_min = KEY_MINUS keymap_increase_viewing_range_min = KEY_PLUS keymap_rangeselect = KEY_KEY_R main_menu_technical_settings = true maintab_LAST = online pitch_move = false port = 30000 remote_port = 30000 wieldview_node_tiles = false wieldview_update_time = 2 ```
Member

image

![image](/attachments/713d5bae-0084-4c90-b611-bcca322c5150)
301 KiB
Member

huh nevermind i get the same issue when connected to the yl_server instead of just using my local yl test world...

i've verified that the definition of the glass is identical in both environments, so .... ??!?!

huh nevermind i get the same issue when connected to the yl_server instead of just using my local yl test world... i've verified that the definition of the glass is *identical* in both environments, so .... ??!?!
flux added
1. kind/bug
3. source/unknown
3. source/client
and removed
1. kind/documentation
labels 2023-07-26 15:57:13 +00:00
Member

ah, not quite identical. on yl, the tiles definition only lists a single node, instead of two, which is necessary to create a connected texture. i suspect a0ca02f5f4, but that didn't seem to cause the issue at the time. it should have only fixed the microblocks. perhaps i need to bisect and track this to a specific commit.

noting that my moreblocks fork fixes this, so perhaps that'll be the solution. but the current "upstream" moreblocks also doesn't have the issue, so perhaps something went wrong w/ a merge?

ah, not quite identical. on yl, the tiles definition only lists a single node, instead of two, which is necessary to create a connected texture. i suspect https://gitea.your-land.de/your-land/moreblocks/commit/a0ca02f5f40aa6c3461f53f629d3cc8763e28c71, but that didn't seem to cause the issue at the time. it should have only fixed the microblocks. perhaps i need to bisect and track this to a specific commit. noting that my moreblocks fork fixes this, so perhaps that'll be the solution. but the current "upstream" moreblocks also doesn't have the issue, so perhaps something went wrong w/ a merge?
Member
cf. https://github.com/minetest-mods/moreblocks/pull/113#issuecomment-370190754

Does that mean we can only have one OR the other issue?

Does that mean we can only have one OR the other issue?
Member

Does that mean we can only have one OR the other issue?

both the microblocks and the connected glass look fine w/ my fork. well, not every microblock, a handful still seem to have problems. both things seem to both look okay w/ copy of moreblocks from github.com/minetest-mods/moreblocks, though i haven't looked at as many variants. my theory is that we somehow screwed up a merge.

i can dig deeper into this, but if we're aiming to adopt my moreblocks fork, i'd rather spend time doing other things

> Does that mean we can only have one OR the other issue? both the microblocks and the connected glass look fine w/ my fork. well, not every microblock, a handful still seem to have problems. both things seem to both look okay w/ copy of moreblocks from github.com/minetest-mods/moreblocks, though i haven't looked at as many variants. my theory is that we somehow screwed up a merge. i can dig deeper into this, but if we're aiming to adopt my moreblocks fork, i'd rather spend time doing other things
AliasAlreadyTaken added this to the moreblocks milestone 2023-12-08 06:01:23 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4980
No description provided.