flux reports: probably dragon fire and blaze ... #4860

New Issue

yourland-report · 2023-06-28T18:06:54Z

yourland-report commented

2023-06-28 18:06:54 +00:00

flux reports a bug:

probably dragon fire and blaze fire should go out eventually?

Player position:

{
	x = 3683.0141601563,
	y = 29.5,
	z = 1493.3430175781
}

Player look:

{
	x = 0.56964749097824,
	y = -0.11684408038855,
	z = -0.81354117393494
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.16699999570847,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	max_jitter = 6.3410000801086,
	avg_jitter = 0.0059999972581863,
	connection_uptime = 738,
	serialization_version = 29,
	patch = 0,
	formspec_version = 6,
	protocol_version = 42,
	major = 5,
	version_string = "5.8.0-dev-7388c87ad",
	state = "Active",
	max_rtt = 6.5130000114441,
	lang_code = "",
	minor = 8
}

Player meta:

{
	fields = {
		arenalib_infobox_arenaID = "0",
		["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"player.flux.0.png\", \"blank.png\", \"3d_armor_trans.png^3d_armor_leggings_rainbow.png^shields_shield_rainbow.png^3d_armor_helmet_rainbow.png^nether_mobs_dragon_boots.png^3d_armor_chestplate_rainbow.png\", \"moreores_tool_mithrilsword.png^[colorize:violet:50\"}, [\"animation\"] = \"mine\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\"}",
		jointime = "1615351173",
		bitten = "0",
		repellant = "0",
		["stamina:level"] = "7",
		yl_commons_player_created = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "89",
		hud_state = "on",
		xp = "2089674",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 1227, [\"x\"] = 35, [\"y\"] = 38}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1687231432}",
		partychat = "party",
		yl_commons_thankyou = "319",
		["petz:lycanthropy"] = "1",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		yl_commons_player_joined = "1687974901",
		died = "100",
		["petz:werewolf_vignette_id"] = "20",
		digged_nodes = "1595275",
		placed_nodes = "450276",
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 3240\", \"shields:shield_rainbow 1 3240\", \"3d_armor:helmet_rainbow 1 3240\", \"nether_mobs:dragon_boots 1 8100\", \"3d_armor:chestplate_rainbow 1 3240\", \"\"}",
		crafted = "178918",
		["signslib:pos"] = "(1370,179,415)",
		punch_count = "282771",
		["petz:werewolf"] = "1",
		inflicted_damage = "5544680",
		played_time = "37756253",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_clan_idx"] = "1"
	}
}

Log identifier


[MOD] yl_report log identifier = raDoWRjKuXuz4GoNDM3oGVzY9rqovi1K

Profiler save:

profile-20230628T180654.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 8h 40min 26s | max lag: 0.757s | clients (32/52): Alexium, AliasAlreadyTaken, Appledore, Bailiff, BibaBoba, Bishiro, Bond007, Boot, darealbang, DragonWrangler1, FernanFloo, FireThatFollows, flux, Functional, huguito, Jackcity, JeCel, Kadax, kapybara, Neige, Nodes, Qichta29, rewired_X, rvfvmoncho, savana_g, Service, Shadow, shanish2, swsaty, Sysmatic, wolf123, wordes

Teleport command:

/teleport xyz 3683 30 1493

Compass command:

/give_compass Construction raDoWRjKuXuz4GoNDM3oGVzY9rqovi1K D2691E 3683 30 1493

flux reports a bug: > probably dragon fire and blaze fire should go out eventually? Player position: ``` { x = 3683.0141601563, y = 29.5, z = 1493.3430175781 } ``` Player look: ``` { x = 0.56964749097824, y = -0.11684408038855, z = -0.81354117393494 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.16699999570847, avg_rtt = 0.17499999701977, min_jitter = 0, max_jitter = 6.3410000801086, avg_jitter = 0.0059999972581863, connection_uptime = 738, serialization_version = 29, patch = 0, formspec_version = 6, protocol_version = 42, major = 5, version_string = "5.8.0-dev-7388c87ad", state = "Active", max_rtt = 6.5130000114441, lang_code = "", minor = 8 } ``` Player meta: ``` { fields = { arenalib_infobox_arenaID = "0", ["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"player.flux.0.png\", \"blank.png\", \"3d_armor_trans.png^3d_armor_leggings_rainbow.png^shields_shield_rainbow.png^3d_armor_helmet_rainbow.png^nether_mobs_dragon_boots.png^3d_armor_chestplate_rainbow.png\", \"moreores_tool_mithrilsword.png^[colorize:violet:50\"}, [\"animation\"] = \"mine\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\"}", jointime = "1615351173", bitten = "0", repellant = "0", ["stamina:level"] = "7", yl_commons_player_created = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "89", hud_state = "on", xp = "2089674", yl_church = "return {[\"last_death\"] = {[\"z\"] = 1227, [\"x\"] = 35, [\"y\"] = 38}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1687231432}", partychat = "party", yl_commons_thankyou = "319", ["petz:lycanthropy"] = "1", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", yl_commons_player_joined = "1687974901", died = "100", ["petz:werewolf_vignette_id"] = "20", digged_nodes = "1595275", placed_nodes = "450276", ["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 3240\", \"shields:shield_rainbow 1 3240\", \"3d_armor:helmet_rainbow 1 3240\", \"nether_mobs:dragon_boots 1 8100\", \"3d_armor:chestplate_rainbow 1 3240\", \"\"}", crafted = "178918", ["signslib:pos"] = "(1370,179,415)", punch_count = "282771", ["petz:werewolf"] = "1", inflicted_damage = "5544680", played_time = "37756253", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_clan_idx"] = "1" } } ``` Log identifier ``` [MOD] yl_report log identifier = raDoWRjKuXuz4GoNDM3oGVzY9rqovi1K ``` Profiler save: ``` profile-20230628T180654.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 8h 40min 26s | max lag: 0.757s | clients (32/52): Alexium, AliasAlreadyTaken, Appledore, Bailiff, BibaBoba, Bishiro, Bond007, Boot, darealbang, DragonWrangler1, FernanFloo, FireThatFollows, flux, Functional, huguito, Jackcity, JeCel, Kadax, kapybara, Neige, Nodes, Qichta29, rewired_X, rvfvmoncho, savana_g, Service, Shadow, shanish2, swsaty, Sysmatic, wolf123, wordes ``` Teleport command: ``` /teleport xyz 3683 30 1493 ``` Compass command: ``` /give_compass Construction raDoWRjKuXuz4GoNDM3oGVzY9rqovi1K D2691E 3683 30 1493 ```

👍 1 👎 1

AliasAlreadyTaken was assigned by yourland-report

2023-06-28 18:06:54 +00:00

flux added the

1. kind/balancing

4. step/want approval

labels 2023-06-28 19:21:23 +00:00

AzelfYL commented

2023-06-29 00:41:51 +00:00

I think blaze fire should, but dragon fire shouldn't.

👍 2

AliasAlreadyTaken commented

2023-06-29 05:46:10 +00:00

Cleaning up dragonfire after a major battle is not the funnerest thing to do, so yes, both should go out after a while.

There is already a node timer on them, they go out if there's no burning material nearby. Let's take this nodetimer and make it 10x longer, then go out if there's flammables close.

Cleaning up dragonfire after a major battle is not the funnerest thing to do, so yes, both should go out after a while. There is already a node timer on them, they go out if there's no burning material nearby. Let's take this nodetimer and make it 10x longer, then go out if there's flammables close.

Boot commented

2023-06-29 15:18:48 +00:00

I had confused my thumb down with the dropping of the Blaze.

flux commented

2023-06-29 18:45:55 +00:00

There is already a node timer on them, they go out if there's no burning material nearby. Let's take this nodetimer and make it 10x longer, then go out if there's flammables close.

i implemented this: 2275264922

there's now a chance for it to extinguish if there's a flammable node nearby.

> There is already a node timer on them, they go out if there's no burning material nearby. Let's take this nodetimer and make it 10x longer, then go out if there's flammables close. i implemented this: https://gitea.your-land.de/your-land/yl_events/commit/2275264922d9f45d671b3d3f22c5197499070ebf there's now a chance for it to extinguish if there's a flammable node nearby.

👍 1

flux commented

2023-06-29 18:57:14 +00:00

similarly for blaze fire (required creating a separate node for it)

f4ab870ec2

similarly for blaze fire (required creating a separate node for it) https://gitea.your-land.de/your-land/yl_nether_mobs/commit/f4ab870ec2442b2aa7de6b0fd27ef4794c45250e

👍 1

flux added

4. step/ready to QA test

and removed

4. step/want approval

labels 2023-06-29 18:57:37 +00:00

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-06-29 19:25:56 +00:00

AliasAlreadyTaken commented

2023-08-26 08:26:57 +00:00

QA

Dragonfire goes out nicely after a while
Blaze somehow doesn't, most likely because in line 157 it still fire basic_flame instead of yl_nether_mobs:blaze_fire

QA Dragonfire goes out nicely after a while Blaze somehow doesn't, most likely because in line 157 it still fire basic_flame instead of yl_nether_mobs:blaze_fire

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-08-26 08:27:03 +00:00

AliasAlreadyTaken referenced this issue from a commit

2023-09-11 07:06:40 +00:00

your-land/bugtracker#4860 Blaze: Switch basic flame to specific flame node

AliasAlreadyTaken commented

2023-09-11 07:07:03 +00:00

QA: Both flames go out after a while :)

AliasAlreadyTaken added

ugh/QA OK

and removed