Sokomine reports: thankyou <npcname> ought to wo ... #4791

New Issue

yourland-report · 2023-06-17T17:28:25Z

yourland-report commented

2023-06-17 17:28:25 +00:00

Sokomine reports a bug:

thankyou ought to work as well :-)

Player position:

{
	z = 1170.5009765625,
	x = 1968.9699707031,
	y = 17.5
}

Player look:

{
	z = 0.9315333366394,
	x = 0.27911874651909,
	y = -0.2331059128046
}

Player information:

{
	formspec_version = 6,
	protocol_version = 42,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.01799999922514,
	avg_rtt = 0.019999999552965,
	min_jitter = 0,
	max_jitter = 6.268000125885,
	avg_jitter = 0,
	connection_uptime = 4097,
	minor = 8,
	patch = 0,
	version_string = "5.8.0-dev-c549e84ab-dirty",
	lang_code = "",
	max_rtt = 6.3449997901917,
	major = 5,
	serialization_version = 29
}

Player meta:

{
	fields = {
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		yl_commons_player_created = "1617905120",
		repellant = "0",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 1520, [\"x\"] = 3959, [\"y\"] = 30}, [\"last_heal\"] = 1673909657, [\"last_death_portal\"] = 1686952154}",
		hud_state = "on",
		jointime = "1617905120",
		bitten = "0",
		["signslib:pos"] = "(1576,-54,301)",
		played_time = "14159768",
		digged_nodes = "1901604",
		placed_nodes = "324448",
		died = "46",
		crafted = "581115",
		inflicted_damage = "5574870",
		["ocean_build.last_warning"] = "1.65032e+09",
		["ocean_build.ocean_built"] = "5",
		punch_count = "266457",
		arenalib_infobox_arenaID = "0",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 540\", \"shields:shield_rainbow 1 216\", \"3d_armor:chestplate_crystal 1 540\", \"3d_armor:boots_crystal 1 540\", \"3d_armor:leggings_crystal 1 540\"}",
		xp = "2161731",
		["stamina:exhaustion"] = "117.5",
		["stamina:level"] = "8",
		yl_commons_thankyou = "443",
		["stamina:poisoned"] = "no",
		["ethereal:fly_timer"] = "-99",
		partychat = "main",
		yl_commons_player_joined = "1687018833"
	}
}

Log identifier


[MOD] yl_report log identifier = KkA0SQgPsYI9A3vAfEMF684znQnQHosw

Profiler save:

profile-20230617T172825.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 23h 32min 30s | max lag: 0.782s | clients (24/52): 1234, AliasAlreadyTaken, Bailiff, BibaBoba, Buzz, CatLInA31, crankyape, flux, HorusDamocles, IIIullaIII, jackofthebean000, JeCel, loriens, mahou, MaxMax01, Murmel, nande, Paul45, popefox20, rewired_X, Sacrementum, Service, shanish2, Sokomine

Teleport command:

/teleport xyz 1969 18 1171

Compass command:

/give_compass Construction KkA0SQgPsYI9A3vAfEMF684znQnQHosw D2691E 1969 18 1171

Sokomine reports a bug: > thankyou <npcname> ought to work as well :-) Player position: ``` { z = 1170.5009765625, x = 1968.9699707031, y = 17.5 } ``` Player look: ``` { z = 0.9315333366394, x = 0.27911874651909, y = -0.2331059128046 } ``` Player information: ``` { formspec_version = 6, protocol_version = 42, state = "Active", ip_version = 6, min_rtt = 0.01799999922514, avg_rtt = 0.019999999552965, min_jitter = 0, max_jitter = 6.268000125885, avg_jitter = 0, connection_uptime = 4097, minor = 8, patch = 0, version_string = "5.8.0-dev-c549e84ab-dirty", lang_code = "", max_rtt = 6.3449997901917, major = 5, serialization_version = 29 } ``` Player meta: ``` { fields = { ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", yl_commons_player_created = "1617905120", repellant = "0", yl_church = "return {[\"last_death\"] = {[\"z\"] = 1520, [\"x\"] = 3959, [\"y\"] = 30}, [\"last_heal\"] = 1673909657, [\"last_death_portal\"] = 1686952154}", hud_state = "on", jointime = "1617905120", bitten = "0", ["signslib:pos"] = "(1576,-54,301)", played_time = "14159768", digged_nodes = "1901604", placed_nodes = "324448", died = "46", crafted = "581115", inflicted_damage = "5574870", ["ocean_build.last_warning"] = "1.65032e+09", ["ocean_build.ocean_built"] = "5", punch_count = "266457", arenalib_infobox_arenaID = "0", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 540\", \"shields:shield_rainbow 1 216\", \"3d_armor:chestplate_crystal 1 540\", \"3d_armor:boots_crystal 1 540\", \"3d_armor:leggings_crystal 1 540\"}", xp = "2161731", ["stamina:exhaustion"] = "117.5", ["stamina:level"] = "8", yl_commons_thankyou = "443", ["stamina:poisoned"] = "no", ["ethereal:fly_timer"] = "-99", partychat = "main", yl_commons_player_joined = "1687018833" } } ``` Log identifier ``` [MOD] yl_report log identifier = KkA0SQgPsYI9A3vAfEMF684znQnQHosw ``` Profiler save: ``` profile-20230617T172825.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 23h 32min 30s | max lag: 0.782s | clients (24/52): 1234, AliasAlreadyTaken, Bailiff, BibaBoba, Buzz, CatLInA31, crankyape, flux, HorusDamocles, IIIullaIII, jackofthebean000, JeCel, loriens, mahou, MaxMax01, Murmel, nande, Paul45, popefox20, rewired_X, Sacrementum, Service, shanish2, Sokomine ``` Teleport command: ``` /teleport xyz 1969 18 1171 ``` Compass command: ``` /give_compass Construction KkA0SQgPsYI9A3vAfEMF684znQnQHosw D2691E 1969 18 1171 ```

AliasAlreadyTaken was assigned by yourland-report

2023-06-17 17:28:25 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-06-17 17:45:14 +00:00

flux commented

2023-06-18 03:12:06 +00:00

a confound is that a player can register an NPC's name as their own name

AliasAlreadyTaken added the

1. kind/meme

label 2023-06-18 17:36:01 +00:00

daydream commented

2023-06-20 05:54:53 +00:00

As thankyou is used to see who is useful, I think giving them to NPCs is maybe not that useful. An NPC won't be encouraged to run for bailiff or instance, based on useful stats.

👍 1

Bla commented

2023-06-20 09:34:27 +00:00

sounds strange to use a chat command to thank a NPC after every other interaction with NPC´s is done via formspec.

people could simply add a "thank you" button to the NPC´s menu if wanted/needed which would also make it available as data the NPC could work with.
Might be a nice simple first step task for people learning how to program a NPC too.

sounds strange to use a chat command to thank a NPC after every other interaction with NPC´s is done via formspec. people could simply add a "thank you" button to the NPC´s menu if wanted/needed which would also make it available as data the NPC could work with. Might be a nice simple first step task for people learning how to program a NPC too.

👍 4

Sokomine commented

2023-06-20 16:14:17 +00:00

Blas' idea sounds very good. That'd also avoid the confusion if there's a player and NPC with the same name.

Sign in to join this conversation.