grubibubi reports: i died but i can play now wito ... #478

Open
opened 2021-04-21 09:59:01 +00:00 by yourland-report · 7 comments

grubibubi reports a bug:

i died but i can play now witout health

Player position:

{
	y = 9.5,
	x = 2064.2551269531,
	z = 1253.8780517578
}

Player look:

{
	y = -0.73016232252121,
	x = -0.36177641153336,
	z = 0.57963854074478
}

Player information:

{
	min_rtt = 0.027000000700355,
	max_rtt = 0.66200000047684,
	connection_uptime = 2303,
	lang_code = "",
	address = "::ffff:79.228.1.153",
	formspec_version = 4,
	protocol_version = 39,
	avg_rtt = 0.028999999165535,
	min_jitter = 0,
	ip_version = 6,
	max_jitter = 0.63400000333786,
	avg_jitter = 0.00099999830126762
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		yl_commons_thankyou = "4",
		jointime = "1613058321",
		yl_commons_player_joined = "1618996856",
		digged_nodes = "3457",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 10, [\"x\"] = 2064, [\"z\"] = 1254}, [\"last_heal\"] = 1618328168, [\"last_death_portal\"] = 1618989147}",
		["stamina:level"] = "7",
		punch_count = "983",
		inflicted_damage = "13244",
		crafted = "1127",
		played_time = "152217",
		placed_nodes = "974",
		died = "78",
		hud_state = "on",
		xp = "3430",
		yl_commons_player_created = "1613058321"
	}
}

Log identifier


[MOD] yl_report log identifier = tEo2XwuUvLZlWbyObEFqbz9MHbXMB830

Profiler save:

profile-20210421T115901.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=192063, max_lag=1.43615, clients={phillip, bibi, grubibubi, evil123, Icey_fox, _Zaizen_, White_Feather, Andrew, Service, whosit, Bailiff, AliasAlreadyTaken}
grubibubi reports a bug: > i died but i can play now witout health Player position: ``` { y = 9.5, x = 2064.2551269531, z = 1253.8780517578 } ``` Player look: ``` { y = -0.73016232252121, x = -0.36177641153336, z = 0.57963854074478 } ``` Player information: ``` { min_rtt = 0.027000000700355, max_rtt = 0.66200000047684, connection_uptime = 2303, lang_code = "", address = "::ffff:79.228.1.153", formspec_version = 4, protocol_version = 39, avg_rtt = 0.028999999165535, min_jitter = 0, ip_version = 6, max_jitter = 0.63400000333786, avg_jitter = 0.00099999830126762 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", yl_commons_thankyou = "4", jointime = "1613058321", yl_commons_player_joined = "1618996856", digged_nodes = "3457", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 10, [\"x\"] = 2064, [\"z\"] = 1254}, [\"last_heal\"] = 1618328168, [\"last_death_portal\"] = 1618989147}", ["stamina:level"] = "7", punch_count = "983", inflicted_damage = "13244", crafted = "1127", played_time = "152217", placed_nodes = "974", died = "78", hud_state = "on", xp = "3430", yl_commons_player_created = "1613058321" } } ``` Log identifier ``` [MOD] yl_report log identifier = tEo2XwuUvLZlWbyObEFqbz9MHbXMB830 ``` Profiler save: ``` profile-20210421T115901.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=192063, max_lag=1.43615, clients={phillip, bibi, grubibubi, evil123, Icey_fox, _Zaizen_, White_Feather, Andrew, Service, whosit, Bailiff, AliasAlreadyTaken} ```
AliasAlreadyTaken was assigned by yourland-report 2021-04-21 09:59:01 +00:00
AliasAlreadyTaken added the
1. kind/bug
label 2021-04-22 10:55:05 +00:00

The death-relog-respawn bug was fixed in yl_commons

The death-relog-respawn bug was fixed in yl_commons
AliasAlreadyTaken added the
5. result/fixed
label 2021-07-18 09:54:39 +00:00
Member
https://github.com/minetest/minetest/issues/7879
AliasAlreadyTaken added the
3. source/mod upstream
label 2022-05-21 02:38:37 +00:00
flux added this to the flux's TODO list project 2022-10-08 17:31:14 +00:00
AliasAlreadyTaken was unassigned by flux 2022-10-08 17:31:20 +00:00
flux self-assigned this 2022-10-08 17:31:20 +00:00
Member

re-opening this, as it is very much not fixed. what was fixed before was players logging in while dead and still being dead; the fix for that is to detect that and re-set their HP.

2afad6a26c

i'm going to experiment w/ ways of detecting "dead but can still wander the world" and try to fix that.

re-opening this, as it is very much not fixed. what was fixed before was players logging in while dead and still being dead; the fix for that is to detect that and re-set their HP. https://gitea.your-land.de/your-land/yl_commons/commit/2afad6a26ced55179a25ea443be50a776866c79b i'm going to experiment w/ ways of detecting "dead but can still wander the world" and try to fix that.
flux reopened this issue 2022-10-08 17:32:41 +00:00
Member

noting that the upstream bug w/ the client is still wide open.

noting that the upstream bug w/ the client is still wide open.
Member

wrote some callbacks to re-kill the player again if they try to do anything while dead:

d42f94f1d9

made sure to not punish them xp-wise if they end up in this state.

wrote some callbacks to re-kill the player again if they try to do anything while dead: https://gitea.your-land.de/your-land/yl_commons/commit/d42f94f1d9d6afe0aedcba31e4b35243be6017c6 made sure to not punish them xp-wise if they end up in this state.
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2022-10-08 19:19:34 +00:00
AliasAlreadyTaken was assigned by flux 2022-10-08 19:19:38 +00:00
Member

so, upstream pointed out that it's trivial to reproduce this. die, and get shown any formspec. new formspecs always pre-empt old ones.

so, upstream pointed out that it's trivial to reproduce this. die, and get shown *any* formspec. new formspecs always pre-empt old ones.
flux added
4. step/partially fixed
and removed
4. step/ready to QA test
labels 2022-11-13 15:52:39 +00:00
Member

the mitigation is live, though it's still easy to get into a bugged state if you know how.

the mitigation is live, though it's still easy to get into a bugged state if you know how.
Sign in to join this conversation.
No Milestone
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#478
No description provided.