daydream reports: is it possibly the tapestries ... #4606

New Issue

yourland-report · 2023-05-26T18:15:14Z

yourland-report commented

2023-05-26 18:15:14 +00:00

daydream reports a bug:

is it possibly the tapestries could be fixed so they don't bleed thru whatever is over top of them?

Player position:

{
	z = -9774.3759765625,
	x = -7633.1079101563,
	y = 8
}

Player look:

{
	z = 0.72549360990524,
	x = -0.50780719518661,
	y = -0.46453297138214
}

Player information:

{
	major = 5,
	ip_version = 6,
	min_rtt = 0.16400000452995,
	avg_rtt = 0.17800000309944,
	min_jitter = 0,
	max_jitter = 4.3709998130798,
	avg_jitter = 0.0050000101327896,
	connection_uptime = 115769,
	serialization_version = 29,
	patch = 0,
	minor = 7,
	lang_code = "",
	version_string = "5.7.0",
	formspec_version = 6,
	max_rtt = 4.5390000343323,
	state = "Active",
	protocol_version = 41
}

Player meta:

{
	fields = {
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_clan_idx"] = "1",
		played_time = "22247202",
		digged_nodes = "1849168",
		placed_nodes = "301987",
		died = "292",
		crafted = "24400",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		yl_commons_thankyou = "425",
		jointime = "1650064821",
		bitten = "0",
		punch_count = "279480",
		inflicted_damage = "3754268",
		yl_church = "return {[\"last_death_portal\"] = 1684776834, [\"last_death\"] = {[\"z\"] = 1546, [\"x\"] = 2099, [\"y\"] = 7}, [\"last_heal\"] = 1673944229}",
		["stamina:level"] = "18",
		repellant = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "139.5",
		["signslib:pos"] = "(1952,-2756,1522)",
		xp_redo_hud_color = "0xFFC001",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 460\", \"shields:shield_rainbow 1 184\", \"3d_armor:chestplate_nether 1 920\", \"3d_armor:leggings_nether 1 920\", \"3d_armor:boots_crystal 1 460\", \"\"}",
		["ocean_build.last_warning"] = "1.65235e+09",
		["petz:werewolf"] = "0",
		["ocean_build.ocean_built"] = "8",
		["petz:lycanthropy"] = "0",
		hud_state = "on",
		["petz:werewolf_vignette_id"] = "19",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		yl_commons_player_joined = "1685009175",
		partychat = "party",
		yl_commons_player_created = "1650064821",
		xp = "1696430"
	}
}

Log identifier


[MOD] yl_report log identifier = pFOGQJj7iTwwaQJXcuQKXt3EIROoPrAp

Profiler save:

profile-20230526T181514.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 4d 11min 27s | max lag: 0.546s | clients (27/52): AliasAlreadyTaken, Aliza, annah, Bailiff, Bishiro, daydream, der_c_aus_a, Diaeresis, Dirac, drgn, flux, ivyy, labrat, laira, Laurii, Laylem, mahou, Naan, Papi, popefox20, Qualia, Ravise, Service, shanish2, smith1, Stelio, Sysmatic

Teleport command:

/teleport xyz -7633 8 -9774

Compass command:

/give_compass Construction pFOGQJj7iTwwaQJXcuQKXt3EIROoPrAp D2691E -7633 8 -9774

daydream reports a bug: > is it possibly the tapestries could be fixed so they don't bleed thru whatever is over top of them? Player position: ``` { z = -9774.3759765625, x = -7633.1079101563, y = 8 } ``` Player look: ``` { z = 0.72549360990524, x = -0.50780719518661, y = -0.46453297138214 } ``` Player information: ``` { major = 5, ip_version = 6, min_rtt = 0.16400000452995, avg_rtt = 0.17800000309944, min_jitter = 0, max_jitter = 4.3709998130798, avg_jitter = 0.0050000101327896, connection_uptime = 115769, serialization_version = 29, patch = 0, minor = 7, lang_code = "", version_string = "5.7.0", formspec_version = 6, max_rtt = 4.5390000343323, state = "Active", protocol_version = 41 } ``` Player meta: ``` { fields = { arenalib_infobox_arenaID = "0", ["petz:werewolf_clan_idx"] = "1", played_time = "22247202", digged_nodes = "1849168", placed_nodes = "301987", died = "292", crafted = "24400", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", yl_commons_thankyou = "425", jointime = "1650064821", bitten = "0", punch_count = "279480", inflicted_damage = "3754268", yl_church = "return {[\"last_death_portal\"] = 1684776834, [\"last_death\"] = {[\"z\"] = 1546, [\"x\"] = 2099, [\"y\"] = 7}, [\"last_heal\"] = 1673944229}", ["stamina:level"] = "18", repellant = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "139.5", ["signslib:pos"] = "(1952,-2756,1522)", xp_redo_hud_color = "0xFFC001", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 460\", \"shields:shield_rainbow 1 184\", \"3d_armor:chestplate_nether 1 920\", \"3d_armor:leggings_nether 1 920\", \"3d_armor:boots_crystal 1 460\", \"\"}", ["ocean_build.last_warning"] = "1.65235e+09", ["petz:werewolf"] = "0", ["ocean_build.ocean_built"] = "8", ["petz:lycanthropy"] = "0", hud_state = "on", ["petz:werewolf_vignette_id"] = "19", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", yl_commons_player_joined = "1685009175", partychat = "party", yl_commons_player_created = "1650064821", xp = "1696430" } } ``` Log identifier ``` [MOD] yl_report log identifier = pFOGQJj7iTwwaQJXcuQKXt3EIROoPrAp ``` Profiler save: ``` profile-20230526T181514.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 4d 11min 27s | max lag: 0.546s | clients (27/52): AliasAlreadyTaken, Aliza, annah, Bailiff, Bishiro, daydream, der_c_aus_a, Diaeresis, Dirac, drgn, flux, ivyy, labrat, laira, Laurii, Laylem, mahou, Naan, Papi, popefox20, Qualia, Ravise, Service, shanish2, smith1, Stelio, Sysmatic ``` Teleport command: ``` /teleport xyz -7633 8 -9774 ``` Compass command: ``` /give_compass Construction pFOGQJj7iTwwaQJXcuQKXt3EIROoPrAp D2691E -7633 8 -9774 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-05-26 18:15:14 +00:00

flux added the

4. step/question

label 2023-05-26 18:56:24 +00:00

flux commented

2023-05-26 18:56:59 +00:00

how do they bleed through? they seem to not extend past the top of the upper node they occupy?

how do they bleed through? they seem to not extend past the top of the upper node they occupy? ![image](/attachments/8071597e-f6f5-416d-96f6-348f22921101)

image.png

74 KiB

daydream commented

2023-05-28 01:08:28 +00:00

the same white curtains are placed downstairs as what you see upstairs and I had to cover up all the places because the bleeding 'jumps around' as you move around so it's pretty distracting.

screenshot_20230527_180608.png

293 KiB

screenshot_20230527_180547.png

222 KiB

screenshot_20230527_180624.png

124 KiB

whosit commented

2023-05-28 07:14:47 +00:00

This looks like z-fighting and could be fixed by moving model's top vertices just a tiniest bit lower.

whosit commented

2023-05-28 09:12:18 +00:00

I used this script:

# usage: python ./script output_dir files*

import re


def process_mesh(infile, outfile):
    # 0.999 fixes fighting for closer distances. 0.9999 does not.
    # 0.995 has seams visible when placing tapestries side by side
    scale = 0.999
    x_scale = scale
    y_scale = scale
    z_scale = scale
    with open(infile, 'r') as source:
        with open(outfile, 'w') as target:
            for line in source:
                target_line = line

                # print('-', target_line, end='')
                if (line.startswith('v ')):
                    coordinates = [float(coordinate) for coordinate in re.findall(r'\S+', line)[1:]]
                    rescaled = [c*s for c, s in zip(coordinates, [x_scale, y_scale, z_scale])]
                    rescaled_as_str = " ".join(["{:9.6f}".format(c) for c in rescaled])
                    target_line = f'v {rescaled_as_str}\n'

                # print('+', target_line, end='')
                target.write(target_line)


if __name__ == "__main__":
    import sys
    import os
    output_dir = sys.argv[1]
    for filename in sys.argv[2:]:
        out_name = os.path.join(output_dir, os.path.basename(filename))
        print(filename, '->', out_name)
        process_mesh(filename, out_name)

Scaling tapestry models by 0.999 seems to fix z-fighting at closer distances, while still keeping the seams between placed tapestries mostly unnoticable. Making it disappear at larger distances will make seams more visible. Kinda annoying :\

(also, can't scale only Y, since will poke on the sides too).

Should I push changed files to castle_tapestries/yl_stable?

I used this script: ```python # usage: python ./script output_dir files* import re def process_mesh(infile, outfile): # 0.999 fixes fighting for closer distances. 0.9999 does not. # 0.995 has seams visible when placing tapestries side by side scale = 0.999 x_scale = scale y_scale = scale z_scale = scale with open(infile, 'r') as source: with open(outfile, 'w') as target: for line in source: target_line = line # print('-', target_line, end='') if (line.startswith('v ')): coordinates = [float(coordinate) for coordinate in re.findall(r'\S+', line)[1:]] rescaled = [c*s for c, s in zip(coordinates, [x_scale, y_scale, z_scale])] rescaled_as_str = " ".join(["{:9.6f}".format(c) for c in rescaled]) target_line = f'v {rescaled_as_str}\n' # print('+', target_line, end='') target.write(target_line) if __name__ == "__main__": import sys import os output_dir = sys.argv[1] for filename in sys.argv[2:]: out_name = os.path.join(output_dir, os.path.basename(filename)) print(filename, '->', out_name) process_mesh(filename, out_name) ``` Scaling tapestry models by 0.999 seems to fix z-fighting at closer distances, while still keeping the seams between placed tapestries mostly unnoticable. Making it disappear at larger distances will make seams more visible. Kinda annoying :\ (also, can't scale only Y, since will poke on the sides too). Should I push changed files to castle_tapestries/yl_stable?

flux commented

2023-05-30 17:51:36 +00:00

![image](/attachments/20f03998-746f-4293-be1b-bb4cc6b962b8)

image.png

108 KiB

flux commented

2023-05-30 17:54:44 +00:00

IMO the best solution to this would be to create a new "short" tapestry for this use case:

IMO the best solution to this would be to create a new "short" tapestry for this use case: ![image](/attachments/fbfb23b5-fd1a-4f34-ae85-9d9d4e431938)

image.png

89 KiB

👍 3

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-05-31 03:16:00 +00:00

Sign in to join this conversation.