AliasAlreadyTaken reports: public chests log taking and p ... #4576

New Issue

yourland-report · 2023-05-22T21:17:24Z

yourland-report commented

2023-05-22 21:17:24 +00:00

AliasAlreadyTaken reports a bug:

public chests log taking and plcing of the itemstring, but not the amount

Player position:

{
	z = 2889,
	x = 2968,
	y = 91.121994018555
}

Player look:

{
	z = 0.53915947675705,
	x = -0.49008136987686,
	y = -0.68492865562439
}

Player information:

{
	major = 5,
	ip_version = 6,
	min_rtt = 0.017000000923872,
	avg_rtt = 0.018999999389052,
	min_jitter = 0,
	minor = 8,
	avg_jitter = 0.0070000011473894,
	connection_uptime = 4910,
	serialization_version = 29,
	patch = 0,
	lang_code = "de",
	version_string = "5.8.0-yl_dev-180ec92ef",
	formspec_version = 6,
	max_rtt = 0.22499999403954,
	state = "Active",
	max_jitter = 0.20600000023842,
	protocol_version = 41
}

Player meta:

{
	fields = {
		["petz:werewolf_clan_idx"] = "4",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "19",
		played_time = "81408329",
		digged_nodes = "139924",
		["arena_lib_editor.spawner_ID"] = "0",
		szutil_watch = "return {}",
		crafted = "4776",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_commons_thankyou = "1008",
		["arena_lib_editor.players_number"] = "0",
		bitten = "0",
		lagometer = "1",
		inflicted_damage = "2869852",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 6583, [\"y\"] = -25, [\"z\"] = 10329}, [\"last_heal\"] = 1683837139, [\"last_death_portal\"] = 1683839371}",
		["stamina:level"] = "0",
		repellant = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "69.5",
		["signslib:pos"] = "(2570,44,436)",
		xp_redo_hud_color = "0xFFFF00",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		["ocean_build.last_warning"] = "1.67421e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["petz:lycanthropy"] = "0",
		xp = "0",
		["arena_lib_editor.team_ID"] = "0",
		arenalib_watchID = "0",
		hud_state = "on",
		partychat = "party",
		died = "1586",
		punch_count = "63837",
		placed_nodes = "180360",
		["petz:werewolf"] = "0",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		yl_commons_player_joined = "1684785341",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		team = "STAFF"
	}
}

Log identifier


[MOD] yl_report log identifier = STi8WmOfd6vRuqHHB45SJBn1TqlGu2Rx

Profiler save:

profile-20230522T211724.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1h 23min 31s | max lag: 0.264s | clients (27/52): AliasAlreadyTaken, Aliza, Bailiff, bizon, BobaCat, Boot, Chache, daydream, der_c_aus_a, Diaeresis, JeCel, Kadax, Laylem, mahou, Medoo, MineWorlds, Nodes, Nomtom, Oakenshield, Sandra, Sense, Service, shanish2, Sokomine, Sysmatic, Therottenpotato, whosit

Teleport command:

/teleport xyz 2968 91 2889

Compass command:

/give_compass Construction STi8WmOfd6vRuqHHB45SJBn1TqlGu2Rx D2691E 2968 91 2889

AliasAlreadyTaken reports a bug: > public chests log taking and plcing of the itemstring, but not the amount Player position: ``` { z = 2889, x = 2968, y = 91.121994018555 } ``` Player look: ``` { z = 0.53915947675705, x = -0.49008136987686, y = -0.68492865562439 } ``` Player information: ``` { major = 5, ip_version = 6, min_rtt = 0.017000000923872, avg_rtt = 0.018999999389052, min_jitter = 0, minor = 8, avg_jitter = 0.0070000011473894, connection_uptime = 4910, serialization_version = 29, patch = 0, lang_code = "de", version_string = "5.8.0-yl_dev-180ec92ef", formspec_version = 6, max_rtt = 0.22499999403954, state = "Active", max_jitter = 0.20600000023842, protocol_version = 41 } ``` Player meta: ``` { fields = { ["petz:werewolf_clan_idx"] = "4", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "19", played_time = "81408329", digged_nodes = "139924", ["arena_lib_editor.spawner_ID"] = "0", szutil_watch = "return {}", crafted = "4776", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_commons_thankyou = "1008", ["arena_lib_editor.players_number"] = "0", bitten = "0", lagometer = "1", inflicted_damage = "2869852", yl_church = "return {[\"last_death\"] = {[\"x\"] = 6583, [\"y\"] = -25, [\"z\"] = 10329}, [\"last_heal\"] = 1683837139, [\"last_death_portal\"] = 1683839371}", ["stamina:level"] = "0", repellant = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "69.5", ["signslib:pos"] = "(2570,44,436)", xp_redo_hud_color = "0xFFFF00", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", ["ocean_build.last_warning"] = "1.67421e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["petz:lycanthropy"] = "0", xp = "0", ["arena_lib_editor.team_ID"] = "0", arenalib_watchID = "0", hud_state = "on", partychat = "party", died = "1586", punch_count = "63837", placed_nodes = "180360", ["petz:werewolf"] = "0", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", yl_commons_player_joined = "1684785341", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", team = "STAFF" } } ``` Log identifier ``` [MOD] yl_report log identifier = STi8WmOfd6vRuqHHB45SJBn1TqlGu2Rx ``` Profiler save: ``` profile-20230522T211724.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1h 23min 31s | max lag: 0.264s | clients (27/52): AliasAlreadyTaken, Aliza, Bailiff, bizon, BobaCat, Boot, Chache, daydream, der_c_aus_a, Diaeresis, JeCel, Kadax, Laylem, mahou, Medoo, MineWorlds, Nodes, Nomtom, Oakenshield, Sandra, Sense, Service, shanish2, Sokomine, Sysmatic, Therottenpotato, whosit ``` Teleport command: ``` /teleport xyz 2968 91 2889 ``` Compass command: ``` /give_compass Construction STi8WmOfd6vRuqHHB45SJBn1TqlGu2Rx D2691E 2968 91 2889 ```

AliasAlreadyTaken was assigned by yourland-report

2023-05-22 21:17:24 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-05-22 22:00:05 +00:00

flux commented

2023-05-23 18:09:06 +00:00

<ACTION> 2023-05-23 11:05:33: [Server] flux moves cucina_vegana:flax_roasted to chest at (-140,21,347)
<ACTION> 2023-05-23 11:05:33: [Server] [yl_commons] flux takes "cucina_vegana:flax_roasted 97" from {"name":"flux","type":"player"} [main]
<ACTION> 2023-05-23 11:05:34: [Server] [yl_commons] flux moves "cucina_vegana:flax_roasted 97" to {"name":"flux","type":"player"} [main]
<ACTION> 2023-05-23 11:05:34: [Server] flux takes cucina_vegana:flax_roasted from chest at (-140,21,347)

the code which is supposed to be getting run for inventory logging is https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/features/inventory_logging.lua#L28-L53. and debug.getinfo(minetest.registered_nodes["default:chest"].on_metadata_inventory_put) seems asserts that that's what should be getting run...

i'm not actually sure where the flux moves cucina_vegana:flax_roasted to chest at (-140,21,347) message is coming from, MTG doesn't emit that...

``` <ACTION> 2023-05-23 11:05:33: [Server] flux moves cucina_vegana:flax_roasted to chest at (-140,21,347) <ACTION> 2023-05-23 11:05:33: [Server] [yl_commons] flux takes "cucina_vegana:flax_roasted 97" from {"name":"flux","type":"player"} [main] <ACTION> 2023-05-23 11:05:34: [Server] [yl_commons] flux moves "cucina_vegana:flax_roasted 97" to {"name":"flux","type":"player"} [main] <ACTION> 2023-05-23 11:05:34: [Server] flux takes cucina_vegana:flax_roasted from chest at (-140,21,347) ``` the code which is *supposed* to be getting run for inventory logging is https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/features/inventory_logging.lua#L28-L53. and `debug.getinfo(minetest.registered_nodes["default:chest"].on_metadata_inventory_put)` seems asserts that that's what should be getting run... i'm not actually sure where the `flux moves cucina_vegana:flax_roasted to chest at (-140,21,347)` message is coming from, MTG doesn't emit that...

AliasAlreadyTaken commented

2023-05-23 18:20:54 +00:00

The logging YOU added saved the day in this case, but somehow the chests themselves should as well.

I was fairly certain it comes from MTG. Does anyone overwrite default chests? Maybe pipeworks, so they can add those funny black squares?

The logging YOU added saved the day in this case, but somehow the chests themselves should as well. I was fairly certain it comes from MTG. Does anyone overwrite default chests? Maybe pipeworks, so they can add those funny black squares?

flux added the

4. step/ready to QA test

label 2023-05-23 18:32:00 +00:00

flux commented

2023-05-23 18:33:22 +00:00

i figured it out. open chests. i'm still not sure where the spurious log messages are coming from, but that's not a big deal.

fixed that, and a few other similarly overlooked node variants w/ inventory: 158e60905b

i figured it out. *open chests*. i'm still not sure where the spurious log messages are coming from, but that's not a big deal. fixed that, and a few other similarly overlooked node variants w/ inventory: https://gitea.your-land.de/your-land/yl_commons/commit/158e60905b15eed5e4dc6942e58f920e4b016473

whosit commented

2023-05-23 18:36:53 +00:00

Could it be the ugh mod?
90020b0f2f/petz/misc/chests.lua (L152)
notice the to chest at

Could it be the ugh mod? https://gitea.your-land.de/your-land/petz/src/commit/90020b0f2f31fd311d5390fbd4fb57cd369314ef/petz/misc/chests.lua#L152 notice the `to chest at`

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-05-23 18:57:43 +00:00

flux commented

2023-05-23 23:31:20 +00:00

Could it be the ugh mod?
90020b0f2f/petz/misc/chests.lua (L152)
notice the to chest at

i noticed that too, and put in [petz] tags for those messages. regular chests were not being over-ridden by petz somehow, i have no idea where it's coming from.

> Could it be the ugh mod? > https://gitea.your-land.de/your-land/petz/src/commit/90020b0f2f31fd311d5390fbd4fb57cd369314ef/petz/misc/chests.lua#L152 > notice the `to chest at` i noticed that too, and put in `[petz]` tags for those messages. regular chests were *not* being over-ridden by petz somehow, i have no idea where it's coming from.

AliasAlreadyTaken commented

2023-05-23 23:38:22 +00:00

Wild.

flux commented

2023-05-24 00:20:04 +00:00

oh wait nevermind i found the source 9a9df3a42e/mods/default/functions.lua (L747-L758)

oh wait nevermind i found the source https://github.com/minetest/minetest_game/blob/9a9df3a42efe8749ca470b09f41632902e654967/mods/default/functions.lua#L747-L758

AliasAlreadyTaken commented

2023-08-26 07:23:36 +00:00

QA: This is not in the 1.1.120 update, we update MTG only with a new engine version. Should we have a "Minetest 5.8.0 milestone" as well?

👍 1

AliasAlreadyTaken removed this from the 1.1.120 milestone 2023-08-26 07:23:49 +00:00

flux added this to the minetest 5.8.0 milestone 2024-03-30 00:16:08 +00:00

flux commented

2024-03-30 00:16:30 +00:00

i created a minetest 5.8.0 milestone and added this there.

👍 1

Sign in to join this conversation.