Mail client lag #4548

New Issue

AliasAlreadyTaken · 2023-05-19T15:15:15Z

AliasAlreadyTaken commented

2023-05-19 15:15:15 +00:00

mail:                                                   |         0 |  88822153 |      2136 |   0.0 |  99.7 |   0.0
  - on_player_receive_fields[2] .......................  |         1 |  88821998 |    113247 |   0.0 |  99.7 |   1.4
  - on_player_receive_fields[3] .......................  |         1 |        27 |         1 |   0.0 |   0.1 |   0.0
  - on_player_receive_fields[7] .......................  |         1 |        17 |         1 |   0.0 |   0.1 |   0.0
  - /mail .............................................  |      1456 |     30527 |     12501 |   0.7 |  66.4 |  31.7
  - on_player_receive_fields[10] ......................  |         1 |        54 |         1 |   0.0 |   0.2 |   0.0
  - on_player_receive_fields[8] .......................  |         1 |     15021 |        31 |   0.0 |  48.6 |   0.1
  - on_joinplayer[2] ..................................  |         1 |        39 |         2 |   0.0 |   0.0 |   0.0
  - on_joinplayer[1] ..................................  |         5 |        37 |         9 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[9] .......................  |         1 |        21 |         1 |   0.0 |   0.1 |   0.0
  - on_player_receive_fields[6] .......................  |         1 |        84 |         1 |   0.0 |   0.2 |   0.0
  - on_leaveplayer[1] .................................  |         1 |        13 |         1 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[4] .......................  |         1 |        19 |         1 |   0.0 |   0.2 |   0.0
  - on_player_receive_fields[5] .......................  |         1 |        18 |         1 |   0.0 |   0.1 |   0.0
  - on_player_receive_fields[1] .......................  |         1 |   6834432 |     12750 |   0.0 |  98.0 |   0.4

``` mail: | 0 | 88822153 | 2136 | 0.0 | 99.7 | 0.0 - on_player_receive_fields[2] ....................... | 1 | 88821998 | 113247 | 0.0 | 99.7 | 1.4 - on_player_receive_fields[3] ....................... | 1 | 27 | 1 | 0.0 | 0.1 | 0.0 - on_player_receive_fields[7] ....................... | 1 | 17 | 1 | 0.0 | 0.1 | 0.0 - /mail ............................................. | 1456 | 30527 | 12501 | 0.7 | 66.4 | 31.7 - on_player_receive_fields[10] ...................... | 1 | 54 | 1 | 0.0 | 0.2 | 0.0 - on_player_receive_fields[8] ....................... | 1 | 15021 | 31 | 0.0 | 48.6 | 0.1 - on_joinplayer[2] .................................. | 1 | 39 | 2 | 0.0 | 0.0 | 0.0 - on_joinplayer[1] .................................. | 5 | 37 | 9 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[9] ....................... | 1 | 21 | 1 | 0.0 | 0.1 | 0.0 - on_player_receive_fields[6] ....................... | 1 | 84 | 1 | 0.0 | 0.2 | 0.0 - on_leaveplayer[1] ................................. | 1 | 13 | 1 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[4] ....................... | 1 | 19 | 1 | 0.0 | 0.2 | 0.0 - on_player_receive_fields[5] ....................... | 1 | 18 | 1 | 0.0 | 0.1 | 0.0 - on_player_receive_fields[1] ....................... | 1 | 6834432 | 12750 | 0.0 | 98.0 | 0.4 ```

flux commented

2023-05-20 01:32:45 +00:00

the profiler really needs to give more info than on_player_receive_fields[1]. lua has enough introspection to pull out a filename, line number, and possibly a function name.

the profiler *really* needs to give more info than `on_player_receive_fields[1]`. lua has enough introspection to pull out a filename, line number, and possibly a function name.

AliasAlreadyTaken added the

3. source/lag

1. kind/bug

labels 2023-05-20 08:20:17 +00:00

whosit commented

2023-05-20 08:57:42 +00:00

I remembered that you can use perf to profile lua, but info about it was almost impossible to google again, so I wrote this:
https://gitea.your-land.de/your-land/bugtracker/wiki/Lua-profiling
will maybe expand it later.

I remembered that you can use perf to profile lua, but info about it was almost impossible to google again, so I wrote this: https://gitea.your-land.de/your-land/bugtracker/wiki/Lua-profiling will maybe expand it later.

AliasAlreadyTaken commented

2023-06-04 06:51:55 +00:00

 mail:                          |         0 |   7427704 |    121664 |   0.0 |  99.2 |   3.0
  - on_player_receive_fields[8] |         1 |         1 |         1 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[4] |         1 |         1 |         1 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[1] |   7427700 |   7427700 |   7427700 |  99.2 |  99.2 |  99.2
  - on_player_receive_fields[7] |         1 |         1 |         1 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[6] |         1 |         1 |         1 |   0.0 |   0.0 |   0.0
  - on_player_receive_fields[2] |         1 |    115462 |     38488 |   0.0 |  87.3 |  29.1
  - on_player_receive_fields[5] |         1 |         1 |         1 |   0.0 |   0.0 |   0.0

``` mail: | 0 | 7427704 | 121664 | 0.0 | 99.2 | 3.0 - on_player_receive_fields[8] | 1 | 1 | 1 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[4] | 1 | 1 | 1 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[1] | 7427700 | 7427700 | 7427700 | 99.2 | 99.2 | 99.2 - on_player_receive_fields[7] | 1 | 1 | 1 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[6] | 1 | 1 | 1 | 0.0 | 0.0 | 0.0 - on_player_receive_fields[2] | 1 | 115462 | 38488 | 0.0 | 87.3 | 29.1 - on_player_receive_fields[5] | 1 | 1 | 1 | 0.0 | 0.0 | 0.0 ```

whosit commented

2023-06-04 07:06:23 +00:00

Should we try to make some fixes ourselves? I know a couple of quick ones I guess...
Like this thing:
#4531 (comment)

Should we try to make some fixes ourselves? I know a couple of quick ones I guess... Like this thing: https://gitea.your-land.de/your-land/bugtracker/issues/4531#issuecomment-52450

tour referenced this issue

2023-06-04 08:52:59 +00:00

mail crash #4640

AliasAlreadyTaken commented

2023-06-04 15:55:23 +00:00

Since many people use the mail mod, I'd rather have it fixed upstream - not only to avoid becoming a maintainer, but also to benefit all of minetest.

The mod is not abandoned so the chances your fixes are pulled pretty quick are high and I bet Athozus would be very happy if we helped with suggestions, fixes or PRs.

Even if we fixed for YL only, those fixes would have to go through QA and wait for the update to be delivered, so there's no advantage in time-to-game.

Since many people use the mail mod, I'd rather have it fixed upstream - not only to avoid becoming a maintainer, but also to benefit all of minetest. The mod is not abandoned so the chances your fixes are pulled pretty quick are high and I bet Athozus would be very happy if we helped with suggestions, fixes or PRs. Even if we fixed for YL only, those fixes would have to go through QA and wait for the update to be delivered, so there's no advantage in time-to-game.

whosit commented

2023-06-04 16:01:58 +00:00

Good news :D
the get_setting() got moved:
660d460af2

Good news :D the get_setting() got moved: https://github.com/mt-mods/mail/commit/660d460af20577f0a28ad4d106539f9349eefb22

Sign in to join this conversation.