Shadow reports: add coordinates to message whe ... #4543

New Issue

yourland-report · 2023-05-19T06:26:00Z

yourland-report commented

2023-05-19 06:26:00 +00:00

Shadow reports a bug:

add coordinates to message when removing from bones

Player position:

{
	x = -9000,
	y = -6734.4990234375,
	z = -9000
}

Player look:

{
	x = 0.016405398026109,
	y = -0.9998654127121,
	z = 2.865977876354e-06
}

Player information:

{
	lang_code = "",
	major = 5,
	minor = 7,
	version_string = "5.7.0",
	ip_version = 6,
	max_rtt = 7.7839999198914,
	avg_rtt = 0.1879999935627,
	formspec_version = 6,
	max_jitter = 7.5970001220703,
	avg_jitter = 0.020000010728836,
	connection_uptime = 4512,
	serialization_version = 29,
	patch = 0,
	protocol_version = 41,
	min_rtt = 0.17200000584126,
	min_jitter = 0,
	state = "Active"
}

Player meta:

{
	fields = {
		["stamina:level"] = "16",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "108.5",
		hud_state = "on",
		xp = "24687",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		arenalib_infobox_arenaID = "0",
		yl_commons_player_joined = "1684473060",
		played_time = "56311",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = -9000, [\"y\"] = -6733, [\"z\"] = -9000}, [\"last_death_portal\"] = 1684477434}",
		crafted = "303",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15825\", \"\", \"3d_armor:chestplate_crystal 1 10175\", \"\", \"3d_armor:leggings_crystal 1 10175\", \"3d_armor:boots_crystal 1 15825\"}",
		placed_nodes = "10913",
		died = "16",
		punch_count = "777",
		digged_nodes = "19359",
		inflicted_damage = "9968",
		jointime = "1629654263",
		bitten = "0",
		yl_commons_player_created = "1629654263"
	}
}

Log identifier


[MOD] yl_report log identifier = 8rWKNIC4juEcpM5Mj9LkiQ5aVnyDl2bE

Profiler save:

profile-20230519T062559.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10h 23min 8s | max lag: 0.429s | clients (18/52): AliasAlreadyTaken, Alinia, Aliza, Aniana, answer2, Aspide, Azelf, Bailiff, daydream, Ernesto, HorusDamocles, jaconer, Laylem, Murmel, niceride, Service, Shadow, tiger

Teleport command:

/teleport xyz -9000 -6734 -9000

Compass command:

/give_compass Construction 8rWKNIC4juEcpM5Mj9LkiQ5aVnyDl2bE D2691E -9000 -6734 -9000

Shadow reports a bug: > add coordinates to message when removing from bones Player position: ``` { x = -9000, y = -6734.4990234375, z = -9000 } ``` Player look: ``` { x = 0.016405398026109, y = -0.9998654127121, z = 2.865977876354e-06 } ``` Player information: ``` { lang_code = "", major = 5, minor = 7, version_string = "5.7.0", ip_version = 6, max_rtt = 7.7839999198914, avg_rtt = 0.1879999935627, formspec_version = 6, max_jitter = 7.5970001220703, avg_jitter = 0.020000010728836, connection_uptime = 4512, serialization_version = 29, patch = 0, protocol_version = 41, min_rtt = 0.17200000584126, min_jitter = 0, state = "Active" } ``` Player meta: ``` { fields = { ["stamina:level"] = "16", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "108.5", hud_state = "on", xp = "24687", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", arenalib_infobox_arenaID = "0", yl_commons_player_joined = "1684473060", played_time = "56311", yl_church = "return {[\"last_death\"] = {[\"x\"] = -9000, [\"y\"] = -6733, [\"z\"] = -9000}, [\"last_death_portal\"] = 1684477434}", crafted = "303", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15825\", \"\", \"3d_armor:chestplate_crystal 1 10175\", \"\", \"3d_armor:leggings_crystal 1 10175\", \"3d_armor:boots_crystal 1 15825\"}", placed_nodes = "10913", died = "16", punch_count = "777", digged_nodes = "19359", inflicted_damage = "9968", jointime = "1629654263", bitten = "0", yl_commons_player_created = "1629654263" } } ``` Log identifier ``` [MOD] yl_report log identifier = 8rWKNIC4juEcpM5Mj9LkiQ5aVnyDl2bE ``` Profiler save: ``` profile-20230519T062559.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10h 23min 8s | max lag: 0.429s | clients (18/52): AliasAlreadyTaken, Alinia, Aliza, Aniana, answer2, Aspide, Azelf, Bailiff, daydream, Ernesto, HorusDamocles, jaconer, Laylem, Murmel, niceride, Service, Shadow, tiger ``` Teleport command: ``` /teleport xyz -9000 -6734 -9000 ``` Compass command: ``` /give_compass Construction 8rWKNIC4juEcpM5Mj9LkiQ5aVnyDl2bE D2691E -9000 -6734 -9000 ```

AliasAlreadyTaken was assigned by yourland-report

2023-05-19 06:26:00 +00:00

niceride commented

2023-05-19 06:27:40 +00:00

[bones] you remove items from your bones should read
[bones] you remove items from your bones at (X,Y,Z)

```[bones] you remove items from your bones``` should read ```[bones] you remove items from your bones at (X,Y,Z)```

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-05-19 13:19:38 +00:00

flux commented

2023-05-19 14:48:09 +00:00

implemented bf0f8ce7da

implemented https://github.com/fluxionary/minetest-bones_redo/commit/bf0f8ce7da42269779d02869af91b3b0da2b6ed0

flux added the

4. step/ready to QA test

label 2023-05-19 14:48:23 +00:00

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-05-19 15:06:26 +00:00

AliasAlreadyTaken commented

2023-08-26 07:40:20 +00:00

QA Apparently not on the testserver?

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-08-26 07:40:35 +00:00

flux added this to the flux's TODO list project 2023-09-17 23:58:46 +00:00

flux removed this from the 1.1.120 milestone 2023-09-17 23:58:54 +00:00

flux commented

2023-09-18 00:00:37 +00:00

the fix is in the main branch on my github fork, but it's not in yl_stable on this gitea. the two branches seem to have diverged significantly somehow, though i'm having trouble figuring out how, given that my work is based off this one. my brain still seems to be pretty mushy, but i'll try to figure it out.