your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

Changes to prevent_sethome #4483

New Issue
Closed
opened 2023-05-13 14:35:02 +00:00 by AliasAlreadyTaken · 5 comments
AliasAlreadyTaken commented 2023-05-13 14:35:02 +00:00
Owner
Copy Link

  1. Even though it becomes a mouthful, we should use the "area" prefix: Let's make it /area_prevent_sethome or, if that seems too much to type maybe /area_no_sethome?

  2. Please let the command notify the user about success. It does notify on failure already.

1. Even though it becomes a mouthful, we should use the "area" prefix: Let's make it `/area_prevent_sethome` or, if that seems too much to type maybe `/area_no_sethome`? 2. Please let the command notify the user about success. It does notify on failure already.
👍 1
AliasAlreadyTaken added the
1. kind/bug
1. kind/enhancement
 labels 2023-05-13 14:35:13 +00:00
AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-13 14:35:16 +00:00
flux commented 2023-05-13 17:11:51 +00:00
Member
Copy Link

02a4d7be61

https://gitea.your-land.de/your-land/yl_areas_addon/commit/02a4d7be612d486a8f06b77908c170d195b603a0
flux added the
4. step/ready to QA test
 label 2023-05-13 17:12:01 +00:00
AliasAlreadyTaken commented 2023-05-14 17:32:22 +00:00
Author
Owner
Copy Link

Using /area_prevent_sethome I get this crash:

2023-05-14 17:31:45: ACTION[Main]: Server: Shutting down
2023-05-14 17:31:47: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): ...n/../mods/yl_areas_addon/chatcommand_prevent_sethome.lua:22: bad argument #2 to 'f' (value expected)
2023-05-14 17:31:47: ERROR[Main]: stack traceback:
2023-05-14 17:31:47: ERROR[Main]: 	[C]: in function 'f'
2023-05-14 17:31:47: ERROR[Main]: 	...n/../mods/yl_areas_addon/chatcommand_prevent_sethome.lua:22: in function 'func'
2023-05-14 17:31:47: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function 'func'
2023-05-14 17:31:47: ERROR[Main]: 	/home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:79: in function </home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:52>
2023-05-14 17:31:47: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:432: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:418>
Using `/area_prevent_sethome` I get this crash: ``` 2023-05-14 17:31:45: ACTION[Main]: Server: Shutting down 2023-05-14 17:31:47: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): ...n/../mods/yl_areas_addon/chatcommand_prevent_sethome.lua:22: bad argument #2 to 'f' (value expected) 2023-05-14 17:31:47: ERROR[Main]: stack traceback: 2023-05-14 17:31:47: ERROR[Main]: [C]: in function 'f' 2023-05-14 17:31:47: ERROR[Main]: ...n/../mods/yl_areas_addon/chatcommand_prevent_sethome.lua:22: in function 'func' 2023-05-14 17:31:47: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function 'func' 2023-05-14 17:31:47: ERROR[Main]: /home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:79: in function </home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:52> 2023-05-14 17:31:47: ERROR[Main]: .../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:432: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:418> ```
AliasAlreadyTaken removed the
4. step/ready to QA test
 label 2023-05-14 17:32:32 +00:00
AliasAlreadyTaken added the
4. step/ready to QA test
ugh/QA NOK
 labels 2023-05-14 17:33:41 +00:00
flux commented 2023-05-15 18:30:04 +00:00
Member
Copy Link

Using /area_prevent_sethome I get this crash:

fixed this and actually tested it this time: c913c1df32

> Using `/area_prevent_sethome` I get this crash: fixed this and actually tested it this time: https://gitea.your-land.de/your-land/yl_areas_addon/commit/c913c1df32a19dcb06a57648be0226f97b7cea82
😆 1
AliasAlreadyTaken commented 2023-05-15 21:30:31 +00:00
Author
Owner
Copy Link

QA

  1. Command is now named /area_prevent_sethome 👍

  2. Command notifies on failure 👍

  3. No more crashy 👍

QA 1. Command is now named `/area_prevent_sethome` 👍 2. Command notifies on failure 👍 3. No more crashy 👍
AliasAlreadyTaken added
ugh/QA OK
 and removed
ugh/QA NOK
 labels 2023-05-15 21:30:39 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-05-18 23:36:25 +00:00
flux commented 2023-05-18 23:36:30 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-05-18 23:36:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.119
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4483
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?