Boris reports: petz user.conf is in wrong dir ... #4443

New Issue

yourland-report · 2023-05-09T04:34:58Z

yourland-report commented

2023-05-09 04:34:58 +00:00

Boris reports a bug:

petz user.conf is in wrong directory

Player position:

{
	x = 2146.2661132813,
	y = 15.5,
	z = 1041.0889892578
}

Player look:

{
	x = 0.73003530502319,
	y = -0.30386680364609,
	z = 0.61213833093643
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.01799999922514,
	protocol_version = 41,
	min_jitter = 0,
	max_jitter = 0.23700001835823,
	avg_jitter = 0,
	connection_uptime = 853,
	serialization_version = 29,
	patch = 0,
	formspec_version = 6,
	major = 5,
	minor = 8,
	version_string = "5.8.0-yl_dev-bc4fc6d64",
	state = "Active",
	avg_rtt = 0.018999999389052,
	lang_code = "de",
	max_rtt = 0.25900000333786
}

Player meta:

{
	fields = {
		hud_state = "on",
		["stamina:exhaustion"] = "89.5",
		repellant = "0",
		bitten = "0",
		yl_commons_player_joined = "1683606057",
		["signslib:pos"] = "(1975,19,1178)",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_medium\", \"unified_inventory:bag_small\", \"unified_inventory:bag_large\"}",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 2159, [\"y\"] = 16, [\"z\"] = 1035}, [\"last_death_portal\"] = 1681780733}",
		yl_commons_thankyou = "1",
		arenalib_infobox_arenaID = "0",
		punch_count = "231",
		placed_nodes = "448",
		["ethereal:fly_timer"] = "-99",
		xp = "2227",
		played_time = "4733436",
		digged_nodes = "4204",
		partychat = "party",
		died = "145",
		crafted = "51",
		["stamina:level"] = "9",
		inflicted_damage = "3000",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = BLUnEOt1CHOUTR94obpye3jHOY4SpXl9

Profiler save:

profile-20230509T043458.json_prettyEE

Status:

# Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 6h 46min 56s | max lag: 0.0936s | clients (2/52): AliasAlreadyTaken, Boris

Teleport command:

/teleport xyz 2146 16 1041

Compass command:

/give_compass Construction BLUnEOt1CHOUTR94obpye3jHOY4SpXl9 D2691E 2146 16 1041

Boris reports a bug: > petz user.conf is in wrong directory Player position: ``` { x = 2146.2661132813, y = 15.5, z = 1041.0889892578 } ``` Player look: ``` { x = 0.73003530502319, y = -0.30386680364609, z = 0.61213833093643 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.01799999922514, protocol_version = 41, min_jitter = 0, max_jitter = 0.23700001835823, avg_jitter = 0, connection_uptime = 853, serialization_version = 29, patch = 0, formspec_version = 6, major = 5, minor = 8, version_string = "5.8.0-yl_dev-bc4fc6d64", state = "Active", avg_rtt = 0.018999999389052, lang_code = "de", max_rtt = 0.25900000333786 } ``` Player meta: ``` { fields = { hud_state = "on", ["stamina:exhaustion"] = "89.5", repellant = "0", bitten = "0", yl_commons_player_joined = "1683606057", ["signslib:pos"] = "(1975,19,1178)", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_medium\", \"unified_inventory:bag_small\", \"unified_inventory:bag_large\"}", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", yl_church = "return {[\"last_death\"] = {[\"x\"] = 2159, [\"y\"] = 16, [\"z\"] = 1035}, [\"last_death_portal\"] = 1681780733}", yl_commons_thankyou = "1", arenalib_infobox_arenaID = "0", punch_count = "231", placed_nodes = "448", ["ethereal:fly_timer"] = "-99", xp = "2227", played_time = "4733436", digged_nodes = "4204", partychat = "party", died = "145", crafted = "51", ["stamina:level"] = "9", inflicted_damage = "3000", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = BLUnEOt1CHOUTR94obpye3jHOY4SpXl9 ``` Profiler save: ``` profile-20230509T043458.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 6h 46min 56s | max lag: 0.0936s | clients (2/52): AliasAlreadyTaken, Boris ``` Teleport command: ``` /teleport xyz 2146 16 1041 ``` Compass command: ``` /give_compass Construction BLUnEOt1CHOUTR94obpye3jHOY4SpXl9 D2691E 2146 16 1041 ```

AliasAlreadyTaken was assigned by yourland-report

2023-05-09 04:34:58 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2023-05-09 06:40:20 +00:00

AliasAlreadyTaken commented

2023-05-09 07:22:20 +00:00

Fixed in a75e7cdb0d

Fixed in https://gitea.your-land.de/your-land/petz/commit/a75e7cdb0d708b85ea640a6da8b047ef6b382269

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-05-09 07:22:27 +00:00

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-09 07:22:31 +00:00

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-09 12:56:02 +00:00

AliasAlreadyTaken commented

2023-05-09 12:56:41 +00:00

QA

Now the values are used again, still I feel this file should be in the world folder instead of the mod itself.

QA Now the values are used again, still I feel this file should be in the world folder instead of the mod itself.

flux commented

2023-05-10 04:22:36 +00:00

does petz recognize it if it's in the world folder? that's 100% something i wish existed. moreso, i wish petz used minetest.conf instead of its own stuff. then again, namespace partitioning is nice, maybe there should be a builtin way to provide mod-specific configuration files which didn't require dirty repos

AliasAlreadyTaken commented

2023-05-10 04:43:44 +00:00

I like how linux services do it. There is a someprogram.conf that holds the package config and there's a conf.d folder where userconfig is read from.

Sure, we could cobble a small script together that could wrangle all configs from a directory into one big minetest.conf but still mods have to support that. petz does not: https://gitea.your-land.de/your-land/petz/src/branch/master/petz/settings.lua#L4

Let's request the user.conf be placed in the world folder: #4452

Let's discuss there whether it should be in minetest.conf or elsewhere

I like how linux services do it. There is a someprogram.conf that holds the package config and there's a conf.d folder where userconfig is read from. Sure, we could cobble a small script together that could wrangle all configs from a directory into one big minetest.conf but still mods have to support that. petz does not: https://gitea.your-land.de/your-land/petz/src/branch/master/petz/settings.lua#L4 Let's request the user.conf be placed in the world folder: #4452 Let's discuss there whether it should be in minetest.conf or elsewhere

AliasAlreadyTaken referenced this issue

2023-05-10 04:45:02 +00:00

Move petz config to world folder #4452

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-05-18 21:49:45 +00:00

AliasAlreadyTaken was unassigned by flux

2023-05-18 21:49:48 +00:00

flux commented

2023-05-18 21:50:11 +00:00