daydream reports: one of my lociked chests says ... #4304

New Issue

yourland-report · 2023-04-27T05:44:21Z

yourland-report commented

2023-04-27 05:44:21 +00:00

daydream reports a bug:

one of my lociked chests says (owned by daydream) and the other one just says locked chest - weird?

Player position:

{
	z = -9587.689453125,
	x = -7752.5595703125,
	y = 3.5
}

Player look:

{
	z = -0.43661025166512,
	x = -0.8715106844902,
	y = -0.22325012087822
}

Player information:

{
	lang_code = "",
	major = 5,
	state = "Active",
	version_string = "5.7.0",
	max_jitter = 3.6050000190735,
	ip_version = 6,
	minor = 7,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	max_rtt = 3.7760000228882,
	avg_jitter = 0.0020000040531158,
	connection_uptime = 19453,
	serialization_version = 29,
	patch = 0,
	protocol_version = 41,
	formspec_version = 6,
	min_rtt = 0.16500000655651
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "0",
		played_time = "20016755",
		digged_nodes = "1798643",
		placed_nodes = "279363",
		died = "274",
		crafted = "7096",
		hud_state = "on",
		xp_redo_hud_color = "0xFFC001",
		["stamina:level"] = "16",
		["ocean_build.last_warning"] = "1.65235e+09",
		["stamina:exhaustion"] = "50.5",
		arenalib_infobox_arenaID = "0",
		yl_unified_trash_review = "return {\"moretrees:beech_leaves 2\", \"mobs:fence_top 2\", \"moreblocks:slab_junglewood_2\", \"\"}",
		yl_commons_thankyou = "390",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1682554840",
		partychat = "party",
		xp = "1664613",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["signslib:pos"] = "(2646,56,-49)",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 888, [\"x\"] = 3242, [\"y\"] = 28}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1682546177}",
		["petz:werewolf_vignette_id"] = "19",
		jointime = "1650064821",
		bitten = "0",
		["petz:werewolf_clan_idx"] = "1",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 480\", \"shields:shield_rainbow 1 192\", \"3d_armor:chestplate_nether 1 960\", \"3d_armor:leggings_nether 1 960\", \"3d_armor:boots_crystal 1 480\", \"\"}",
		repellant = "0",
		["ocean_build.ocean_built"] = "8",
		punch_count = "224895",
		["stamina:poisoned"] = "no",
		inflicted_damage = "3248898",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}"
	}
}

Log identifier


[MOD] yl_report log identifier = 8UlqTUqou8ldxsT6EdkIYMWGInD3Pe4T

Profiler save:

profile-20230427T054421.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 9h 50min 41s | max lag: 0.229s | clients (12/52): 9T9, AliasAlreadyTaken, Alinia, Anos, Bailiff, daydream, flux, HorusDamocles, MaxMax01, Penelopee, Service, Sysmatic

Teleport command:

/teleport xyz -7753 4 -9588

Compass command:

/give_compass Construction 8UlqTUqou8ldxsT6EdkIYMWGInD3Pe4T D2691E -7753 4 -9588

daydream reports a bug: > one of my lociked chests says (owned by daydream) and the other one just says locked chest - weird? Player position: ``` { z = -9587.689453125, x = -7752.5595703125, y = 3.5 } ``` Player look: ``` { z = -0.43661025166512, x = -0.8715106844902, y = -0.22325012087822 } ``` Player information: ``` { lang_code = "", major = 5, state = "Active", version_string = "5.7.0", max_jitter = 3.6050000190735, ip_version = 6, minor = 7, avg_rtt = 0.17499999701977, min_jitter = 0, max_rtt = 3.7760000228882, avg_jitter = 0.0020000040531158, connection_uptime = 19453, serialization_version = 29, patch = 0, protocol_version = 41, formspec_version = 6, min_rtt = 0.16500000655651 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "0", played_time = "20016755", digged_nodes = "1798643", placed_nodes = "279363", died = "274", crafted = "7096", hud_state = "on", xp_redo_hud_color = "0xFFC001", ["stamina:level"] = "16", ["ocean_build.last_warning"] = "1.65235e+09", ["stamina:exhaustion"] = "50.5", arenalib_infobox_arenaID = "0", yl_unified_trash_review = "return {\"moretrees:beech_leaves 2\", \"mobs:fence_top 2\", \"moreblocks:slab_junglewood_2\", \"\"}", yl_commons_thankyou = "390", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1682554840", partychat = "party", xp = "1664613", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["signslib:pos"] = "(2646,56,-49)", yl_church = "return {[\"last_death\"] = {[\"z\"] = 888, [\"x\"] = 3242, [\"y\"] = 28}, [\"last_heal\"] = 1673944229, [\"last_death_portal\"] = 1682546177}", ["petz:werewolf_vignette_id"] = "19", jointime = "1650064821", bitten = "0", ["petz:werewolf_clan_idx"] = "1", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 480\", \"shields:shield_rainbow 1 192\", \"3d_armor:chestplate_nether 1 960\", \"3d_armor:leggings_nether 1 960\", \"3d_armor:boots_crystal 1 480\", \"\"}", repellant = "0", ["ocean_build.ocean_built"] = "8", punch_count = "224895", ["stamina:poisoned"] = "no", inflicted_damage = "3248898", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}" } } ``` Log identifier ``` [MOD] yl_report log identifier = 8UlqTUqou8ldxsT6EdkIYMWGInD3Pe4T ``` Profiler save: ``` profile-20230427T054421.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 9h 50min 41s | max lag: 0.229s | clients (12/52): 9T9, AliasAlreadyTaken, Alinia, Anos, Bailiff, daydream, flux, HorusDamocles, MaxMax01, Penelopee, Service, Sysmatic ``` Teleport command: ``` /teleport xyz -7753 4 -9588 ``` Compass command: ``` /give_compass Construction 8UlqTUqou8ldxsT6EdkIYMWGInD3Pe4T D2691E -7753 4 -9588 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-27 05:44:21 +00:00

AliasAlreadyTaken added the

3. source/unknown

1. kind/bug

labels 2023-04-27 14:15:12 +00:00

flux commented

2023-04-29 17:03:44 +00:00

that indicates that the chest was "constructed" but not "placed"

1e237b8d18/mods/default/chests.lua (L93-L104)

this can be done by e.g. the following lua code:

minetest.set_node(pos, {name = "default:chest"})

i'm not sure how the chest ended up like that though, i don't think daydream was placing chests via lua. node replacement tools seem to properly initialize them.

one thing to beware, this probably means that the chest doesn't actually have an owner, and so is not actually locked - anyone will be able to use it.

@daydream what are the approximate coordinates of the chest, so i can take a look at it? there was nothing where the bug was reported.

that indicates that the chest was "constructed" but not "placed" https://github.com/minetest/minetest_game/blob/1e237b8d18da799593ad3a8253cdc5d8a7d772a9/mods/default/chests.lua#L93-L104 this can be done by e.g. the following lua code: ```lua minetest.set_node(pos, {name = "default:chest"}) ``` i'm not sure how the chest ended up like that though, i don't think daydream was placing chests via lua. node replacement tools seem to properly initialize them. one thing to beware, this probably means that the chest doesn't actually have an owner, and so is not actually locked - anyone will be able to use it. @daydream what are the approximate coordinates of the chest, so i can take a look at it? there was nothing where the bug was reported.

flux commented

2023-04-29 17:06:19 +00:00

hm, i found some of these weird chests, they do have an owner, so my previous theory isn't right...

hm, i found some of these weird chests, they *do* have an owner, so my previous theory isn't right... ![image](/attachments/571496ae-c9f2-4925-9c8b-f665619457e0)

image.png

10 KiB

AliasAlreadyTaken commented

2023-04-29 19:49:02 +00:00

The replacer goes around the usual "on_place" mecahnics, could this tool be responsible?

JeCel commented

2023-04-29 23:51:53 +00:00

This could have also been caused by the shared chest function which let's you change the chest type on left click on a chest while wielding a shared chest. At least in the past this used to cause shared chests created through this way to not have the "owned by..." part in the infotext.

EDIT: cf. #3287

This could have also been caused by the shared chest function which let's you change the chest type on left click on a chest while wielding a shared chest. At least in the past this used to cause shared chests created through this way to not have the "owned by..." part in the infotext. EDIT: cf. #3287

AliasAlreadyTaken added

4. step/needs confirmation

and removed

3. source/unknown

labels 2023-04-30 01:45:47 +00:00

flux commented

2023-04-30 16:35:09 +00:00

The replacer goes around the usual "on_place" mecahnics, could this tool be responsible?

i tested that, and it doesn't seem to be responsible. JeCel's explanation sounds plausible.

> The replacer goes around the usual "on_place" mecahnics, could this tool be responsible? i tested that, and it doesn't seem to be responsible. JeCel's explanation sounds plausible.

flux commented

2023-04-30 16:37:44 +00:00

yeah that's exactly the issue. steps to re-create:

place an default unlocked chest
use the chesttools shared chest to transform it into a locked chest

yeah that's exactly the issue. steps to re-create: 1. place an default unlocked chest 2. use the chesttools shared chest to transform it into a locked chest 3. ![image](/attachments/2e47cd05-6b55-4373-baff-bdf724523794)

image.png

9.2 KiB

flux added

3. source/mod upstream

and removed

4. step/needs confirmation

labels 2023-04-30 16:38:09 +00:00

Sign in to join this conversation.