sixer reports: major flaw in new woodcutting: ... #4277

New Issue

yourland-report · 2023-04-25T20:41:29Z

yourland-report commented

2023-04-25 20:41:29 +00:00

sixer reports a bug:

major flaw in new woodcutting: it is activated by default and if you don't press sneak fast enough, it will chop down whole tree. Very annoying if you wantr just to cut one small branch for a path, extremely annoying if you build a wooden structure (like custom/bigger tree) out of tree parts and want to make just small adjustment to it (gets destroyed)

Player position:

{
	x = -6867.19921875,
	y = 5.5,
	z = 2464.6650390625
}

Player look:

{
	x = 0.99962681531906,
	y = 0.010297260247171,
	z = -0.025303438305855
}

Player information:

{
	major = 5,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.021999999880791,
	avg_rtt = 0.021999999880791,
	min_jitter = 0,
	max_jitter = 0.16899999976158,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 382,
	max_rtt = 0.20100000500679,
	patch = 1,
	formspec_version = 6,
	version_string = "5.6.1",
	protocol_version = 41,
	lang_code = "",
	minor = 6,
	serialization_version = 29
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "90",
		yl_commons_player_created = "1678554780",
		yl_commons_player_joined = "1682454916",
		played_time = "472404",
		xp_redo_hud_color = "0x0088FF",
		placed_nodes = "36700",
		died = "23",
		repellant = "0",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		arenalib_infobox_arenaID = "0",
		bitten = "0",
		punch_count = "6137",
		yl_commons_thankyou = "2",
		inflicted_damage = "120770",
		hud_state = "on",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp = "102884",
		jointime = "1678554780",
		digged_nodes = "88690",
		["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 3360\", \"3d_armor:boots_crystal 1 8400\", \"3d_armor:helmet_crystal 1 8400\", \"3d_armor:chestplate_crystal 1 8400\", \"3d_armor:leggings_crystal 1 8400\", \"\"}",
		yl_church = "return {[\"last_death_portal\"] = 1682369139, [\"last_heal\"] = 1681095067, [\"last_death\"] = {[\"x\"] = 2507, [\"y\"] = -4784, [\"z\"] = 4481}}",
		["signslib:pos"] = "(2939,76,4179)",
		crafted = "1996",
		["stamina:level"] = "14",
		["ocean_build.last_warning"] = "1.68125e+09"
	}
}

Log identifier


[MOD] yl_report log identifier = TSwkZ7eQX23YetGZdiao8ZOGUXDHmCO6

Profiler save:

profile-20230425T204129.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 8h 50min 35s | max lag: 0.783s | clients (33/52): Aspide, Bailiff, Boot, Chache, Chameleon, Chazz, daydream, der_c_aus_a, Dirac, drgn, Duximagnus, Elias, fellow, flux, itaca94, JeCel, Julia, Kadax, Kaline, kobra123456789, laira, Laurii, Lupercus, mahou, MineWorlds, Parrish, Prismatim, rewired_X, rheo, Sandra, shanish3, sixer, Vegeta

Teleport command:

/teleport xyz -6867 6 2465

Compass command:

/give_compass Construction TSwkZ7eQX23YetGZdiao8ZOGUXDHmCO6 D2691E -6867 6 2465

sixer reports a bug: > major flaw in new woodcutting: it is activated by default and if you don't press sneak fast enough, it will chop down whole tree. Very annoying if you wantr just to cut one small branch for a path, extremely annoying if you build a wooden structure (like custom/bigger tree) out of tree parts and want to make just small adjustment to it (gets destroyed) Player position: ``` { x = -6867.19921875, y = 5.5, z = 2464.6650390625 } ``` Player look: ``` { x = 0.99962681531906, y = 0.010297260247171, z = -0.025303438305855 } ``` Player information: ``` { major = 5, state = "Active", ip_version = 6, min_rtt = 0.021999999880791, avg_rtt = 0.021999999880791, min_jitter = 0, max_jitter = 0.16899999976158, avg_jitter = 0.0010000001639128, connection_uptime = 382, max_rtt = 0.20100000500679, patch = 1, formspec_version = 6, version_string = "5.6.1", protocol_version = 41, lang_code = "", minor = 6, serialization_version = 29 } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "90", yl_commons_player_created = "1678554780", yl_commons_player_joined = "1682454916", played_time = "472404", xp_redo_hud_color = "0x0088FF", placed_nodes = "36700", died = "23", repellant = "0", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", arenalib_infobox_arenaID = "0", bitten = "0", punch_count = "6137", yl_commons_thankyou = "2", inflicted_damage = "120770", hud_state = "on", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp = "102884", jointime = "1678554780", digged_nodes = "88690", ["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 3360\", \"3d_armor:boots_crystal 1 8400\", \"3d_armor:helmet_crystal 1 8400\", \"3d_armor:chestplate_crystal 1 8400\", \"3d_armor:leggings_crystal 1 8400\", \"\"}", yl_church = "return {[\"last_death_portal\"] = 1682369139, [\"last_heal\"] = 1681095067, [\"last_death\"] = {[\"x\"] = 2507, [\"y\"] = -4784, [\"z\"] = 4481}}", ["signslib:pos"] = "(2939,76,4179)", crafted = "1996", ["stamina:level"] = "14", ["ocean_build.last_warning"] = "1.68125e+09" } } ``` Log identifier ``` [MOD] yl_report log identifier = TSwkZ7eQX23YetGZdiao8ZOGUXDHmCO6 ``` Profiler save: ``` profile-20230425T204129.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 8h 50min 35s | max lag: 0.783s | clients (33/52): Aspide, Bailiff, Boot, Chache, Chameleon, Chazz, daydream, der_c_aus_a, Dirac, drgn, Duximagnus, Elias, fellow, flux, itaca94, JeCel, Julia, Kadax, Kaline, kobra123456789, laira, Laurii, Lupercus, mahou, MineWorlds, Parrish, Prismatim, rewired_X, rheo, Sandra, shanish3, sixer, Vegeta ``` Teleport command: ``` /teleport xyz -6867 6 2465 ``` Compass command: ``` /give_compass Construction TSwkZ7eQX23YetGZdiao8ZOGUXDHmCO6 D2691E -6867 6 2465 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-25 20:41:29 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

3. source/mod upstream

labels 2023-04-26 02:48:18 +00:00

flux commented

2023-04-28 14:27:56 +00:00

"enabled by default" is intended. you can toggle this behavior w/ /toggle_choppy.

"enabled by default" is intended. you can toggle this behavior w/ `/toggle_choppy`.

niceride commented

2023-04-28 16:26:07 +00:00

"enabled by default" is intended. you can toggle this behavior w/ /toggle_choppy.

Too late now, but probably this should have been disabled by default for existing accounts.

> "enabled by default" is intended. you can toggle this behavior w/ `/toggle_choppy`. Too late now, but probably this should have been disabled by default for existing accounts.

flux commented

2023-04-30 03:41:58 +00:00

probably a better behavior would be to throw up a formspec when a player uses it for the first time, asking them whether they want it on by default, or off by default. but i'm terrible at formspecs.

AliasAlreadyTaken commented

2023-04-30 18:14:17 +00:00

Sounds like yl_settings could help with that, but the question remains: Should it be enabled or disabled by default?

Someone also suggested to start the chopping slower and then when no panic shift stopping happens it can increase speed.

Sounds like yl_settings could help with that, but the question remains: Should it be enabled or disabled by default? Someone also suggested to start the chopping slower and then when no panic shift stopping happens it can increase speed.

👍 1

JeCel commented

2023-04-30 19:19:00 +00:00

Disabled by default to avoid noobs (or anyone else who doesn't know about this mechanic yet) destroying beautiful landscapes accidently.

Agree with the speed increase thing.

Disabled by default to avoid noobs (or anyone else who doesn't know about this mechanic yet) destroying beautiful landscapes accidently. Agree with the speed increase thing.

Horus commented

2023-05-06 21:44:33 +00:00

am I missing something but theres no real way to disable it as the shift is just a toggle of how shift is used?/.

AliasAlreadyTaken commented

2023-05-06 21:50:23 +00:00

You can disable it with /toggle_choppy and you can stop it with shift.

You can disable it with `/toggle_choppy` and you can stop it with shift.

flux commented

2023-05-09 03:43:50 +00:00

it's mentioned elsewhere, but not here, that the purpose of having it on by default is to inform new players about the mechanic w/out them having to learn an esoteric command. i agree it is a problem for existing players who expect behavior to never change, but i didn't come up w/ a good solution before this was released. i think adding a formspec to ask players whether they want it on or off by default is a good compromise, i'll try to get around to doing that.

it's mentioned elsewhere, but not here, that the purpose of having it on by default is to inform new players about the mechanic w/out them having to learn an esoteric command. i agree it *is* a problem for existing players who expect behavior to never change, but i didn't come up w/ a good solution before this was released. i think adding a formspec to ask players whether they want it on or off by default is a good compromise, i'll try to get around to doing that.

flux added the

2. prio/elevated

label 2023-05-09 03:43:58 +00:00

flux added this to the flux's TODO list project 2023-05-09 03:44:02 +00:00

AliasAlreadyTaken commented

2023-05-09 07:14:59 +00:00

Sounds like an application for yl_settings to be honest. As in "first time they start chopping a tree, they get a question to decide on the setting and where to alter it in case they reconsider". /choppy_toggle would toggle the setting, too.

flux commented

2023-05-11 20:32:24 +00:00

Sounds like an application for yl_settings to be honest. As in "first time they start chopping a tree, they get a question to decide on the setting and where to alter it in case they reconsider". /choppy_toggle would toggle the setting, too.

unfortunately i can't rely on yl_settings, because (1) it doesn't exist (2) what's the timeline for when the code would become public?

implemented a prompt in fba67d148e

> Sounds like an application for yl_settings to be honest. As in "first time they start chopping a tree, they get a question to decide on the setting and where to alter it in case they reconsider". /choppy_toggle would toggle the setting, too. unfortunately i can't rely on yl_settings, because (1) it doesn't exist (2) what's the timeline for when the code would become public? implemented a prompt in https://github.com/fluxionary/minetest-choppy/commit/fba67d148e137afe120bc5986286a9ea929ac030

niceride commented

2023-05-12 17:02:57 +00:00

Needs two additional modes where (1) we can sneak or not sneak and not have choppy active at all. This was lacking from the woodcutting mod, which forced woodcutting on us and should be possible to disable totally any auto-cutting now that it is replaced by choppy. Also (2) a mode that emulates the latching behavior of woodcutting, because you need to be able to eat or switch axes without having to continually hold down sneak. That covers all uses.

Modes:

"press & hold sneak when cutting to use choppy."

"press sneak when cutting to start choppy; press again sneak to stop choppy."

"choppy is on! press sneak to stop choppy."

"choppy is off. Use /toggle_choppy to enable"

The unique non-alphanumeric character in each message is intentional so the user doesn't have to read it they can scan for that one character '&', ';', '!', '/'.

/toggle_choppy command should show the formspec for (above) choices of choppy mode, and this should be shown to users the first time they trigger the pre-conditions for choppy to possibly be in effect (i.e. axe + natural tree trunk). If you use the command and make a selection before the formspec is shown from a "first timer" hook it should not ask you to make a choice again after you have made your choice.

Needs two additional modes where (1) we can sneak or not sneak and not have choppy active at all. This was lacking from the woodcutting mod, which forced woodcutting on us and should be possible to disable totally any auto-cutting now that it is replaced by choppy. Also (2) a mode that emulates the latching behavior of woodcutting, because you need to be able to eat or switch axes without having to continually hold down sneak. That covers all uses. Modes: "press & hold sneak when cutting to use choppy." "press sneak when cutting to start choppy; press again sneak to stop choppy." "choppy is on! press sneak to stop choppy." "choppy is off. Use /toggle_choppy to enable" The unique non-alphanumeric character in each message is intentional so the user doesn't have to read it they can scan for that one character '&', ';', '!', '/'. `/toggle_choppy` command should show the formspec for (above) choices of choppy mode, and this should be shown to users the first time they trigger the pre-conditions for choppy to possibly be in effect (i.e. axe + natural tree trunk). If you use the command and make a selection before the formspec is shown from a "first timer" hook it should not ask you to make a choice again after you have made your choice.

👎 1

flux added the

5. result/fixed

label 2023-11-26 21:59:34 +00:00

flux removed this from the flux's TODO list project 2023-11-26 21:59:37 +00:00

AliasAlreadyTaken was unassigned by flux

2023-11-26 21:59:43 +00:00

flux commented

2023-11-26 22:00:38 +00:00

the prompt has been live for a while. niceride's additional suggestions can become another issue if someone wants to propose them.

flux closed this issue

2023-11-26 22:00:38 +00:00