AliasAlreadyTaken reports: testserver smartshops facing e ... #4257

New Issue

yourland-report · 2023-04-25T06:49:27Z

yourland-report commented

2023-04-25 06:49:27 +00:00

AliasAlreadyTaken reports a bug:

testserver smartshops facing east or west are now turned 90°

Player position:

{
	y = 16.877000808716,
	z = 1165.373046875,
	x = 2124.3391113281
}

Player look:

{
	y = -0.042573165148497,
	z = -0.071606338024139,
	x = 0.99652397632599
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.017000000923872,
	avg_rtt = 0.01799999922514,
	min_jitter = 0,
	max_jitter = 0.26100000739098,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 2065,
	serialization_version = 29,
	patch = 0,
	protocol_version = 41,
	major = 5,
	minor = 8,
	formspec_version = 6,
	state = "Active",
	lang_code = "de",
	version_string = "5.8.0-yl_dev-4158b7297",
	max_rtt = 0.28000000119209
}

Player meta:

{
	fields = {
		yl_commons_thankyou = "919",
		["petz:werewolf"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		xp = "0",
		arenalib_watchID = "0",
		hud_state = "on",
		repellant = "0",
		lagometer = "1",
		yl_unified_trash_review = "return {\"mesecons_blinkyplant:blinky_plant_off 99\", \"default:fence_acacia_wood 99\", \"\", \"\"}",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:level"] = "0",
		punch_count = "63258",
		["stamina:exhaustion"] = "101.5",
		played_time = "78596779",
		digged_nodes = "138972",
		placed_nodes = "179832",
		died = "1583",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"\", \"\", \"\", \"\", \"\"}",
		["signslib:pos"] = "(2007,16,1157)",
		bitten = "0",
		yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}",
		team = "STAFF",
		partychat = "party",
		["ocean_build.ocean_built"] = "12",
		["petz:werewolf_clan_idx"] = "4",
		yl_audio_state = "off",
		["arena_lib_editor.team_ID"] = "0",
		["ocean_build.last_warning"] = "1.67421e+09",
		["ocean_build.forbidden"] = "true",
		arenalib_infobox_arenaID = "0",
		xp_redo_hud_color = "0xFFFF00",
		["stamina:poisoned"] = "no",
		inflicted_damage = "2840866",
		crafted = "4765",
		["ethereal:fly_timer"] = "-99",
		["arena_lib_editor.players_number"] = "0",
		yl_commons_player_joined = "1682403315",
		["petz:lycanthropy"] = "0",
		szutil_watch = "return {}",
		["arena_lib_editor.spawner_ID"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = jsKwya6HjqX460KfUM2pttRDH4NW3nGp

Profiler save:

profile-20230425T064927.json_prettyEE

Status:

# Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 35min 32s | max lag: 1.09s | clients (1/52): AliasAlreadyTaken

Teleport command:

/teleport xyz 2124 17 1165

Compass command:

/give_compass Construction jsKwya6HjqX460KfUM2pttRDH4NW3nGp D2691E 2124 17 1165

AliasAlreadyTaken reports a bug: > testserver smartshops facing east or west are now turned 90° Player position: ``` { y = 16.877000808716, z = 1165.373046875, x = 2124.3391113281 } ``` Player look: ``` { y = -0.042573165148497, z = -0.071606338024139, x = 0.99652397632599 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.017000000923872, avg_rtt = 0.01799999922514, min_jitter = 0, max_jitter = 0.26100000739098, avg_jitter = 0.0010000001639128, connection_uptime = 2065, serialization_version = 29, patch = 0, protocol_version = 41, major = 5, minor = 8, formspec_version = 6, state = "Active", lang_code = "de", version_string = "5.8.0-yl_dev-4158b7297", max_rtt = 0.28000000119209 } ``` Player meta: ``` { fields = { yl_commons_thankyou = "919", ["petz:werewolf"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", xp = "0", arenalib_watchID = "0", hud_state = "on", repellant = "0", lagometer = "1", yl_unified_trash_review = "return {\"mesecons_blinkyplant:blinky_plant_off 99\", \"default:fence_acacia_wood 99\", \"\", \"\"}", ["petz:werewolf_vignette_id"] = "19", ["stamina:level"] = "0", punch_count = "63258", ["stamina:exhaustion"] = "101.5", played_time = "78596779", digged_nodes = "138972", placed_nodes = "179832", died = "1583", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"\", \"\", \"\", \"\", \"\"}", ["signslib:pos"] = "(2007,16,1157)", bitten = "0", yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}", team = "STAFF", partychat = "party", ["ocean_build.ocean_built"] = "12", ["petz:werewolf_clan_idx"] = "4", yl_audio_state = "off", ["arena_lib_editor.team_ID"] = "0", ["ocean_build.last_warning"] = "1.67421e+09", ["ocean_build.forbidden"] = "true", arenalib_infobox_arenaID = "0", xp_redo_hud_color = "0xFFFF00", ["stamina:poisoned"] = "no", inflicted_damage = "2840866", crafted = "4765", ["ethereal:fly_timer"] = "-99", ["arena_lib_editor.players_number"] = "0", yl_commons_player_joined = "1682403315", ["petz:lycanthropy"] = "0", szutil_watch = "return {}", ["arena_lib_editor.spawner_ID"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = jsKwya6HjqX460KfUM2pttRDH4NW3nGp ``` Profiler save: ``` profile-20230425T064927.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 35min 32s | max lag: 1.09s | clients (1/52): AliasAlreadyTaken ``` Teleport command: ``` /teleport xyz 2124 17 1165 ``` Compass command: ``` /give_compass Construction jsKwya6HjqX460KfUM2pttRDH4NW3nGp D2691E 2124 17 1165 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-25 06:49:27 +00:00

AliasAlreadyTaken commented

2023-04-25 06:49:41 +00:00

![image](/attachments/a57fff75-70e3-47ca-886f-63cd2f76f901) ![image](/attachments/f0937774-68b2-41b8-b50b-33c78a876307)

image.png

167 KiB

image.png

802 KiB

AliasAlreadyTaken referenced this issue

2023-04-25 07:05:51 +00:00

1.1.118 #3401

flux added the

1. kind/bug

label 2023-04-25 15:43:06 +00:00

flux commented

2023-04-25 15:57:26 +00:00

it looks fine on the test server to me currently? and i can't reproduce it locally? do you know which version of the smartshop code was present before and after this issue?

flux added the

4. step/question

label 2023-04-25 15:57:39 +00:00

AliasAlreadyTaken commented

2023-04-26 05:57:07 +00:00

For 1.1.118 I rolled back to 0997e9f1cda6d4f0af111ff5f2bf5389d6303cd8 which does not cause the issue. During testing it was on latest master: 40481067f2

For 1.1.118 I rolled back to 0997e9f1cda6d4f0af111ff5f2bf5389d6303cd8 which does not cause the issue. During testing it was on latest master: https://gitea.your-land.de/your-land/minetest-smartshop/commit/40481067f2e08890a0017d47624b1b7ba2bb5573

flux commented

2023-04-29 00:07:34 +00:00

w/ 0997e9f1cda6d4f0af111ff5f2bf5389d6303cd8:

w/ 40481067f2e08890a0017d47624b1b7ba2bb5573:

i'm stumped.

w/ 0997e9f1cda6d4f0af111ff5f2bf5389d6303cd8: ![image](/attachments/bc6d5e5d-afc6-4686-86c3-63e2c657b257) w/ 40481067f2e08890a0017d47624b1b7ba2bb5573: ![image](/attachments/e47b9d0b-9080-4575-bbfb-568a43a382c8) i'm stumped.

image.png

169 KiB

image.png

162 KiB

AliasAlreadyTaken commented

2023-05-08 10:14:38 +00:00

latest commit is bd33fb9c910573f2c88efba3c177e390bfca3c6a

fix orientation whether or not queues are present

And the oddly oriented smartshops are back.

Since you mentioned it I added

a53bf1df96

but they're still oriented wrong on the testserver

latest commit is bd33fb9c910573f2c88efba3c177e390bfca3c6a fix orientation whether or not queues are present And the oddly oriented smartshops are back. Since you mentioned it I added https://github.com/fluxionary/minetest-node_entity_queue/commit/a53bf1df964161fa194e110ec490a5b9540592ec but they're still oriented wrong on the testserver

flux commented

2023-05-09 18:39:24 +00:00

but they're still oriented wrong on the testserver

could you leave them on the testserver for the moment, so i can take a look at them and see if i can learn anything?

> but they're still oriented wrong on the testserver could you leave them on the testserver for the moment, so i can take a look at them and see if i can learn anything?

👍 1

flux added this to the flux's TODO list project 2023-05-09 18:44:57 +00:00

flux added the

2. prio/interesting

3. source/mod upstream

labels 2023-05-09 18:45:16 +00:00

AliasAlreadyTaken added

4. step/needs confirmation

and removed

4. step/question

labels 2023-05-10 05:45:39 +00:00

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-10 05:45:44 +00:00

flux commented

2023-05-15 23:22:14 +00:00

@AliasAlreadyTaken i still can't replicate this locally (i thought maybe the issue was run-once LBMs but that's not it).

but perhaps try testing this commit to see whether the problem goes away? the test would have to be against a fresh clone of the world from production.

also, i presume that you don't copy the world via postgres DB commands and not via minetest schemas? https://github.com/minetest/minetest/pull/13432

@AliasAlreadyTaken i still can't replicate this locally (i thought maybe the issue was run-once LBMs but that's not it). but perhaps try testing [this commit](https://github.com/AiTechEye/smartshop/commit/10114a903a13318e24f8eb42292b80452f52356d) to see whether the problem goes away? the test would have to be against a fresh clone of the world from production. also, i presume that you don't copy the world via postgres DB commands and not via minetest schemas? https://github.com/minetest/minetest/pull/13432

flux added the

4. step/at work

label 2023-05-15 23:31:43 +00:00

AliasAlreadyTaken commented

2023-05-16 03:37:50 +00:00

We dump the database and restore it via postgresql.

Ok, I'll add this commit. But why is it on the AiTechEye/smartshop repo? :D

We dump the database and restore it via postgresql. Ok, I'll add this commit. But why is it on the AiTechEye/smartshop repo? :D

AliasAlreadyTaken commented

2023-05-16 04:17:39 +00:00

minetest.register_lbm({
        name = "smartshop:fix_orientation",
        nodenames = { "group:smartshop" },
        run_at_every_load = true,
        action = function(pos, node)
                -- make sure that shops w/ weird param2 are normal before creating entities
                if node.param2 >= 4 then
                        node.param2 = node.param2 % 4
                        minetest.swap_node(pos, node)
                end
        end,
})

Sounds like when I comment out this code, I could omit the lbm altogether? At least in flux/smartshop commit bd33fb9c910573f2c88efba3c177e390bfca3c6a there is nothing else in there?

I didn't import a new database, but looked at cities I was fairly certain they were not loaded yet: Pluton and Monsabor. Both had their smartshops turned.

``` minetest.register_lbm({ name = "smartshop:fix_orientation", nodenames = { "group:smartshop" }, run_at_every_load = true, action = function(pos, node) -- make sure that shops w/ weird param2 are normal before creating entities if node.param2 >= 4 then node.param2 = node.param2 % 4 minetest.swap_node(pos, node) end end, }) ``` Sounds like when I comment out this code, I could omit the lbm altogether? At least in flux/smartshop commit bd33fb9c910573f2c88efba3c177e390bfca3c6a there is nothing else in there? I didn't import a new database, but looked at cities I was fairly certain they were not loaded yet: Pluton and Monsabor. Both had their smartshops turned.

AliasAlreadyTaken commented

2023-05-16 10:29:31 +00:00

This is the commit after which the smartshops are turn: 2b037300be

In the commit before they are not.

This is the commit after which the smartshops are turn: https://gitea.your-land.de/your-land-mirror/minetest-smartshop/commit/2b037300beef55770f751aece18cac69b2df2729 In the commit before they are not.

flux commented

2023-05-16 17:06:51 +00:00

This is the commit after which the smartshops are turn: 2b037300be

In the commit before they are not.

hm. does the behavior of 4dir vary by server? O_O.

try this? 76bbc6a8f9

> This is the commit after which the smartshops are turn: https://gitea.your-land.de/your-land-mirror/minetest-smartshop/commit/2b037300beef55770f751aece18cac69b2df2729 > > In the commit before they are not. hm. does the behavior of 4dir vary by server? O_O. try this? https://github.com/fluxionary/minetest-smartshop/commit/76bbc6a8f9479abaf91e3aecdd1233c91fb6a84c

AliasAlreadyTaken commented

2023-05-16 17:16:14 +00:00

4dir is a 5.7.0 thing. YL is on 5.6.1

Try search 4dir on the API doc:

https://raw.githubusercontent.com/minetest/minetest/587f6656a4b86346e35da1b43b48b832d3f1b32e/doc/lua_api.txt

4dir is a 5.7.0 thing. YL is on 5.6.1 Try search 4dir on the API doc: https://raw.githubusercontent.com/minetest/minetest/587f6656a4b86346e35da1b43b48b832d3f1b32e/doc/lua_api.txt

Bla commented

2023-05-16 18:31:42 +00:00

hm. does the behavior of 4dir vary by server? O_O.

running dev? 80574cdbe8 might be the culprit

> hm. does the behavior of 4dir vary by server? O_O. running dev? https://github.com/minetest/minetest/commit/80574cdbe8628df0bfbff1332b77a1cf822ca58a might be the culprit

flux commented

2023-05-16 20:45:17 +00:00

4dir is a 5.7.0 thing. YL is on 5.6.1

i did not realize it was that new. alright, that's certainly the cause then.

> 4dir is a 5.7.0 thing. YL is on 5.6.1 i did not realize it was that new. alright, that's certainly the cause then.

AliasAlreadyTaken commented

2023-05-17 00:10:41 +00:00

We'll test for 5.7.0 right after 1.1.119

Edit: If you want to write code for engine versions < 5.7.0 we'll test it for 5.6.1, if not we'll postpone delivery until we get 5.7.0

We'll test for 5.7.0 right after 1.1.119 Edit: If you want to write code for engine versions < 5.7.0 we'll test it for 5.6.1, if not we'll postpone delivery until we get 5.7.0

AliasAlreadyTaken commented

2023-05-18 00:03:41 +00:00

We rolled it back to what it was before. I'll remove this from the 1.1.119 milestone and readd to the milestone after the 5.7.0 rollout.

👍 1

AliasAlreadyTaken removed this from the 1.1.119 milestone 2023-05-18 00:03:47 +00:00

AliasAlreadyTaken referenced this issue

2023-06-05 18:09:30 +00:00

yl_cinema #4668

AliasAlreadyTaken commented

2023-06-23 07:30:38 +00:00

But now for reals: your-land/minetest-smartshop#24

But now for reals: https://gitea.your-land.de/your-land/minetest-smartshop/pulls/24