Mesecons pipeworks deployer: How did I do this? Connecting from the sides #4236

New Issue

Open

opened 2023-04-20 07:47:13 +00:00 by niceride · 12 comments

niceride commented 2023-04-20 07:47:13 +00:00

Copy Link

Wait... how did I do this?

Nodedeployer accepting items from the side via mesecons conducting tube. I can't seem to reproduce the effect, and haven't figured out what I did to make it happen.

Is this supposed to happen?

Wait... how did I do this? Nodedeployer accepting items from the side via mesecons conducting tube. I can't seem to reproduce the effect, and haven't figured out what I did to make it happen. Is this supposed to happen? 

screenshot_20230420_004539.png

546 KiB

niceride commented 2023-04-20 08:02:36 +00:00

Author

Copy Link

Maybe, got it... Actually kind of a useful glitch.

1. node deployers with "backside" facing central area
   

2. plumb deployers with mesecons conducting tube
   

3. node replacer tool on deployers to a different orientation
   

Node deployers remain plumbed to mesecons conducting tubes. Normally when placing mesecons conducting tubes, they do not accept connections from the sides.

I find this unexpected behavior to be quite useful, would be okay with a WONTFIX, unless there's something simple in the code and this has been a bug that is problematic.

Maybe, got it... Actually kind of a useful glitch. 1. node deployers with "backside" facing central area  2. plumb deployers with mesecons conducting tube  3. node replacer tool on deployers to a different orientation  Node deployers remain plumbed to mesecons conducting tubes. Normally when placing mesecons conducting tubes, they do not accept connections from the sides. I find this unexpected behavior to be quite useful, would be okay with a WONTFIX, unless there's something simple in the code and this has been a bug that is problematic.

screenshot_20230420_005737.png

421 KiB

screenshot_20230420_005812.png

476 KiB

screenshot_20230420_005926.png

450 KiB

flux commented 2023-04-20 17:45:56 +00:00

Member

Copy Link

if anything, this is a bug w/ the node replacement tool, which doesn't call the proper callbacks when re-orienting the machine. i don't think my replacer redo handles this properly either. i'm fine w/ leaving this the way it is though, there's no reason i see why items shouldn't be able to go into a deployer from the side.

if anything, this is a bug w/ the node replacement tool, which doesn't call the proper callbacks when re-orienting the machine. i don't think my replacer redo handles this properly either. i'm fine w/ leaving this the way it is though, there's no reason i see why items shouldn't be able to go into a deployer from the side.

👍 2

AliasAlreadyTaken added the

1. kind/bug

label 2023-04-20 17:47:43 +00:00

flux added the

1. kind/balancing

3. source/mod upstream

3. source/integration

labels 2023-04-20 17:47:47 +00:00

niceride referenced this issue 2023-04-26 08:41:43 +00:00

niceride reports: 'Replacing nodes of type "pipe ... #4289

niceride commented 2023-05-06 21:19:30 +00:00

Author

Copy Link

Mostly harmless. Closing.

Mostly harmless. Closing.

😆 1

niceride closed this issue 2023-05-06 21:19:30 +00:00

AliasAlreadyTaken commented 2023-05-06 21:35:33 +00:00

Owner

Copy Link

We should keep that open until we decided on the replacer and can confirm this doesn't happen anymore: your-land/administration#143

We should keep that open until we decided on the replacer and can confirm this doesn't happen anymore: https://gitea.your-land.de/your-land/administration/issues/143

AliasAlreadyTaken reopened this issue 2023-05-06 21:35:33 +00:00

niceride commented 2023-05-10 01:50:30 +00:00

Author

Copy Link

Well, there's no harm in it happening. Sorting tube and one-way tube both connect to node deployer from the side. This is a feature not a bug.

Well, there's no harm in it happening. Sorting tube and one-way tube both connect to node deployer from the side. This is a feature not a bug.

flux commented 2023-05-10 17:04:07 +00:00

Member

Copy Link

This is a feature not a bug.

if that's the case, then it's a bug that normal tubes don't usually connect to the sides.

> This is a feature not a bug. if that's the case, then it's a bug that normal tubes don't usually connect to the sides.

niceride commented 2023-05-11 00:21:29 +00:00

Author

Copy Link

This is a feature not a bug.

if that's the case, then it's a bug that normal tubes don't usually connect to the sides.

I'm not sure how you would accomplish that fix though, both without breaking player builds and also working within the limits of metadata. It would have to be a new deployer node that is permissive in accepting connections from normal tubes, or, advanced use with some kind of tool to get the tubes to connect. If only we had such a tool?

> > This is a feature not a bug. > > if that's the case, then it's a bug that normal tubes don't usually connect to the sides. I'm not sure how you would accomplish that fix though, both without breaking player builds and also working within the limits of metadata. It would have to be a new deployer node that is permissive in accepting connections from normal tubes, or, advanced use with some kind of tool to get the tubes to connect. If only we had such a tool?

flux commented 2023-05-11 05:11:58 +00:00

Member

Copy Link

This is a feature not a bug.

if that's the case, then it's a bug that normal tubes don't usually connect to the sides.

I'm not sure how you would accomplish that fix though, both without breaking player builds and also working within the limits of metadata. It would have to be a new deployer node that is permissive in accepting connections from normal tubes, or, advanced use with some kind of tool to get the tubes to connect. If only we had such a tool?

i apologize because this is certainly a rude thing to say, but as someone who wants us to abandon pipeworks and move to tubelib/techpack, because i think pipeworks is fundamentally flawed for a multitude of reasons, i don't think it's worth investing time in fixing pipeworks' architectural bugs, particularly when people think they are features.

> > > This is a feature not a bug. > > > > if that's the case, then it's a bug that normal tubes don't usually connect to the sides. > > I'm not sure how you would accomplish that fix though, both without breaking player builds and also working within the limits of metadata. It would have to be a new deployer node that is permissive in accepting connections from normal tubes, or, advanced use with some kind of tool to get the tubes to connect. If only we had such a tool? i apologize because this is certainly a rude thing to say, but as someone who wants us to abandon pipeworks and move to tubelib/techpack, because i think pipeworks is fundamentally flawed for a multitude of reasons, i don't think it's worth investing time in fixing pipeworks' architectural bugs, particularly when people think they are features.

niceride commented 2023-05-11 08:29:33 +00:00

Author

Copy Link

No investment needed, just allowlist node deployer for the existing node replacer. It's still broken, but at least it is workable.

No investment needed, just allowlist node deployer for the existing node replacer. It's still broken, but at least it is workable.

AliasAlreadyTaken commented 2023-05-11 13:07:39 +00:00

Owner

Copy Link

IMO a clear wontfix, until we know pipeworks "intended" this bahaviour and accounts for it in its code.

If they do not intend the behaviour, it's an integration bug between the replacer and pipeworks. The integration bug is fixed by blacklisting.

I cannot see the feature in this. If the pipeworks people had intended a connection on the sides, then they had added those ugly black rectangles. They did not.

IMO a clear wontfix, until we know pipeworks "intended" this bahaviour and accounts for it in its code. If they do not intend the behaviour, it's an integration bug between the replacer and pipeworks. The integration bug is fixed by blacklisting. I cannot see the feature in this. If the pipeworks people had intended a connection on the sides, then they had added those ugly black rectangles. They did not.

niceride commented 2023-05-11 15:28:57 +00:00

Author

Copy Link

I cannot see the feature in this. If the pipeworks people had intended a connection on the sides, then they had added those ugly black rectangles. They did not.

There are no such rectangles on several nodes that must accept connections from the sides in order to work correctly. At least kick this upstream for their advice?

> I cannot see the feature in this. If the pipeworks people had intended a connection on the sides, then they had added those ugly black rectangles. They did not. There are no such rectangles on several nodes that must accept connections from the sides in order to work correctly. At least kick this upstream for their advice?

niceride commented 2023-05-17 01:38:43 +00:00

Author

Copy Link

Aside: I believe that #4513 and the existing pipeworks:steel_block_embedded_tube addresses my concerns for being able to build things, without the disconnected visual and in an intuitive manner.

Aside: I believe that #4513 and the existing pipeworks:steel_block_embedded_tube addresses my concerns for being able to build things, without the disconnected visual and in an intuitive manner.

flux referenced this issue 2023-11-24 22:42:20 +00:00

Find a pipeworks successor #5547

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

Labels

Clear labels   

1. kind/balancing

Depends on balancing

  

1. kind/breaking

something that alters or disables an existing game mechanic

  

1. kind/bug

Something is not working

  

1. kind/construction

A build needs fixing

  

1. kind/documentation

Needs proper documentation

  

1. kind/enhancement

New feature

  

1. kind/griefing

players despoiling builds or nature

  

1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  

1. kind/meme

issue is mostly a joke

  

1. kind/node limit

something which works for or against the node limit

  

1. kind/other

Something not within the other kinds

  

1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  

2. prio/controversial

not likely to happen w/out a lot of discussion

  

2. prio/critical

Very important

  

2. prio/elevated

something players are eager to have fixed

  

2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  

2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  

2. prio/low

Not so important

  

3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  

3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  

3. source/engine

Issue is due to a bug or feature of the minetest engine

  

3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  

3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  

3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  

3. source/license

A licensing problem is involved

  

3. source/mod upstream

Problem is upstream (not engine/client)

  

3. source/unknown

  

3. source/website

Affects the website

  

4. step/approved

Alias has approved this feature, someone should implement it

  

4. step/at work

Being worked on

  

4. step/blocked

we plan to do this, but other work has to be finished first

  

4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  

4. step/help wanted

Need some help

  

4. step/needs confirmation

  

4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  

4. step/question

More information is needed

  

4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  

4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  

4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  

5. result/cannot reproduce

  

5. result/duplicate

This issue or pull request already exists

  

5. result/fixed

problem is fixed

  

5. result/maybe

not planned currently, but maybe some day

  

5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  

ugh/petz

yet another petz bugz.

  

ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  

ugh/QA NOK

Fix didn't yield the expected results

  

ugh/QA OK

tested

No Label

1. kind/balancing

1. kind/breaking

1. kind/bug

1. kind/construction

1. kind/documentation

1. kind/enhancement

1. kind/griefing

1. kind/invalid

1. kind/meme

1. kind/node limit

1. kind/other

1. kind/protocol

2. prio/controversial

2. prio/critical

2. prio/elevated

2. prio/good first issue

2. prio/interesting

2. prio/low

3. source/art

3. source/client

3. source/engine

3. source/ingame

3. source/integration

3. source/lag

3. source/license

3. source/mod upstream

3. source/unknown

3. source/website

4. step/approved

4. step/at work

4. step/blocked

4. step/discussion

4. step/help wanted

4. step/needs confirmation

4. step/partially fixed

4. step/question

4. step/ready to deploy

4. step/ready to QA test

4. step/want approval

5. result/cannot reproduce

5. result/duplicate

5. result/fixed

5. result/maybe

5. result/wontfix

ugh/petz

ugh/QA main

ugh/QA NOK

ugh/QA OK

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4236

No description provided.