your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

rheo reports: mail response to bug reports i ... #4210

New Issue
Closed
opened 2023-04-16 00:12:56 +00:00 by yourland-report · 10 comments
yourland-report commented 2023-04-16 00:12:56 +00:00
Member
Copy Link

rheo reports a bug:

mail response to bug reports isn't showing up in "new mail" on the test server

Player position:

{
	x = 1281.0440673828,
	y = -37.499000549316,
	z = 614.50500488281
}

Player look:

{
	x = -0.052556075155735,
	y = 0.99542957544327,
	z = -0.079735726118088
}

Player information:

{
	ip_version = 6,
	formspec_version = 6,
	avg_rtt = 0.25,
	min_jitter = 0,
	max_jitter = 5.0310001373291,
	avg_jitter = 0.0040000081062317,
	connection_uptime = 592,
	serialization_version = 29,
	patch = 1,
	lang_code = "",
	major = 5,
	minor = 6,
	version_string = "5.6.1",
	state = "Active",
	max_rtt = 5.228000164032,
	min_rtt = 0.18600000441074,
	protocol_version = 41
}

Player meta:

{
	fields = {
		crafted = "1672",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		["stamina:poisoned"] = "no",
		died = "2",
		["stamina:exhaustion"] = "129",
		punch_count = "1033",
		inflicted_damage = "240574",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_clan_idx"] = "1",
		["signslib:pos"] = "(19789,19986,20054)",
		yl_commons_player_joined = "1681603416",
		yl_commons_thankyou = "48",
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.66814e+09",
		["petz:werewolf_vignette_id"] = "16",
		["ocean_build.ocean_built"] = "6",
		yl_commons_player_created = "1644205752",
		partychat = "party",
		jointime = "1644205752",
		bitten = "0",
		xp = "0",
		["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["ethereal:fly_timer"] = "-99",
		hud_state = "off",
		repellant = "0",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"\", \"\", \"\", \"\", \"\"}",
		["stamina:level"] = "0",
		played_time = "4017403",
		digged_nodes = "12345",
		placed_nodes = "16875",
		["petz:lycanthropy"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = WI268EdzpPC7AVQqNSudiXSm9XXmUTRK

Profiler save:

profile-20230416T001256.json_prettyEE

Status:

# Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 14h 17min 16s | max lag: 0.128s | clients (2/52): AliasAlreadyTaken, rheo

Teleport command:

/teleport xyz 1281 -37 615

Compass command:

/give_compass Construction WI268EdzpPC7AVQqNSudiXSm9XXmUTRK D2691E 1281 -37 615
rheo reports a bug: > mail response to bug reports isn't showing up in "new mail" on the test server Player position: ``` { x = 1281.0440673828, y = -37.499000549316, z = 614.50500488281 } ``` Player look: ``` { x = -0.052556075155735, y = 0.99542957544327, z = -0.079735726118088 } ``` Player information: ``` { ip_version = 6, formspec_version = 6, avg_rtt = 0.25, min_jitter = 0, max_jitter = 5.0310001373291, avg_jitter = 0.0040000081062317, connection_uptime = 592, serialization_version = 29, patch = 1, lang_code = "", major = 5, minor = 6, version_string = "5.6.1", state = "Active", max_rtt = 5.228000164032, min_rtt = 0.18600000441074, protocol_version = 41 } ``` Player meta: ``` { fields = { crafted = "1672", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", ["stamina:poisoned"] = "no", died = "2", ["stamina:exhaustion"] = "129", punch_count = "1033", inflicted_damage = "240574", arenalib_infobox_arenaID = "0", ["petz:werewolf_clan_idx"] = "1", ["signslib:pos"] = "(19789,19986,20054)", yl_commons_player_joined = "1681603416", yl_commons_thankyou = "48", ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.66814e+09", ["petz:werewolf_vignette_id"] = "16", ["ocean_build.ocean_built"] = "6", yl_commons_player_created = "1644205752", partychat = "party", jointime = "1644205752", bitten = "0", xp = "0", ["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"speed\"] = 2, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["ethereal:fly_timer"] = "-99", hud_state = "off", repellant = "0", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"\", \"\", \"\", \"\", \"\"}", ["stamina:level"] = "0", played_time = "4017403", digged_nodes = "12345", placed_nodes = "16875", ["petz:lycanthropy"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = WI268EdzpPC7AVQqNSudiXSm9XXmUTRK ``` Profiler save: ``` profile-20230416T001256.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl-debug | game: Minetest Game | uptime: 14h 17min 16s | max lag: 0.128s | clients (2/52): AliasAlreadyTaken, rheo ``` Teleport command: ``` /teleport xyz 1281 -37 615 ``` Compass command: ``` /give_compass Construction WI268EdzpPC7AVQqNSudiXSm9XXmUTRK D2691E 1281 -37 615 ```
AliasAlreadyTaken was assigned by yourland-report 2023-04-16 00:12:57 +00:00
flux added the
1. kind/bug
2. prio/elevated
 labels 2023-04-17 03:05:51 +00:00
flux commented 2023-04-17 03:06:11 +00:00
Member
Copy Link

API for mail may have changed, needs analysis

API for mail may have changed, needs analysis
AliasAlreadyTaken added this to the 1.1.119 milestone 2023-04-25 14:21:05 +00:00
flux commented 2023-04-30 03:46:23 +00:00
Member
Copy Link

as the mail update is now on the main server, this applies there as well

as the mail update is now on the main server, this applies there as well
AliasAlreadyTaken commented 2023-05-07 20:00:25 +00:00
Owner
Copy Link

Reason is mail_mod changed the API from

function mail.send(sender, receiver, subject, message)

to

function mail.send(m)

where m is a table composed of

mail = {
	from = "sender name",
	to = "players, which, are, addressed",
	cc = "carbon copy",
	bcc = "players, which, get, a, copy, but, are, not, visible, to, others",
	subject = "subject line",
	body = "mail body"
}

per api.md

Reason is mail_mod changed the API from ```lua function mail.send(sender, receiver, subject, message) ``` to ```lua function mail.send(m) ``` where m is a table composed of ```lua mail = { from = "sender name", to = "players, which, are, addressed", cc = "carbon copy", bcc = "players, which, get, a, copy, but, are, not, visible, to, others", subject = "subject line", body = "mail body" } ``` per api.md
AliasAlreadyTaken added this to the Alias@work project 2023-05-07 20:04:09 +00:00
AliasAlreadyTaken commented 2023-05-08 03:12:11 +00:00
Owner
Copy Link

Fixed in

yl_chat:
f0fb5dc361

mailbox:
234b6e68d8

yl_commons:
5664ea3628

yl_report:
c1a8a338fa

ad733d654d

yl_events:
25b67fe44e

e30a4d1c51

Fixed in yl_chat: https://gitea.your-land.de/your-land/yl_chat/commit/f0fb5dc3611eea763ed264258ee4febde4980214 mailbox: https://gitea.your-land.de/your-land/mailbox/commit/234b6e68d87d34f99f3ef2ec7dc9c0a0f03dcf38 yl_commons: https://gitea.your-land.de/your-land/yl_commons/commit/5664ea36283b9460396472e0bdda0c43e377c6f7 yl_report: https://gitea.your-land.de/your-land/yl_report/commit/c1a8a338fa36d60c65aa53c94165af71470d32e8 https://gitea.your-land.de/your-land/yl_report/commit/ad733d654d7a58145d7b0b9878f543d47db28b8f yl_events: https://gitea.your-land.de/your-land/yl_events/commit/25b67fe44ec2e503f80629c61918a4e7e1f85312 https://gitea.your-land.de/your-land/yl_events/commit/e30a4d1c51d44cb2c75c7e79e07d19149c1160fa
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2023-05-08 03:18:06 +00:00
AliasAlreadyTaken added the
ugh/QA NOK
 label 2023-05-09 09:31:14 +00:00
AliasAlreadyTaken commented 2023-05-10 16:20:02 +00:00
Owner
Copy Link

Offline message does not work properly

Because I added a check for minetest.check_player_privs(to, {staff = true}) everywhere. Now why would I do that?!

Offline message does not work properly Because I added a check for minetest.check_player_privs(to, {staff = true}) everywhere. Now why would I do that?!
😕 2
AliasAlreadyTaken commented 2023-05-14 18:47:48 +00:00
Owner
Copy Link

Fixed:

yl_chat

c17dc322af

mailbox

455a8091e2

yl_report

b437f956cb

yl_events

9b8df37785

Fixed: yl_chat https://gitea.your-land.de/your-land/yl_chat/commit/c17dc322af7aa5cb0dceee52454d01afe287964d mailbox https://gitea.your-land.de/your-land/mailbox/commit/455a8091e29eeb5a8536189ed43075ced85c4a40 yl_report https://gitea.your-land.de/your-land/yl_report/commit/b437f956cb79d3c8a8ec2076fcaf2d23f9ede39d yl_events https://gitea.your-land.de/your-land/yl_events/commit/9b8df37785aebf2a4dba487e0902d12a14493ad2
AliasAlreadyTaken removed the
ugh/QA NOK
 label 2023-05-14 18:47:56 +00:00
AliasAlreadyTaken commented 2023-05-14 21:15:11 +00:00
Owner
Copy Link

This should be ready for testing now, could please someone else look over what I did? Code is still in a non-optimized but better comparable state.

This should be ready for testing now, could please someone else look over what I did? Code is still in a non-optimized but better comparable state.
AliasAlreadyTaken added the
ugh/QA main
 label 2023-05-14 21:42:48 +00:00
flux commented 2023-05-15 18:46:57 +00:00
Member
Copy Link

the code looks correct, though it'll be a bit tricky for me to test all of the things. i'll poke things though.

the code looks correct, though it'll be a bit tricky for me to test all of the things. i'll poke things though.
flux commented 2023-05-15 21:48:04 +00:00
Member
Copy Link

i've tested yl_chat, mailbox, yl_events, but not yl_report. no problems to report, except that the new mail sound is perhaps a bit too intense.

i've tested yl_chat, mailbox, yl_events, but not yl_report. no problems to report, except that the new mail sound is perhaps a bit too intense.
👍 1
flux added
ugh/QA OK
 and removed
ugh/QA main
 labels 2023-05-15 21:48:22 +00:00
flux commented 2023-05-18 19:32:00 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-05-18 19:32:00 +00:00
flux removed this from the Alias@work project 2023-05-18 19:32:06 +00:00
AliasAlreadyTaken was unassigned by flux 2023-05-18 19:32:09 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-05-18 19:32:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.119
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4210
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?