AliasAlreadyTaken reports: Make a duplicate finder for bo ... #4157

New Issue

yourland-report · 2023-04-10T20:10:42Z

yourland-report commented

2023-04-10 20:10:42 +00:00

AliasAlreadyTaken reports a bug:

Make a duplicate finder for books. When a book is wielded and the player uses a chatcommand, show all other locations of similar books

Player position:

{
	x = 1979.3000488281,
	z = 1174.25,
	y = 18
}

Player look:

{
	x = 0.99185168743134,
	z = -0.014715853147209,
	y = -0.12654523551464
}

Player information:

{
	lang_code = "de",
	patch = 0,
	formspec_version = 6,
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.017000000923872,
	avg_rtt = 0.018999999389052,
	min_jitter = 0,
	max_jitter = 0.32699999213219,
	minor = 8,
	connection_uptime = 5371,
	serialization_version = 29,
	max_rtt = 0.34799998998642,
	version_string = "5.8.0-yl_dev-1d88d85f1",
	state = "Active",
	avg_jitter = 0.0010000001639128,
	major = 5
}

Player meta:

{
	fields = {
		["stamina:level"] = "2",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "125.5",
		["ocean_build.last_warning"] = "1.67421e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		yl_commons_thankyou = "908",
		arenalib_watchID = "0",
		["ethereal:fly_timer"] = "-99",
		partychat = "party",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		digged_nodes = "138895",
		placed_nodes = "179403",
		died = "1583",
		["signslib:pos"] = "(2016,17,1153)",
		yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}",
		punch_count = "63151",
		inflicted_damage = "2827888",
		hud_state = "on",
		bitten = "0",
		repellant = "0",
		["petz:lycanthropy"] = "0",
		xp = "0",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		["petz:werewolf_vignette_id"] = "19",
		["arena_lib_editor.players_number"] = "0",
		["arena_lib_editor.spawner_ID"] = "0",
		["arena_lib_editor.team_ID"] = "0",
		lagometer = "1",
		["petz:werewolf_clan_idx"] = "4",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp_redo_hud_color = "0xFFFF00",
		yl_commons_player_joined = "1681152079",
		szutil_watch = "return {}",
		team = "STAFF",
		played_time = "77877316",
		["petz:werewolf"] = "0",
		yl_audio_state = "off",
		crafted = "4757",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = bOAahNyp9xhD6mt5b0li5opfDl46KOtt

Profiler save:

profile-20230410T201042.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 17h 6min 46s | max lag: 0.969s | clients (33/52): AliasAlreadyTaken, Allan, Amanda, Apocralypse, AspireMint, azistonistoraro56, Bailiff, bizon, Bla, BobaCat, Boot, bubbafrog, Chache, copper248, darealbang, flux, g1ngercat, HorusDamocles, JeCel, labrat, Laurii, Lupercus, MineWorlds, Murmel, niceride, Rizzkus, Scathach, Service, shanish3, sixer, Sokomine, Sysmatic, vansantha

Teleport command:

/teleport xyz 1979 18 1174

Compass command:

/give_compass Construction bOAahNyp9xhD6mt5b0li5opfDl46KOtt D2691E 1979 18 1174

AliasAlreadyTaken reports a bug: > Make a duplicate finder for books. When a book is wielded and the player uses a chatcommand, show all other locations of similar books Player position: ``` { x = 1979.3000488281, z = 1174.25, y = 18 } ``` Player look: ``` { x = 0.99185168743134, z = -0.014715853147209, y = -0.12654523551464 } ``` Player information: ``` { lang_code = "de", patch = 0, formspec_version = 6, protocol_version = 41, ip_version = 6, min_rtt = 0.017000000923872, avg_rtt = 0.018999999389052, min_jitter = 0, max_jitter = 0.32699999213219, minor = 8, connection_uptime = 5371, serialization_version = 29, max_rtt = 0.34799998998642, version_string = "5.8.0-yl_dev-1d88d85f1", state = "Active", avg_jitter = 0.0010000001639128, major = 5 } ``` Player meta: ``` { fields = { ["stamina:level"] = "2", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "125.5", ["ocean_build.last_warning"] = "1.67421e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", yl_commons_thankyou = "908", arenalib_watchID = "0", ["ethereal:fly_timer"] = "-99", partychat = "party", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", digged_nodes = "138895", placed_nodes = "179403", died = "1583", ["signslib:pos"] = "(2016,17,1153)", yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}", punch_count = "63151", inflicted_damage = "2827888", hud_state = "on", bitten = "0", repellant = "0", ["petz:lycanthropy"] = "0", xp = "0", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", ["petz:werewolf_vignette_id"] = "19", ["arena_lib_editor.players_number"] = "0", ["arena_lib_editor.spawner_ID"] = "0", ["arena_lib_editor.team_ID"] = "0", lagometer = "1", ["petz:werewolf_clan_idx"] = "4", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp_redo_hud_color = "0xFFFF00", yl_commons_player_joined = "1681152079", szutil_watch = "return {}", team = "STAFF", played_time = "77877316", ["petz:werewolf"] = "0", yl_audio_state = "off", crafted = "4757", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = bOAahNyp9xhD6mt5b0li5opfDl46KOtt ``` Profiler save: ``` profile-20230410T201042.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 17h 6min 46s | max lag: 0.969s | clients (33/52): AliasAlreadyTaken, Allan, Amanda, Apocralypse, AspireMint, azistonistoraro56, Bailiff, bizon, Bla, BobaCat, Boot, bubbafrog, Chache, copper248, darealbang, flux, g1ngercat, HorusDamocles, JeCel, labrat, Laurii, Lupercus, MineWorlds, Murmel, niceride, Rizzkus, Scathach, Service, shanish3, sixer, Sokomine, Sysmatic, vansantha ``` Teleport command: ``` /teleport xyz 1979 18 1174 ``` Compass command: ``` /give_compass Construction bOAahNyp9xhD6mt5b0li5opfDl46KOtt D2691E 1979 18 1174 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-10 20:10:42 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-04-10 20:10:55 +00:00

AliasAlreadyTaken commented

2023-04-10 20:16:15 +00:00

There are various challenges to this task:

What constitutes a duplicate? Same content? Same title? Same author? A combination of those?

Once we know which conditions form a duplicate, we can hash them and store them in a database with ID, hash and location. Location would be "inventory of player X" or "placed at position xyz" or "in storage at location xyz"

This required us to capture all inventory and other operations
Where to store this database? modstorage?
How would such a database be cleaned?

Longterm we should replace books and move their metadata to some database, so they only get loaded when interacted with.

There are various challenges to this task: - What constitutes a duplicate? Same content? Same title? Same author? A combination of those? Once we know which conditions form a duplicate, we can hash them and store them in a database with ID, hash and location. Location would be "inventory of player X" or "placed at position xyz" or "in storage at location xyz" - This required us to capture all inventory and other operations - Where to store this database? modstorage? - How would such a database be cleaned? Longterm we should replace books and move their metadata to some database, so they only get loaded when interacted with.

flux commented

2023-04-12 04:10:46 +00:00

What constitutes a duplicate? Same content? Same title? Same author? A combination of those?

this is a deeply difficult question. detecting identical content is easy, detecting "similar" content requires "intelligence". there's certainly ways to apply AI to minetest, but they're not trivial.

> What constitutes a duplicate? Same content? Same title? Same author? A combination of those? this is a deeply difficult question. detecting identical content is easy, detecting "similar" content requires "intelligence". there's certainly ways to apply AI to minetest, but they're not trivial.

AliasAlreadyTaken commented

2023-04-12 18:07:13 +00:00

For a first attempt I'd rather got with exact matches.

👍 2

Sign in to join this conversation.