shanish reports: Increase max smartshop storage ... #4156

Closed
opened 2023-04-10 18:15:44 +00:00 by yourland-report · 7 comments

shanish reports a bug:

Increase max smartshop storage distance from 30 to 64 or even 128, which is the highest protected single area.

Player position:

{
	x = 1579.0369873047,
	z = 1136.7249755859,
	y = -26.498998641968
}

Player look:

{
	x = -0.1582161039114,
	z = 0.97577661275864,
	y = -0.15108828246593
}

Player information:

{
	lang_code = "",
	formspec_version = 4,
	protocol_version = 39,
	min_jitter = 0,
	max_jitter = 16.098001480103,
	avg_jitter = 0.0080000013113022,
	connection_uptime = 1441,
	serialization_version = 28,
	patch = 1,
	max_rtt = 16.483999252319,
	version_string = "5.4.1",
	state = "Active",
	min_rtt = 0.16699999570847,
	minor = 4,
	avg_rtt = 0.17599999904633,
	ip_version = 6,
	major = 5
}

Player meta:

{
	fields = {
		inflicted_damage = "21180056",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		jointime = "1638658291",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["stamina:level"] = "7",
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.67315e+09",
		["petz:lycanthropy"] = "1",
		xp = "5120000",
		yl_commons_thankyou = "15",
		yl_commons_player_created = "1638658291",
		["ethereal:fly_timer"] = "-99",
		["petz:werewolf_vignette_id"] = "19",
		["ocean_build.ocean_built"] = "1",
		["signslib:pos"] = "(2001,-30909,1488)",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:exhaustion"] = "21.5",
		["petz:werewolf_clan_idx"] = "2",
		arenalib_infobox_arenaID = "0",
		played_time = "8354630",
		digged_nodes = "984033",
		placed_nodes = "268577",
		died = "165",
		yl_commons_player_joined = "1681149168",
		crafted = "1075",
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 1400\", \"3d_armor:leggings_nether 1 6480\", \"shields:shield_rainbow 1 9212\", \"3d_armor:helmet_nether 1 9220\", \"3d_armor:boots_crystal 1 3240\", \"\"}",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 2016, [\"y\"] = 28833, [\"z\"] = 1543}, [\"last_death_portal\"] = 1674422323}",
		repellant = "0",
		partychat = "party",
		punch_count = "1667509",
		hud_state = "on"
	}
}

Log identifier


[MOD] yl_report log identifier = dT4t8EHj0W6wqLs3Igbo8zthd2J5dUu5

Profiler save:

profile-20230410T181544.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 15h 9min 31s | max lag: 1.04s | clients (26/52): AliasAlreadyTaken, Amanda, AriellesWish, Bailiff, bizon, BobaCat, Boot, copper248, darealbang, daydream, drgn, Ente, flux, FullmetalBOI, JeCel, labrat, MineWorlds, Murmel, niceride, Service, shanish, sixer, Sokomine, Sysmatic, tour, Traube

Teleport command:

/teleport xyz 1579 -26 1137

Compass command:

/give_compass Construction dT4t8EHj0W6wqLs3Igbo8zthd2J5dUu5 D2691E 1579 -26 1137
shanish reports a bug: > Increase max smartshop storage distance from 30 to 64 or even 128, which is the highest protected single area. Player position: ``` { x = 1579.0369873047, z = 1136.7249755859, y = -26.498998641968 } ``` Player look: ``` { x = -0.1582161039114, z = 0.97577661275864, y = -0.15108828246593 } ``` Player information: ``` { lang_code = "", formspec_version = 4, protocol_version = 39, min_jitter = 0, max_jitter = 16.098001480103, avg_jitter = 0.0080000013113022, connection_uptime = 1441, serialization_version = 28, patch = 1, max_rtt = 16.483999252319, version_string = "5.4.1", state = "Active", min_rtt = 0.16699999570847, minor = 4, avg_rtt = 0.17599999904633, ip_version = 6, major = 5 } ``` Player meta: ``` { fields = { inflicted_damage = "21180056", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", jointime = "1638658291", bitten = "0", ["stamina:poisoned"] = "no", ["stamina:level"] = "7", ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.67315e+09", ["petz:lycanthropy"] = "1", xp = "5120000", yl_commons_thankyou = "15", yl_commons_player_created = "1638658291", ["ethereal:fly_timer"] = "-99", ["petz:werewolf_vignette_id"] = "19", ["ocean_build.ocean_built"] = "1", ["signslib:pos"] = "(2001,-30909,1488)", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:exhaustion"] = "21.5", ["petz:werewolf_clan_idx"] = "2", arenalib_infobox_arenaID = "0", played_time = "8354630", digged_nodes = "984033", placed_nodes = "268577", died = "165", yl_commons_player_joined = "1681149168", crafted = "1075", ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 1400\", \"3d_armor:leggings_nether 1 6480\", \"shields:shield_rainbow 1 9212\", \"3d_armor:helmet_nether 1 9220\", \"3d_armor:boots_crystal 1 3240\", \"\"}", yl_church = "return {[\"last_death\"] = {[\"x\"] = 2016, [\"y\"] = 28833, [\"z\"] = 1543}, [\"last_death_portal\"] = 1674422323}", repellant = "0", partychat = "party", punch_count = "1667509", hud_state = "on" } } ``` Log identifier ``` [MOD] yl_report log identifier = dT4t8EHj0W6wqLs3Igbo8zthd2J5dUu5 ``` Profiler save: ``` profile-20230410T181544.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 15h 9min 31s | max lag: 1.04s | clients (26/52): AliasAlreadyTaken, Amanda, AriellesWish, Bailiff, bizon, BobaCat, Boot, copper248, darealbang, daydream, drgn, Ente, flux, FullmetalBOI, JeCel, labrat, MineWorlds, Murmel, niceride, Service, shanish, sixer, Sokomine, Sysmatic, tour, Traube ``` Teleport command: ``` /teleport xyz 1579 -26 1137 ``` Compass command: ``` /give_compass Construction dT4t8EHj0W6wqLs3Igbo8zthd2J5dUu5 D2691E 1579 -26 1137 ```
AliasAlreadyTaken was assigned by yourland-report 2023-04-10 18:15:44 +00:00
flux added the
1. kind/balancing
label 2023-04-11 03:58:40 +00:00
Member

this is controlled by a setting, e.g. smartshop.storage_max_distance = 64

this is controlled by a setting, e.g. `smartshop.storage_max_distance = 64`

Does a greater distance cause lag?

Does a greater distance cause lag?
Member

Does a greater distance cause lag?

very little - only loading the block w/ the storage, if it isn't already loaded. before i rewrote the mod, the distance was unlimited - you could have shops and storage on completely separate sides of the map. problems sometimes occurred if the storage was somewhere that wasn't loaded, which is why i wanted to create a limit on how far away they could be. the value i chose for the default was pretty arbitrary. then again, even being a few nodes away could result in problems, cf. #2794 - though that's been fixed now. shops make sure that storage is loaded before trying to interact w/ it.

> Does a greater distance cause lag? very little - only loading the block w/ the storage, if it isn't already loaded. before i rewrote the mod, the distance was unlimited - you could have shops and storage on completely separate sides of the map. problems sometimes occurred if the storage was somewhere that wasn't loaded, which is why i wanted to create a limit on how far away they could be. the value i chose for the default was pretty arbitrary. then again, even being a few nodes away could result in problems, cf. #2794 - though that's been fixed now. shops make sure that storage is loaded before trying to interact w/ it.

Let's try with 256 and see whether it gives us any lag.

smartshop.storage_max_distance = 256
Let's try with 256 and see whether it gives us any lag. ``` smartshop.storage_max_distance = 256 ```
AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-12 17:27:51 +00:00
AliasAlreadyTaken added the
4. step/ready to QA test
label 2023-04-12 17:27:58 +00:00
AliasAlreadyTaken added the
4. step/blocked
label 2023-04-13 20:01:03 +00:00

Test blocked by #4180

Test blocked by #4180

QA

nice!

QA nice!
AliasAlreadyTaken added
ugh/QA OK
and removed
4. step/blocked
labels 2023-04-16 03:34:32 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-26 14:30:41 +00:00
AliasAlreadyTaken was unassigned by flux 2023-04-26 14:30:44 +00:00
Member

this is live

this is live
flux closed this issue 2023-04-26 14:30:52 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4156
No description provided.