your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

party/init.lua:338: attempt to concatenate local 'param3' (a nil value) #4064

New Issue
Closed
opened 2023-03-24 03:07:35 +00:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2023-03-24 03:07:35 +00:00
Owner
Copy Link

2023-03-24 03:06:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'party' in callback on_chat_message(): /home/mt/5.6.1/Minetest_live/bin/../mods/party/init.lua:338: attempt to concatenate local 'param3' (a nil value)
2023-03-24 03:06:10: ERROR[Main]: stack traceback:
2023-03-24 03:06:10: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/party/init.lua:338: in function 'func'
2023-03-24 03:06:10: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'func'
2023-03-24 03:06:10: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:79: in function 'func'
2023-03-24 03:06:10: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2023-03-24 03:06:10: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>

2023-03-24 03:06:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'party' in callback on_chat_message(): /home/mt/5.6.1/Minetest_live/bin/../mods/party/init.lua:338: attempt to concatenate local 'param3' (a nil value) 2023-03-24 03:06:10: ERROR[Main]: stack traceback: 2023-03-24 03:06:10: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/party/init.lua:338: in function 'func' 2023-03-24 03:06:10: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'func' 2023-03-24 03:06:10: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:79: in function 'func' 2023-03-24 03:06:10: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2023-03-24 03:06:10: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2023-03-24 03:10:04 +00:00
AliasAlreadyTaken commented 2023-03-24 03:43:02 +00:00
Author
Owner
Copy Link

Fixed in 14952d0f61

Fixed in https://gitea.your-land.de/your-land/party/commit/14952d0f61027ba1d5c149eab32fa870bd3464ef
AliasAlreadyTaken added this to the 1.1.118 milestone 2023-03-24 03:45:07 +00:00
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2023-03-24 03:45:17 +00:00
flux commented 2023-03-24 04:07:26 +00:00
Member
Copy Link

@AliasAlreadyTaken looking at the quantity of nil checks i see you add, i feel like you're exhausted w/ how poorly defined the minetest API is. but this check in particular seems totally reasonable.

@AliasAlreadyTaken looking at the quantity of nil checks i see you add, i feel like you're exhausted w/ how poorly defined the minetest API is. but this check in particular seems totally reasonable.
AliasAlreadyTaken commented 2023-03-24 05:04:02 +00:00
Author
Owner
Copy Link

I don't understand ... ?

Is that a joke because I only added two? :D And because those nil checks are pure lua, they have not much to do with the MT API (which IS poorly designed, documented and censored due to rage.), rather with how the developer of the party mod evaluated the parameters that come from the user of the command.

The first nil check of line 337 avoids the crash - param3 is checked against nil nowhere, while param2 is. We must have been plain lucky noone ever executed the command in this fashion.

The second nil check of line 731 is a mere guess. The developer checks param3 against a string "nil" instead of nil, even though this param3 will hardly ever become string "nil" unless a user really adds "nil" to the /p command as third parameter. I just guessed the developer wanted to check against nil, instead of string "nil".

Or do I misunderstand and I should have done soemthing else instead?

I don't understand ... ? Is that a joke because I only added two? :D And because those nil checks are pure lua, they have not much to do with the MT API (which IS poorly designed, documented and *censored due to rage*.), rather with how the developer of the party mod evaluated the parameters that come from the user of the command. The first nil check of line 337 avoids the crash - param3 is checked against nil nowhere, while param2 is. We must have been plain lucky noone ever executed the command in this fashion. The second nil check of line 731 is a mere guess. The developer checks param3 against a string "nil" instead of nil, even though this param3 will hardly ever become string "nil" unless a user really adds "nil" to the /p command as third parameter. I just guessed the developer wanted to check against nil, instead of string "nil". Or do I misunderstand and I should have done soemthing else instead?
AliasAlreadyTaken added the
ugh/QA main
 label 2023-04-13 20:04:15 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-04-26 14:52:34 +00:00
flux commented 2023-04-26 14:52:44 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-04-26 14:52:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.118
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4064
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?