Chache reports: The recently added lilac flowe ... #4038

New Issue

yourland-report · 2023-03-21T09:33:23Z

yourland-report commented

2023-03-21 09:33:23 +00:00

Chache reports a bug:

The recently added lilac flowers cannot be put inside clay pots like all the other flowers

Player position:

{
	x = 3067.2829589844,
	y = 9.5,
	z = -2619.5439453125
}

Player look:

{
	x = 0.24057020246983,
	y = -0.41087797284126,
	z = -0.87937778234482
}

Player information:

{
	connection_uptime = 2368,
	serialization_version = 29,
	patch = 1,
	formspec_version = 6,
	lang_code = "es",
	max_rtt = 1.5499999523163,
	protocol_version = 41,
	state = "Active",
	minor = 6,
	version_string = "5.6.1",
	min_jitter = 0,
	ip_version = 6,
	min_rtt = 0.028999999165535,
	avg_rtt = 0.032000001519918,
	major = 5,
	max_jitter = 1.3310000896454,
	avg_jitter = 0
}

Player meta:

{
	fields = {
		crafted = "27859",
		punch_count = "15546",
		["ocean_build.forbidden"] = "true",
		inflicted_damage = "938678",
		yl_church = "return {[\"last_heal\"] = 1653594577, [\"last_death\"] = {[\"z\"] = -2855, [\"x\"] = 3030, [\"y\"] = 55}, [\"last_death_portal\"] = 1659644212}",
		["stamina:level"] = "15",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "22",
		yl_commons_thankyou = "77",
		yl_commons_player_created = "1645471717",
		hud_state = "on",
		["ocean_build.last_warning"] = "1.65606e+09",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 3460\", \"\", \"3d_armor:chestplate_crystal 1 17040\", \"3d_armor:leggings_crystal 1 17040\", \"shields:shield_rainbow 1 1400\", \"3d_armor:boots_crystal 1 17040\"}",
		yl_commons_player_joined = "1679388862",
		played_time = "5590524",
		partychat = "party",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		placed_nodes = "293635",
		arenalib_infobox_arenaID = "0",
		jointime = "1645471717",
		xp = "764580",
		["ocean_build.ocean_built"] = "12",
		["signslib:pos"] = "(3008,-4,-2724)",
		digged_nodes = "728046",
		xp_redo_hud_color = "0xFFFF00",
		died = "11",
		repellant = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = uJ8aQr5TN8trVKLcEEuwE6YTqGviTY5B

Profiler save:

profile-20230321T093323.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 26min | max lag: 1.61s | clients (12/52): 9T9, AliasAlreadyTaken, Azelf, Bailiff, Chache, daydream, dukela, Murmel, NafiShahriyar, niceride, richelles, Service

Teleport command:

/teleport xyz 3067 10 -2620

Compass command:

/give_compass Construction uJ8aQr5TN8trVKLcEEuwE6YTqGviTY5B D2691E 3067 10 -2620

Chache reports a bug: > The recently added lilac flowers cannot be put inside clay pots like all the other flowers Player position: ``` { x = 3067.2829589844, y = 9.5, z = -2619.5439453125 } ``` Player look: ``` { x = 0.24057020246983, y = -0.41087797284126, z = -0.87937778234482 } ``` Player information: ``` { connection_uptime = 2368, serialization_version = 29, patch = 1, formspec_version = 6, lang_code = "es", max_rtt = 1.5499999523163, protocol_version = 41, state = "Active", minor = 6, version_string = "5.6.1", min_jitter = 0, ip_version = 6, min_rtt = 0.028999999165535, avg_rtt = 0.032000001519918, major = 5, max_jitter = 1.3310000896454, avg_jitter = 0 } ``` Player meta: ``` { fields = { crafted = "27859", punch_count = "15546", ["ocean_build.forbidden"] = "true", inflicted_damage = "938678", yl_church = "return {[\"last_heal\"] = 1653594577, [\"last_death\"] = {[\"z\"] = -2855, [\"x\"] = 3030, [\"y\"] = 55}, [\"last_death_portal\"] = 1659644212}", ["stamina:level"] = "15", bitten = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "22", yl_commons_thankyou = "77", yl_commons_player_created = "1645471717", hud_state = "on", ["ocean_build.last_warning"] = "1.65606e+09", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 3460\", \"\", \"3d_armor:chestplate_crystal 1 17040\", \"3d_armor:leggings_crystal 1 17040\", \"shields:shield_rainbow 1 1400\", \"3d_armor:boots_crystal 1 17040\"}", yl_commons_player_joined = "1679388862", played_time = "5590524", partychat = "party", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", placed_nodes = "293635", arenalib_infobox_arenaID = "0", jointime = "1645471717", xp = "764580", ["ocean_build.ocean_built"] = "12", ["signslib:pos"] = "(3008,-4,-2724)", digged_nodes = "728046", xp_redo_hud_color = "0xFFFF00", died = "11", repellant = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = uJ8aQr5TN8trVKLcEEuwE6YTqGviTY5B ``` Profiler save: ``` profile-20230321T093323.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 26min | max lag: 1.61s | clients (12/52): 9T9, AliasAlreadyTaken, Azelf, Bailiff, Chache, daydream, dukela, Murmel, NafiShahriyar, niceride, richelles, Service ``` Teleport command: ``` /teleport xyz 3067 10 -2620 ``` Compass command: ``` /give_compass Construction uJ8aQr5TN8trVKLcEEuwE6YTqGviTY5B D2691E 3067 10 -2620 ```

AliasAlreadyTaken was assigned by yourland-report

2023-03-21 09:33:23 +00:00

flux added the

1. kind/enhancement

3. source/mod upstream

labels 2023-03-21 15:41:45 +00:00

flux added

3. source/integration

4. step/ready to QA test

and removed

3. source/mod upstream

labels 2023-03-21 15:48:41 +00:00

flux commented

2023-03-21 15:49:39 +00:00

i was worried that it wouldn't look right because it's much taller than a single node, but it works quite well:

implemented in 210d5156b6

i was worried that it wouldn't look right because it's much taller than a single node, but it works quite well: ![image](/attachments/c0831b97-d0b2-4e55-9fd5-7bc3bcf7c25a) implemented in https://gitea.your-land.de/your-land/yl_commons/commit/210d5156b678d09cc4a2a32dcb6df079d9fdffc3

image.png

40 KiB

👍 3

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-03-21 17:28:45 +00:00

AliasAlreadyTaken commented

2023-04-13 20:40:21 +00:00

QA

Why does ethereal have group:flora while there's already a group:flower ?

However the plant looks very pretty IMO

QA Why does ethereal have group:flora while there's already a group:flower ? However the plant looks very pretty IMO

AliasAlreadyTaken added the

ugh/QA OK

label 2023-04-13 20:40:28 +00:00

flux commented

2023-04-14 03:40:39 +00:00

Why does ethereal have group:flora while there's already a group:flower ?

group:flora isn't only an ethereal thing, it's used for a lot of stuff. the picture below doesn't even include the stuff that's "not in creative inventory":

> Why does ethereal have group:flora while there's already a group:flower ? `group:flora` isn't only an ethereal thing, it's used for a lot of stuff. the picture below doesn't even include the stuff that's "not in creative inventory": ![image](/attachments/733d61d1-ca72-47dc-a728-fc903b1f3c02)

image.png

80 KiB

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-04-26 00:04:05 +00:00

AliasAlreadyTaken was unassigned by flux

2023-04-26 00:04:08 +00:00

flux commented

2023-04-26 00:05:34 +00:00

this is live. i hid a potted lilac in the haven town hall.