Bla reports: [crash] just crashed the serve ... #3909

Bla reports a bug:

[crash] just crashed the server by trying to send a mail with colorized text, sry my bad was a quick & dirty idea should have gone to the testserver

Player position:

{
	x = 1982.5100097656,
	y = 18,
	z = 1174.1500244141
}

Player look:

{
	x = -0.98627328872681,
	y = -0.16453117132187,
	z = -0.013943989761174
}

Player information:

{
	connection_uptime = 199,
	max_rtt = 0.81900000572205,
	patch = 0,
	state = "Active",
	formspec_version = 6,
	ip_version = 6,
	serialization_version = 29,
	max_jitter = 0.75700002908707,
	major = 5,
	version_string = "5.7.0-dev-4cd6b773b-dirty",
	avg_rtt = 0.025000000372529,
	protocol_version = 41,
	min_rtt = 0.023000000044703,
	minor = 7,
	min_jitter = 0,
	lang_code = "",
	avg_jitter = 0
}

Player meta:

{
	fields = {
		yl_commons_player_joined = "1677656522",
		arenalib_infobox_arenaID = "0",
		jointime = "1635266646",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 798, [\"x\"] = 2395, [\"y\"] = 29377}, [\"last_death_portal\"] = 1673135349, [\"last_heal\"] = 1635970005}",
		["signslib:pos"] = "(4476,-56,-29877)",
		xp = "2196008",
		partychat = "party",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 20500\", \"3d_armor:chestplate_crystal 1 20500\", \"3d_armor:boots_crystal 1 20500\", \"3d_armor:leggings_crystal 1 20500\", \"shields:shield_crystal 1 20500\", \"\"}",
		hud_state = "on",
		["ocean_build.last_warning"] = "1.66187e+09",
		played_time = "10947443",
		yl_commons_thankyou = "382",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["stamina:level"] = "18",
		died = "104",
		digged_nodes = "1765866",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		punch_count = "185080",
		placed_nodes = "660008",
		inflicted_damage = "3711142",
		repellant = "0",
		crafted = "31646",
		["ambience.svol"] = "1",
		["stamina:poisoned"] = "no",
		bitten = "0",
		["stamina:exhaustion"] = "9",
		ui_waypoints = "{\"data\":[{\"active\":false,\"color\":2.0,\"display_pos\":true,\"world_pos\":{\"x\":-448.0,\"y\":25.0,\"z\":1341.0}},{\"active\":false,\"world_pos\":{\"x\":-447.0,\"y\":25.0,\"z\":1344.0}}],\"selected\":1.0}",
		yl_commons_player_created = "1635266646"
	}
}

Log identifier


[MOD] yl_report log identifier = dECoINrAscelBlSMihzgN9baoTqX3wHU

Profiler save:

profile-20230301T074503.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3min 30s | max lag: 1.78s | clients (10/52): AliasAlreadyTaken, Bailiff, Bla, daydream, Diorx, HorusDamocles, MainCoone, mrminer, Service, Sokomine

Teleport command:

/teleport xyz 1983 18 1174

Compass command:

/give_compass Construction dECoINrAscelBlSMihzgN9baoTqX3wHU D2691E 1983 18 1174

Bla reports a bug: > [crash] just crashed the server by trying to send a mail with colorized text, sry my bad was a quick & dirty idea should have gone to the testserver Player position: ``` { x = 1982.5100097656, y = 18, z = 1174.1500244141 } ``` Player look: ``` { x = -0.98627328872681, y = -0.16453117132187, z = -0.013943989761174 } ``` Player information: ``` { connection_uptime = 199, max_rtt = 0.81900000572205, patch = 0, state = "Active", formspec_version = 6, ip_version = 6, serialization_version = 29, max_jitter = 0.75700002908707, major = 5, version_string = "5.7.0-dev-4cd6b773b-dirty", avg_rtt = 0.025000000372529, protocol_version = 41, min_rtt = 0.023000000044703, minor = 7, min_jitter = 0, lang_code = "", avg_jitter = 0 } ``` Player meta: ``` { fields = { yl_commons_player_joined = "1677656522", arenalib_infobox_arenaID = "0", jointime = "1635266646", yl_church = "return {[\"last_death\"] = {[\"z\"] = 798, [\"x\"] = 2395, [\"y\"] = 29377}, [\"last_death_portal\"] = 1673135349, [\"last_heal\"] = 1635970005}", ["signslib:pos"] = "(4476,-56,-29877)", xp = "2196008", partychat = "party", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 20500\", \"3d_armor:chestplate_crystal 1 20500\", \"3d_armor:boots_crystal 1 20500\", \"3d_armor:leggings_crystal 1 20500\", \"shields:shield_crystal 1 20500\", \"\"}", hud_state = "on", ["ocean_build.last_warning"] = "1.66187e+09", played_time = "10947443", yl_commons_thankyou = "382", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["stamina:level"] = "18", died = "104", digged_nodes = "1765866", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", punch_count = "185080", placed_nodes = "660008", inflicted_damage = "3711142", repellant = "0", crafted = "31646", ["ambience.svol"] = "1", ["stamina:poisoned"] = "no", bitten = "0", ["stamina:exhaustion"] = "9", ui_waypoints = "{\"data\":[{\"active\":false,\"color\":2.0,\"display_pos\":true,\"world_pos\":{\"x\":-448.0,\"y\":25.0,\"z\":1341.0}},{\"active\":false,\"world_pos\":{\"x\":-447.0,\"y\":25.0,\"z\":1344.0}}],\"selected\":1.0}", yl_commons_player_created = "1635266646" } } ``` Log identifier ``` [MOD] yl_report log identifier = dECoINrAscelBlSMihzgN9baoTqX3wHU ``` Profiler save: ``` profile-20230301T074503.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3min 30s | max lag: 1.78s | clients (10/52): AliasAlreadyTaken, Bailiff, Bla, daydream, Diorx, HorusDamocles, MainCoone, mrminer, Service, Sokomine ``` Teleport command: ``` /teleport xyz 1983 18 1174 ``` Compass command: ``` /give_compass Construction dECoINrAscelBlSMihzgN9baoTqX3wHU D2691E 1983 18 1174 ```

Steps to reproduce
Try to send a mail with that text as body
(c@#ee82ee)Bla (c@#00FF00)can (c@#FFFF00)do (c@#FF7F00)it (c@#990012):-P(c@#ffffff)

Not sure how gitea handles ESC control character so I type it out
ESCc@#ee82ee)Bla ESCc@#00FF00)can ESCc@#FFFF00)do ESCc@#FF7F00)it ESCc@#990012):-PESCc@#ffffff)

edit: per comment edit you can get the original text including ESC character to copy&paste for tests

Steps to reproduce Try to send a mail with that text as body `(c@#ee82ee)Bla (c@#00FF00)can (c@#FFFF00)do (c@#FF7F00)it (c@#990012):-P(c@#ffffff)` Not sure how gitea handles ESC control character so I type it out `ESCc@#ee82ee)Bla ESCc@#00FF00)can ESCc@#FFFF00)do ESCc@#FF7F00)it ESCc@#990012):-PESCc@#ffffff)` edit: per comment edit you can get the original text including ESC character to copy&paste for tests

2023-03-01 07:37:41: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): ...t_live/bin/../mods/yl_commons/util/strip_translation.lua:35: attempt to perform arithmetic on local 'k' (a nil value)
2023-03-01 07:37:41: ERROR[Main]: stack traceback:
2023-03-01 07:37:41: ERROR[Main]: 	...t_live/bin/../mods/yl_commons/util/strip_translation.lua:35: in function 'tokenize'
2023-03-01 07:37:41: ERROR[Main]: 	...t_live/bin/../mods/yl_commons/util/strip_translation.lua:146: in function 'strip_translation'
2023-03-01 07:37:41: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:205: in function 'get_sender'
2023-03-01 07:37:41: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:233: in function 'chat_send_player'
2023-03-01 07:37:41: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mail_mod/api.lua:111: in function 'send'
2023-03-01 07:37:41: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mail_mod/gui.lua:467: in function 'func'
2023-03-01 07:37:41: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2023-03-01 07:37:41: ERROR[Main]: 	.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>

``` 2023-03-01 07:37:41: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): ...t_live/bin/../mods/yl_commons/util/strip_translation.lua:35: attempt to perform arithmetic on local 'k' (a nil value) 2023-03-01 07:37:41: ERROR[Main]: stack traceback: 2023-03-01 07:37:41: ERROR[Main]: ...t_live/bin/../mods/yl_commons/util/strip_translation.lua:35: in function 'tokenize' 2023-03-01 07:37:41: ERROR[Main]: ...t_live/bin/../mods/yl_commons/util/strip_translation.lua:146: in function 'strip_translation' 2023-03-01 07:37:41: ERROR[Main]: ...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:205: in function 'get_sender' 2023-03-01 07:37:41: ERROR[Main]: ...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:233: in function 'chat_send_player' 2023-03-01 07:37:41: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mail_mod/api.lua:111: in function 'send' 2023-03-01 07:37:41: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mail_mod/gui.lua:467: in function 'func' 2023-03-01 07:37:41: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2023-03-01 07:37:41: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417> ```

seems to be my code. hm.

does the recipient have to be ignoring the sender?

![image](/attachments/3034191d-f633-4c6a-8b60-e0b62c5fa0a0) ![image](/attachments/452f1df9-299b-4784-9a21-c35fb16be8f6) does the recipient have to be ignoring the sender?

image.png

14 KiB

image.png

12 KiB

still can't replicate it locally, even when ignoring myself...

figured out how to repeat it:

paste the text into the subject, not the body
omit one of the closing parentheses in the escape code

figured out how to repeat it: * paste the text into the *subject*, not the body * omit one of the closing parentheses in the escape code

should be fixed in 8dc0347e03, as well as several other crashes that could happen due to malformed user input.

added to the 1.1.118 milestone

should be fixed in https://gitea.your-land.de/your-land/yl_commons/commit/8dc0347e03fafcea26968e7909a42556a01be7ee, as well as several other crashes that could happen due to malformed user input. added to the 1.1.118 milestone

figured out how to repeat it:

paste the text into the subject, not the body

sry thought I copied it into the body not subject, probably misclicked

> figured out how to repeat it: > * paste the text into the *subject*, not the body sry thought I copied it into the body not subject, probably misclicked

this is live

Labels Milestones

Bla reports: [crash] just crashed the serve ... #3909