flux reports: new feature request: shared ar ... #374

Closed
opened 2021-03-27 22:02:04 +00:00 by yourland-report · 10 comments

flux reports a bug:

new feature request: shared armor stand

Player position:

{
	y = 71.25,
	x = 1264.7889404297,
	z = 542.81097412109
}

Player look:

{
	y = -0.79122352600098,
	x = 0.61120140552521,
	z = 0.019955046474934
}

Player information:

{
	min_rtt = 0.16500000655651,
	max_rtt = 5.9959998130798,
	connection_uptime = 4145,
	lang_code = "",
	address = "::ffff:73.202.104.204",
	formspec_version = 4,
	protocol_version = 39,
	avg_rtt = 0.28999999165535,
	min_jitter = 0,
	ip_version = 6,
	max_jitter = 5.7999997138977,
	avg_jitter = 0.11299999058247
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"rainbow_ore:rainbow_ore_shield 1 3538\", \"rainbow_ore:rainbow_ore_helmet 1 3538\", \"rainbow_ore:rainbow_ore_leggings 1 3538\", \"rainbow_ore:rainbow_ore_chestplate 1 3538\", \"3d_armor:boots_crystal 1 8720\", \"\"}",
		["petz:werewolf_vignette_id"] = "15",
		yl_commons_thankyou = "2",
		jointime = "1615351173",
		yl_commons_player_joined = "1616878404",
		["signslib:pos"] = "(25009,-34,30523)",
		digged_nodes = "84196",
		partychat = "party",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 9, [\"x\"] = 1020, [\"z\"] = 1500}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1616806105}",
		["stamina:level"] = "7.075",
		punch_count = "5979",
		died = "26",
		inflicted_damage = "102874",
		crafted = "2156",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		xp = "87483",
		["petz:werewolf_clan_idx"] = "1",
		placed_nodes = "19715",
		hud_state = "on",
		played_time = "529998",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = 0TcTFj1RjmYfeySochLMbINPCa9pMKbG

Profiler save:

profile-20210327T230159.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=291201, max_lag=3.71317, clients={whosit, FunkWizard, Izzy_Wolf, ria, LadyPyle, flux, Chazz, Chicheno, Modder, itaca94, ThinkSome, Nefar, Test_User, Elias, LadyK, AliasAlreadyTaken, Violetta, Service, Bailiff, Boris}
flux reports a bug: > new feature request: shared armor stand Player position: ``` { y = 71.25, x = 1264.7889404297, z = 542.81097412109 } ``` Player look: ``` { y = -0.79122352600098, x = 0.61120140552521, z = 0.019955046474934 } ``` Player information: ``` { min_rtt = 0.16500000655651, max_rtt = 5.9959998130798, connection_uptime = 4145, lang_code = "", address = "::ffff:73.202.104.204", formspec_version = 4, protocol_version = 39, avg_rtt = 0.28999999165535, min_jitter = 0, ip_version = 6, max_jitter = 5.7999997138977, avg_jitter = 0.11299999058247 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"rainbow_ore:rainbow_ore_shield 1 3538\", \"rainbow_ore:rainbow_ore_helmet 1 3538\", \"rainbow_ore:rainbow_ore_leggings 1 3538\", \"rainbow_ore:rainbow_ore_chestplate 1 3538\", \"3d_armor:boots_crystal 1 8720\", \"\"}", ["petz:werewolf_vignette_id"] = "15", yl_commons_thankyou = "2", jointime = "1615351173", yl_commons_player_joined = "1616878404", ["signslib:pos"] = "(25009,-34,30523)", digged_nodes = "84196", partychat = "party", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 9, [\"x\"] = 1020, [\"z\"] = 1500}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1616806105}", ["stamina:level"] = "7.075", punch_count = "5979", died = "26", inflicted_damage = "102874", crafted = "2156", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", xp = "87483", ["petz:werewolf_clan_idx"] = "1", placed_nodes = "19715", hud_state = "on", played_time = "529998", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = 0TcTFj1RjmYfeySochLMbINPCa9pMKbG ``` Profiler save: ``` profile-20210327T230159.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=291201, max_lag=3.71317, clients={whosit, FunkWizard, Izzy_Wolf, ria, LadyPyle, flux, Chazz, Chicheno, Modder, itaca94, ThinkSome, Nefar, Test_User, Elias, LadyK, AliasAlreadyTaken, Violetta, Service, Bailiff, Boris} ```
AliasAlreadyTaken was assigned by yourland-report 2021-03-27 22:02:04 +00:00
AliasAlreadyTaken added the
1. kind/enhancement
label 2021-03-27 23:04:30 +00:00
Owner

Im Not 100% Sure but i think Just people added To an area can Open an normal Armor stand which makes it Kind of an shared one

Im Not 100% Sure but i think Just people added To an area can Open an normal Armor stand which makes it Kind of an shared one
Member

Just tested this, and the unlocked armor stand is 100% usable by anyone.

Just tested this, and the unlocked armor stand is 100% usable by anyone.

Having a "protected" armor stand would benefit defenders of a town, they could have some ready armor and whoever is online at the time could take and go fight, then return afterwards.

Will implement.

Having a "protected" armor stand would benefit defenders of a town, they could have some ready armor and whoever is online at the time could take and go fight, then return afterwards. Will implement.
flux added the
4. step/want approval
label 2022-07-02 18:00:19 +00:00
flux added this to the flux's TODO list project 2022-07-02 18:00:22 +00:00
Member

i could easily add such a thing in yl_commons (or whereever)

i could easily add such a thing in yl_commons (or whereever)

That's something 3d_armor in general might benefit from, if the project wasn't stale, I'd probably recommend PR there. What's your opinion?

Regarding armour stands: Not a big fan, they look somewhat aged and don't have a place for the shield, let alone a weapon. Maybe we could abuse NPCs as armor stands. What's @Sokomine 's opinion on that?

That's something 3d_armor in general might benefit from, if the project wasn't stale, I'd probably recommend PR there. What's your opinion? Regarding armour stands: Not a big fan, they look somewhat aged and don't have a place for the shield, let alone a weapon. Maybe we could abuse NPCs as armor stands. What's @Sokomine 's opinion on that?
Member

That's something 3d_armor in general might benefit from, if the project wasn't stale, I'd probably recommend PR there. What's your opinion?

Regarding armour stands: Not a big fan, they look somewhat aged and don't have a place for the shield, let alone a weapon. Maybe we could abuse NPCs as armor stands. What's @Sokomine 's opinion on that?

i got maybe 50% done in a rewrite of 3d_armor, but stopped to deal w/ more important things. a shared armour stand, and the ability to put shields & other armor on them, was part of that work. another big part of the work was to make it easier to define the behavior when the player experiences various kinds of damage.

> That's something 3d_armor in general might benefit from, if the project wasn't stale, I'd probably recommend PR there. What's your opinion? > > Regarding armour stands: Not a big fan, they look somewhat aged and don't have a place for the shield, let alone a weapon. Maybe we could abuse NPCs as armor stands. What's @Sokomine 's opinion on that? i got maybe 50% done in a rewrite of 3d_armor, but stopped to deal w/ more important things. a shared armour stand, and the ability to put shields & other armor on them, was part of that work. another big part of the work was to make it easier to define the behavior when the player experiences various kinds of damage.
AliasAlreadyTaken added the
4. step/approved
label 2022-08-09 01:31:05 +00:00
flux removed the
4. step/want approval
label 2022-08-30 23:25:07 +00:00
Member

The version of 3darmor that I have (slightly outdated perhaps?) already uses an entity that wears the armor stand texture when "empty" and the textures of the armor put on top. So it's already that way.

The model used doesn't seem to support wepaons or shields. It looks like this (made visible by using default_wood.png as "empty" texture. Er. Hope it got added somewhere here.

Changing the model so that it displays the other things requires someone with skill in changing 3d models. It differs a bit from the player model insofar as the arms are not hanging down but are angled a bit. And this is IMHO pretty nice.

A shared version would be very good and ought to be doable with far less work than changing a model (at least from my point of view).

In the long run, clothing would be very nice for NPC to have. Like complex crafted food, clothing could be something that makes NPC happy and more loyal. Players have skins and armor and thus no use or place for it. But NPC do...

The version of 3darmor that I have (slightly outdated perhaps?) already uses an entity that wears the armor stand texture when "empty" and the textures of the armor put on top. So it's already that way. The model used doesn't seem to support wepaons or shields. It looks like this (made visible by using default_wood.png as "empty" texture. Er. Hope it got added somewhere here. Changing the model so that it displays the other things requires someone with skill in changing 3d models. It differs a bit from the player model insofar as the arms are not hanging down but are angled a bit. And this is IMHO pretty nice. A shared version would be very good and ought to be doable with far less work than changing a model (at least from my point of view). In the long run, clothing would be very nice for NPC to have. Like complex crafted food, clothing could be something that makes NPC happy and more loyal. Players have skins and armor and thus no use or place for it. But NPC do...
flux added the
2. prio/elevated
label 2023-03-05 04:10:47 +00:00
flux added the
4. step/ready to QA test
label 2023-11-27 20:16:28 +00:00
Member
upstream PR https://github.com/minetest-mods/3d_armor/pull/127
Member

upstream PR got merged

upstream PR got merged
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-29 01:32:05 +00:00
AliasAlreadyTaken added the
ugh/QA OK
label 2023-12-04 13:02:23 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-12-17 20:10:53 +00:00
flux removed this from the flux's TODO list project 2023-12-17 20:10:55 +00:00
AliasAlreadyTaken was unassigned by flux 2023-12-17 20:10:58 +00:00
Member

this is live.

this is live.
flux closed this issue 2023-12-17 20:11:12 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#374
No description provided.