your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

update sandwiches #3683

New Issue
Closed
opened 2023-01-31 00:58:01 +00:00 by flux · 10 comments
flux commented 2023-01-31 00:58:01 +00:00
Member
Copy Link

to try to make sure 1.1.118 stuff is ready soon, i've started working on updating sandwiches. a review of our changes to the mod found that pretty much all our custom changes are already in the mod or irrelevant. it still needs testing, though, particularly the integration stuff.

to try to make sure 1.1.118 stuff is ready soon, i've started working on updating sandwiches. a review of our changes to the mod found that pretty much all our custom changes are already in the mod or irrelevant. it still needs testing, though, particularly the integration stuff.
flux added this to the 1.1.117.1 milestone 2023-01-31 00:58:01 +00:00
flux added the
1. kind/enhancement
4. step/at work
 labels 2023-01-31 00:58:01 +00:00
flux self-assigned this 2023-01-31 00:58:02 +00:00
flux added this to the flux's TODO list project 2023-01-31 00:58:02 +00:00
flux commented 2023-01-31 01:46:51 +00:00
Author
Member
Copy Link
2023-01-30 16:55:44: ERROR[Main]: ModError: Failed to load and run script from /opt/minetest/bin/../worlds/your-land/worldmods/yl_commons/init.lua:
2023-01-30 16:55:44: ERROR[Main]: ...../worlds/your-land/worldmods/yl_commons/util/groups.lua:19: attempting to override unknown item sandwiches:rasperry_jam_sandwich
2023-01-30 16:55:44: ERROR[Main]: stack traceback:
2023-01-30 16:55:44: ERROR[Main]: 	[C]: in function 'error'
2023-01-30 16:55:44: ERROR[Main]: 	...../worlds/your-land/worldmods/yl_commons/util/groups.lua:19: in function 'add_groups'
2023-01-30 16:55:44: ERROR[Main]: 	...lds/your-land/worldmods/yl_commons/groups/sandwiches.lua:18: in main chunk
2023-01-30 16:55:44: ERROR[Main]: 	[C]: in function 'dofile'
2023-01-30 16:55:44: ERROR[Main]: 	...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:181: in function 'dofile'
2023-01-30 16:55:44: ERROR[Main]: 	...../worlds/your-land/worldmods/yl_commons/groups/init.lua:31: in main chunk
2023-01-30 16:55:44: ERROR[Main]: 	[C]: in function 'dofile'
2023-01-30 16:55:44: ERROR[Main]: 	...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:181: in function 'dofile'
2023-01-30 16:55:44: ERROR[Main]: 	...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:188: in main chunk
``` 2023-01-30 16:55:44: ERROR[Main]: ModError: Failed to load and run script from /opt/minetest/bin/../worlds/your-land/worldmods/yl_commons/init.lua: 2023-01-30 16:55:44: ERROR[Main]: ...../worlds/your-land/worldmods/yl_commons/util/groups.lua:19: attempting to override unknown item sandwiches:rasperry_jam_sandwich 2023-01-30 16:55:44: ERROR[Main]: stack traceback: 2023-01-30 16:55:44: ERROR[Main]: [C]: in function 'error' 2023-01-30 16:55:44: ERROR[Main]: ...../worlds/your-land/worldmods/yl_commons/util/groups.lua:19: in function 'add_groups' 2023-01-30 16:55:44: ERROR[Main]: ...lds/your-land/worldmods/yl_commons/groups/sandwiches.lua:18: in main chunk 2023-01-30 16:55:44: ERROR[Main]: [C]: in function 'dofile' 2023-01-30 16:55:44: ERROR[Main]: ...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:181: in function 'dofile' 2023-01-30 16:55:44: ERROR[Main]: ...../worlds/your-land/worldmods/yl_commons/groups/init.lua:31: in main chunk 2023-01-30 16:55:44: ERROR[Main]: [C]: in function 'dofile' 2023-01-30 16:55:44: ERROR[Main]: ...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:181: in function 'dofile' 2023-01-30 16:55:44: ERROR[Main]: ...st/bin/../worlds/your-land/worldmods/yl_commons/init.lua:188: in main chunk ```
flux commented 2023-01-31 02:20:52 +00:00
Author
Member
Copy Link

upstream issue: https://notabug.org/Annalysa/sandwiches/issues/2

upstream issue: https://notabug.org/Annalysa/sandwiches/issues/2
flux added the
3. source/mod upstream
4. step/blocked
 labels 2023-01-31 02:21:07 +00:00
flux commented 2023-01-31 21:06:33 +00:00
Author
Member
Copy Link

another upstream issue: https://notabug.org/Annalysa/sandwiches/issues/3

another upstream issue: https://notabug.org/Annalysa/sandwiches/issues/3
flux commented 2023-02-01 19:18:22 +00:00
Author
Member
Copy Link

upstream PR: https://notabug.org/Annalysa/sandwiches/pulls/4

upstream PR: https://notabug.org/Annalysa/sandwiches/pulls/4
flux added
4. step/ready to QA test
 and removed
4. step/at work
4. step/blocked
 labels 2023-02-02 05:14:08 +00:00
flux commented 2023-02-02 05:15:36 +00:00
Author
Member
Copy Link

upstream is ready to be pulled

upstream is ready to be pulled
flux commented 2023-02-02 18:35:09 +00:00
Author
Member
Copy Link

updated our integration code for new sandwiches (should continue to work w/ old ones too) e2ea43b067

updated our integration code for new sandwiches (should continue to work w/ old ones too) https://gitea.your-land.de/your-land/yl_commons/commit/e2ea43b067fd5d5449335e47869d083e5db73e06
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 2023-02-12 14:30:09 +00:00
AliasAlreadyTaken commented 2023-02-22 06:48:15 +00:00
Owner
Copy Link

All we need to do is pull sandwiches, right? All the integration stuff is waiting for upstream sandwiches? No special commits to sandwiches anymore?

All we need to do is pull sandwiches, right? All the integration stuff is waiting for upstream sandwiches? No special commits to sandwiches anymore?
flux commented 2023-02-22 18:04:05 +00:00
Author
Member
Copy Link

All we need to do is pull sandwiches, right? All the integration stuff is waiting for upstream sandwiches? No special commits to sandwiches anymore?

yup, no need to merge all the custom changes we made to the mod, we should just use the upstream code as it is.

> All we need to do is pull sandwiches, right? All the integration stuff is waiting for upstream sandwiches? No special commits to sandwiches anymore? yup, no need to merge all the custom changes we made to the mod, we should just use the upstream code as it is.
👍 1
AliasAlreadyTaken commented 2023-04-13 22:49:08 +00:00
Owner
Copy Link

QA

Except #4184 : NICE!

QA Except #4184 : NICE!
AliasAlreadyTaken added the
ugh/QA OK
 label 2023-04-13 22:49:13 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-04-25 18:40:52 +00:00
flux removed this from the flux's TODO list project 2023-04-25 18:40:55 +00:00
flux removed their assignment 2023-04-25 18:40:57 +00:00
flux commented 2023-04-25 18:41:17 +00:00
Author
Member
Copy Link

this is live =D

this is live =D
🚀 1
flux closed this issue 2023-04-25 18:41:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.118
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3683
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?