AliasAlreadyTaken reports: Public chat is not logged anym ... #3617

New Issue

yourland-report · 2023-01-25T12:19:01+01:00

yourland-report commented

2023-01-25 12:19:01 +01:00

AliasAlreadyTaken reports a bug:

Public chat is not logged anymore

Player position:

{
	x = 1979.3010253906,
	y = 18,
	z = 1174.2969970703
}

Player look:

{
	x = 0.99389344453812,
	y = -0.10053536295891,
	z = -0.045480024069548
}

Player information:

{
	version_string = "5.7.0-dev-b8aaad4f1",
	protocol_version = 41,
	avg_jitter = 0,
	major = 5,
	minor = 7,
	lang_code = "",
	max_rtt = 5.0900001525879,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.017000000923872,
	avg_rtt = 0.018999999389052,
	min_jitter = 0,
	max_jitter = 5.0700001716614,
	formspec_version = 6,
	connection_uptime = 34823,
	serialization_version = 29,
	patch = 0
}

Player meta:

{
	fields = {
		["arena_lib_editor.players_number"] = "0",
		["arena_lib_editor.spawner_ID"] = "0",
		["arena_lib_editor.team_ID"] = "0",
		played_time = "71699320",
		szutil_watch = "return {}",
		placed_nodes = "178369",
		died = "1583",
		arenalib_watchID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		arenalib_infobox_arenaID = "0",
		yl_commons_thankyou = "762",
		partychat = "party",
		yl_commons_player_joined = "1674610727",
		lagometer = "1",
		["petz:werewolf"] = "0",
		digged_nodes = "137725",
		["petz:lycanthropy"] = "0",
		xp = "0",
		xp_redo_hud_color = "0xFFFF00",
		repellant = "0",
		punch_count = "62530",
		["petz:werewolf_vignette_id"] = "19",
		crafted = "4544",
		inflicted_damage = "2549278",
		yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}",
		bitten = "0",
		["petz:werewolf_clan_idx"] = "4",
		hud_state = "on",
		team = "STAFF",
		["stamina:exhaustion"] = "51.5",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		["ocean_build.last_warning"] = "1.67421e+09",
		["signslib:pos"] = "(1941,17,1132)",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["stamina:poisoned"] = "no",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		["stamina:level"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = 2Xn2LmaK8MrO5jf3fRKFuNu67Y6aF89U

Profiler save:

profile-20230125T111901.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10h 27s | max lag: 2.72s | clients (22/42): 9T9, ALCOHOL3, AliasAlreadyTaken, Aliza, Azelf, Bailiff, bizon, Chazz, daydream, drgn, Ecklair, EnokiM, haha12313, HorusDamocles, iwefowfwoq, niceride, Penelopee, pitbull, rewired_X, Service, Sysmatic, Xonon

Teleport command:

/teleport xyz 1979 18 1174

Compass command:

/give_compass Construction 2Xn2LmaK8MrO5jf3fRKFuNu67Y6aF89U D2691E 1979 18 1174

AliasAlreadyTaken reports a bug: > Public chat is not logged anymore Player position: ``` { x = 1979.3010253906, y = 18, z = 1174.2969970703 } ``` Player look: ``` { x = 0.99389344453812, y = -0.10053536295891, z = -0.045480024069548 } ``` Player information: ``` { version_string = "5.7.0-dev-b8aaad4f1", protocol_version = 41, avg_jitter = 0, major = 5, minor = 7, lang_code = "", max_rtt = 5.0900001525879, state = "Active", ip_version = 6, min_rtt = 0.017000000923872, avg_rtt = 0.018999999389052, min_jitter = 0, max_jitter = 5.0700001716614, formspec_version = 6, connection_uptime = 34823, serialization_version = 29, patch = 0 } ``` Player meta: ``` { fields = { ["arena_lib_editor.players_number"] = "0", ["arena_lib_editor.spawner_ID"] = "0", ["arena_lib_editor.team_ID"] = "0", played_time = "71699320", szutil_watch = "return {}", placed_nodes = "178369", died = "1583", arenalib_watchID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", arenalib_infobox_arenaID = "0", yl_commons_thankyou = "762", partychat = "party", yl_commons_player_joined = "1674610727", lagometer = "1", ["petz:werewolf"] = "0", digged_nodes = "137725", ["petz:lycanthropy"] = "0", xp = "0", xp_redo_hud_color = "0xFFFF00", repellant = "0", punch_count = "62530", ["petz:werewolf_vignette_id"] = "19", crafted = "4544", inflicted_damage = "2549278", yl_church = "return {[\"last_heal\"] = 1622459682, [\"last_death\"] = {[\"z\"] = 307, [\"x\"] = 2876, [\"y\"] = 64}, [\"last_death_portal\"] = 1670634104}", bitten = "0", ["petz:werewolf_clan_idx"] = "4", hud_state = "on", team = "STAFF", ["stamina:exhaustion"] = "51.5", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", ["ocean_build.last_warning"] = "1.67421e+09", ["signslib:pos"] = "(1941,17,1132)", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["stamina:poisoned"] = "no", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", ["stamina:level"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2Xn2LmaK8MrO5jf3fRKFuNu67Y6aF89U ``` Profiler save: ``` profile-20230125T111901.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10h 27s | max lag: 2.72s | clients (22/42): 9T9, ALCOHOL3, AliasAlreadyTaken, Aliza, Azelf, Bailiff, bizon, Chazz, daydream, drgn, Ecklair, EnokiM, haha12313, HorusDamocles, iwefowfwoq, niceride, Penelopee, pitbull, rewired_X, Service, Sysmatic, Xonon ``` Teleport command: ``` /teleport xyz 1979 18 1174 ``` Compass command: ``` /give_compass Construction 2Xn2LmaK8MrO5jf3fRKFuNu67Y6aF89U D2691E 1979 18 1174 ```

AliasAlreadyTaken was assigned by yourland-report

2023-01-25 12:19:01 +01:00

AliasAlreadyTaken added the

1. kind/bug

label 2023-01-25 13:01:49 +01:00

flux commented

2023-01-26 18:07:07 +01:00

what controlled logging of public chat? smart_chat?

flux commented

2023-01-26 18:10:31 +01:00

it looks like smart_chat should be logging it, but only if debug_log_level is verbose or higher: 9a036fd044/lib.lua (L306)

it looks like smart_chat should be logging it, but only if `debug_log_level` is `verbose` or higher: https://gitea.your-land.de/your-land/smart_chat/src/commit/9a036fd044767775e0c6af3c0347ab0f0c9fedf9/lib.lua#L306

Sokomine commented

2023-01-26 19:09:25 +01:00

When fixing that: Might it be possible to forward announcements and perhaps /me emotes/messages to IRC as well? Announcements already seem to be forwarded to Discord - but not to IRC :-(

flux commented

2023-01-26 20:50:35 +01:00

When fixing that: Might it be possible to forward announcements and perhaps /me emotes/messages to IRC as well? Announcements already seem to be forwarded to Discord - but not to IRC :-(

see #3217 for some discussion about that

> When fixing that: Might it be possible to forward announcements and perhaps /me emotes/messages to IRC as well? Announcements already seem to be forwarded to Discord - but not to IRC :-( see #3217 for some discussion about that

AliasAlreadyTaken commented

2023-01-26 20:53:18 +01:00

Of all things, the party mod logged our chat

For 1.1.118 I'll add some more to yl_chat, including our logging.

Of all things, the party mod logged our chat For 1.1.118 I'll add some more to yl_chat, including our logging.

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-10 20:48:55 +02:00

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-04-10 20:49:00 +02:00

AliasAlreadyTaken commented

2023-04-10 20:49:30 +02:00

This got delivered prematurely, because public chat logging is pretty important. However fore 1.1.118 we should formally test it

👍 1

AliasAlreadyTaken commented

2023-04-14 04:31:31 +02:00

QA

It may even log "too much" by now. The chatbridge logs, yl_chat logs and smartchat logs as well.

2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT : Boris : test1
2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT to bridge : Boris : test1
2023-04-14 02:28:52: ACTION[Server]: [MOD] smart_chat : Module matterbridge: send_2_bridge: test1

We'll most likely sort out with yl_chat and your-land/administration#76 and your-land/administration#97 ... until then: OK

QA It may even log "too much" by now. The chatbridge logs, yl_chat logs and smartchat logs as well. ``` 2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT : Boris : test1 2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT to bridge : Boris : test1 2023-04-14 02:28:52: ACTION[Server]: [MOD] smart_chat : Module matterbridge: send_2_bridge: test1 ``` We'll most likely sort out with yl_chat and https://gitea.your-land.de/your-land/administration/issues/76 and https://gitea.your-land.de/your-land/administration/issues/97 ... until then: OK

AliasAlreadyTaken added the

4. step/QA OK

label 2023-04-14 04:31:53 +02:00

flux commented

2023-04-14 05:21:32 +02:00

2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT : Boris : test1
2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT to bridge : Boris : test1
2023-04-14 02:28:52: ACTION[Server]: [MOD] smart_chat : Module matterbridge: send_2_bridge: test1

personally, the pattern i prefer is to format the message similar to the following:

[modname] we did something %s %s ...

knowing which mod the log came from is much more useful than just knowing whether the message came from a mod, particularly when you're familiar w/ all the main log messages.

> ``` > 2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT : Boris : test1 > 2023-04-14 02:28:52: ACTION[Server]: [MOD] CHAT to bridge : Boris : test1 > 2023-04-14 02:28:52: ACTION[Server]: [MOD] smart_chat : Module matterbridge: send_2_bridge: test1 > ``` personally, the pattern i prefer is to format the message similar to the following: ``` [modname] we did something %s %s ... ``` knowing which mod the log came from is much more useful than just knowing whether the message came from a mod, particularly when you're familiar w/ all the main log messages.

👍 1

flux commented

2023-04-25 22:52:00 +02:00

i can't verify whether this is live because i can't see the logs.

👍 1

AliasAlreadyTaken commented

2023-04-26 03:59:19 +02:00

It's in :)

AliasAlreadyTaken closed this issue

2023-04-26 03:59:20 +02:00

AliasAlreadyTaken added

5. result/fixed