test server anvil migration #3577

New Issue

niceride · 2023-01-21T04:53:29Z

niceride commented

2023-01-21 04:53:29 +00:00

Joining test server in nether, an existing shared anvil in the map appears as "???'s private anvil; repairing Steel hammer for repairing tools on the anvil (96%)" which doesn't make sense; attempting to use it is successful even though it is a private anvil and I am not the owner. An existing shared anvil in inventory when placed appears as "niceride's private anvil" and that is also a broken migration.

Attempting to craft the anvil in inventory (which says "niceride's private anvil") with paper is not helpful on the tooltip hints, on the input side it says "anvil" and on the output it says "anvil" - surely these should indicate if they are private or shared? Realizing the crafted anvil it says "anvil" and when placed it is shown as "niceride's private anvil".

Anvil logic is broken completely.

The black colour is also very strange, is the material supposed to be something other than steel?

Joining test server in nether, an existing shared anvil in the map appears as "???'s private anvil; repairing Steel hammer for repairing tools on the anvil (96%)" which doesn't make sense; attempting to use it is successful even though it is a private anvil and I am not the owner. An existing shared anvil in inventory when placed appears as "niceride's private anvil" and that is also a broken migration. Attempting to craft the anvil in inventory (which says "niceride's private anvil") with paper is not helpful on the tooltip hints, on the input side it says "anvil" and on the output it says "anvil" - surely these should indicate if they are private or shared? Realizing the crafted anvil it says "anvil" and when placed it is shown as "niceride's private anvil". Anvil logic is broken completely. The black colour is also very strange, is the material supposed to be something other than steel?

flux added the

1. kind/bug

2. prio/critical

ugh/QA NOK

labels 2023-01-21 05:14:07 +00:00

flux commented

2023-01-21 05:14:32 +00:00

mostly asleep, making a note to check this out tomorrow

flux added this to the flux's TODO list project 2023-01-21 05:14:42 +00:00

flux self-assigned this 2023-01-21 05:14:53 +00:00

flux commented

2023-01-21 05:15:26 +00:00

please poke me if i don't respond within 48 hours

AliasAlreadyTaken commented

2023-01-21 17:16:35 +00:00

This may be due to the "new" cottages mod that's still active on the testserver

flux commented

2023-01-21 18:24:03 +00:00

i had tried to add public anvil support w/ the cottages update, but clearly i didn't test it very well.

i've got an update, but there's at least one major issue w/ it. 06b5ccdb65

the infotext on old shared anvils will now read "public anvil".
you can now properly place public anvils (old or new).
you can now properly craft public anvils w/ paper, and craft them back to private anvils.
when breaking shared/public anvils (old or new), you will now get back a public anvil item.

what doesn't work:

old anvil items (not nodes) cannot be used in craft recipes. i'm not sure exactly what the problem here is, but i tried a bunch of things and nothing worked so i'll blame unified_inventory for not supporting aliased items.

The black colour is also very strange, is the material supposed to be something other than steel?

people complained because the anvils currently look like stone, not steel. this is meant to make them look like cast-iron

i had tried to add public anvil support w/ the cottages update, but clearly i didn't test it very well. i've got an update, but there's at least one major issue w/ it. https://github.com/fluxionary/minetest-cottages/commit/06b5ccdb657d1a819e40d06739cf8bb048a26c9e * the infotext on old shared anvils will now read "public anvil". * you can now properly place public anvils (old or new). * you can now properly craft public anvils w/ paper, and craft them back to private anvils. * when breaking shared/public anvils (old or new), you will now get back a public anvil item. what doesn't work: * old anvil *items* (not nodes) cannot be used in craft recipes. i'm not sure exactly what the problem here is, but i tried a bunch of things and nothing worked so i'll blame unified_inventory for not supporting aliased items. > The black colour is also very strange, is the material supposed to be something other than steel? people complained because the anvils currently look like *stone*, not steel. this is meant to make them look like cast-iron ![image](/attachments/e4be2c12-7bfa-428c-b19e-72f93f3cd286)

image.png

81 KiB

flux commented

2023-01-21 18:25:14 +00:00

This may be due to the "new" cottages mod that's still active on the testserver

yup, if we don't want to adopt that, we can just go back to the "old" cottages mod, but this has helped me discover and fix this issue w/ that PR :)

> This may be due to the "new" cottages mod that's still active on the testserver yup, if we don't want to adopt that, we can just go back to the "old" cottages mod, but this has helped me discover and fix this issue w/ that PR :)

flux added the

4. step/question

3. source/integration

4. step/ready to QA test

labels 2023-01-21 19:53:43 +00:00

niceride commented

2023-01-21 20:24:33 +00:00

The black colour is also very strange, is the material supposed to be something other than steel?

people complained because the anvils currently look like stone, not steel. this is meant to make them look like cast-iron

Yes the pre-existing anvil artwork is surely made of stone material by appearances. There is no horn in the mini-artwork, it looks like some kind of stone bench or display stand.

Look also at colour palette limited artwork representation, not "real" anvils. The specular reflections are shown as a deep gun-metal blue colour.

On anvils that are used and have some normal wear, the black patina is shiny and blunt from impacts, so there is a small bit of surface rust and noticeable reflections on these worn areas (the horn and top plate also makers marks on the sides). Some newly sold anvils are painted blue (or red or yellow - machine paint colours) not black. You can easily tell it's paint and unused because the horn is not worn shiny.

Should test for "readability" obvious nature of what it is when placed in liquids (water, dark water, lava) and dark/light environments of nether basalt rooms and caves or snowy stone castles in daylight. Making the anvil more difficult to "read" is less welcoming to players wanting to participate in co-operative environment.

> > The black colour is also very strange, is the material supposed to be something other than steel? > > people complained because the anvils currently look like *stone*, not steel. this is meant to make them look like cast-iron > > ![image](/attachments/e4be2c12-7bfa-428c-b19e-72f93f3cd286) Yes the pre-existing anvil artwork is surely made of stone material by appearances. There is no horn in the mini-artwork, it looks like some kind of stone bench or display stand. ![image](https://m.media-amazon.com/images/I/711B-igGP5L._AC_SL1500_.jpg) Look also at colour palette limited artwork representation, not "real" anvils. The specular reflections are shown as a deep gun-metal blue colour. ![image](https://www.berfrois.com/uploads/2011/06/rr5.jpg) On anvils that are used and have some normal wear, the black patina is shiny and blunt from impacts, so there is a small bit of surface rust and noticeable reflections on these worn areas (the horn and top plate also makers marks on the sides). Some newly sold anvils are painted blue (or red or yellow - machine paint colours) not black. You can easily tell it's paint and unused because the horn is not worn shiny. ![image](https://m.media-amazon.com/images/I/61IKJjqCB9L._AC_SL1000_.jpg) ![image](https://images.squarespace-cdn.com/content/v1/5a9cbc5e50a54f17d4cd0ec6/1537033758762-DYFU0LEBDO2EKBZSGF9V/20180914_140423.jpg) Should test for "readability" obvious nature of what it is when placed in liquids (water, dark water, lava) and dark/light environments of nether basalt rooms and caves or snowy stone castles in daylight. Making the anvil more difficult to "read" is less welcoming to players wanting to participate in co-operative environment.

Sokomine commented

2023-01-21 20:33:42 +00:00

The original anvil irrc was created during the time when we had nodboxes - not models. So something to fancy wasn't possible. I'm now used to the simple design and like it.

AliasAlreadyTaken commented

2023-01-21 20:45:36 +00:00

Since the cottages rework will not be part of 1.1.117, I disabled it on the testserver. Unfortunately that meant existing anvil items will become unknown blocks on the testserver.

We'll deal with cottages in its own issue.

The stony texture didn't look too bad, but also far from good. I have an wornout anvil in my workshop that is close to the darkgrey/black texture presented in the cottages rework. I'll gladly accept textures for the new anvil though :)

Since the cottages rework will not be part of 1.1.117, I disabled it on the testserver. Unfortunately that meant existing anvil items will become unknown blocks on the testserver. We'll deal with cottages in its own issue. The stony texture didn't look too bad, but also far from good. I have an wornout anvil in my workshop that is close to the darkgrey/black texture presented in the cottages rework. I'll gladly accept textures for the new anvil though :)

niceride referenced this issue

2023-01-24 03:20:30 +00:00

Azelf reports: pre-existing anvils on the Tes ... #3604

AliasAlreadyTaken added this to the 1.1.117.1 milestone 2023-01-30 23:53:41 +00:00

flux referenced this issue

2023-02-01 16:52:27 +00:00

1.1.118 #3401

AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118

2023-02-23 12:06:00 +00:00

AliasAlreadyTaken commented

2023-04-16 04:34:26 +00:00

QA