Laylem reports: [moreblocks] I'm wondering, wh ... #3527

New Issue

yourland-report · 2023-01-15T11:10:50Z

yourland-report commented

2023-01-15 11:10:50 +00:00

Laylem reports a bug:

[moreblocks] I'm wondering, why do some blocks not have a 100% cutting efficiency rate? I think ratios should be adjusted to 100% efficiency. Suppose you are cutting veneers of rare blocks for decoration, you could cut thinner but if you need to change something you lose material...

Player position:

{
	x = -973.64001464844,
	y = -34.499000549316,
	z = -1987.4840087891
}

Player look:

{
	x = 0.80024576187134,
	y = -0.59762513637543,
	z = -0.049506615847349
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.16099999845028,
	avg_rtt = 0.16899999976158,
	min_jitter = 0,
	max_jitter = 2.0250000953674,
	avg_jitter = 0.0030000060796738,
	connection_uptime = 8127,
	serialization_version = 29,
	patch = 1,
	max_rtt = 2.2049999237061,
	major = 5,
	version_string = "5.6.1",
	formspec_version = 6,
	protocol_version = 41,
	minor = 6,
	state = "Active",
	lang_code = ""
}

Player meta:

{
	fields = {
		inflicted_damage = "528750",
		yl_commons_thankyou = "62",
		played_time = "2013587",
		digged_nodes = "315395",
		partychat = "main",
		["stamina:level"] = "17",
		crafted = "72139",
		placed_nodes = "87863",
		["stamina:poisoned"] = "no",
		jointime = "1659420654",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = -7806, [\"y\"] = 29888, [\"z\"] = -9652}, [\"last_death_portal\"] = 1673312400, [\"last_heal\"] = 1673778297}",
		died = "43",
		arenalib_infobox_arenaID = "0",
		["ocean_build.last_warning"] = "1.66072e+09",
		["signslib:pos"] = "(-946,-7,-1995)",
		["ocean_build.ocean_built"] = "11",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 18005\", \"shields:shield_rainbow 1 15328\", \"3d_armor:chestplate_crystal 1 18005\", \"3d_armor:boots_crystal 1 18005\", \"3d_armor:leggings_crystal 1 18005\", \"\"}",
		yl_commons_player_created = "1659420654",
		yl_commons_player_joined = "1673772947",
		repellant = "0",
		["stamina:exhaustion"] = "145.5",
		hud_state = "on",
		punch_count = "25429",
		xp = "324348"
	}
}

Log identifier


[MOD] yl_report log identifier = tcfAL1LFxyjagQL5wlyUnzYmBFSjW443

Profiler save:

profile-20230115T111050.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 13h 10min 4s | max lag: 2.44s | clients (18/42): 9T9, AliasAlreadyTaken, Aliza, Azelf, Bailiff, Boot, Chache, daydream, Ernesto, Jetro, khstony, Laylem, niceride, NodeBreaker, Papi, Penelopee, Robo, Service

Teleport command:

/teleport xyz -974 -34 -1987

Compass command:

/give_compass Construction tcfAL1LFxyjagQL5wlyUnzYmBFSjW443 D2691E -974 -34 -1987

Laylem reports a bug: > [moreblocks] I'm wondering, why do some blocks not have a 100% cutting efficiency rate? I think ratios should be adjusted to 100% efficiency. Suppose you are cutting veneers of rare blocks for decoration, you could cut thinner but if you need to change something you lose material... Player position: ``` { x = -973.64001464844, y = -34.499000549316, z = -1987.4840087891 } ``` Player look: ``` { x = 0.80024576187134, y = -0.59762513637543, z = -0.049506615847349 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.16099999845028, avg_rtt = 0.16899999976158, min_jitter = 0, max_jitter = 2.0250000953674, avg_jitter = 0.0030000060796738, connection_uptime = 8127, serialization_version = 29, patch = 1, max_rtt = 2.2049999237061, major = 5, version_string = "5.6.1", formspec_version = 6, protocol_version = 41, minor = 6, state = "Active", lang_code = "" } ``` Player meta: ``` { fields = { inflicted_damage = "528750", yl_commons_thankyou = "62", played_time = "2013587", digged_nodes = "315395", partychat = "main", ["stamina:level"] = "17", crafted = "72139", placed_nodes = "87863", ["stamina:poisoned"] = "no", jointime = "1659420654", yl_church = "return {[\"last_death\"] = {[\"x\"] = -7806, [\"y\"] = 29888, [\"z\"] = -9652}, [\"last_death_portal\"] = 1673312400, [\"last_heal\"] = 1673778297}", died = "43", arenalib_infobox_arenaID = "0", ["ocean_build.last_warning"] = "1.66072e+09", ["signslib:pos"] = "(-946,-7,-1995)", ["ocean_build.ocean_built"] = "11", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 18005\", \"shields:shield_rainbow 1 15328\", \"3d_armor:chestplate_crystal 1 18005\", \"3d_armor:boots_crystal 1 18005\", \"3d_armor:leggings_crystal 1 18005\", \"\"}", yl_commons_player_created = "1659420654", yl_commons_player_joined = "1673772947", repellant = "0", ["stamina:exhaustion"] = "145.5", hud_state = "on", punch_count = "25429", xp = "324348" } } ``` Log identifier ``` [MOD] yl_report log identifier = tcfAL1LFxyjagQL5wlyUnzYmBFSjW443 ``` Profiler save: ``` profile-20230115T111050.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 13h 10min 4s | max lag: 2.44s | clients (18/42): 9T9, AliasAlreadyTaken, Aliza, Azelf, Bailiff, Boot, Chache, daydream, Ernesto, Jetro, khstony, Laylem, niceride, NodeBreaker, Papi, Penelopee, Robo, Service ``` Teleport command: ``` /teleport xyz -974 -34 -1987 ``` Compass command: ``` /give_compass Construction tcfAL1LFxyjagQL5wlyUnzYmBFSjW443 D2691E -974 -34 -1987 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-01-15 11:10:50 +00:00

flux added the

1. kind/bug

4. step/question

labels 2023-01-16 03:26:58 +00:00

flux commented

2023-01-16 03:27:21 +00:00

sent an email to laylem:

what exactly are you trying to cut? currently everything except ethereal:glostone has a 100% efficiency rate, and ethereal glostone is bugged out and has random efficiency rates greater/less than 100%. 

however, currently, to recover all the material, you have to recycle things in the circular saw, not use crafting recipes to recover it.

sent an email to laylem: ``` what exactly are you trying to cut? currently everything except ethereal:glostone has a 100% efficiency rate, and ethereal glostone is bugged out and has random efficiency rates greater/less than 100%. however, currently, to recover all the material, you have to recycle things in the circular saw, not use crafting recipes to recover it. ```

laylem commented

2023-01-16 04:58:32 +00:00

![image](/attachments/233c0484-c626-4e67-8baf-31eb207ad53c)

image.png

110 KiB

laylem commented

2023-01-16 05:00:08 +00:00

Additionally, we can see that slabs and panels etc. smaller than 1/8th don't get 100% efficiency?

flux commented

2023-01-16 06:05:50 +00:00

https://media.discordapp.net/attachments/654724082687934464/1064139725977440286/image.png

every stairs+ node is "x/8" of a normal node, where 1 <= x <= 8. despite the fact that they sometimes don't translate to the nearest reasonable value for their volume, they're all consistent - you can trade them back in for exactly as much material as you used to create them, if you don't hit an of the current moreblocks bugs.

imo, there's no good reason why the value of a node should be equal to it's apparent relative volume.

> https://media.discordapp.net/attachments/654724082687934464/1064139725977440286/image.png every stairs+ node is "x/8" of a normal node, where 1 <= x <= 8. despite the fact that they sometimes don't translate to the nearest reasonable value for their volume, they're all consistent - you can trade them back in for exactly as much material as you used to create them, if you don't hit an of the current moreblocks bugs. imo, there's no good reason why the value of a node should be equal to it's apparent relative volume.

flux added this to the flux's TODO list project 2023-01-16 06:06:04 +00:00

flux added the

2. prio/interesting

label 2023-01-16 06:06:19 +00:00

flux commented

2023-01-16 18:00:51 +00:00

let's see, volume of a cone is base * height / 3, so the volumes of those shapes are 1/3 and 1/6 respectively. rounding to the nearest multiple of 1/8, this becomes 3/8 and 1/8. that means the stack sizes ought to be 8 and 24, so it looks like the number of 8ths allocated to slope_outer_half is 2/8 when it should be 1/8, but again, the material isn't actually lost, since the thing can be recycled.

however, i should audit the quantities allocated to the shapes to make sure they're correct in my moreblocks fork.

let's see, volume of a cone is `base * height / 3`, so the volumes of those shapes are `1/3` and `1/6` respectively. rounding to the nearest multiple of `1/8`, this becomes `3/8` and `1/8`. that means the stack sizes *ought* to be `8` and `24`, so it looks like the number of 8ths allocated to `slope_outer_half` is `2/8` when it should be `1/8`, but again, the material isn't actually lost, since the thing can be recycled. however, i should audit the quantities allocated to the shapes to make sure they're correct in my moreblocks fork.

flux added

1. kind/documentation

and removed

1. kind/bug

4. step/question

labels 2023-01-16 18:01:16 +00:00

flux commented

2023-02-20 01:03:13 +00:00

implemented in 39c0558248

implemented in https://github.com/fluxionary/minetest-moreblocks/commit/39c0558248bf5aae4e5d5b556001ccea5e4a985f ![image](/attachments/7eceb6e0-a478-4f0b-9788-0193645e9e06) ![image](/attachments/fdedf957-b912-487a-9ae9-01b08864693c)

image.png

87 KiB

image.png

89 KiB

flux added this to the 1.1.118 milestone 2023-02-20 01:14:56 +00:00

flux added the

4. step/ready to QA test

label 2023-02-20 01:15:19 +00:00

flux commented

2023-02-20 01:25:29 +00:00

Suppose you are cutting veneers of rare blocks for decoration, you could cut thinner but if you need to change something you lose material...
Additionally, we can see that slabs and panels etc. smaller than 1/8th don't get 100% efficiency?

i suppose i never addressed this directly.

players will have a fit if they can't recover even small slivers of their valuable materials (or even sgg), which they used to be able to recover. that is why i consider losing material a non-starter. however, as this issue pointed out, some of the values needed slight tweaking.

trying to allow meaningful divisions of a node into smaller-than-1/8th pieces is technically possible, but it's quite tricky to get right, particularly if you want everything to be recycle-able. sure, it's easy to say that you need 2 1/16 slabs to recover 1/8 of a node of material, but players will get confused when they can e.g. only recover material w/ input in multiples of 7 for one shape and 11 for a different shape. the current mechanics (well, the mechanics in my moreblocks fork) are logical and intuitive, once you learn that everything is calculated in 1/8th nodes.

> Suppose you are cutting veneers of rare blocks for decoration, you could cut thinner but if you need to change something you lose material... > Additionally, we can see that slabs and panels etc. smaller than 1/8th don't get 100% efficiency? i suppose i never addressed this directly. players will have a fit if they can't recover even small slivers of their valuable materials (or even sgg), which they used to be able to recover. that is why i consider losing material a non-starter. however, as this issue pointed out, some of the values needed slight tweaking. trying to allow meaningful divisions of a node into smaller-than-1/8th pieces is technically possible, but it's quite tricky to get right, particularly if you want everything to be recycle-able. sure, it's easy to say that you need 2 1/16 slabs to recover 1/8 of a node of material, but players will get confused when they can e.g. only recover material w/ input in multiples of 7 for one shape and 11 for a different shape. the current mechanics (well, the mechanics in my moreblocks fork) are logical and intuitive, once you learn that everything is calculated in 1/8th nodes.

flux referenced this issue

2023-02-20 17:25:03 +00:00

1.1.118 #3401

AliasAlreadyTaken commented

2023-04-14 01:41:38 +00:00

Let's test this issue together with moreblocks ore reschedule

AliasAlreadyTaken modified the milestone from 1.1.118 to 1.1.119

2023-04-14 01:41:42 +00:00

AliasAlreadyTaken modified the milestone from 1.1.119 to 1.1.120

2023-05-09 11:03:52 +00:00

AliasAlreadyTaken removed this from the 1.1.120 milestone 2023-08-28 10:12:49 +00:00

AliasAlreadyTaken added this to the moreblocks milestone 2023-12-06 14:14:57 +00:00