Wine major overhaul #3392
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#3392
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Wine was reworked, we can now add fermentation from the outside.
We also could add drinks via API, but this would create
yl_commons:eggnogg instead of the desired wine:eggnogg
https://forum.minetest.net/viewtopic.php?p=419983#p419983
Let's investigate whether we can now add our beverages via API, instead of the wine mod itself.
This issue is ment to document what happened in the wine mod.
The old yl_stable was renamed to before_overhaul
The new yl_stable is an attempt at using the new API: https://gitea.your-land.de/your-land/wine/src/branch/yl_stable
The "fix is two parts, one in wine and one in yl_commons:
wine:
68d223f1c4
yl_commons
22c3f218c7
Looks like now you need to add water and a drinking glass to the barrel, additionally to what you want to ferment.
I bet a lot of people will be confused
this is live, HOWEVER old barrels are not automatically updated. putting a fermentable item updates them partially, but they're in a broken state. we need to create an LBM that re-runs the constructor logic.
closing this; the above issue will be addressed in #3625